1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <objbase.h>
#include <propkey.h>
#include <shellapi.h>
#include <shlobj.h>
#include <wrl/client.h>
#include <string>
#include "base/command_line.h"
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "base/win/scoped_propvariant.h"
#include "chrome/browser/apps/app_service/app_launch_params.h"
#include "chrome/browser/apps/app_service/app_service_proxy.h"
#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
#include "chrome/browser/apps/app_service/browser_app_launcher.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_attributes_entry.h"
#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/profiles/profile_shortcut_manager_win.h"
#include "chrome/browser/profiles/profile_test_util.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/web_applications/os_integration/web_app_shortcut.h"
#include "chrome/browser/web_applications/os_integration/web_app_shortcut_win.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/test_utils.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "ui/views/win/hwnd_util.h"
typedef extensions::ExtensionBrowserTest BrowserWindowPropertyManagerTest;
namespace {
std::wstring AddIdToIconPath(const std::wstring& path) {
return path + L",0";
}
// Checks that the relaunch name, relaunch command and app icon for the given
// |browser| are correct.
void ValidateBrowserWindowProperties(
const Browser* browser,
const std::u16string& expected_profile_name) {
// Let shortcut creation finish before we validate the results.
content::RunAllTasksUntilIdle();
HWND hwnd = views::HWNDForNativeWindow(browser->window()->GetNativeWindow());
Microsoft::WRL::ComPtr<IPropertyStore> pps;
HRESULT result = SHGetPropertyStoreForWindow(hwnd, IID_PPV_ARGS(&pps));
EXPECT_TRUE(SUCCEEDED(result));
base::win::ScopedPropVariant prop_var;
// The relaunch name should be of the form "Chromium" if there is only 1
// profile and "First User - Chromium" if there are more. The expected value
// is given by |expected_profile_name|.
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchDisplayNameResource,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
EXPECT_EQ(base::FilePath(profiles::internal::GetShortcutFilenameForProfile(
expected_profile_name))
.RemoveExtension()
.value(),
prop_var.get().pwszVal);
prop_var.Reset();
// The relaunch command should specify the profile.
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchCommand,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
base::CommandLine cmd_line(
base::CommandLine::FromString(prop_var.get().pwszVal));
EXPECT_EQ(browser->profile()->GetBaseName().value(),
cmd_line.GetSwitchValueNative(switches::kProfileDirectory));
prop_var.Reset();
// The app icon should be set to the profile icon.
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchIconResource,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
EXPECT_EQ(AddIdToIconPath(profiles::internal::GetProfileIconPath(
browser->profile()->GetPath())
.value()),
prop_var.get().pwszVal);
prop_var.Reset();
}
void ValidateHostedAppWindowProperties(const Browser* browser,
const extensions::Extension* extension) {
content::RunAllTasksUntilIdle();
HWND hwnd = views::HWNDForNativeWindow(browser->window()->GetNativeWindow());
Microsoft::WRL::ComPtr<IPropertyStore> pps;
HRESULT result = SHGetPropertyStoreForWindow(hwnd, IID_PPV_ARGS(&pps));
EXPECT_TRUE(SUCCEEDED(result));
base::win::ScopedPropVariant prop_var;
// The relaunch name should be the extension name.
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchDisplayNameResource,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
EXPECT_EQ(base::UTF8ToWide(extension->name()), prop_var.get().pwszVal);
prop_var.Reset();
// The relaunch command should specify the profile and the app id.
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchCommand,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
base::CommandLine cmd_line(
base::CommandLine::FromString(prop_var.get().pwszVal));
EXPECT_EQ(browser->profile()->GetBaseName().value(),
cmd_line.GetSwitchValueNative(switches::kProfileDirectory));
EXPECT_EQ(base::UTF8ToWide(extension->id()),
cmd_line.GetSwitchValueNative(switches::kAppId));
prop_var.Reset();
// The app icon should be set to the extension app icon.
base::FilePath web_app_dir =
web_app::GetOsIntegrationResourcesDirectoryForApp(
browser->profile()->GetPath(), extension->id(), GURL());
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchIconResource,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
EXPECT_EQ(
AddIdToIconPath(web_app::internals::GetIconFilePath(
web_app_dir, base::UTF8ToUTF16(extension->name()))
.value()),
prop_var.get().pwszVal);
prop_var.Reset();
}
} // namespace
// Tests that require the profile shortcut manager to be instantiated despite
// having --user-data-dir specified.
class BrowserTestWithProfileShortcutManager : public InProcessBrowserTest {
public:
BrowserTestWithProfileShortcutManager() = default;
BrowserTestWithProfileShortcutManager(
const BrowserTestWithProfileShortcutManager&) = delete;
BrowserTestWithProfileShortcutManager& operator=(
const BrowserTestWithProfileShortcutManager&) = delete;
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(switches::kEnableProfileShortcutManager);
}
};
// Check that the window properties on Windows are properly set.
IN_PROC_BROWSER_TEST_F(BrowserTestWithProfileShortcutManager,
DISABLED_WindowProperties) {
// Single profile case. The profile name should not be shown.
ValidateBrowserWindowProperties(browser(), std::u16string());
// If multiprofile mode is not enabled, we can't test the behavior when there
// are multiple profiles.
if (!profiles::IsMultipleProfilesEnabled()) {
return;
}
// Two profile case. Both profile names should be shown.
ProfileManager* profile_manager = g_browser_process->profile_manager();
base::FilePath path_profile2 =
profile_manager->GenerateNextProfileDirectoryPath();
profiles::testing::CreateProfileSync(profile_manager, path_profile2);
// The default profile's name should be part of the relaunch name.
ValidateBrowserWindowProperties(
browser(), base::UTF8ToUTF16(browser()->profile()->GetProfileUserName()));
// The second profile's name should be part of the relaunch name.
Browser* profile2_browser =
CreateBrowser(profile_manager->GetProfileByPath(path_profile2));
ProfileAttributesEntry* entry =
profile_manager->GetProfileAttributesStorage()
.GetProfileAttributesWithPath(path_profile2);
ASSERT_NE(entry, nullptr);
ValidateBrowserWindowProperties(profile2_browser, entry->GetName());
}
IN_PROC_BROWSER_TEST_F(BrowserWindowPropertyManagerTest, DISABLED_HostedApp) {
// Load an app.
const extensions::Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("app/"));
EXPECT_TRUE(extension);
base::RunLoop done;
apps::AppServiceProxyFactory::GetForProfile(browser()->profile())
->BrowserAppLauncher()
->LaunchAppWithParams(
apps::AppLaunchParams(extension->id(),
apps::LaunchContainer::kLaunchContainerWindow,
WindowOpenDisposition::NEW_FOREGROUND_TAB,
apps::LaunchSource::kFromTest),
base::IgnoreArgs<content::WebContents*>(done.QuitClosure()));
done.Run();
// Check that the new browser has an app name.
// The launch should have created a new browser.
ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile()));
// Find the new browser.
Browser* app_browser = nullptr;
for (Browser* b : *BrowserList::GetInstance()) {
if (b != browser()) {
app_browser = b;
}
}
ASSERT_TRUE(app_browser);
ASSERT_TRUE(app_browser != browser());
ValidateHostedAppWindowProperties(app_browser, extension);
}
|
