File: hover_button_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (311 lines) | stat: -rw-r--r-- 11,918 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/ui/views/controls/hover_button.h"

#include <array>
#include <memory>
#include <string>

#include "base/strings/strcat.h"
#include "base/strings/to_string.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/test/views/chrome_views_test_base.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/accessibility/ax_enums.mojom.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/text_utils.h"
#include "ui/views/accessibility/view_accessibility.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/label.h"
#include "ui/views/controls/styled_label.h"
#include "ui/views/style/typography.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/view.h"
#include "ui/views/view_class_properties.h"
#include "ui/views/widget/widget_utils.h"

namespace {

constexpr int kButtonWidth = 150;

struct TitleSubtitlePair {
  const std::u16string title;
  const std::u16string subtitle;
  // Whether the HoverButton is expected to have a tooltip for this text.
  bool tooltip;
};

const std::array<TitleSubtitlePair, 4> kTitleSubtitlePairs{
    // Two short strings that will fit in the space given.
    {
        {u"Clap!", u"Clap!", false},
        // First string fits, second string doesn't.
        {u"If you're happy and you know it, clap your hands!", u"Clap clap!",
         true},
        // Second string fits, first string doesn't.
        {u"Clap clap!",
         u"If you're happy and you know it, and you really want to show it,",
         true},
        // Both strings don't fit.
        {u"If you're happy and you know it, and you really want to show it,",
         u"If you're happy and you know it, clap your hands!", true},
    }};

// Returns the accessible name of `button`.
std::u16string GetAccessibleName(HoverButton& button) {
  ui::AXNodeData data;
  button.GetViewAccessibility().GetAccessibleNodeData(&data);
  return data.GetString16Attribute(ax::mojom::StringAttribute::kName);
}

}  // namespace

class HoverButtonTest : public ChromeViewsTestBase {
 public:
  HoverButtonTest() = default;

  HoverButtonTest(const HoverButtonTest&) = delete;
  HoverButtonTest& operator=(const HoverButtonTest&) = delete;

  void SetUp() override {
    ChromeViewsTestBase::SetUp();
    widget_ = CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
    generator_ = std::make_unique<ui::test::EventGenerator>(
        GetRootWindow(widget_.get()), widget_->GetNativeWindow());
  }

  void TearDown() override {
    widget_.reset();
    generator_.reset();
    ChromeViewsTestBase::TearDown();
  }

  std::unique_ptr<views::View> CreateIcon() {
    auto icon = std::make_unique<views::View>();
    icon->SetPreferredSize(gfx::Size(16, 16));
    return icon;
  }

  ui::test::EventGenerator* generator() { return generator_.get(); }
  views::Widget* widget() { return widget_.get(); }

  views::Label* GetButtonSubtitle(const HoverButton& button) {
    return button.subtitle();
  }

  views::Label* GetButtonFooter(const HoverButton& button) {
    return button.footer();
  }

  views::View* GetButtonIconWrapper(const HoverButton& button) {
    return button.icon_wrapper_;
  }

 private:
  std::unique_ptr<views::Widget> widget_;
  std::unique_ptr<ui::test::EventGenerator> generator_;
};

// Tests whether the HoverButton has the correct tooltip and accessible name.
TEST_F(HoverButtonTest, TooltipAndAccessibleName) {
  for (size_t i = 0; i < std::size(kTitleSubtitlePairs); ++i) {
    TitleSubtitlePair pair = kTitleSubtitlePairs[i];
    SCOPED_TRACE(testing::Message() << "Index: " << i << ", expected_tooltip="
                                    << base::ToString(pair.tooltip));
    auto button =
        std::make_unique<HoverButton>(views::Button::PressedCallback(),
                                      CreateIcon(), pair.title, pair.subtitle);
    views::IgnoreMissingWidgetForTestingScopedSetter ignore_missing_widget(
        button->GetViewAccessibility());

    button->SetSize(gfx::Size(kButtonWidth, 40));

    // The accessible name should always be the title and subtitle concatenated
    // by \n.
    const std::u16string expected =
        base::StrCat({pair.title, u"\n", pair.subtitle});
    EXPECT_EQ(expected, GetAccessibleName(*button));

    EXPECT_EQ(pair.tooltip ? expected : std::u16string(),
              button->GetRenderedTooltipText(gfx::Point()));
  }
}

TEST_F(HoverButtonTest, TooltipAndAccessibleNameWithFooter) {
  auto button = std::make_unique<HoverButton>(
      views::Button::PressedCallback(), CreateIcon(), u"Title", u"Subtitle",
      /*secondary_icon=*/nullptr,
      /*add_vertical_label_spacing=*/true, u"Footer");
  button->SetSize(gfx::Size(kButtonWidth, 40));
  // The accessible name should be the title, subtitle, and footer concatenated
  // by \n.
  const std::u16string expected = u"Title\nSubtitle\nFooter";

  views::IgnoreMissingWidgetForTestingScopedSetter ignore_missing_widget(
      button->GetViewAccessibility());

  EXPECT_EQ(expected, GetAccessibleName(*button));
  EXPECT_EQ(std::u16string(), button->GetRenderedTooltipText(gfx::Point()));
}

TEST_F(HoverButtonTest, TooltipAndAccessibleName_DynamicTextUpdate) {
  std::u16string original_title = u"Title";
  std::u16string original_subtitle = u"Subtitle";

  auto button = std::make_unique<HoverButton>(views::Button::PressedCallback(),
                                              CreateIcon(), original_title,
                                              original_subtitle);
  button->SetSize(gfx::Size(kButtonWidth, 40));

  views::IgnoreMissingWidgetForTestingScopedSetter ignore_missing_widget(
      button->GetViewAccessibility());

  // Verify accessible has the original title and subtitle text, and tooltip is
  // empty since text fits in the button.
  std::u16string expected =
      base::StrCat({original_title, u"\n", original_subtitle});
  EXPECT_EQ(expected, GetAccessibleName(*button));
  EXPECT_EQ(std::u16string(), button->GetTooltipText());

  // Update the title with text that still fits in the button.
  std::u16string updated_title = u"New title";
  button->title()->SetText(updated_title);

  // Verify accessible name has the updated title, and tooltip is still empty
  // since text fits in the button.
  expected = base::StrCat({updated_title, u"\n", original_subtitle});
  EXPECT_EQ(expected, GetAccessibleName(*button));
  EXPECT_EQ(std::u16string(), button->GetTooltipText());

  // Update the subtitle with text that doesn't fit in the button.
  std::u16string updated_subtitle =
      u"A very long new subtitle that should not fit in the button";
  GetButtonSubtitle(*button)->SetText(updated_subtitle);

  // Verify both accessible name and tooltip have the updated title and
  // subtitle.
  expected = base::StrCat({updated_title, u"\n", updated_subtitle});
  EXPECT_EQ(expected, GetAccessibleName(*button));
  EXPECT_EQ(expected, button->GetTooltipText());
}

// Tests that a button with a subtitle and icons can be instantiated without a
// crash.
TEST_F(HoverButtonTest, CreateButtonWithSubtitleAndIcons) {
  std::unique_ptr<views::View> primary_icon = CreateIcon();
  views::View* primary_icon_raw = primary_icon.get();
  std::unique_ptr<views::View> secondary_icon = CreateIcon();
  views::View* secondary_icon_raw = secondary_icon.get();

  HoverButton button(views::Button::PressedCallback(), std::move(primary_icon),
                     u"Title", u"Subtitle", std::move(secondary_icon));
  EXPECT_TRUE(button.Contains(primary_icon_raw));
  EXPECT_TRUE(button.Contains(secondary_icon_raw));
}

// Tests a button with a subtitle and a footer.
TEST_F(HoverButtonTest, CreateButtonWithSubtitleAndFooter) {
  std::unique_ptr<views::View> primary_icon = CreateIcon();
  views::View* primary_icon_raw = primary_icon.get();
  std::unique_ptr<views::View> secondary_icon = CreateIcon();
  views::View* secondary_icon_raw = secondary_icon.get();
  HoverButton button(views::Button::PressedCallback(), std::move(primary_icon),
                     u"Title", u"Subtitle", std::move(secondary_icon),
                     /*add_vertical_label_spacing=*/true, u"Footer");
  EXPECT_TRUE(button.Contains(primary_icon_raw));
  EXPECT_TRUE(button.Contains(secondary_icon_raw));
  EXPECT_EQ(button.title()->GetText(), u"Title");
  EXPECT_EQ(GetButtonSubtitle(button)->GetText(), u"Subtitle");
  EXPECT_EQ(GetButtonFooter(button)->GetText(), u"Footer");
}

// Tests that the button is activated on mouse release rather than mouse press.
TEST_F(HoverButtonTest, ActivatesOnMouseReleased) {
  bool clicked = false;
  HoverButton* button = widget()->SetContentsView(std::make_unique<HoverButton>(
      base::BindRepeating([](bool* clicked) { *clicked = true; }, &clicked),
      CreateIcon(), u"Title", std::u16string()));
  button->SetBoundsRect(gfx::Rect(100, 100, 200, 200));
  widget()->Show();

  // Button callback should not be called on press.
  generator()->PressLeftButton();
  EXPECT_FALSE(clicked);

  // Button callback should be called on release.
  generator()->ReleaseLeftButton();
  EXPECT_TRUE(clicked);

  widget()->Close();
}

// Test that changing the text style updates the return value of
// views::View::GetHeightForWidth().
TEST_F(HoverButtonTest, ChangingTextStyleResizesButton) {
  auto button = std::make_unique<HoverButton>(
      views::Button::PressedCallback(), CreateIcon(), u"Title", u"Subtitle");
  button->SetSubtitleTextStyle(views::style::CONTEXT_LABEL,
                               views::style::STYLE_SECONDARY);
  int height1 = button->GetHeightForWidth(100);
  button->SetSubtitleTextStyle(views::style::CONTEXT_DIALOG_TITLE,
                               views::style::STYLE_SECONDARY);
  int height2 = button->GetHeightForWidth(100);
  EXPECT_NE(height1, height2);
}

// No touch on desktop Mac.
#if !BUILDFLAG(IS_MAC) || defined(USE_AURA)

// Tests that tapping hover button does not crash if the tap handler removes the
// button from views hierarchy.
TEST_F(HoverButtonTest, TapGestureThatDeletesTheButton) {
  bool clicked = false;
  HoverButton* button = widget()->SetContentsView(std::make_unique<HoverButton>(
      base::BindRepeating(
          [](bool* clicked, views::Widget* widget) {
            *clicked = true;
            // Update the widget contents view, which deletes the hover button.
            widget->SetContentsView(std::make_unique<views::View>());
          },
          &clicked, widget()),
      CreateIcon(), u"Title", std::u16string()));
  button->SetBoundsRect(gfx::Rect(100, 100, 200, 200));
  widget()->Show();

  generator()->GestureTapAt(gfx::Point(150, 150));
  EXPECT_TRUE(clicked);

  widget()->Close();
}

TEST_F(HoverButtonTest, SetIconHorizontalMargins) {
  std::unique_ptr<views::View> primary_icon = CreateIcon();

  HoverButton button(views::Button::PressedCallback(), std::move(primary_icon),
                     u"Title");
  button.SetIconHorizontalMargins(/*left=*/3, /*right=*/4);
  gfx::Insets* margins =
      GetButtonIconWrapper(button)->GetProperty(views::kMarginsKey);
  EXPECT_EQ(margins->left(), 3);
  EXPECT_EQ(margins->right(), 4);
}

TEST_F(HoverButtonTest, AddExtraAccessibleText) {
  std::unique_ptr<views::View> primary_icon = CreateIcon();
  auto button = std::make_unique<HoverButton>(
      views::Button::PressedCallback(), std::move(primary_icon), u"Title");
  button->AddExtraAccessibleText(u"A11y text");

  views::IgnoreMissingWidgetForTestingScopedSetter ignore_missing_widget(
      button->GetViewAccessibility());
  button->SetSize(gfx::Size(kButtonWidth, 40));

  EXPECT_EQ(GetAccessibleName(*button), u"Title\nA11y text");
}

#endif  // !BUILDFLAG(IS_MAC) || defined(USE_AURA)