1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <vector>
#include "base/memory/raw_ptr.h"
#include "base/numerics/safe_conversions.h"
#include "base/metrics/histogram_base.h"
#include "base/run_loop.h"
#include "base/scoped_observation.h"
#include "base/strings/strcat.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/browser/apps/app_service/app_service_proxy.h"
#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
#include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h"
#include "chrome/browser/apps/link_capturing/metrics/intent_handling_metrics.h"
#include "chrome/browser/ash/app_list/arc/arc_app_list_prefs.h"
#include "chrome/browser/ash/arc/arc_util.h"
#include "chrome/browser/ash/arc/session/arc_session_manager.h"
#include "chrome/browser/ui/actions/chrome_action_id.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_navigator_params.h"
#include "chrome/browser/ui/intent_picker_tab_helper.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/toolbar_button_provider.h"
#include "chrome/browser/ui/views/intent_picker_bubble_view.h"
#include "chrome/browser/ui/views/location_bar/intent_chip_button.h"
#include "chrome/browser/ui/views/location_bar/intent_picker_view.h"
#include "chrome/browser/ui/views/page_action/page_action_view.h"
#include "chrome/browser/ui/views/web_apps/web_app_link_capturing_test_utils.h"
#include "chrome/browser/ui/web_applications/app_browser_controller.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/web_applications/link_capturing_features.h"
#include "chrome/browser/web_applications/mojom/user_display_mode.mojom.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "chromeos/ash/experiences/arc/session/arc_bridge_service.h"
#include "chromeos/ash/experiences/arc/session/arc_service_manager.h"
#include "chromeos/ash/experiences/arc/test/arc_util_test_support.h"
#include "chromeos/ash/experiences/arc/test/connection_holder_util.h"
#include "chromeos/ash/experiences/arc/test/fake_app_instance.h"
#include "chromeos/ash/experiences/arc/test/fake_intent_helper_instance.h"
#include "components/services/app_service/public/cpp/app_types.h"
#include "components/services/app_service/public/cpp/icon_loader.h"
#include "components/services/app_service/public/cpp/intent_filter_util.h"
#include "components/services/app_service/public/cpp/intent_test_util.h"
#include "components/services/app_service/public/cpp/intent_util.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/events/base_event_utils.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/image/image_skia_rep.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/button/checkbox.h"
#include "ui/views/test/button_test_api.h"
#include "ui/views/test/dialog_test.h"
#include "ui/views/view_utils.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_observer.h"
#include "ui/views/widget/widget_utils.h"
#include "url/gurl.h"
#include "url/url_constants.h"
namespace {
const char kTestAppActivity[] = "abcdefg";
constexpr char kMigrationEnabled[] = "MigrationEnabled";
constexpr char kMigrationDisabled[] = "MigrationDisabled";
class FakeIconLoader : public apps::IconLoader {
public:
FakeIconLoader() = default;
FakeIconLoader(const FakeIconLoader&) = delete;
FakeIconLoader& operator=(const FakeIconLoader&) = delete;
~FakeIconLoader() override = default;
std::unique_ptr<apps::IconLoader::Releaser> LoadIconFromIconKey(
const std::string& id,
const apps::IconKey& icon_key,
apps::IconType icon_type,
int32_t size_hint_in_dip,
bool allow_placeholder_icon,
apps::LoadIconCallback callback) override {
auto iv = std::make_unique<apps::IconValue>();
iv->icon_type = icon_type;
iv->uncompressed = gfx::ImageSkia(gfx::ImageSkiaRep(gfx::Size(1, 1), 1.0f));
iv->is_placeholder_icon = false;
std::move(callback).Run(std::move(iv));
return nullptr;
}
};
// Waits for a particular widget to be destroyed.
class WidgetDestroyedWaiter : public views::WidgetObserver {
public:
explicit WidgetDestroyedWaiter(views::Widget* widget) {
observation_.Observe(widget);
}
~WidgetDestroyedWaiter() override = default;
// Blocks until OnWidgetDestroyed is called for the widget.
void WaitForDestroyed() { run_loop_.Run(); }
// views::WidgetObserver:
void OnWidgetDestroyed(views::Widget* widget) override {
run_loop_.Quit();
observation_.Reset();
}
private:
base::RunLoop run_loop_;
base::ScopedObservation<views::Widget, views::WidgetObserver> observation_{
this};
};
} // namespace
class IntentPickerBubbleViewBrowserTestChromeOSBase
: public InProcessBrowserTest {
public:
IntentPickerBubbleViewBrowserTestChromeOSBase() = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
arc::SetArcAvailableCommandLineForTesting(command_line);
}
void SetUpInProcessBrowserTestFixture() override {
InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
arc::ArcSessionManager::SetUiEnabledForTesting(false);
}
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
app_service_proxy_ = apps::AppServiceProxyFactory::GetForProfile(profile());
ASSERT_TRUE(app_service_proxy_);
app_service_proxy_->OverrideInnerIconLoaderForTesting(&icon_loader_);
arc::SetArcPlayStoreEnabledForProfile(profile(), true);
intent_helper_instance_ = std::make_unique<arc::FakeIntentHelperInstance>();
arc::ArcServiceManager::Get()
->arc_bridge_service()
->intent_helper()
->SetInstance(intent_helper_instance_.get());
WaitForInstanceReady(
arc::ArcServiceManager::Get()->arc_bridge_service()->intent_helper());
app_instance_ = std::make_unique<arc::FakeAppInstance>(app_host());
arc::ArcServiceManager::Get()->arc_bridge_service()->app()->SetInstance(
app_instance_.get());
WaitForInstanceReady(
arc::ArcServiceManager::Get()->arc_bridge_service()->app());
ASSERT_TRUE(embedded_test_server()->Start());
}
std::string AddArcAppWithIntentFilter(const std::string& app_name,
const GURL& url) {
std::vector<arc::mojom::AppInfoPtr> app_infos;
arc::mojom::AppInfoPtr app_info(arc::mojom::AppInfo::New());
app_info->name = app_name;
app_info->package_name = app_name;
app_info->activity = kTestAppActivity;
app_info->sticky = false;
app_infos.push_back(std::move(app_info));
app_host()->OnAppListRefreshed(std::move(app_infos));
std::string app_id = ArcAppListPrefs::GetAppId(app_name, kTestAppActivity);
auto test_app_info = app_prefs()->GetApp(app_id);
EXPECT_TRUE(test_app_info);
auto app = std::make_unique<apps::App>(apps::AppType::kArc, app_id);
app->name = app_name;
app->intent_filters.push_back(apps_util::MakeIntentFilterForUrlScope(url));
std::vector<apps::AppPtr> apps;
apps.push_back(std::move(app));
app_service_proxy_->OnApps(std::move(apps), apps::AppType::kArc,
false /* should_notify_initialized */);
return app_id;
}
std::string InstallWebApp(const std::string& app_name, const GURL& url) {
auto web_app_info =
web_app::WebAppInstallInfo::CreateWithStartUrlForTesting(url);
web_app_info->title = base::UTF8ToUTF16(app_name);
web_app_info->scope = url;
web_app_info->user_display_mode =
web_app::mojom::UserDisplayMode::kStandalone;
auto app_id =
web_app::test::InstallWebApp(profile(), std::move(web_app_info));
return app_id;
}
IntentPickerBubbleView* intent_picker_bubble() {
return IntentPickerBubbleView::intent_picker_bubble();
}
views::Checkbox* remember_selection_checkbox() {
return views::AsViewClass<views::Checkbox>(
intent_picker_bubble()->GetViewByID(
IntentPickerBubbleView::ViewId::kRememberCheckbox));
}
// TODO(crbug.com/40203946): There should be an explicit signal we can wait on
// rather than assuming the AppService will be started after RunUntilIdle.
void WaitForAppService() { base::RunLoop().RunUntilIdle(); }
ArcAppListPrefs* app_prefs() { return ArcAppListPrefs::Get(profile()); }
// Returns as AppHost interface in order to access to private implementation
// of the interface.
arc::mojom::AppHost* app_host() { return app_prefs(); }
Profile* profile() { return browser()->profile(); }
// The handled intents list in the intent helper instance represents the arc
// app that app service tried to launch.
const std::vector<arc::FakeIntentHelperInstance::HandledIntent>&
launched_arc_apps() {
return intent_helper_instance_->handled_intents();
}
void clear_launched_arc_apps() {
intent_helper_instance_->clear_handled_intents();
}
virtual bool IsMigrationEnabled() const = 0;
views::Button* GetIntentPickerIcon() {
auto* toolbar_button_provider =
BrowserView::GetBrowserViewForBrowser(browser())
->toolbar_button_provider();
if (IsMigrationEnabled()) {
return toolbar_button_provider->GetPageActionView(kActionShowIntentPicker);
}
return toolbar_button_provider->GetIntentChipButton();
}
void ClickIconToShowBubble() {
views::NamedWidgetShownWaiter waiter(
views::test::AnyWidgetTestPasskey{},
IntentPickerBubbleView::kViewClassName);
views::test::ButtonTestApi test_api(GetIntentPickerIcon());
test_api.NotifyClick(ui::MouseEvent(
ui::EventType::kMousePressed, gfx::Point(), gfx::Point(),
base::TimeTicks(), ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON));
waiter.WaitIfNeededAndGet();
ASSERT_NE(intent_picker_bubble(), nullptr);
EXPECT_TRUE(intent_picker_bubble()->GetVisible());
}
void NavigateAndWaitForIconUpdate(const GURL& url) {
DoAndWaitForIntentPickerIconUpdate([this, url]() {
NavigateParams params(browser(), url,
ui::PageTransition::PAGE_TRANSITION_LINK);
ui_test_utils::NavigateToURL(¶ms);
});
}
// Dummy method to be called upon bubble closing.
void OnBubbleClosed(const std::string& selected_app_package,
apps::PickerEntryType entry_type,
apps::IntentPickerCloseReason close_reason,
bool should_persist) {
bubble_closed_ = true;
}
void ShowBubbleForTesting() {
std::vector<apps::IntentPickerAppInfo> app_info;
app_info.emplace_back(apps::PickerEntryType::kArc, ui::ImageModel(),
"package_1", "dank app 1");
app_info.emplace_back(apps::PickerEntryType::kArc, ui::ImageModel(),
"package_2", "dank_app_2");
browser()->window()->ShowIntentPickerBubble(
std::move(app_info), /*show_stay_in_chrome=*/true,
/*show_remember_selection=*/true,
IntentPickerBubbleView::BubbleType::kLinkCapturing, std::nullopt,
base::BindOnce(
&IntentPickerBubbleViewBrowserTestChromeOSBase::OnBubbleClosed,
base::Unretained(this)));
}
bool bubble_closed() { return bubble_closed_; }
void CheckStayInChrome() {
ASSERT_TRUE(intent_picker_bubble());
intent_picker_bubble()->CancelDialog();
EXPECT_EQ(BrowserList::GetInstance()->GetLastActive(), browser());
EXPECT_EQ(launched_arc_apps().size(), 0U);
}
void VerifyArcAppLaunched(const std::string& app_name, const GURL& test_url) {
WaitForAppService();
ASSERT_EQ(1U, launched_arc_apps().size());
EXPECT_EQ(app_name, launched_arc_apps()[0].activity->package_name);
EXPECT_EQ(test_url.spec(), launched_arc_apps()[0].intent->data);
}
bool VerifyPWALaunched(const std::string& app_id) {
WaitForAppService();
Browser* app_browser = BrowserList::GetInstance()->GetLastActive();
return web_app::AppBrowserController::IsForWebApp(app_browser, app_id);
}
size_t GetItemContainerSize(IntentPickerBubbleView* bubble) {
return bubble->GetViewByID(IntentPickerBubbleView::ViewId::kItemContainer)
->children()
.size();
}
views::View* GetButtonAtIndex(IntentPickerBubbleView* bubble, size_t index) {
auto children =
bubble->GetViewByID(IntentPickerBubbleView::ViewId::kItemContainer)
->children();
CHECK_LT(index, children.size());
return children[index];
}
GURL InScopeAppUrl() {
return embedded_test_server()->GetURL("/web_apps/standalone/basic.html");
}
GURL OutOfScopeAppUrl() {
return embedded_test_server()->GetURL("/web_apps/minimal_ui/basic.html");
}
content::WebContents* GetWebContents() {
return browser()->tab_strip_model()->GetActiveWebContents();
}
template <typename Action>
void DoAndWaitForIntentPickerIconUpdate(Action action) {
base::RunLoop run_loop;
auto* tab_helper = IntentPickerTabHelper::FromWebContents(GetWebContents());
tab_helper->SetIconUpdateCallbackForTesting(run_loop.QuitClosure());
action();
run_loop.Run();
}
void ClickAppAtIndexOnGrid(size_t index) {
auto event_generator = ui::test::EventGenerator(
views::GetRootWindow(intent_picker_bubble()->GetWidget()));
event_generator.MoveMouseTo(GetButtonAtIndex(intent_picker_bubble(), index)
->GetBoundsInScreen()
.CenterPoint());
event_generator.ClickLeftButton();
}
private:
raw_ptr<apps::AppServiceProxy, DanglingUntriaged> app_service_proxy_ =
nullptr;
std::unique_ptr<arc::FakeIntentHelperInstance> intent_helper_instance_;
std::unique_ptr<arc::FakeAppInstance> app_instance_;
FakeIconLoader icon_loader_;
bool bubble_closed_ = false;
};
class IntentPickerBubbleViewBrowserTestChromeOS
: public IntentPickerBubbleViewBrowserTestChromeOSBase,
public ::testing::WithParamInterface<bool> {
public:
IntentPickerBubbleViewBrowserTestChromeOS() {
feature_list_.InitAndEnableFeatureWithParameters(
features::kPageActionsMigration,
{{features::kPageActionsMigrationIntentPicker.name,
IsMigrationEnabled() ? "true" : "false"}});
}
bool IsMigrationEnabled() const override { return GetParam(); }
private:
base::test::ScopedFeatureList feature_list_;
};
// Test that the intent picker bubble will show for ARC apps.
//
// TODO(crbug.com/40863954): Fix timeouts under MSAN.
#if defined(MEMORY_SANITIZER)
#define MAYBE_ArcOnlyShowBubble Disabled_ArcOnlyShowBubble
#else
#define MAYBE_ArcOnlyShowBubble ArcOnlyShowBubble
#endif
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
MAYBE_ArcOnlyShowBubble) {
GURL test_url(InScopeAppUrl());
std::string app_name = "test_name";
auto app_id = AddArcAppWithIntentFilter(app_name, test_url);
views::Button* intent_picker_view = GetIntentPickerIcon();
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
EXPECT_EQ(1U, GetItemContainerSize(intent_picker_bubble()));
auto& app_info = intent_picker_bubble()->app_info_for_testing();
ASSERT_EQ(1U, app_info.size());
EXPECT_EQ(app_id, app_info[0].launch_name);
EXPECT_EQ(app_name, app_info[0].display_name);
// Check the status of the remember selection checkbox.
ASSERT_TRUE(remember_selection_checkbox());
EXPECT_TRUE(remember_selection_checkbox()->GetEnabled());
EXPECT_FALSE(remember_selection_checkbox()->GetChecked());
// Launch the default selected app.
EXPECT_EQ(0U, launched_arc_apps().size());
DoAndWaitForIntentPickerIconUpdate([this, app_name, test_url] {
intent_picker_bubble()->AcceptDialog();
ASSERT_NO_FATAL_FAILURE(VerifyArcAppLaunched(app_name, test_url));
});
// Make sure that the intent picker icon is no longer visible.
ASSERT_TRUE(intent_picker_view);
EXPECT_FALSE(intent_picker_view->GetVisible());
}
// Test that intent picker bubble shows if there is only PWA as candidates.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
PWAOnlyShowBubble) {
GURL test_url(InScopeAppUrl());
std::string app_name = "test_name";
auto app_id = InstallWebApp(app_name, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
EXPECT_EQ(1U, GetItemContainerSize(intent_picker_bubble()));
auto& app_info = intent_picker_bubble()->app_info_for_testing();
ASSERT_EQ(1U, app_info.size());
EXPECT_EQ(app_id, app_info[0].launch_name);
EXPECT_EQ(app_name, app_info[0].display_name);
// Check the status of the remember selection checkbox.
ASSERT_TRUE(remember_selection_checkbox());
EXPECT_TRUE(remember_selection_checkbox()->GetEnabled());
EXPECT_FALSE(remember_selection_checkbox()->GetChecked());
// Launch the app.
intent_picker_bubble()->AcceptDialog();
EXPECT_TRUE(VerifyPWALaunched(app_id));
}
// Test that show intent picker bubble multiple times without closing doesn't
// crash the browser.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
ShowBubbleMultipleTimes) {
ShowBubbleForTesting();
auto* bubble_1 = intent_picker_bubble();
ASSERT_TRUE(bubble_1);
EXPECT_TRUE(bubble_1->GetVisible());
EXPECT_EQ(2U, GetItemContainerSize(intent_picker_bubble()));
WidgetDestroyedWaiter bubble_1_waiter(bubble_1->GetWidget());
ShowBubbleForTesting();
auto* bubble_2 = intent_picker_bubble();
ASSERT_TRUE(bubble_2);
EXPECT_TRUE(bubble_2->GetVisible());
EXPECT_EQ(2U, GetItemContainerSize(intent_picker_bubble()));
// Bubble 1 should be fully destroyed after the second bubble appears.
bubble_1_waiter.WaitForDestroyed();
WidgetDestroyedWaiter bubble_2_waiter(bubble_2->GetWidget());
ShowBubbleForTesting();
auto* bubble_3 = intent_picker_bubble();
ASSERT_TRUE(bubble_3);
EXPECT_TRUE(bubble_3->GetVisible());
EXPECT_EQ(2U, GetItemContainerSize(intent_picker_bubble()));
// Bubble 2 should be fully destroyed after the third bubble appears.
bubble_2_waiter.WaitForDestroyed();
}
// Test that loading a page with pushState() call that doesn't change URL work
// as normal.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
PushStateLoadingTest) {
const GURL test_url =
embedded_test_server()->GetURL("/intent_picker/push_state_test.html");
std::string app_name = "test_name";
auto app_id = AddArcAppWithIntentFilter(app_name, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
EXPECT_EQ(1U, GetItemContainerSize(intent_picker_bubble()));
auto& app_info = intent_picker_bubble()->app_info_for_testing();
ASSERT_EQ(1U, app_info.size());
EXPECT_EQ(app_id, app_info[0].launch_name);
EXPECT_EQ(app_name, app_info[0].display_name);
// Launch the default selected app.
EXPECT_EQ(0U, launched_arc_apps().size());
intent_picker_bubble()->AcceptDialog();
ASSERT_NO_FATAL_FAILURE(VerifyArcAppLaunched(app_name, test_url));
}
// Test that reload a page after app installation will show intent picker.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
ReloadAfterInstall) {
GURL test_url(InScopeAppUrl());
views::Button* intent_picker_view = GetIntentPickerIcon();
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
EXPECT_FALSE(intent_picker_view->GetVisible());
std::string app_name = "test_name";
auto app_id = AddArcAppWithIntentFilter(app_name, test_url);
// Reload the page and the intent picker should show up.
DoAndWaitForIntentPickerIconUpdate([this] {
chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);
});
EXPECT_TRUE(intent_picker_view->GetVisible());
ClickIconToShowBubble();
EXPECT_EQ(1U, GetItemContainerSize(intent_picker_bubble()));
auto& app_info = intent_picker_bubble()->app_info_for_testing();
ASSERT_EQ(1U, app_info.size());
EXPECT_EQ(app_id, app_info[0].launch_name);
EXPECT_EQ(app_name, app_info[0].display_name);
// Launch the default selected app.
EXPECT_EQ(0U, launched_arc_apps().size());
intent_picker_bubble()->AcceptDialog();
ASSERT_NO_FATAL_FAILURE(VerifyArcAppLaunched(app_name, test_url));
}
// Test that stay in chrome works when there is only PWA candidates.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
StayInChromePWAOnly) {
GURL test_url(InScopeAppUrl());
std::string app_name = "test_name";
auto app_id = InstallWebApp(app_name, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
ASSERT_NO_FATAL_FAILURE(CheckStayInChrome());
}
// Test that stay in chrome works when there is only ARC candidates.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
StayInChromeARCOnly) {
GURL test_url(InScopeAppUrl());
std::string app_name = "test_name";
auto app_id = AddArcAppWithIntentFilter(app_name, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
ASSERT_NO_FATAL_FAILURE(CheckStayInChrome());
}
// Test that bubble pops out when there is both PWA and ARC candidates, and
// test launch the PWA.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
ARCAndPWACandidateLaunchPWA) {
base::HistogramTester histogram_tester;
GURL test_url(InScopeAppUrl());
std::string app_name_pwa = "pwa_test_name";
auto app_id_pwa = InstallWebApp(app_name_pwa, test_url);
std::string app_name_arc = "arc_test_name";
auto app_id_arc = AddArcAppWithIntentFilter(app_name_arc, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
EXPECT_EQ(2U, GetItemContainerSize(intent_picker_bubble()));
auto& app_info = intent_picker_bubble()->app_info_for_testing();
ASSERT_EQ(2U, app_info.size());
const apps::IntentPickerAppInfo* pwa_app_info;
const apps::IntentPickerAppInfo* arc_app_info;
size_t index_for_pwa = 0;
if (app_info[0].launch_name == app_id_pwa) {
pwa_app_info = &app_info[0];
arc_app_info = &app_info[1];
index_for_pwa = 0;
} else {
pwa_app_info = &app_info[1];
arc_app_info = &app_info[0];
index_for_pwa = 1;
}
ClickAppAtIndexOnGrid(index_for_pwa);
EXPECT_EQ(app_id_pwa, pwa_app_info->launch_name);
EXPECT_EQ(app_name_pwa, pwa_app_info->display_name);
EXPECT_EQ(app_id_arc, arc_app_info->launch_name);
EXPECT_EQ(app_name_arc, arc_app_info->display_name);
// Check the status of the remember selection checkbox.
ASSERT_TRUE(remember_selection_checkbox());
EXPECT_TRUE(remember_selection_checkbox()->GetEnabled());
EXPECT_FALSE(remember_selection_checkbox()->GetChecked());
// Launch the app.
intent_picker_bubble()->AcceptDialog();
EXPECT_TRUE(VerifyPWALaunched(app_id_pwa));
// WebApp histogram.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.WebApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kAppOpened, 1);
// ArcApp histogram.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2.ArcApp",
apps::IntentHandlingMetrics::LinkCapturingEvent::kAppOpened, 0);
// General histogram.
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kEntryPointShown, 1);
histogram_tester.ExpectBucketCount(
"ChromeOS.Intents.LinkCapturingEvent2",
apps::IntentHandlingMetrics::LinkCapturingEvent::kAppOpened, 1);
}
// Test that bubble pops out when there is both PWA and ARC candidates, and
// test launch the ARC app.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
ARCAndPWACandidateLaunchARC) {
GURL test_url(InScopeAppUrl());
std::string app_name_pwa = "pwa_test_name";
auto app_id_pwa = InstallWebApp(app_name_pwa, test_url);
std::string app_name_arc = "arc_test_name";
auto app_id_arc = AddArcAppWithIntentFilter(app_name_arc, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
EXPECT_EQ(2U, GetItemContainerSize(intent_picker_bubble()));
auto& app_info = intent_picker_bubble()->app_info_for_testing();
ASSERT_EQ(2U, app_info.size());
const apps::IntentPickerAppInfo* pwa_app_info;
const apps::IntentPickerAppInfo* arc_app_info;
size_t arc_app_index = 0;
if (app_info[0].launch_name == app_id_pwa) {
pwa_app_info = &app_info[0];
arc_app_info = &app_info[1];
arc_app_index = 1;
} else {
pwa_app_info = &app_info[1];
arc_app_info = &app_info[0];
arc_app_index = 0;
}
ClickAppAtIndexOnGrid(arc_app_index);
EXPECT_EQ(app_id_pwa, pwa_app_info->launch_name);
EXPECT_EQ(app_name_pwa, pwa_app_info->display_name);
EXPECT_EQ(app_id_arc, arc_app_info->launch_name);
EXPECT_EQ(app_name_arc, arc_app_info->display_name);
// Check the status of the remember selection checkbox.
ASSERT_TRUE(remember_selection_checkbox());
EXPECT_TRUE(remember_selection_checkbox()->GetEnabled());
EXPECT_FALSE(remember_selection_checkbox()->GetChecked());
// Launch the app.
EXPECT_EQ(0U, launched_arc_apps().size());
intent_picker_bubble()->AcceptDialog();
ASSERT_NO_FATAL_FAILURE(VerifyArcAppLaunched(app_name_arc, test_url));
}
// Test that stay in chrome works when there is both PWA and ARC candidates.
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOS,
StayInChromeARCAndPWA) {
GURL test_url(InScopeAppUrl());
std::string app_name_pwa = "pwa_test_name";
auto app_id_pwa = InstallWebApp(app_name_pwa, test_url);
std::string app_name_arc = "arc_test_name";
auto app_id_arc = AddArcAppWithIntentFilter(app_name_arc, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
ASSERT_NO_FATAL_FAILURE(CheckStayInChrome());
}
INSTANTIATE_TEST_SUITE_P(All,
IntentPickerBubbleViewBrowserTestChromeOS,
testing::Bool(),
[](const testing::TestParamInfo<bool>& info) {
return info.param ? kMigrationEnabled
: kMigrationDisabled;
});
class IntentPickerBubbleViewBrowserTestChromeOSParameterized
: public IntentPickerBubbleViewBrowserTestChromeOSBase,
public testing::WithParamInterface<
std::tuple<apps::test::LinkCapturingFeatureVersion, bool>> {
public:
using ParamType = std::tuple<apps::test::LinkCapturingFeatureVersion, bool>;
IntentPickerBubbleViewBrowserTestChromeOSParameterized() {
std::vector<base::test::FeatureRefAndParams> features_to_enable =
apps::test::GetFeaturesToEnableLinkCapturingUX(std::get<0>(GetParam()));
std::vector<base::test::FeatureRef> features_to_disable;
if (std::get<1>(GetParam())) {
features_to_enable.push_back(
{features::kPageActionsMigration,
{{features::kPageActionsMigrationIntentPicker.name, "true"}}});
} else {
features_to_disable.push_back(features::kPageActionsMigration);
}
feature_list_.InitWithFeaturesAndParameters(features_to_enable,
features_to_disable);
}
bool IsMigrationEnabled() const override { return std::get<1>(GetParam()); }
apps::test::LinkCapturingFeatureVersion GetLinkCapturingVersionParam() const {
return std::get<0>(GetParam());
}
bool IsMigrationEnabledTupleElement() const {
return std::get<1>(GetParam());
}
private:
base::test::ScopedFeatureList feature_list_;
};
// Test that remember this choice checkbox works for open ARC app option.
//
// TODO(crbug.com/40863954): Fix timeouts under MSAN.
#if defined(MEMORY_SANITIZER)
#define MAYBE_RememberOpenARCApp DISABLED_RememberOpenARCApp
#else
#define MAYBE_RememberOpenARCApp RememberOpenARCApp
#endif
IN_PROC_BROWSER_TEST_P(IntentPickerBubbleViewBrowserTestChromeOSParameterized,
MAYBE_RememberOpenARCApp) {
GURL test_url(InScopeAppUrl());
std::string app_name = "test_name";
auto app_id = AddArcAppWithIntentFilter(app_name, test_url);
chrome::NewTab(browser());
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateAndWaitForIconUpdate(test_url);
ClickIconToShowBubble();
// Check "Remember my choice" and choose "Open App".
ASSERT_TRUE(remember_selection_checkbox());
ASSERT_TRUE(remember_selection_checkbox()->GetEnabled());
remember_selection_checkbox()->SetChecked(true);
ASSERT_TRUE(intent_picker_bubble());
intent_picker_bubble()->AcceptDialog();
WaitForAppService();
// Navigate to the same site again, and verify the app is automatically
// launched.
clear_launched_arc_apps();
ASSERT_TRUE(
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)));
NavigateParams params(browser(), test_url,
ui::PageTransition::PAGE_TRANSITION_LINK);
ui_test_utils::NavigateToURL(¶ms);
ASSERT_NO_FATAL_FAILURE(VerifyArcAppLaunched(app_name, test_url));
// Navigate to the same site again, this time in a new tab (which would allow
// the non-arc navigation capturing code to also potentially trigger on this
// navigation), and verify the app was launched.
clear_launched_arc_apps();
content::RenderFrameHost* rfh =
ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL));
ASSERT_TRUE(rfh);
EXPECT_TRUE(content::ExecJs(
rfh,
content::JsReplace("window.open($1, '_blank', 'noopener');", test_url)));
ASSERT_NO_FATAL_FAILURE(VerifyArcAppLaunched(app_name, test_url));
}
INSTANTIATE_TEST_SUITE_P(
All,
IntentPickerBubbleViewBrowserTestChromeOSParameterized,
testing::Combine(
testing::Values(apps::test::LinkCapturingFeatureVersion::kV1DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOff),
testing::Bool()),
[](const testing::TestParamInfo<
IntentPickerBubbleViewBrowserTestChromeOSParameterized::ParamType>&
info) {
return base::StrCat(
{std::get<1>(info.param) ? kMigrationEnabled : kMigrationDisabled,
"_", apps::test::ToString(std::get<0>(info.param))});
});
|