1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/scoped_observation.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/ui/views/menu_test_base.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/dragdrop/mojom/drag_drop_types.mojom.h"
#include "ui/base/dragdrop/os_exchange_data.h"
#include "ui/base/metadata/metadata_header_macros.h"
#include "ui/base/metadata/metadata_impl_macros.h"
#include "ui/base/ozone_buildflags.h"
#include "ui/compositor/layer_tree_owner.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/controls/menu/menu_controller.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/controls/menu/submenu_view.h"
#include "ui/views/view.h"
#include "ui/views/widget/drop_helper.h"
namespace {
using ::ui::mojom::DragOperation;
const char16_t kTestNestedDragData[] = u"test_nested_drag_data";
const char16_t kTestTopLevelDragData[] = u"test_top_level_drag_data";
// A simple view which can be dragged.
class TestDragView : public views::View {
METADATA_HEADER(TestDragView, views::View)
public:
TestDragView();
TestDragView(const TestDragView&) = delete;
TestDragView& operator=(const TestDragView&) = delete;
~TestDragView() override;
private:
// views::View:
int GetDragOperations(const gfx::Point& point) override;
void WriteDragData(const gfx::Point& point,
ui::OSExchangeData* data) override;
};
TestDragView::TestDragView() = default;
TestDragView::~TestDragView() = default;
int TestDragView::GetDragOperations(const gfx::Point& point) {
return ui::DragDropTypes::DRAG_MOVE;
}
void TestDragView::WriteDragData(const gfx::Point& point,
ui::OSExchangeData* data) {
data->SetString(kTestNestedDragData);
}
BEGIN_METADATA(TestDragView)
END_METADATA
// A simple view to serve as a drop target.
class TestTargetView : public views::View {
METADATA_HEADER(TestTargetView, views::View)
public:
TestTargetView() = default;
TestTargetView(const TestTargetView&) = delete;
TestTargetView& operator=(const TestTargetView&) = delete;
~TestTargetView() override = default;
// Initializes this view to have the same bounds as its parent, and to have
// two draggable child views.
void Init();
bool dragging() const { return dragging_; }
bool dropped() const { return dropped_; }
private:
// views::View:
bool GetDropFormats(int* formats,
std::set<ui::ClipboardFormatType>* format_types) override;
bool AreDropTypesRequired() override;
bool CanDrop(const OSExchangeData& data) override;
void OnDragEntered(const ui::DropTargetEvent& event) override;
int OnDragUpdated(const ui::DropTargetEvent& event) override;
DropCallback GetDropCallback(const ui::DropTargetEvent& event) override;
void OnDragExited() override;
// Performs the drop operation and updates |output_drag_op| accordingly.
void PerformDrop(const ui::DropTargetEvent& event,
ui::mojom::DragOperation& output_drag_op,
std::unique_ptr<ui::LayerTreeOwner> drag_image_layer_owner);
// Whether or not we are currently dragging.
bool dragging_ = false;
// Whether or not a drop has been performed on the view.
bool dropped_ = false;
};
void TestTargetView::Init() {
// First, fill the parent completely.
SetBoundsRect(parent()->GetLocalBounds());
// Then add two draggable views, each 10x5.
views::View* first = new TestDragView();
AddChildViewRaw(first);
first->SetBounds(2, 2, 10, 5);
views::View* second = new TestDragView();
AddChildViewRaw(second);
second->SetBounds(15, 2, 10, 5);
}
bool TestTargetView::GetDropFormats(
int* formats,
std::set<ui::ClipboardFormatType>* format_types) {
*formats = ui::OSExchangeData::STRING;
return true;
}
bool TestTargetView::AreDropTypesRequired() {
return true;
}
bool TestTargetView::CanDrop(const OSExchangeData& data) {
std::u16string contents = data.GetString().value_or(std::u16string());
return contents == kTestNestedDragData;
}
void TestTargetView::OnDragEntered(const ui::DropTargetEvent& event) {
dragging_ = true;
}
int TestTargetView::OnDragUpdated(const ui::DropTargetEvent& event) {
return ui::DragDropTypes::DRAG_MOVE;
}
views::View::DropCallback TestTargetView::GetDropCallback(
const ui::DropTargetEvent& event) {
dragging_ = false;
return base::BindOnce(&TestTargetView::PerformDrop, base::Unretained(this));
}
void TestTargetView::OnDragExited() {
dragging_ = false;
}
void TestTargetView::PerformDrop(
const ui::DropTargetEvent& event,
ui::mojom::DragOperation& output_drag_op,
std::unique_ptr<ui::LayerTreeOwner> drag_image_layer_owner) {
dropped_ = true;
output_drag_op = DragOperation::kMove;
}
BEGIN_METADATA(TestTargetView)
END_METADATA
} // namespace
class MenuViewDragAndDropTest : public MenuTestBase,
public views::WidgetObserver {
public:
MenuViewDragAndDropTest() = default;
MenuViewDragAndDropTest(const MenuViewDragAndDropTest&) = delete;
MenuViewDragAndDropTest& operator=(const MenuViewDragAndDropTest&) = delete;
~MenuViewDragAndDropTest() override = default;
protected:
// MenuTestBase:
void BuildMenu(views::MenuItemView* menu) override;
void DoTestWithMenuOpen() override;
void TearDown() override;
virtual void OnDragEntered();
void SetStopDraggingView(const views::View* view) {
views::DropHelper::SetDragEnteredCallbackForTesting(
view, base::BindRepeating(&MenuViewDragAndDropTest::OnDragEntered,
base::Unretained(this)));
}
TestTargetView* target_view() { return target_view_; }
bool asked_to_close() const { return asked_to_close_; }
bool performed_in_menu_drop() const { return performed_in_menu_drop_; }
private:
// views::MenuDelegate:
bool GetDropFormats(views::MenuItemView* menu,
int* formats,
std::set<ui::ClipboardFormatType>* format_types) override;
bool AreDropTypesRequired(views::MenuItemView* menu) override;
bool CanDrop(views::MenuItemView* menu,
const ui::OSExchangeData& data) override;
DragOperation GetDropOperation(views::MenuItemView* item,
const ui::DropTargetEvent& event,
DropPosition* position) override;
views::View::DropCallback GetDropCallback(
views::MenuItemView* menu,
DropPosition position,
const ui::DropTargetEvent& event) override;
bool CanDrag(views::MenuItemView* menu) override;
void WriteDragData(views::MenuItemView* sender,
ui::OSExchangeData* data) override;
int GetDragOperations(views::MenuItemView* sender) override;
bool ShouldCloseOnDragComplete() override;
// Performs the drop operation and updates |output_drag_op| accordingly.
void PerformDrop(const ui::DropTargetEvent& event,
ui::mojom::DragOperation& output_drag_op,
std::unique_ptr<ui::LayerTreeOwner> drag_image_layer_owner);
// The special view in the menu, which supports its own drag and drop.
raw_ptr<TestTargetView, DanglingUntriaged> target_view_ = nullptr;
// Whether or not we have been asked to close on drag complete.
bool asked_to_close_ = false;
// Whether or not a drop was performed in-menu (i.e., not including drops
// in separate child views).
bool performed_in_menu_drop_ = false;
base::ScopedObservation<views::Widget, views::WidgetObserver>
widget_observation_{this};
};
void MenuViewDragAndDropTest::BuildMenu(views::MenuItemView* menu) {
// Build a menu item that has a nested view that supports its own drag and
// drop...
views::MenuItemView* menu_item_view = menu->AppendMenuItem(1, u"item 1");
target_view_ = new TestTargetView();
menu_item_view->AddChildViewRaw(target_view_.get());
// ... as well as two other, normal items.
menu->AppendMenuItem(2, u"item 2");
menu->AppendMenuItem(3, u"item 3");
}
void MenuViewDragAndDropTest::DoTestWithMenuOpen() {
// Sanity checks: We should be showing the menu, it should have three
// children, and the first of those children should have a nested view of the
// TestTargetView.
views::SubmenuView* submenu = menu()->GetSubmenu();
ASSERT_TRUE(submenu);
ASSERT_TRUE(submenu->IsShowing());
ASSERT_EQ(3u, submenu->GetMenuItems().size());
const views::View* first_view = submenu->GetMenuItemAt(0);
ASSERT_EQ(1u, first_view->children().size());
const views::View* child_view = first_view->children().front();
EXPECT_EQ(child_view, target_view_);
// The menu is showing, so it has a widget we can observe now.
widget_observation_.Observe(submenu->GetWidget());
// We do this here (instead of in BuildMenu()) so that the menu is already
// built and the bounds are correct.
target_view_->Init();
}
void MenuViewDragAndDropTest::TearDown() {
widget_observation_.Reset();
MenuTestBase::TearDown();
}
void MenuViewDragAndDropTest::OnDragEntered() {
// Drop the element, which should result in calling OnWidgetDragComplete().
GetDragTaskRunner()->PostTask(
FROM_HERE,
base::BindOnce(base::IgnoreResult(&ui_controls::SendMouseEvents),
ui_controls::LEFT, ui_controls::UP,
ui_controls::kNoAccelerator, gfx::NativeWindow()));
}
bool MenuViewDragAndDropTest::GetDropFormats(
views::MenuItemView* menu,
int* formats,
std::set<ui::ClipboardFormatType>* format_types) {
*formats = ui::OSExchangeData::STRING;
return true;
}
bool MenuViewDragAndDropTest::AreDropTypesRequired(views::MenuItemView* menu) {
return true;
}
bool MenuViewDragAndDropTest::CanDrop(views::MenuItemView* menu,
const ui::OSExchangeData& data) {
std::u16string contents = data.GetString().value_or(std::u16string());
return contents == kTestTopLevelDragData;
}
DragOperation MenuViewDragAndDropTest::GetDropOperation(
views::MenuItemView* item,
const ui::DropTargetEvent& event,
DropPosition* position) {
return DragOperation::kMove;
}
views::View::DropCallback MenuViewDragAndDropTest::GetDropCallback(
views::MenuItemView* menu,
DropPosition position,
const ui::DropTargetEvent& event) {
return base::BindOnce(&MenuViewDragAndDropTest::PerformDrop,
base::Unretained(this));
}
bool MenuViewDragAndDropTest::CanDrag(views::MenuItemView* menu) {
return true;
}
void MenuViewDragAndDropTest::WriteDragData(views::MenuItemView* sender,
ui::OSExchangeData* data) {
data->SetString(kTestTopLevelDragData);
}
int MenuViewDragAndDropTest::GetDragOperations(views::MenuItemView* sender) {
return ui::DragDropTypes::DRAG_MOVE;
}
bool MenuViewDragAndDropTest::ShouldCloseOnDragComplete() {
asked_to_close_ = true;
return false;
}
void MenuViewDragAndDropTest::PerformDrop(
const ui::DropTargetEvent& event,
ui::mojom::DragOperation& output_drag_op,
std::unique_ptr<ui::LayerTreeOwner> drag_image_layer_owner) {
performed_in_menu_drop_ = true;
output_drag_op = DragOperation::kMove;
}
class MenuViewDragAndDropTestTestInMenuDrag : public MenuViewDragAndDropTest {
public:
MenuViewDragAndDropTestTestInMenuDrag() = default;
~MenuViewDragAndDropTestTestInMenuDrag() override = default;
// views::WidgetObserver:
void OnWidgetDragWillStart(views::Widget* widget) override;
void OnWidgetDragComplete(views::Widget* widget) override;
protected:
// MenuViewDragAndDropTest:
void DoTestWithMenuOpen() override;
private:
void StartDrag();
};
void MenuViewDragAndDropTestTestInMenuDrag::OnWidgetDragWillStart(
views::Widget* widget) {
// Enqueue an event to drag the second menu element to the third element,
// which should result in calling OnDragEntered().
const views::View* drop_target_view = menu()->GetSubmenu()->GetMenuItemAt(2);
const gfx::Point target =
ui_test_utils::GetCenterInScreenCoordinates(drop_target_view);
GetDragTaskRunner()->PostTask(
FROM_HERE, base::BindOnce(base::IgnoreResult(&ui_controls::SendMouseMove),
target.x(), target.y(), gfx::NativeWindow()));
}
void MenuViewDragAndDropTestTestInMenuDrag::OnWidgetDragComplete(
views::Widget* widget) {
// We should have performed an in-menu drop, and the nested view should not
// have had a drag and drop.
EXPECT_TRUE(performed_in_menu_drop());
EXPECT_FALSE(target_view()->dropped());
EXPECT_TRUE(asked_to_close());
// TODO(crbug.com/375959961): For X11, the menu is always closed on drag
// completion because the native widget's state is not properly updated.
#if !BUILDFLAG(IS_OZONE_X11)
EXPECT_TRUE(menu()->GetSubmenu()->IsShowing());
#endif
Done();
}
void MenuViewDragAndDropTestTestInMenuDrag::DoTestWithMenuOpen() {
MenuViewDragAndDropTest::DoTestWithMenuOpen();
// Cause the third menu item to trigger a mouse up when dragged over.
views::SubmenuView* submenu = menu()->GetSubmenu();
SetStopDraggingView(submenu->GetMenuItemAt(2));
// We're going to drag the second menu element.
views::MenuItemView* drag_view = submenu->GetMenuItemAt(1);
ASSERT_NE(nullptr, drag_view);
ui_test_utils::MoveMouseToCenterAndClick(
drag_view, ui_controls::LEFT, ui_controls::DOWN,
CreateEventTask(this, &MenuViewDragAndDropTestTestInMenuDrag::StartDrag));
}
void MenuViewDragAndDropTestTestInMenuDrag::StartDrag() {
// Begin dragging the second menu element, which should result in calling
// OnWidgetDragWillStart().
const views::View* drag_view = menu()->GetSubmenu()->GetMenuItemAt(1);
const gfx::Point current_position =
ui_test_utils::GetCenterInScreenCoordinates(drag_view);
EXPECT_TRUE(ui_controls::SendMouseMove(current_position.x() + 10,
current_position.y()));
}
// Test that an in-menu drag asks the delegate to stay open.
// TODO(pkasting): https://crbug.com/939621 Fails on Mac.
// TODO(crbug.com/40911016): Re-enable this test for linux.
#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
#define MAYBE_TestInMenuDrag DISABLED_TestInMenuDrag
#else
#define MAYBE_TestInMenuDrag TestInMenuDrag
#endif
VIEW_TEST(MenuViewDragAndDropTestTestInMenuDrag, MAYBE_TestInMenuDrag)
class MenuViewDragAndDropTestTestInMenuDragNoDrop
: public MenuViewDragAndDropTest {
public:
MenuViewDragAndDropTestTestInMenuDragNoDrop() = default;
~MenuViewDragAndDropTestTestInMenuDragNoDrop() override = default;
// MenuViewDragAndDropTest:
void OnWidgetDragWillStart(views::Widget* widget) override;
void OnWidgetDragComplete(views::Widget* widget) override;
protected:
// MenuViewDragAndDropTest:
void DoTestWithMenuOpen() override;
private:
void StartDrag();
bool CanDrop(views::MenuItemView* menu,
const ui::OSExchangeData& data) override;
};
bool MenuViewDragAndDropTestTestInMenuDragNoDrop::CanDrop(
views::MenuItemView* menu,
const ui::OSExchangeData& data) {
return false;
}
void MenuViewDragAndDropTestTestInMenuDragNoDrop::OnWidgetDragWillStart(
views::Widget* widget) {
// Sending the mouse-up event will end the drag and result in calling
// OnWidgetDragComplete().
GetDragTaskRunner()->PostTask(
FROM_HERE,
base::BindOnce(base::IgnoreResult(&ui_controls::SendMouseEvents),
ui_controls::LEFT, ui_controls::UP,
ui_controls::kNoAccelerator, gfx::NativeWindow()));
}
void MenuViewDragAndDropTestTestInMenuDragNoDrop::OnWidgetDragComplete(
views::Widget* widget) {
// We should have performed an in-menu drop, and the nested view should not
// have had a drag and drop. Since the drag happened in menu code, the
// delegate should not have been asked whether or not to close, and the menu
// should simply be closed.
EXPECT_FALSE(performed_in_menu_drop());
EXPECT_FALSE(target_view()->dropped());
EXPECT_TRUE(asked_to_close());
EXPECT_TRUE(menu()->GetSubmenu()->IsShowing());
Done();
}
void MenuViewDragAndDropTestTestInMenuDragNoDrop::DoTestWithMenuOpen() {
MenuViewDragAndDropTest::DoTestWithMenuOpen();
// We're going to drag the second menu element.
views::SubmenuView* submenu = menu()->GetSubmenu();
views::MenuItemView* drag_view = submenu->GetMenuItemAt(1);
ASSERT_NE(nullptr, drag_view);
ui_test_utils::MoveMouseToCenterAndClick(
drag_view, ui_controls::LEFT, ui_controls::DOWN,
CreateEventTask(this,
&MenuViewDragAndDropTestTestInMenuDragNoDrop::StartDrag));
}
void MenuViewDragAndDropTestTestInMenuDragNoDrop::StartDrag() {
// Begin dragging the second menu element, which should result in calling
// OnWidgetDragWillStart().
const views::View* drag_view = menu()->GetSubmenu()->GetMenuItemAt(1);
const gfx::Point current_position =
ui_test_utils::GetCenterInScreenCoordinates(drag_view);
EXPECT_TRUE(ui_controls::SendMouseMove(current_position.x() + 10,
current_position.y()));
}
// TODO(crbug.com/375959961): For X11, the menu is closed on drag completion
// because the native widget's state is not properly updated.
#if BUILDFLAG(IS_OZONE_X11)
#define MAYBE_TestInMenuDragNoDrop DISABLED_TestInMenuDragNoDrop
#else
#define MAYBE_TestInMenuDragNoDrop TestInMenuDragNoDrop
#endif
// Test that an in-menu (i.e., entirely implemented in the menu code) does not
// close the menu when the drag is complete but there is no drop.
VIEW_TEST(MenuViewDragAndDropTestTestInMenuDragNoDrop,
MAYBE_TestInMenuDragNoDrop)
class MenuViewDragAndDropTestNestedDrag : public MenuViewDragAndDropTest {
public:
MenuViewDragAndDropTestNestedDrag() = default;
~MenuViewDragAndDropTestNestedDrag() override = default;
// views::WidgetObserver:
void OnWidgetDragWillStart(views::Widget* widget) override;
void OnWidgetDragComplete(views::Widget* widget) override;
protected:
// MenuViewDragAndDropTest:
void DoTestWithMenuOpen() override;
void OnDragEntered() override;
private:
void StartDrag();
};
void MenuViewDragAndDropTestNestedDrag::OnWidgetDragWillStart(
views::Widget* widget) {
// Enqueue an event to drag the target's first child to its second, which
// should result in calling OnDragEntered().
const views::View* drop_target_view = target_view()->children()[1];
const gfx::Point target =
ui_test_utils::GetCenterInScreenCoordinates(drop_target_view);
GetDragTaskRunner()->PostTask(
FROM_HERE, base::BindOnce(base::IgnoreResult(&ui_controls::SendMouseMove),
target.x(), target.y(), gfx::NativeWindow()));
}
void MenuViewDragAndDropTestNestedDrag::OnWidgetDragComplete(
views::Widget* widget) {
// The target view should have finished its drag, and should have dropped the
// view. The main menu should not have done any drag, and the delegate should
// have been asked if it wanted to close. Since the delegate did not want to
// close, the menu should still be open.
EXPECT_FALSE(target_view()->dragging());
EXPECT_TRUE(target_view()->dropped());
EXPECT_FALSE(performed_in_menu_drop());
EXPECT_TRUE(asked_to_close());
views::SubmenuView* submenu = menu()->GetSubmenu();
// TODO(crbug.com/375959961): On X11, the native widget's mouse button state
// is not updated when the mouse button is released to end a drag. Therefore,
// all subsequent mouse movements will be delivered as "MouseDragged" events
// to MenuController.
// Until this is fixed, the menu closes at the end of drags.
EXPECT_NE(submenu->IsShowing(), BUILDFLAG(IS_OZONE_X11));
// Clean up.
submenu->Close();
Done();
}
void MenuViewDragAndDropTestNestedDrag::DoTestWithMenuOpen() {
MenuViewDragAndDropTest::DoTestWithMenuOpen();
// Cause the target's second child to trigger a mouse up when dragged over.
ASSERT_EQ(2u, target_view()->children().size());
SetStopDraggingView(target_view()->children()[1]);
// We're going to drag the target's first child.
views::View* drag_view = target_view()->children()[0];
ASSERT_NE(nullptr, drag_view);
ui_test_utils::MoveMouseToCenterAndClick(
drag_view, ui_controls::LEFT, ui_controls::DOWN,
CreateEventTask(this, &MenuViewDragAndDropTestNestedDrag::StartDrag));
}
void MenuViewDragAndDropTestNestedDrag::OnDragEntered() {
// The view should be dragging now.
EXPECT_TRUE(target_view()->dragging());
MenuViewDragAndDropTest::OnDragEntered();
}
void MenuViewDragAndDropTestNestedDrag::StartDrag() {
// Begin dragging the target's first child, which should result in calling
// OnWidgetDragWillStart().
const views::View* drag_view = target_view()->children().front();
const gfx::Point current_position =
ui_test_utils::GetCenterInScreenCoordinates(drag_view);
EXPECT_TRUE(ui_controls::SendMouseMove(current_position.x() + 10,
current_position.y()));
}
// Test that a nested drag (i.e. one via a child view, and not entirely
// implemented in menu code) will consult the delegate before closing the view
// after the drag.
// TODO(pkasting): https://crbug.com/939621 Fails on Mac.
// TODO(crbug.com/41496561): Test is failing under ChromeRefresh2023 on wayland.
#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_OZONE_WAYLAND)
#define MAYBE_MenuViewDragAndDropNestedDrag \
DISABLED_MenuViewDragAndDropNestedDrag
#else
#define MAYBE_MenuViewDragAndDropNestedDrag MenuViewDragAndDropNestedDrag
#endif
VIEW_TEST(MenuViewDragAndDropTestNestedDrag,
MAYBE_MenuViewDragAndDropNestedDrag)
class MenuViewDragAndDropForDropStayOpen : public MenuViewDragAndDropTest {
public:
MenuViewDragAndDropForDropStayOpen() = default;
~MenuViewDragAndDropForDropStayOpen() override = default;
private:
// MenuViewDragAndDropTest:
int GetMenuRunnerFlags() override;
void DoTestWithMenuOpen() override;
};
int MenuViewDragAndDropForDropStayOpen::GetMenuRunnerFlags() {
return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::NESTED_DRAG |
views::MenuRunner::FOR_DROP;
}
void MenuViewDragAndDropForDropStayOpen::DoTestWithMenuOpen() {
MenuViewDragAndDropTest::DoTestWithMenuOpen();
views::MenuController* controller = menu()->GetMenuController();
ASSERT_TRUE(controller);
EXPECT_FALSE(controller->IsCancelAllTimerRunningForTest());
Done();
}
// Test that if a menu is opened for a drop which is handled by a child view
// that the menu does not immediately try to close.
// If this flakes, disable and log details in http://crbug.com/523255.
VIEW_TEST(MenuViewDragAndDropForDropStayOpen, MenuViewStaysOpenForNestedDrag)
class MenuViewDragAndDropForDropCancel : public MenuViewDragAndDropTest {
public:
MenuViewDragAndDropForDropCancel() = default;
~MenuViewDragAndDropForDropCancel() override = default;
private:
// MenuViewDragAndDropTest:
int GetMenuRunnerFlags() override;
void DoTestWithMenuOpen() override;
};
int MenuViewDragAndDropForDropCancel::GetMenuRunnerFlags() {
return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::FOR_DROP;
}
void MenuViewDragAndDropForDropCancel::DoTestWithMenuOpen() {
MenuViewDragAndDropTest::DoTestWithMenuOpen();
views::MenuController* controller = menu()->GetMenuController();
ASSERT_TRUE(controller);
EXPECT_TRUE(controller->IsCancelAllTimerRunningForTest());
Done();
}
// Test that if a menu is opened for a drop handled entirely by menu code, the
// menu will try to close if it does not receive any drag updates.
VIEW_TEST(MenuViewDragAndDropForDropCancel, MenuViewCancelsForOwnDrag)
|