File: tab_strip_scroll_session_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (283 lines) | stat: -rw-r--r-- 10,612 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/ui/views/tabs/dragging/tab_strip_scroll_session.h"

#include <memory>

#include "base/test/scoped_feature_list.h"
#include "base/timer/mock_timer.h"
#include "chrome/browser/ui/tabs/features.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/tabs/dragging/tab_drag_controller.h"
#include "chrome/test/views/chrome_views_test_base.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/point_f.h"
#include "ui/views/controls/scroll_view.h"
#include "ui/views/view.h"

using ::testing::_;
using ::testing::AtLeast;
using ::testing::DoAll;
using ::testing::Return;
using ::testing::SaveArg;

// Mock class for scroll_manager
class MockTabDragWithScrollManager : public TabDragWithScrollManager {
 public:
  MockTabDragWithScrollManager() = default;
  ~MockTabDragWithScrollManager() override = default;
  MockTabDragWithScrollManager(const MockTabDragWithScrollManager&) = delete;
  MockTabDragWithScrollManager(MockTabDragWithScrollManager&&) = delete;
  MockTabDragWithScrollManager& operator=(const MockTabDragWithScrollManager&) =
      delete;
  MockTabDragWithScrollManager& operator=(MockTabDragWithScrollManager&&) =
      delete;

  MOCK_METHOD(void, MoveAttached, (gfx::Point point_in_screen), ());
  MOCK_METHOD(views::ScrollView*, GetScrollView, (), ());
  MOCK_METHOD(gfx::Point, GetLastPointInScreen, (), ());
  MOCK_METHOD(views::View*, GetAttachedContext, (), ());
  MOCK_METHOD(gfx::Rect, GetEnclosingRectForDraggedTabs, (), ());
};

class TabStripScrollSessionWithTimerTestBase : public ChromeViewsTestBase {
 public:
  explicit TabStripScrollSessionWithTimerTestBase(
      TabStripScrollSession::ScrollWithDragStrategy strategy)
      : strategy_(strategy) {
    scoped_feature_list_.InitWithFeatures({tabs::kScrollableTabStrip}, {});
  }

  ~TabStripScrollSessionWithTimerTestBase() override = default;

  void SetUp() override {
    ChromeViewsTestBase::SetUp();

    mock_timer_ = new base::MockRepeatingTimer();
    drag_controller_ = std::make_unique<MockTabDragWithScrollManager>();

    if (strategy_ ==
        TabStripScrollSession::ScrollWithDragStrategy::kVariableSpeed) {
      scroll_session_ = std::make_unique<TabStripScrollSessionWithTimer>(
          *(drag_controller_.get()),
          TabStripScrollSessionWithTimer::ScrollSessionTimerType::
              kVariableTimer);
    } else {
      scroll_session_ = std::make_unique<TabStripScrollSessionWithTimer>(
          *(drag_controller_.get()),
          TabStripScrollSessionWithTimer::ScrollSessionTimerType::
              kConstantTimer);
    }
    scroll_session_->SetTimerForTesting(mock_timer_);

    scroll_view_ = std::make_unique<views::ScrollView>();
    scroll_view_->SetBounds(0, 0,
                            5 * TabStyle::Get()->GetMinimumInactiveWidth(), 5);

    attached_context_ =
        scroll_view_->SetContents(std::make_unique<views::View>());
    attached_context_->SetBounds(
        0, 0, 10 * TabStyle::Get()->GetMinimumInactiveWidth(), 5);
  }

  void TearDown() override { ChromeViewsTestBase::TearDown(); }

 protected:
  TabStripScrollSession::ScrollWithDragStrategy strategy_ =
      TabStripScrollSession::ScrollWithDragStrategy::kDisabled;
  std::unique_ptr<MockTabDragWithScrollManager> drag_controller_;
  std::unique_ptr<views::ScrollView> scroll_view_;
  std::unique_ptr<TabStripScrollSessionWithTimer> scroll_session_;
  raw_ptr<views::View, DanglingUntriaged> attached_context_;
  raw_ptr<base::MockRepeatingTimer> mock_timer_;
  base::test::ScopedFeatureList scoped_feature_list_;
};

class TabStripScrollSessionTestWithConstantSpeed
    : public TabStripScrollSessionWithTimerTestBase {
 public:
  TabStripScrollSessionTestWithConstantSpeed()
      : TabStripScrollSessionWithTimerTestBase(
            TabStripScrollSession::ScrollWithDragStrategy::kConstantSpeed) {}
  TabStripScrollSessionTestWithConstantSpeed(
      const TabStripScrollSessionTestWithConstantSpeed&) = delete;
  TabStripScrollSessionTestWithConstantSpeed& operator=(
      const TabStripScrollSessionTestWithConstantSpeed&) = delete;
  ~TabStripScrollSessionTestWithConstantSpeed() override = default;

 private:
};

// When the tab scroll direction is `kNoScroll` then do not start the scroll
// session
TEST_F(TabStripScrollSessionTestWithConstantSpeed,
       GivenNoScrollWhenScrollSessionMaybeStartThenTimerDoesNotRun) {
  // create a dragged_tab_rect outside of the right and left scrollable regions
  const gfx::Rect dragged_tabs_rect = gfx::Rect(
      scroll_view_->GetVisibleRect().top_right().x() -
          2 * scroll_session_->GetScrollableOffsetFromScrollViewForTesting(),
      0, (scroll_session_->GetScrollableOffsetFromScrollViewForTesting() / 2),
      1);

  EXPECT_CALL(*drag_controller_, GetAttachedContext())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(attached_context_));
  EXPECT_CALL(*drag_controller_, GetEnclosingRectForDraggedTabs())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(dragged_tabs_rect));
  EXPECT_CALL(*drag_controller_, GetScrollView())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(scroll_view_.get()));

  // assert
  scroll_session_->MaybeStart();
  EXPECT_FALSE(mock_timer_->IsRunning());
}

// If there is no attached context to the `drag_controller_`, then do not run
// the timer.
TEST_F(TabStripScrollSessionTestWithConstantSpeed,
       GivenNoAttachedContextWhenScrollSessionMaybeStartThenTimerDoesNotRun) {
  // arrange
  EXPECT_CALL(*drag_controller_, GetAttachedContext())
      .Times(1)
      .WillOnce(Return(nullptr));

  // act
  scroll_session_->MaybeStart();

  // assert
  EXPECT_FALSE(mock_timer_->IsRunning());
}

// When scroll session starts with correct arguments, timer callback is invoked
TEST_F(TabStripScrollSessionTestWithConstantSpeed,
       GivenScrollSessionWhenMaybeStartThenTimerCallback) {
  // create a rect that is in the right scrollable region.
  const gfx::Rect dragged_tabs_rect =
      gfx::Rect(scroll_view_->GetVisibleRect().top_right().x(), 0, 1, 1);

  EXPECT_CALL(*drag_controller_, GetAttachedContext())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(attached_context_));

  EXPECT_CALL(*drag_controller_, GetScrollView())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(scroll_view_.get()));

  EXPECT_CALL(*drag_controller_, GetLastPointInScreen())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(gfx::Point()));

  EXPECT_CALL(*drag_controller_, GetEnclosingRectForDraggedTabs())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(dragged_tabs_rect));

  EXPECT_CALL(*drag_controller_, MoveAttached(_)).Times(1);

  // act
  scroll_session_->MaybeStart();

  // make sure timer is running
  EXPECT_TRUE(mock_timer_->IsRunning());

  if (mock_timer_->IsRunning()) {
    mock_timer_->Fire();
  }

  // assert
  EXPECT_TRUE(scroll_session_->IsRunning());
  EXPECT_EQ(ceil(scroll_session_->CalculateBaseScrollOffset()),
            scroll_view_->GetVisibleRect().x());
}

// When scroll is started with one direction but in the callback check,
// the direction calculation is different, stop the timer.
TEST_F(TabStripScrollSessionTestWithConstantSpeed,
       GivenScrollingTowardsRightWhenShouldScrollToLeftThenStopTimer) {
  // arrange
  const gfx::Rect dragged_tabs_rect_for_scrolling_left =
      gfx::Rect(scroll_view_->GetVisibleRect().origin().x(), 0, 1, 1);
  const gfx::Rect dragged_tabs_rect_for_scrolling_right =
      gfx::Rect(scroll_view_->GetVisibleRect().top_right().x(), 0, 1, 1);

  EXPECT_CALL(*drag_controller_, GetAttachedContext())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(attached_context_));
  EXPECT_CALL(*drag_controller_, GetScrollView())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(scroll_view_.get()));
  EXPECT_CALL(*drag_controller_, GetEnclosingRectForDraggedTabs())
      .Times(AtLeast(1))
      .WillOnce(Return(dragged_tabs_rect_for_scrolling_right))
      .WillRepeatedly(Return(dragged_tabs_rect_for_scrolling_left));
  EXPECT_CALL(*drag_controller_, MoveAttached(_)).Times(0);

  // act
  scroll_session_->MaybeStart();
  // check if timer is running
  EXPECT_TRUE(mock_timer_->IsRunning());
  mock_timer_->Fire();
  // assert
  EXPECT_FALSE(scroll_session_->IsRunning());
  EXPECT_EQ(scroll_view_->GetVisibleRect().x(), 0);
}

class TabStripScrollSessionTestWithVariableSpeed
    : public TabStripScrollSessionWithTimerTestBase {
 public:
  TabStripScrollSessionTestWithVariableSpeed()
      : TabStripScrollSessionWithTimerTestBase(
            TabStripScrollSession::ScrollWithDragStrategy::kVariableSpeed) {}
  TabStripScrollSessionTestWithVariableSpeed(
      const TabStripScrollSessionTestWithVariableSpeed&) = delete;
  TabStripScrollSessionTestWithVariableSpeed& operator=(
      const TabStripScrollSessionTestWithVariableSpeed&) = delete;
  ~TabStripScrollSessionTestWithVariableSpeed() override = default;

 private:
};

// When scroll session starts with correct arguments, timer callback is invoked
TEST_F(TabStripScrollSessionTestWithVariableSpeed,
       GivenScrollSessionWhenMaybeStartThenTimerCallback) {
  // create a rect starting from the scrollable region to half of the end of the
  // attached_context
  const gfx::Rect dragged_tabs_rect = gfx::Rect(
      scroll_view_->GetVisibleRect().top_right().x() -
          scroll_session_->GetScrollableOffsetFromScrollViewForTesting(),
      0, (scroll_session_->GetScrollableOffsetFromScrollViewForTesting() / 2),
      1);

  EXPECT_CALL(*drag_controller_, GetAttachedContext())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(attached_context_));
  EXPECT_CALL(*drag_controller_, GetScrollView())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(scroll_view_.get()));

  EXPECT_CALL(*drag_controller_, GetEnclosingRectForDraggedTabs())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(dragged_tabs_rect));

  EXPECT_CALL(*drag_controller_, GetLastPointInScreen())
      .Times(AtLeast(1))
      .WillRepeatedly(Return(gfx::Point()));

  EXPECT_CALL(*drag_controller_, MoveAttached(_)).Times(1);

  scroll_session_->MaybeStart();
  EXPECT_TRUE(mock_timer_->IsRunning());

  if (mock_timer_->IsRunning()) {
    mock_timer_->Fire();
  }

  EXPECT_TRUE(scroll_session_->IsRunning());
  EXPECT_GE(scroll_view_->GetVisibleRect().x(), 0);
  EXPECT_LE(scroll_view_->GetVisibleRect().x(),
            ceil(scroll_session_->CalculateBaseScrollOffset()));
}