1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_element_identifiers.h"
#include "chrome/browser/ui/browser_window/public/browser_window_features.h"
#include "chrome/browser/ui/toolbar/app_menu_model.h"
#include "chrome/browser/ui/toolbar/bookmark_sub_menu_model.h"
#include "chrome/browser/ui/toolbar/reading_list_sub_menu_model.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/side_panel/side_panel_coordinator.h"
#include "chrome/browser/ui/views/side_panel/side_panel_entry.h"
#include "chrome/browser/ui/views/side_panel/side_panel_util.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/test/interaction/interactive_browser_test.h"
#include "components/prefs/pref_service.h"
#include "components/webui/chrome_urls/pref_names.h"
#include "content/public/test/browser_test.h"
#include "ui/base/interaction/element_identifier.h"
namespace {
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kBrowserTabId);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kBrowserTabId2);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kReadLaterWebContentsElementId);
} // namespace
class HelpBubbleHandlerInteractiveUiTest : public InteractiveBrowserTest {
public:
HelpBubbleHandlerInteractiveUiTest() = default;
~HelpBubbleHandlerInteractiveUiTest() override = default;
void SetUpOnMainThread() override {
InteractiveBrowserTest::SetUpOnMainThread();
g_browser_process->local_state()->SetBoolean(
chrome_urls::kInternalOnlyUisEnabled, true);
}
// Opens the side panel and instruments the Read Later WebContents as
// kReadLaterWebContentsElementId.
auto OpenReadingListSidePanel() {
return Steps(
// Remove delays in switching side panels to prevent possible race
// conditions when selecting items from the side panel dropdown.
Do([this]() {
browser()
->GetFeatures()
.side_panel_coordinator()
->SetNoDelaysForTesting(true);
}),
PressButton(kToolbarAppMenuButtonElementId),
SelectMenuItem(AppMenuModel::kBookmarksMenuItem),
SelectMenuItem(BookmarkSubMenuModel::kReadingListMenuItem),
SelectMenuItem(ReadingListSubMenuModel::kReadingListMenuShowUI),
WaitForShow(kSidePanelElementId),
WaitForShow(kReadLaterSidePanelWebViewElementId),
// Ensure that the Reading List side panel loads properly.
InstrumentNonTabWebView(kReadLaterWebContentsElementId,
kReadLaterSidePanelWebViewElementId));
}
auto OpenBookmarksSidePanel() {
return Steps(
PressButton(kToolbarAppMenuButtonElementId),
SelectMenuItem(AppMenuModel::kBookmarksMenuItem),
SelectMenuItem(BookmarkSubMenuModel::kShowBookmarkSidePanelItem),
WaitForShow(kSidePanelElementId));
}
auto CloseSidePanel() {
return Steps(EnsurePresent(kSidePanelElementId),
PressButton(kSidePanelCloseButtonElementId),
WaitForHide(kSidePanelElementId));
}
};
IN_PROC_BROWSER_TEST_F(HelpBubbleHandlerInteractiveUiTest,
ElementBecomesVisibleOnPageLoad) {
RunTestSequence(
InstrumentTab(kBrowserTabId),
NavigateWebContents(kBrowserTabId,
GURL(chrome::kChromeUIUserEducationInternalsURL)),
InAnyContext(WaitForShow(kWebUIIPHDemoElementIdentifier)));
}
IN_PROC_BROWSER_TEST_F(HelpBubbleHandlerInteractiveUiTest,
ElementBecomesHiddenOnTabBackgrounded) {
RunTestSequence(
InstrumentTab(kBrowserTabId),
NavigateWebContents(kBrowserTabId,
GURL(chrome::kChromeUIUserEducationInternalsURL)),
InAnyContext(WaitForShow(kWebUIIPHDemoElementIdentifier)),
// This will add the new tab in the foreground.
AddInstrumentedTab(kBrowserTabId2, GURL(chrome::kChromeUIBookmarksURL)),
InAnyContext(WaitForHide(kWebUIIPHDemoElementIdentifier)));
}
IN_PROC_BROWSER_TEST_F(HelpBubbleHandlerInteractiveUiTest,
ElementBecomesVisibleOnSecondaryUILoad) {
RunTestSequence(
OpenReadingListSidePanel(),
InAnyContext(WaitForShow(kAddCurrentTabToReadingListElementId)));
}
IN_PROC_BROWSER_TEST_F(HelpBubbleHandlerInteractiveUiTest,
ElementBecomesHiddenOnSecondaryUIHide) {
RunTestSequence(
OpenReadingListSidePanel(),
InAnyContext(WaitForShow(kAddCurrentTabToReadingListElementId)),
CloseSidePanel(),
InAnyContext(WaitForHide(kAddCurrentTabToReadingListElementId)));
}
// This test is flaky on Mac; see: https://crbug.com/348242589
// Suspect that something in the async way the combo box works is causing this
// particular issue. Might be solved by programmatically switching panels.
#if BUILDFLAG(IS_MAC)
#define MAYBE_ElementBecomesHiddenOnSecondaryUISwap \
DISABLED_ElementBecomesHiddenOnSecondaryUISwap
#else
#define MAYBE_ElementBecomesHiddenOnSecondaryUISwap \
ElementBecomesHiddenOnSecondaryUISwap
#endif
IN_PROC_BROWSER_TEST_F(HelpBubbleHandlerInteractiveUiTest,
MAYBE_ElementBecomesHiddenOnSecondaryUISwap) {
RunTestSequence(
OpenReadingListSidePanel(),
InAnyContext(WaitForShow(kAddCurrentTabToReadingListElementId)),
OpenBookmarksSidePanel(),
InAnyContext(WaitForHide(kAddCurrentTabToReadingListElementId)));
}
|
