1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/constants/web_app_id_constants.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/ui/web_applications/web_app_browsertest_base.h"
#include "chrome/browser/web_applications/policy/web_app_policy_constants.h"
#include "chrome/browser/web_applications/policy/web_app_policy_manager.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/test/web_app_test_observers.h"
#include "chrome/browser/web_applications/test/web_app_test_utils.h"
#include "chrome/browser/web_applications/web_app_provider.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/pref_names.h"
#include "components/prefs/pref_service.h"
#include "content/public/test/browser_test.h"
#include "third_party/abseil-cpp/absl/cleanup/cleanup.h"
namespace web_app {
namespace {
constexpr char kCalculatorAppUrl[] = "https://calculator.apps.chrome/";
} // namespace
class PreventCloseControllerBrowserTest : public WebAppBrowserTestBase {
public:
PreventCloseControllerBrowserTest() { BuildAndInitFeatureList(); }
protected:
void BuildAndInitFeatureList() {
scoped_feature_list_.InitWithFeatures({features::kDesktopPWAsRunOnOsLogin,
features::kDesktopPWAsPreventClose},
{});
}
void ForceInstallWebApp(const webapps::AppId& app_id, const GURL& url) {
web_app::WebAppTestInstallObserver observer(browser()->profile());
observer.BeginListening({app_id});
profile()->GetPrefs()->SetList(
prefs::kWebAppInstallForceList,
base::Value::List().Append(
base::Value::Dict()
.Set(kUrlKey, url.spec())
.Set(kDefaultLaunchContainerKey,
kDefaultLaunchContainerWindowValue)));
const webapps::AppId installed_app_id = observer.Wait();
EXPECT_EQ(installed_app_id, app_id);
}
void ConfigurePreventClose(const GURL& url, bool prevent_close) {
profile()->GetPrefs()->SetList(
prefs::kWebAppSettings,
base::Value::List().Append(base::Value::Dict()
.Set(kManifestId, url.spec())
.Set(kRunOnOsLogin, kRunWindowed)
.Set(kPreventClose, prevent_close)));
WebAppProvider::GetForTest(profile())
->policy_manager()
.RefreshPolicySettingsForTesting();
}
void ClearPolicySettings() {
profile()->GetPrefs()->SetList(prefs::kWebAppSettings, base::Value::List());
profile()->GetPrefs()->SetList(prefs::kWebAppInstallForceList,
base::Value::List());
}
base::test::ScopedFeatureList scoped_feature_list_;
};
IN_PROC_BROWSER_TEST_F(PreventCloseControllerBrowserTest,
NonClosablePWADoesNotLaunchAdditionalWindow) {
absl::Cleanup policy_cleanup = [this] { ClearPolicySettings(); };
// Arrange with non-closable PWA and start it a first time
size_t expected_browser_count = chrome::GetBrowserCount(profile());
const GURL url(kCalculatorAppUrl);
ForceInstallWebApp(ash::kCalculatorAppId, url);
Browser* browser = LaunchWebAppBrowserAndWait(ash::kCalculatorAppId);
++expected_browser_count;
ASSERT_TRUE(browser);
EXPECT_EQ(expected_browser_count, chrome::GetBrowserCount(profile()));
ConfigurePreventClose(url, /*prevent_close=*/true);
// Act by launching PWA a second time
Browser* second_browser = LaunchWebAppBrowser(ash::kCalculatorAppId);
#if BUILDFLAG(IS_CHROMEOS)
// Assert that the PWA only has one existing window
EXPECT_TRUE(WebAppProvider::GetForTest(profile())
->registrar_unsafe()
.IsPreventCloseEnabled(ash::kCalculatorAppId));
EXPECT_EQ(browser, second_browser);
EXPECT_EQ(expected_browser_count, chrome::GetBrowserCount(profile()));
#else
// On other platforms, the prevent close should not be enabled.
EXPECT_FALSE(WebAppProvider::GetForTest(profile())
->registrar_unsafe()
.IsPreventCloseEnabled(ash::kCalculatorAppId));
EXPECT_NE(browser, second_browser);
EXPECT_EQ(expected_browser_count + 1, chrome::GetBrowserCount(profile()));
#endif
}
IN_PROC_BROWSER_TEST_F(PreventCloseControllerBrowserTest,
ClosablePWALaunchesAdditionalWindow) {
absl::Cleanup policy_cleanup = [this] { ClearPolicySettings(); };
size_t expected_browser_count = chrome::GetBrowserCount(profile());
const GURL url(kCalculatorAppUrl);
ForceInstallWebApp(ash::kCalculatorAppId, url);
Browser* browser = LaunchWebAppBrowserAndWait(ash::kCalculatorAppId);
++expected_browser_count;
ASSERT_TRUE(browser);
EXPECT_EQ(expected_browser_count, chrome::GetBrowserCount(profile()));
ConfigurePreventClose(url, /*prevent_close=*/false);
// Act by launching PWA a second time
Browser* second_browser = LaunchWebAppBrowserAndWait(ash::kCalculatorAppId);
expected_browser_count++;
// Assert that the PWA only has one existing window
EXPECT_NE(browser, second_browser);
EXPECT_EQ(expected_browser_count, chrome::GetBrowserCount(profile()));
}
} // namespace web_app
|
