1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <tuple>
#include "base/location.h"
#include "base/metrics/field_trial_params.h"
#include "base/notreached.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/test/bind.h"
#include "base/test/gmock_expected_support.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_future.h"
#include "base/types/expected.h"
#include "build/build_config.h"
#include "chrome/browser/apps/app_service/app_registry_cache_waiter.h"
#include "chrome/browser/apps/app_service/app_service_proxy.h"
#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
#include "chrome/browser/apps/intent_helper/preferred_apps_test_util.h"
#include "chrome/browser/apps/link_capturing/link_capturing_feature_test_support.h"
#include "chrome/browser/apps/link_capturing/link_capturing_navigation_throttle.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/web_applications/app_browser_controller.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/ui/web_applications/test/web_app_navigation_browsertest.h"
#include "chrome/browser/web_applications/mojom/user_display_mode.mojom.h"
#include "chrome/browser/web_applications/test/web_app_test_observers.h"
#include "chrome/browser/web_applications/web_app_helpers.h"
#include "chrome/browser/web_applications/web_app_provider.h"
#include "chrome/browser/web_applications/web_app_registrar.h"
#include "chrome/browser/web_applications/web_app_registry_update.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/common/content_features.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/hit_test_region_observer.h"
#include "content/public/test/prerender_test_util.h"
#include "content/public/test/test_navigation_observer.h"
#include "content/public/test/test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
#include "third_party/blink/public/mojom/manifest/display_mode.mojom-shared.h"
#include "third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom.h"
using content::RenderFrameHost;
using content::WebContents;
using content::test::PrerenderHostObserver;
using content::test::PrerenderHostRegistryObserver;
using content::test::PrerenderTestHelper;
using ui_test_utils::BrowserChangeObserver;
namespace web_app {
namespace {
using ClientMode = LaunchHandler::ClientMode;
// Tests that links are captured correctly into an installed WebApp using the
// 'tabbed' display mode, which allows the webapp window to have multiple tabs.
class WebAppLinkCapturingBrowserTest
: public WebAppNavigationBrowserTest,
public testing::WithParamInterface<
apps::test::LinkCapturingFeatureVersion> {
public:
WebAppLinkCapturingBrowserTest()
: prerender_helper_(base::BindRepeating(
&WebAppLinkCapturingBrowserTest::prerender_web_contents,
base::Unretained(this))) {
feature_list_.InitWithFeaturesAndParameters(
apps::test::GetFeaturesToEnableLinkCapturingUX(GetParam()),
/*disabled_features=*/{});
}
~WebAppLinkCapturingBrowserTest() override = default;
bool IsV1() const { return apps::test::IsV1(GetParam()); }
bool IsV2() const { return apps::test::IsV2(GetParam()); }
bool ShouldLinksWithExistingFrameTargetsCapture() const {
return apps::test::ShouldLinksWithExistingFrameTargetsCapture(GetParam());
}
bool LinkCapturingEnabledByDefault() const {
#if BUILDFLAG(IS_CHROMEOS)
return false;
#else
const apps::test::LinkCapturingFeatureVersion& version = GetParam();
return version == apps::test::LinkCapturingFeatureVersion::kV2DefaultOn;
#endif
}
void SetUpOnMainThread() override {
WebAppNavigationBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(https_server().Start());
ASSERT_TRUE(embedded_test_server()->Start());
out_of_scope_ = https_server().GetURL("/");
}
// Returns [app_id, in_scope_1, in_scope_2, scope]
std::tuple<webapps::AppId, GURL, GURL, GURL> InstallTestApp(
const char* path) {
GURL start_url = embedded_test_server()->GetURL(path);
GURL in_scope_1 = start_url.Resolve("page1.html");
GURL in_scope_2 = start_url.Resolve("page2.html");
GURL scope = start_url.GetWithoutFilename();
webapps::AppId app_id =
InstallWebAppFromPageAndCloseAppBrowser(browser(), start_url);
apps::AppReadinessWaiter(profile(), app_id).Await();
return std::make_tuple(app_id, in_scope_1, in_scope_2, scope);
}
GURL GetNestedAppUrl() {
return embedded_test_server()->GetURL(
"/web_apps/nesting/nested/index.html");
}
GURL GetParentAppUrl() {
return embedded_test_server()->GetURL("/web_apps/nesting/index.html");
}
// Note: This must be installed AFTER installing the nested app, as the
// `InstallWebAppFromPageAndCloseAppBrowser` function does a link-like
// navigation to open the url, which would be captured by the parent app if
// installed first.
webapps::AppId InstallParentApp() {
GURL start_url = GetParentAppUrl();
webapps::AppId app_id =
InstallWebAppFromPageAndCloseAppBrowser(browser(), start_url);
apps::AppReadinessWaiter(profile(), app_id).Await();
return app_id;
}
// Note: This must be installed BEFORE installing the parent app, as the
// `InstallWebAppFromPageAndCloseAppBrowser` function does a link-like
// navigation to open the url, which would be captured by the parent app if
// installed first.
webapps::AppId InstallNestedApp() {
GURL start_url = GetNestedAppUrl();
webapps::AppId app_id =
InstallWebAppFromPageAndCloseAppBrowser(browser(), start_url);
apps::AppReadinessWaiter(profile(), app_id).Await();
return app_id;
}
WebAppProvider& provider() {
auto* provider = WebAppProvider::GetForTest(profile());
DCHECK(provider);
return *provider;
}
void AddTab(Browser* browser, const GURL& url) {
content::TestNavigationObserver observer(url);
observer.StartWatchingNewWebContents();
chrome::AddTabAt(browser, url, /*index=*/-1, /*foreground=*/true);
observer.Wait();
}
void NavigateCapturable(Browser* browser, const GURL& url) {
LinkTarget target = (IsV1() ? LinkTarget::SELF : LinkTarget::BLANK);
ClickLinkAndWait(browser->tab_strip_model()->GetActiveWebContents(), url,
target, "");
}
void NavigateSelf(Browser* browser, const GURL& url) {
ClickLinkAndWait(browser->tab_strip_model()->GetActiveWebContents(), url,
LinkTarget::SELF, "");
}
void NavigateBlank(Browser* browser, const GURL& url) {
ClickLinkAndWait(browser->tab_strip_model()->GetActiveWebContents(), url,
LinkTarget::BLANK, "");
}
Browser* GetNewBrowserFromNavigation(Browser* browser, const GURL& url) {
if (browser->tab_strip_model()
->GetActiveWebContents()
->GetVisibleURL()
.IsAboutBlank()) {
// Create a new tab to link capture in because about:blank tabs are
// destroyed after link capturing, see:
// CommonAppsNavigationThrottle::ShouldCancelNavigation()
AddTab(browser, about_blank_);
}
BrowserChangeObserver observer(nullptr,
BrowserChangeObserver::ChangeType::kAdded);
NavigateCapturable(browser, url);
return observer.Wait();
}
void ExpectTabs(Browser* test_browser,
std::vector<GURL> urls,
base::Location location = FROM_HERE) {
std::string debug_info = "\nOpen browsers:\n";
for (Browser* open_browser : *BrowserList::GetInstance()) {
debug_info += " ";
if (open_browser == browser()) {
debug_info += "Main browser";
} else if (open_browser->app_controller()) {
debug_info += "App browser";
} else {
debug_info += "Browser";
}
debug_info += ":\n";
for (int i = 0; i < open_browser->tab_strip_model()->count(); ++i) {
debug_info += " - " +
open_browser->tab_strip_model()
->GetWebContentsAt(i)
->GetVisibleURL()
.spec() +
"\n";
}
}
SCOPED_TRACE(location.ToString());
SCOPED_TRACE(debug_info);
TabStripModel& tab_strip = *test_browser->tab_strip_model();
ASSERT_EQ(static_cast<size_t>(tab_strip.count()), urls.size());
for (int i = 0; i < tab_strip.count(); ++i) {
SCOPED_TRACE(base::StringPrintf("is app browser: %d, tab index: %d",
bool(test_browser->app_controller()), i));
EXPECT_EQ(
test_browser->tab_strip_model()->GetWebContentsAt(i)->GetVisibleURL(),
urls[i]);
}
}
std::optional<LaunchHandler> GetLaunchHandler(const webapps::AppId& app_id) {
return provider().registrar_unsafe().GetAppById(app_id)->launch_handler();
}
content::WebContents* prerender_web_contents() {
return browser()->tab_strip_model()->GetActiveWebContents();
}
protected:
GURL out_of_scope_;
const GURL about_blank_{"about:blank"};
PrerenderTestHelper prerender_helper_;
base::test::ScopedFeatureList feature_list_;
};
// Link capturing with navigate_existing_client: always should navigate existing
// app windows.
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
NavigateExistingClientFromBrowserTargetSelf) {
const auto [app_id, in_scope_1, in_scope_2, scope] = InstallTestApp(
"/web_apps/get_manifest.html?"
"launch_handler_client_mode_navigate_existing.json");
auto launch_handler = GetLaunchHandler(app_id);
EXPECT_EQ(ClientMode::kNavigateExisting,
launch_handler->parsed_client_mode());
EXPECT_TRUE(launch_handler->client_mode_valid_and_specified());
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Start browser at an out of scope page.
NavigateSelf(browser(), out_of_scope_);
// In scope navigation should open app window.
Browser* app_browser = GetNewBrowserFromNavigation(browser(), in_scope_1);
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_1});
// Click a link in the browser in to scope.
NavigateSelf(browser(), in_scope_2);
if (ShouldLinksWithExistingFrameTargetsCapture()) {
// Ensure that no additional tabs get opened in the browser.
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_2});
} else {
ExpectTabs(browser(), {in_scope_2});
ExpectTabs(app_browser, {in_scope_1});
}
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
NavigateExistingClientFromBrowserTargetBlank) {
const auto [app_id, in_scope_1, in_scope_2, scope] = InstallTestApp(
"/web_apps/get_manifest.html?"
"launch_handler_client_mode_navigate_existing.json");
auto launch_handler = GetLaunchHandler(app_id);
EXPECT_EQ(ClientMode::kNavigateExisting,
launch_handler->parsed_client_mode());
EXPECT_TRUE(launch_handler->client_mode_valid_and_specified());
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Start browser at an out of scope page.
NavigateSelf(browser(), out_of_scope_);
// In scope navigation should open app window.
Browser* app_browser = GetNewBrowserFromNavigation(browser(), in_scope_1);
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_1});
// Verify capturing works with target=_blank.
NavigateBlank(browser(), in_scope_2);
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_2});
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
NavigateExistingClientFromBrowserWithAppOutOfScope) {
const auto [app_id, in_scope_1, _, scope] = InstallTestApp(
"/web_apps/get_manifest.html?"
"launch_handler_client_mode_navigate_existing.json");
auto launch_handler = GetLaunchHandler(app_id);
EXPECT_EQ(ClientMode::kNavigateExisting,
launch_handler->parsed_client_mode());
EXPECT_TRUE(launch_handler->client_mode_valid_and_specified());
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Start browser at an out of scope page.
NavigateSelf(browser(), out_of_scope_);
// In scope navigation should open app window.
Browser* app_browser = GetNewBrowserFromNavigation(browser(), in_scope_1);
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_1});
// App browsers that are out-of-scope don't get navigated with
// navigate-existing in v2.
NavigateSelf(app_browser, out_of_scope_);
BrowserChangeObserver observer(nullptr,
BrowserChangeObserver::ChangeType::kAdded);
NavigateBlank(browser(), in_scope_1);
ExpectTabs(browser(), {out_of_scope_});
if (IsV1()) {
ExpectTabs(app_browser, {in_scope_1});
} else {
Browser* other_app_browser = observer.Wait();
ExpectTabs(other_app_browser, {in_scope_1});
}
}
// Link captures from about:blank cleans up the about:blank page.
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
AboutBlankNavigationCleanUp) {
if (!ShouldLinksWithExistingFrameTargetsCapture()) {
GTEST_SKIP();
}
const auto [app_id, in_scope_1, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
ExpectTabs(browser(), {about_blank_});
BrowserChangeObserver removed_observer(
browser(), BrowserChangeObserver::ChangeType::kRemoved);
// Navigate an about:blank page.
BrowserChangeObserver observer(nullptr,
BrowserChangeObserver::ChangeType::kAdded);
NavigateSelf(browser(), in_scope_1);
Browser* app_browser = observer.Wait();
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(app_browser, {in_scope_1});
// Old about:blank page cleaned up.
removed_observer.Wait();
}
// JavaScript initiated link captures from about:blank cleans up the about:blank
// page.
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
JavascriptAboutBlankNavigationCleanUp) {
if (!ShouldLinksWithExistingFrameTargetsCapture()) {
GTEST_SKIP();
}
const auto [app_id, in_scope_1, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
ExpectTabs(browser(), {about_blank_});
BrowserChangeObserver removed_observer(
browser(), BrowserChangeObserver::ChangeType::kRemoved);
// Navigate an about:blank page using JavaScript.
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
ASSERT_TRUE(content::ExecJs(
browser()->tab_strip_model()->GetActiveWebContents(),
base::StringPrintf("location = '%s';", in_scope_1.spec().c_str())));
Browser* app_browser = added_observer.Wait();
ExpectTabs(app_browser, {in_scope_1});
// Old about:blank page cleaned up.
removed_observer.Wait();
// Must wait for link capturing launch to complete so that its keep alives go
// out of scope.
base::test::TestFuture<bool /*closed_web_contents*/> future;
apps::LinkCapturingNavigationThrottle::
GetLinkCaptureLaunchCallbackForTesting() = future.GetCallback();
EXPECT_TRUE(future.Get<bool /*closed_web_contents*/>());
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
DifferentPortConsideredDifferent) {
net::EmbeddedTestServer other_server;
other_server.AddDefaultHandlers(GetChromeTestDataDir());
ASSERT_TRUE(other_server.Start());
ASSERT_EQ(embedded_test_server()->GetOrigin().scheme(),
other_server.GetOrigin().scheme());
ASSERT_EQ(embedded_test_server()->GetOrigin().host(),
other_server.GetOrigin().host());
ASSERT_NE(embedded_test_server()->GetOrigin().port(),
other_server.GetOrigin().port());
const auto [app_id, url1, url2, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
ExpectTabs(browser(), {about_blank_});
GURL url = other_server.GetURL("/web_apps/basic.html");
NavigateSelf(browser(), url);
ExpectTabs(browser(), {url});
}
// Tests that links to apps from sandboxed iframes can be captured.
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
HandleClickFromSandboxedIframe) {
const auto [app_id, in_scope_1, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Create a sandboxed iframe, which contains a link to the installed app,
// covering the full viewport of the iframe.
constexpr char kIframeCaptureJs[] = R"js(
(() => {
let i = document.createElement("iframe");
i.id = 'iframe';
i.sandbox = "allow-popups allow-popups-to-escape-sandbox";
i.srcdoc = `<a href="$1"
target="_blank"
style="position: absolute; top: 0; left: 0; bottom: 0; right: 0;">
</a>`
document.body.appendChild(i);
})();
)js";
// At present we can't create a sandbox srcdoc frame in a top-level
// about:blank frame, so navigate to an empty page. See
// https://crbug.com/1499982
GURL url = embedded_test_server()->GetURL("/title1.html");
NavigateSelf(browser(), url);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::TestNavigationObserver observer(web_contents);
ASSERT_TRUE(content::ExecJs(
web_contents,
base::ReplaceStringPlaceholders(kIframeCaptureJs, {in_scope_1.spec()},
/*offsets=*/nullptr)));
observer.Wait();
// When the JS code in `kIframeCaptureJs` finishes executing, we should be
// guaranteed that the child frame has been created, but the browser-side
// RenderFrameHost for the child may not have received the hit-testing data
// necessary for the event to propagate properly.
RenderFrameHost* child_frame =
ChildFrameAt(web_contents->GetPrimaryMainFrame(), 0);
ASSERT_NE(nullptr, child_frame);
content::WaitForHitTestData(child_frame);
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
// Click the iframe, which should click the <a> tag and open the app.
// At this point the hit test data for targeting the event should be valid.
content::SimulateMouseClickOrTapElementWithId(web_contents, "iframe");
Browser* app_browser = added_observer.Wait();
EXPECT_NE(browser(), app_browser);
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
ParentAppWithChildLinks) {
// Note: The order matters so the nested app navigation for installation
// doesn't get captured by the parent app.
webapps::AppId nested_app_id = InstallNestedApp();
webapps::AppId parent_app_id = InstallParentApp();
if (!LinkCapturingEnabledByDefault()) {
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), parent_app_id),
base::ok());
}
if (!IsV2()) {
AddTab(browser(), about_blank_);
}
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
NavigateCapturable(browser(), GetNestedAppUrl());
// https://crbug.com/1476011: ChromeOS currently capturing nested app links
// into the parent app, but other platforms split the URL space and fully
// respect the child app's user setting.
#if BUILDFLAG(IS_CHROMEOS)
Browser* app_browser = added_observer.Wait();
EXPECT_NE(browser(), app_browser);
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, parent_app_id));
ExpectTabs(app_browser, {GetNestedAppUrl()});
ExpectTabs(browser(), {about_blank_});
#else
if (LinkCapturingEnabledByDefault()) {
// If link capturing is on by default, then the nested app will also be
// capturing links in it's scope (and thus the nested url will launch a
// nested app browser. the nested app browser.
Browser* app_browser = added_observer.Wait();
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, nested_app_id));
EXPECT_NE(browser(), app_browser);
ExpectTabs(app_browser, {GetNestedAppUrl()});
ExpectTabs(browser(), {about_blank_});
} else {
ExpectTabs(browser(), {about_blank_, GetNestedAppUrl()});
}
#endif
}
// https://crbug.com/1476011: ChromeOS currently capturing nested app links into
// the parent app, treating them as overlapping apps. Other platforms split the
// URL space and fully respect the child app's user setting.
// Thus, on non-CrOS platforms both apps can capture links.
#if !BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
ParentAppAndChildAppCapture) {
// Note: The order matters so the nested app navigation for installation
// doesn't get captured by the parent app.
webapps::AppId nested_app_id = InstallNestedApp();
webapps::AppId parent_app_id = InstallParentApp();
if (!LinkCapturingEnabledByDefault()) {
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), nested_app_id),
base::ok());
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), parent_app_id),
base::ok());
}
Browser* nested_browser;
Browser* parent_browser;
{
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
NavigateCapturable(browser(), GetNestedAppUrl());
nested_browser = added_observer.Wait();
}
{
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
NavigateCapturable(browser(), GetParentAppUrl());
parent_browser = added_observer.Wait();
}
ASSERT_TRUE(nested_browser);
ASSERT_TRUE(parent_browser);
EXPECT_NE(browser(), nested_browser);
EXPECT_NE(browser(), parent_browser);
EXPECT_NE(nested_browser, parent_browser);
EXPECT_TRUE(AppBrowserController::IsForWebApp(nested_browser, nested_app_id));
EXPECT_TRUE(AppBrowserController::IsForWebApp(parent_browser, parent_app_id));
ExpectTabs(browser(), {about_blank_});
ExpectTabs(nested_browser, {GetNestedAppUrl()});
ExpectTabs(parent_browser, {GetParentAppUrl()});
}
#endif // !BUILDFLAG(IS_CHROMEOS)
// Tests that link capturing works while inside a web app window.
// TODO(crbug.com/330148482): Flaky on Linux Debug bots.
#if BUILDFLAG(IS_LINUX) && !defined(NDEBUG)
#define MAYBE_LinkCaptureInWebAppWindow DISABLED_LinkCaptureInWebAppWindow
#else
#define MAYBE_LinkCaptureInWebAppWindow LinkCaptureInWebAppWindow
#endif
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
MAYBE_LinkCaptureInWebAppWindow) {
// Note: The order matters so the nested app navigation for installation
// doesn't get captured by the parent app.
webapps::AppId nested_app_id = InstallNestedApp();
webapps::AppId parent_app_id = InstallParentApp();
if (!LinkCapturingEnabledByDefault()) {
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), nested_app_id),
base::ok());
}
content::WebContents* parent_app = OpenApplication(parent_app_id);
// Clicking a link from target="_self" should link capture in V1.
{
apps::test::NavigationCommittedForUrlObserver navigated_observer(
GetNestedAppUrl());
ClickLinkAndWait(parent_app, GetNestedAppUrl(), LinkTarget::SELF,
/*rel=*/"");
navigated_observer.Wait();
ASSERT_TRUE(navigated_observer.web_contents());
Browser* navigated_browser =
chrome::FindBrowserWithTab(navigated_observer.web_contents());
if (ShouldLinksWithExistingFrameTargetsCapture()) {
// Self links should be captured into a new app.
EXPECT_TRUE(
AppBrowserController::IsForWebApp(navigated_browser, nested_app_id));
} else {
// Since we are navigating in the parent, the web contents should stay the
// same (and thus stay in the parent app).
EXPECT_TRUE(
AppBrowserController::IsForWebApp(navigated_browser, parent_app_id));
}
}
// Clicking a link from target="_blank" should link capture in v1 and v2.
{
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
ClickLinkAndWait(parent_app, GetNestedAppUrl(), LinkTarget::BLANK,
/*rel=*/"");
EXPECT_TRUE(AppBrowserController::IsForWebApp(added_observer.Wait(),
nested_app_id));
}
// Links clicked within an app popup browser will also capture.
{
const gfx::Size size(500, 500);
// The parent link capturing must be turned off or the popup window url will
// automatically capture.
if (LinkCapturingEnabledByDefault()) {
ASSERT_EQ(
apps::test::DisableLinkCapturingByUser(profile(), parent_app_id),
base::ok());
}
Browser* const popup_browser = OpenPopupAndWait(
chrome::FindBrowserWithTab(parent_app), GetParentAppUrl(), size);
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
ClickLinkAndWait(popup_browser->tab_strip_model()->GetActiveWebContents(),
GetNestedAppUrl(),
IsV2() ? LinkTarget::BLANK : LinkTarget::SELF,
/*rel=*/"");
EXPECT_TRUE(AppBrowserController::IsForWebApp(added_observer.Wait(),
nested_app_id));
}
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
NoLinkCaptureOutOfScopeInAppWindow) {
const auto [app_id, in_scope_1, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
content::WebContents* test_app = OpenApplication(app_id);
ClickLinkAndWait(test_app, out_of_scope_, LinkTarget::SELF, /*rel=*/"");
ClickLinkAndWait(test_app, in_scope_1, LinkTarget::SELF, /*rel=*/"");
ExpectTabs(chrome::FindBrowserWithTab(test_app), {in_scope_1});
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
PrerenderNavigationForBlankLinks) {
GURL out_of_scope = embedded_test_server()->GetURL("/empty.html");
const auto [app_id, in_scope, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Start navigation from an out-of-scope URL on the same origin to ensure that
// prerendering can happen.
NavigateSelf(browser(), out_of_scope);
// Prerenders are cancelled for all links that use the throttle to cancel
// navigations and launch apps. For v1, this is all links. For v2, this is
// only if the supplemental throttle is used (CrOS only).
bool expect_prerender_cancel = ShouldLinksWithExistingFrameTargetsCapture();
PrerenderHostObserver host_observer(*prerender_web_contents(), in_scope);
if (expect_prerender_cancel) {
prerender_helper_.AddPrerenderAsync(in_scope);
host_observer.WaitForDestroyed();
} else {
// This will EXPECT-fail if the prerender is cancelled.
prerender_helper_.AddPrerender(in_scope);
}
// The out of scope URL should still be open in the main browser.
ExpectTabs(browser(), {out_of_scope});
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
ClickLinkAndWait(prerender_web_contents(), in_scope, LinkTarget::BLANK,
/*rel=*/"");
Browser* app_browser = added_observer.Wait();
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(app_browser, {in_scope});
}
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
PrerenderNavigationForSelfLinks) {
GURL out_of_scope = embedded_test_server()->GetURL("/empty.html");
const auto [app_id, in_scope, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Start navigation from an out-of-scope URL on the same origin to ensure that
// prerendering can happen.
NavigateSelf(browser(), out_of_scope);
// Prerenders are cancelled for all links that use the throttle to cancel
// navigations and launch apps. For v1, this is all links. For v2, this is
// only if the supplemental throttle is used (CrOS only).
bool expect_prerender_cancel = ShouldLinksWithExistingFrameTargetsCapture();
PrerenderHostObserver host_observer(*prerender_web_contents(), in_scope);
if (expect_prerender_cancel) {
prerender_helper_.AddPrerenderAsync(in_scope);
host_observer.WaitForDestroyed();
} else {
// This will EXPECT-fail if the prerender is cancelled.
prerender_helper_.AddPrerender(in_scope);
}
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
ClickLinkAndWait(prerender_web_contents(), in_scope, LinkTarget::SELF,
/*rel=*/"");
if (ShouldLinksWithExistingFrameTargetsCapture()) {
ExpectTabs(browser(), {out_of_scope});
Browser* app_browser = added_observer.Wait();
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(app_browser, {in_scope});
} else {
ExpectTabs(browser(), {in_scope});
}
}
// TODO(crbug.com/394710875): Re-enable this test
#if BUILDFLAG(IS_LINUX)
#define MAYBE_NoLinkCapturePopupNavigation DISABLED_NoLinkCapturePopupNavigation
#else
#define MAYBE_NoLinkCapturePopupNavigation NoLinkCapturePopupNavigation
#endif
IN_PROC_BROWSER_TEST_P(WebAppLinkCapturingBrowserTest,
MAYBE_NoLinkCapturePopupNavigation) {
const auto [app_id, in_scope, _, scope] =
InstallTestApp("/web_apps/basic.html");
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
AddTab(browser(), about_blank_);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
constexpr char kPopupNavigationJs[] = R"js(
(() => {
let button = document.createElement("button");
button.id = 'popup';
button.addEventListener('click', () => {
window.open('$1', 'foo', 'popup');
});
document.body.appendChild(button);
})();
)js";
ASSERT_TRUE(content::ExecJs(
web_contents,
base::ReplaceStringPlaceholders(kPopupNavigationJs, {in_scope.spec()},
/*offsets=*/nullptr)));
// Clicking a link that opens a popup should open a regular popup window
// without link capturing.
BrowserChangeObserver added_observer(
nullptr, BrowserChangeObserver::ChangeType::kAdded);
auto navigation_observer = GetTestNavigationObserver(in_scope);
content::SimulateEndOfPaintHoldingOnPrimaryMainFrame(web_contents);
content::SimulateMouseClickOrTapElementWithId(web_contents, "popup");
Browser* popup_browser = added_observer.Wait();
// We need to wait for the navigation to complete inside the popup browser, to
// give link capturing a chance to trigger.
navigation_observer->Wait();
EXPECT_FALSE(AppBrowserController::IsForWebApp(popup_browser, app_id));
EXPECT_TRUE(popup_browser->is_type_popup());
ExpectTabs(popup_browser, {in_scope});
}
INSTANTIATE_TEST_SUITE_P(
,
WebAppLinkCapturingBrowserTest,
#if BUILDFLAG(IS_CHROMEOS)
testing::Values(apps::test::LinkCapturingFeatureVersion::kV1DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOff,
apps::test::LinkCapturingFeatureVersion::
kV2DefaultOffCaptureExistingFrames),
#else
testing::Values(apps::test::LinkCapturingFeatureVersion::kV2DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOn),
#endif
apps::test::LinkCapturingVersionToString);
// TODO(crbug.com/376922620): Add tabbed mode support for navigation capturing.
#if BUILDFLAG(IS_CHROMEOS)
class WebAppTabStripLinkCapturingBrowserTest
: public WebAppLinkCapturingBrowserTest {
public:
WebAppTabStripLinkCapturingBrowserTest() {
features_.InitWithFeatures(
/*enabled_features=*/{blink::features::kDesktopPWAsTabStrip,
blink::features::
kDesktopPWAsTabStripCustomizations},
/*disabled_features=*/{});
}
// Returns [app_id, in_scope_1, in_scope_2, scope]
std::tuple<webapps::AppId, GURL, GURL, GURL> InstallTestTabbedApp() {
const auto [app_id, in_scope_1, in_scope_2, scope] =
WebAppLinkCapturingBrowserTest::InstallTestApp(
"/banners/"
"manifest_test_page.html?manifest=manifest_tabbed_display_override."
"json");
return std::make_tuple(app_id, in_scope_1, in_scope_2, scope);
}
private:
base::test::ScopedFeatureList features_;
};
// First in scope navigation from out of scope gets captured and reparented into
// the app window.
IN_PROC_BROWSER_TEST_P(WebAppTabStripLinkCapturingBrowserTest,
InScopeNavigationsCaptured) {
if (!WebAppRegistrar::IsSupportedDisplayModeForNavigationCapture(
blink::mojom::DisplayMode::kTabbed)) {
GTEST_SKIP() << "kTabbed mode not yet supported for navigation capturing.";
}
const auto [app_id, in_scope_1, in_scope_2, scope] = InstallTestTabbedApp();
ASSERT_EQ(apps::test::EnableLinkCapturingByUser(profile(), app_id),
base::ok());
// Start browser at an out of scope page.
NavigateSelf(browser(), out_of_scope_);
// In scope navigation should open app window.
Browser* app_browser = GetNewBrowserFromNavigation(browser(), in_scope_1);
EXPECT_TRUE(AppBrowserController::IsForWebApp(app_browser, app_id));
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_1});
// Another in scope navigation should open a new tab in the same app window.
NavigateCapturable(browser(), in_scope_2);
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_1, in_scope_2});
// Whole origin should count as in scope.
NavigateCapturable(browser(), scope);
ExpectTabs(browser(), {out_of_scope_});
ExpectTabs(app_browser, {in_scope_1, in_scope_2, scope});
// Middle clicking links should not be captured.
auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
content::SimulateEndOfPaintHoldingOnPrimaryMainFrame(web_contents);
ClickLinkWithModifiersAndWaitForURL(
web_contents, scope, scope, LinkTarget::SELF, "",
blink::WebInputEvent::Modifiers::kNoModifiers,
blink::WebMouseEvent::Button::kMiddle);
ExpectTabs(browser(), {out_of_scope_, scope});
ExpectTabs(app_browser, {in_scope_1, in_scope_2, scope});
// Out of scope should behave as usual.
NavigateSelf(browser(), out_of_scope_);
ExpectTabs(browser(), {out_of_scope_, scope});
ExpectTabs(app_browser, {in_scope_1, in_scope_2, scope});
}
INSTANTIATE_TEST_SUITE_P(
,
WebAppTabStripLinkCapturingBrowserTest,
#if BUILDFLAG(IS_CHROMEOS)
testing::Values(apps::test::LinkCapturingFeatureVersion::kV1DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOff,
apps::test::LinkCapturingFeatureVersion::
kV2DefaultOffCaptureExistingFrames),
#else
testing::Values(apps::test::LinkCapturingFeatureVersion::kV1DefaultOff,
apps::test::LinkCapturingFeatureVersion::kV2DefaultOff),
#endif // BUILDFLAG(IS_CHROMEOS)
apps::test::LinkCapturingVersionToString);
#endif
} // namespace
} // namespace web_app
|