1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/web_applications/web_app_ui_manager_impl.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/test_future.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/web_applications/mojom/user_display_mode.mojom.h"
#include "chrome/browser/web_applications/test/fake_os_integration_manager.h"
#include "chrome/browser/web_applications/test/fake_web_app_provider.h"
#include "chrome/browser/web_applications/test/os_integration_test_override_impl.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/browser/web_applications/web_app_provider.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/webapps/browser/installable/installable_metrics.h"
#include "components/webapps/browser/uninstall_result_code.h"
#include "components/webapps/common/web_app_id.h"
#include "content/public/test/browser_test.h"
#include "url/gurl.h"
#if BUILDFLAG(IS_CHROMEOS)
#include "chrome/browser/ash/app_list/app_list_syncable_service.h"
#include "chrome/browser/ash/app_list/app_list_syncable_service_factory.h"
#include "chrome/browser/web_applications/test/web_app_test_observers.h"
#endif
namespace web_app {
class WebAppUiManagerImplBrowserTest : public InProcessBrowserTest {
protected:
// InProcessBrowserTest:
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
web_app::test::WaitUntilWebAppProviderAndSubsystemsReady(
WebAppProvider::GetForTest(profile()));
}
Profile* profile() { return browser()->profile(); }
webapps::AppId InstallWebApp(const GURL& start_url) {
auto web_app_info =
WebAppInstallInfo::CreateWithStartUrlForTesting(start_url);
web_app_info->user_display_mode = mojom::UserDisplayMode::kStandalone;
return web_app::test::InstallWebApp(profile(), std::move(web_app_info));
}
Browser* LaunchWebApp(const webapps::AppId& app_id) {
return LaunchWebAppBrowser(profile(), app_id);
}
WebAppUiManager& ui_manager() {
return WebAppProvider::GetForTest(profile())->ui_manager();
}
private:
web_app::OsIntegrationTestOverrideBlockingRegistration faked_os_integration_;
};
IN_PROC_BROWSER_TEST_F(WebAppUiManagerImplBrowserTest,
GetNumWindowsForApp_AppWindowsAdded) {
// Zero apps on start:
EXPECT_EQ(0u, ui_manager().GetNumWindowsForApp(webapps::AppId()));
webapps::AppId foo_app_id = InstallWebApp(GURL("https://example.com"));
LaunchWebApp(foo_app_id);
EXPECT_EQ(1u, ui_manager().GetNumWindowsForApp(foo_app_id));
LaunchWebApp(foo_app_id);
EXPECT_EQ(2u, ui_manager().GetNumWindowsForApp(foo_app_id));
}
IN_PROC_BROWSER_TEST_F(WebAppUiManagerImplBrowserTest,
UninstallDuringLastBrowserWindow) {
// Zero apps on start:
EXPECT_EQ(0u, ui_manager().GetNumWindowsForApp(webapps::AppId()));
webapps::AppId foo_app_id = InstallWebApp(GURL("https://example.com"));
LaunchWebApp(foo_app_id);
EXPECT_EQ(1u, ui_manager().GetNumWindowsForApp(foo_app_id));
// It has 2 browser window object.
EXPECT_EQ(2u, BrowserList::GetInstance()->size());
web_app::CloseAndWait(browser());
EXPECT_EQ(1u, BrowserList::GetInstance()->size());
Browser* app_browser = BrowserList::GetInstance()->GetLastActive();
BrowserWaiter waiter(app_browser);
// Uninstalling should close the |app_browser|, but keep the browser
// object alive long enough to complete the uninstall.
test::UninstallWebApp(app_browser->profile(), foo_app_id);
waiter.AwaitRemoved();
EXPECT_EQ(0u, BrowserList::GetInstance()->size());
}
IN_PROC_BROWSER_TEST_F(WebAppUiManagerImplBrowserTest,
GetNumWindowsForApp_AppWindowsRemoved) {
webapps::AppId foo_app_id = InstallWebApp(GURL("https://example.com"));
auto* foo_window1 = LaunchWebApp(foo_app_id);
auto* foo_window2 = LaunchWebApp(foo_app_id);
webapps::AppId bar_app_id = InstallWebApp(GURL("https://example2.com"));
LaunchWebApp(bar_app_id);
EXPECT_EQ(2u, ui_manager().GetNumWindowsForApp(foo_app_id));
EXPECT_EQ(1u, ui_manager().GetNumWindowsForApp(bar_app_id));
CloseAndWait(foo_window1);
EXPECT_EQ(1u, ui_manager().GetNumWindowsForApp(foo_app_id));
EXPECT_EQ(1u, ui_manager().GetNumWindowsForApp(bar_app_id));
CloseAndWait(foo_window2);
EXPECT_EQ(0u, ui_manager().GetNumWindowsForApp(foo_app_id));
EXPECT_EQ(1u, ui_manager().GetNumWindowsForApp(bar_app_id));
}
IN_PROC_BROWSER_TEST_F(WebAppUiManagerImplBrowserTest,
NotifyOnAllAppWindowsClosed_NoOpenedWindows) {
webapps::AppId foo_app_id = InstallWebApp(GURL("https://example.com"));
webapps::AppId bar_app_id = InstallWebApp(GURL("https://example2.com"));
LaunchWebApp(bar_app_id);
base::RunLoop run_loop;
// Should return early; no windows for |foo_app|.
ui_manager().NotifyOnAllAppWindowsClosed(foo_app_id, run_loop.QuitClosure());
run_loop.Run();
}
// Tests that the callback is correctly called when there is more than one
// app window.
IN_PROC_BROWSER_TEST_F(WebAppUiManagerImplBrowserTest,
NotifyOnAllAppWindowsClosed_MultipleOpenedWindows) {
webapps::AppId foo_app_id = InstallWebApp(GURL("https://example.com"));
webapps::AppId bar_app_id = InstallWebApp(GURL("https://example2.com"));
// Test that NotifyOnAllAppWindowsClosed can be called more than once for
// the same app.
for (int i = 0; i < 2; i++) {
auto* foo_window1 = LaunchWebApp(foo_app_id);
auto* foo_window2 = LaunchWebApp(foo_app_id);
auto* bar_window = LaunchWebApp(bar_app_id);
bool callback_ran = false;
base::RunLoop run_loop;
ui_manager().NotifyOnAllAppWindowsClosed(foo_app_id,
base::BindLambdaForTesting([&]() {
callback_ran = true;
run_loop.Quit();
}));
CloseAndWait(foo_window1);
// The callback shouldn't have run yet because there is still one window
// opened.
EXPECT_FALSE(callback_ran);
CloseAndWait(bar_window);
EXPECT_FALSE(callback_ran);
CloseAndWait(foo_window2);
run_loop.Run();
EXPECT_TRUE(callback_ran);
}
}
#if BUILDFLAG(IS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(WebAppUiManagerImplBrowserTest, MigrateAppAttribute) {
app_list::AppListSyncableService* app_list_service =
app_list::AppListSyncableServiceFactory::GetForProfile(
browser()->profile());
// Install an old app to be replaced.
webapps::AppId old_app_id = test::InstallDummyWebApp(
profile(), "old_app", GURL("https://old.app.com"));
app_list_service->SetPinPosition(old_app_id,
syncer::StringOrdinal("positionold"));
// Install a new app to migrate the old one to.
webapps::AppId new_app_id = test::InstallDummyWebApp(
profile(), "new_app", GURL("https://new.app.com"));
base::test::TestFuture<void> future;
ui_manager().MigrateLauncherState(old_app_id, new_app_id,
future.GetCallback());
ASSERT_TRUE(future.Wait());
// New app should acquire old app's pin position.
EXPECT_EQ(app_list_service->GetSyncItem(new_app_id)
->item_pin_ordinal.ToDebugString(),
"positionold");
}
#endif // BUILDFLAG(IS_CHROMEOS)
} // namespace web_app
|
