1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/webui/profile_helper.h"
#include "base/containers/contains.h"
#include "base/files/file_util.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_timeouts.h"
#include "build/build_config.h"
#include "chrome/browser/apps/platform_apps/shortcut_manager.h"
#include "chrome/browser/browser_features.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/profiles/profile_test_util.h"
#include "chrome/browser/profiles/profile_window.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/profile_deletion_observer.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/browsing_data_remover.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browsing_data_remover_test_util.h"
#include "content/public/test/test_utils.h"
#include "content/public/test/test_web_ui.h"
namespace {
Profile* CreateProfile() {
ProfileManager* profile_manager = g_browser_process->profile_manager();
base::FilePath new_path = profile_manager->GenerateNextProfileDirectoryPath();
return &profiles::testing::CreateProfileSync(profile_manager, new_path);
}
// An observer returns back to test code after brower window associated with
// the profile is activated.
class ExpectBrowserActivationForProfile : public BrowserListObserver {
public:
explicit ExpectBrowserActivationForProfile(Profile* profile)
: profile_(profile) {
BrowserList::AddObserver(this);
}
~ExpectBrowserActivationForProfile() override {
BrowserList::RemoveObserver(this);
}
void Wait() { loop_.Run(); }
protected:
void OnBrowserSetLastActive(Browser* browser) override {
if (browser->profile() == profile_) {
loop_.Quit();
}
}
private:
raw_ptr<Profile> profile_;
base::RunLoop loop_;
};
// An observer that returns back to test code after a new browser is added to
// the BrowserList.
class BrowserAddedObserver : public BrowserListObserver {
public:
BrowserAddedObserver() { BrowserList::AddObserver(this); }
~BrowserAddedObserver() override { BrowserList::RemoveObserver(this); }
Browser* Wait() {
run_loop_.Run();
return browser_;
}
protected:
// BrowserListObserver:
void OnBrowserAdded(Browser* browser) override {
browser_ = browser;
run_loop_.Quit();
}
private:
raw_ptr<Browser> browser_ = nullptr;
base::RunLoop run_loop_;
};
} // namespace
class ProfileHelperTest : public InProcessBrowserTest {
public:
ProfileHelperTest() = default;
protected:
void SetUp() override {
// Shortcut deletion delays tests shutdown on Win-7 and results in time out.
// See crbug.com/1073451.
#if BUILDFLAG(IS_WIN)
AppShortcutManager::SuppressShortcutsForTesting();
#endif
InProcessBrowserTest::SetUp();
}
};
IN_PROC_BROWSER_TEST_F(ProfileHelperTest, OpenNewWindowForProfile) {
BrowserList* browser_list = BrowserList::GetInstance();
Browser* original_browser = browser();
Profile* original_profile = original_browser->profile();
std::unique_ptr<ExpectBrowserActivationForProfile> activation_observer;
// Sanity checks.
EXPECT_EQ(1u, browser_list->size());
EXPECT_TRUE(base::Contains(*browser_list, original_browser));
// Opening existing browser profile shouldn't open additional browser windows.
webui::OpenNewWindowForProfile(original_profile);
EXPECT_EQ(1u, browser_list->size());
EXPECT_EQ(original_browser, browser_list->GetLastActive());
// Opening additional browser will add new window and activate it.
Profile* additional_profile = CreateProfile();
activation_observer =
std::make_unique<ExpectBrowserActivationForProfile>(additional_profile);
webui::OpenNewWindowForProfile(additional_profile);
EXPECT_EQ(2u, browser_list->size());
activation_observer->Wait();
Browser* additional_browser = browser_list->GetLastActive();
EXPECT_EQ(additional_profile, additional_browser->profile());
// On Macs OpenNewWindowForProfile does not activate existing browser
// while non of the browser windows have focus. BrowserWindowCocoa::Show() got
// the same issue as BrowserWindowCocoa::Activate(), and execute call
// BrowserList::SetLastActive() directly. Not sure if it is a bug or desired
// behaviour.
#if !BUILDFLAG(IS_MAC)
// Switch to original browser. Only LastActive should change.
activation_observer =
std::make_unique<ExpectBrowserActivationForProfile>(original_profile);
webui::OpenNewWindowForProfile(original_profile);
EXPECT_EQ(2u, browser_list->size());
activation_observer->Wait();
EXPECT_EQ(original_profile, browser_list->GetLastActive()->profile());
#endif
}
IN_PROC_BROWSER_TEST_F(ProfileHelperTest, DeleteSoleProfile) {
content::TestWebUI web_ui;
Browser* original_browser = browser();
ProfileAttributesStorage& storage =
g_browser_process->profile_manager()->GetProfileAttributesStorage();
base::FilePath original_browser_profile_path =
original_browser->profile()->GetPath();
BrowserList* browser_list = BrowserList::GetInstance();
EXPECT_EQ(1u, browser_list->size());
EXPECT_TRUE(base::Contains(*browser_list, original_browser));
EXPECT_EQ(1u, storage.GetNumberOfProfiles());
// Original browser will be closed, and browser with the new profile created.
BrowserAddedObserver added_observer;
webui::DeleteProfileAtPath(original_browser->profile()->GetPath(),
ProfileMetrics::DELETE_PROFILE_SETTINGS);
ui_test_utils::WaitForBrowserToClose(original_browser);
Browser* new_browser = added_observer.Wait();
content::RunAllTasksUntilIdle();
EXPECT_EQ(1u, browser_list->size());
EXPECT_NE(original_browser_profile_path, new_browser->profile()->GetPath());
EXPECT_EQ(1u, storage.GetNumberOfProfiles());
}
IN_PROC_BROWSER_TEST_F(ProfileHelperTest, DeleteActiveProfile) {
content::TestWebUI web_ui;
Browser* original_browser = browser();
ProfileAttributesStorage& storage =
g_browser_process->profile_manager()->GetProfileAttributesStorage();
BrowserList* browser_list = BrowserList::GetInstance();
EXPECT_EQ(1u, browser_list->size());
EXPECT_TRUE(base::Contains(*browser_list, original_browser));
EXPECT_EQ(1u, storage.GetNumberOfProfiles());
Profile* additional_profile = CreateProfile();
EXPECT_EQ(2u, storage.GetNumberOfProfiles());
// Original browser will be closed, and browser with the new profile created.
webui::DeleteProfileAtPath(original_browser->profile()->GetPath(),
ProfileMetrics::DELETE_PROFILE_SETTINGS);
ui_test_utils::WaitForBrowserToClose(original_browser);
content::RunAllTasksUntilIdle();
EXPECT_EQ(1u, browser_list->size());
EXPECT_EQ(additional_profile, browser_list->get(0)->profile());
EXPECT_EQ(1u, storage.GetNumberOfProfiles());
}
class ProfileHelperTestWithDestroyProfile
: public ProfileHelperTest,
public testing::WithParamInterface<bool> {
public:
ProfileHelperTestWithDestroyProfile() {
bool enable_destroy_profile = GetParam();
if (enable_destroy_profile) {
feature_list_.InitAndEnableFeature(
features::kDestroyProfileOnBrowserClose);
} else {
feature_list_.InitAndDisableFeature(
features::kDestroyProfileOnBrowserClose);
}
}
private:
base::test::ScopedFeatureList feature_list_;
};
// TODO(crbug.com/40945232): Fix this flaky test. Probably a timing issue.
IN_PROC_BROWSER_TEST_P(ProfileHelperTestWithDestroyProfile,
DISABLED_DeleteInactiveProfile) {
content::TestWebUI web_ui;
Browser* original_browser = browser();
ProfileAttributesStorage& storage =
g_browser_process->profile_manager()->GetProfileAttributesStorage();
BrowserList* browser_list = BrowserList::GetInstance();
EXPECT_EQ(1u, browser_list->size());
EXPECT_TRUE(base::Contains(*browser_list, original_browser));
EXPECT_EQ(1u, storage.GetNumberOfProfiles());
Profile* additional_profile = CreateProfile();
EXPECT_EQ(2u, storage.GetNumberOfProfiles());
base::FilePath additional_profile_dir = additional_profile->GetPath();
bool destroy_profile =
base::FeatureList::IsEnabled(features::kDestroyProfileOnBrowserClose);
if (destroy_profile) {
ProfileDeletionObserver observer;
webui::DeleteProfileAtPath(additional_profile_dir,
ProfileMetrics::DELETE_PROFILE_SETTINGS);
observer.Wait();
} else {
content::BrowsingDataRemoverCompletionInhibitor inhibitor(
additional_profile->GetBrowsingDataRemover());
webui::DeleteProfileAtPath(additional_profile_dir,
ProfileMetrics::DELETE_PROFILE_SETTINGS);
inhibitor.BlockUntilNearCompletion();
inhibitor.ContinueToCompletion();
}
EXPECT_EQ(1u, browser_list->size());
EXPECT_TRUE(base::Contains(*browser_list, original_browser));
EXPECT_EQ(1u, storage.GetNumberOfProfiles());
if (destroy_profile) {
// Check that NukeProfileFromDisk() works correctly.
base::ScopedAllowBlockingForTesting allow_blocking;
base::Time start = base::Time::Now();
while (base::PathExists(additional_profile_dir) &&
base::Time::Now() - start < TestTimeouts::action_timeout()) {
base::RunLoop().RunUntilIdle();
}
EXPECT_FALSE(base::PathExists(additional_profile_dir));
}
}
#if BUILDFLAG(IS_CHROMEOS)
INSTANTIATE_TEST_SUITE_P(DestroyProfileOnBrowserClose,
ProfileHelperTestWithDestroyProfile,
testing::Values(false));
#else
INSTANTIATE_TEST_SUITE_P(DestroyProfileOnBrowserClose,
ProfileHelperTestWithDestroyProfile,
testing::Bool());
#endif // BUILDFLAG(IS_CHROMEOS)
|