1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/web_applications/visited_manifest_manager.h"
#include "base/feature_list.h"
#include "base/strings/strcat.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/simple_test_clock.h"
#include "base/time/time.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/mojom/manifest/manifest.mojom.h"
namespace web_app {
namespace {
GURL GetExampleUrl(int i) {
return GURL(
base::StrCat({"https://www.example", base::ToString(i), ".com/"}));
}
blink::mojom::ManifestPtr CreateManifestWithScope(const GURL& scope) {
blink::mojom::ManifestPtr manifest = blink::mojom::Manifest::New();
manifest->start_url = GURL(scope.GetWithoutFilename().spec() + "index.html");
manifest->id = manifest->start_url;
manifest->scope = scope;
manifest->has_valid_specified_start_url = true;
return manifest;
}
blink::mojom::ManifestPtr CreatManifestWithScopeNoStartUrl(const GURL& scope) {
blink::mojom::ManifestPtr manifest = CreateManifestWithScope(scope);
manifest->has_valid_specified_start_url = false;
return manifest;
}
blink::mojom::ManifestPtr CreateExampleManifest(int i) {
return CreateManifestWithScope(GetExampleUrl(i));
}
class VisitedManagerEnabledTest : public testing::Test {
private:
base::test::ScopedFeatureList enable_feature{
kBlockMlPromotionInNestedPagesNoManifest};
};
TEST_F(VisitedManagerEnabledTest, ControlledChecks) {
VisitedManifestManager manager;
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example0.com/pre/")));
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example1.com/seen/")));
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example2.com/seeo/")));
EXPECT_TRUE(manager.IsUrlControlledBySeenManifest(
GURL("https://www.example1.com/seen/")));
EXPECT_TRUE(manager.IsUrlControlledBySeenManifest(
GURL("https://www.example1.com/seen/nest")));
EXPECT_TRUE(manager.IsUrlControlledBySeenManifest(
GURL("https://www.example1.com/seen/nested/")));
// Before 'seen/' in index ordering, and matches path on other origin
EXPECT_FALSE(manager.IsUrlControlledBySeenManifest(
GURL("https://www.example1.com/pre/")));
EXPECT_FALSE(manager.IsUrlControlledBySeenManifest(
GURL("https://www.example1.com/seen")));
// After 'seen/' in index ordering, and matches path on other origin
EXPECT_FALSE(manager.IsUrlControlledBySeenManifest(
GURL("https://www.example1.com/seeo/")));
}
TEST_F(VisitedManagerEnabledTest, ClearDateRange) {
base::SimpleTestClock clock;
VisitedManifestManager manager(&clock);
base::Time start = base::Time::Now();
clock.SetNow(start);
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example0.com/")));
clock.Advance(base::Minutes(10));
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example1.com/")));
clock.Advance(base::Minutes(10));
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example2.com/")));
clock.Advance(base::Minutes(10));
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example3.com/")));
// This should clear examples 1 and 2.
manager.ClearSeenScopes(start + base::Minutes(10), start + base::Minutes(20));
base::Time check_time = clock.Now();
EXPECT_TRUE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example0.com/")));
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example1.com/")));
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example2.com/")));
EXPECT_TRUE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example3.com/")));
// Checking the entries also updates the time, so clearing at the check_time
// should clear those entries too.
manager.ClearSeenScopes(check_time, check_time);
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example0.com/")));
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example3.com/")));
}
TEST_F(VisitedManagerEnabledTest, TestLru) {
VisitedManifestManager manager;
// Fill up the cache. Eviction should start from 0, as that is the first one
// that was added.
for (int i = 0; i < VisitedManifestManager::kMaxScopesToSave; ++i) {
manager.OnManifestSeen(*CreateExampleManifest(i));
}
// Check they are all present, in order again which should keep the same
// ordering.
for (int i = 0; i < VisitedManifestManager::kMaxScopesToSave; ++i) {
EXPECT_TRUE(manager.IsUrlControlledBySeenManifest(GetExampleUrl(i)));
}
// Test that is '0' was evicted after adding one more.
manager.OnManifestSeen(
*CreateExampleManifest(VisitedManifestManager::kMaxScopesToSave));
EXPECT_FALSE(manager.IsUrlControlledBySeenManifest(GetExampleUrl(0)));
// Test `OnManifestSeen` and `IsUrlControlledBySeenManifest` both move the
// entry to the top of the queue. '1' and '2' will not be deleted, instead '3'
// and '4' will when adding two more manifests.
manager.OnManifestSeen(*CreateExampleManifest(1));
EXPECT_TRUE(manager.IsUrlControlledBySeenManifest(GetExampleUrl(2)));
manager.OnManifestSeen(
*CreateExampleManifest(VisitedManifestManager::kMaxScopesToSave + 1));
manager.OnManifestSeen(
*CreateExampleManifest(VisitedManifestManager::kMaxScopesToSave + 2));
EXPECT_FALSE(manager.IsUrlControlledBySeenManifest(GetExampleUrl(3)));
EXPECT_FALSE(manager.IsUrlControlledBySeenManifest(GetExampleUrl(4)));
// Final check that all is correct.
for (int i = 0; i < VisitedManifestManager::kMaxScopesToSave + 3; ++i) {
bool is_controlled =
manager.IsUrlControlledBySeenManifest(GetExampleUrl(i));
if (i == 0 || i == 3 || i == 4) {
EXPECT_FALSE(is_controlled) << i;
} else {
EXPECT_TRUE(is_controlled) << i;
}
}
}
TEST_F(VisitedManagerEnabledTest, TestInvalidManifests) {
VisitedManifestManager manager;
manager.OnManifestSeen(
*CreatManifestWithScopeNoStartUrl(GURL("https://www.example0.com/")));
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example0.com/")));
}
TEST(VisitedManagerDisabledTest, DisabledFeature) {
// Ensure that we can disable the feature and have things not crash, and
// always returns 'false'.
base::test::ScopedFeatureList disable;
disable.InitAndDisableFeature(kBlockMlPromotionInNestedPagesNoManifest);
base::SimpleTestClock clock;
VisitedManifestManager manager(&clock);
base::Time start = base::Time::Now();
clock.SetNow(start);
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example0.com/")));
manager.OnManifestSeen(
*CreateManifestWithScope(GURL("https://www.example1.com/")));
base::Time check_time = clock.Now();
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example0.com/")));
EXPECT_FALSE(
manager.IsUrlControlledBySeenManifest(GURL("https://www.example1.com/")));
manager.ClearSeenScopes(start, check_time);
}
} // namespace
} // namespace web_app
|
