1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/webauthn/mechanism_sorter.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/time/time.h"
#include "chrome/app/vector_icons/vector_icons.h"
#include "chrome/browser/webauthn/authenticator_request_dialog_model.h"
#include "device/fido/fido_types.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using Mechanism = AuthenticatorRequestDialogModel::Mechanism;
using CredentialInfo = Mechanism::CredentialInfo;
using PasswordInfo = Mechanism::PasswordInfo;
const auto kUserId = std::vector<uint8_t>{0x01, 0x02, 0x03};
// Helper to create a GPM Passkey mechanism.
Mechanism CreateEnclavePasskey(const std::u16string& user_name,
std::optional<base::Time> last_used_time) {
Mechanism::Credential cred_info(
{device::AuthenticatorType::kEnclave, kUserId, last_used_time});
return Mechanism(std::move(cred_info), user_name, user_name, kSmartphoneIcon,
base::DoNothing());
}
// Helper to create a Platform Passkey mechanism.
Mechanism CreatePlatformPasskey(const std::u16string& user_name,
std::optional<base::Time> last_used_time) {
Mechanism::Credential cred_info(
{device::AuthenticatorType::kICloudKeychain, kUserId, last_used_time});
return Mechanism(std::move(cred_info), user_name, user_name, kSmartphoneIcon,
base::DoNothing());
}
// Helper to create a Password mechanism.
Mechanism CreatePassword(const std::u16string& user_name,
base::Time last_used_time) {
Mechanism::Type password_data =
Mechanism::Password(Mechanism::PasswordInfo(last_used_time));
return Mechanism(std::move(password_data), user_name, user_name,
kSmartphoneIcon, base::DoNothing());
}
class MechanismSorterTest : public ::testing::Test {
public:
MechanismSorterTest() = default;
protected:
void ExpectNoDeduplication() {
histogram_tester_.ExpectUniqueSample(
"WebAuthentication.MechanismSorter.DeduplicationHappened", false, 1);
histogram_tester_.ExpectTotalCount(
"WebAuthentication.MechanismSorter.SelectedMechanismType", 0);
}
void ExpectDeduplicationRecorded(
WebAuthnMechanismDeduplicatedType deduplicated_type) {
histogram_tester_.ExpectUniqueSample(
"WebAuthentication.MechanismSorter.DeduplicationHappened", true, 1);
histogram_tester_.ExpectUniqueSample(
"WebAuthentication.MechanismSorter.SelectedMechanismType",
deduplicated_type, 1);
}
MechanismSorter sorter_;
base::HistogramTester histogram_tester_;
};
// Test that an empty list remains empty.
TEST_F(MechanismSorterTest, EmptyList) {
std::vector<Mechanism> mechanisms;
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
EXPECT_TRUE(result.empty());
ExpectNoDeduplication();
}
// Test that a list with one enclave passkey remains unchanged.
TEST_F(MechanismSorterTest, SingleEnclaveMechanism) {
std::vector<Mechanism> mechanisms;
mechanisms.push_back(CreateEnclavePasskey(u"user1", base::Time::Now()));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_EQ(result[0].name, u"user1");
ExpectNoDeduplication();
}
// Test that a list with one platform passkey remains unchanged.
TEST_F(MechanismSorterTest, SinglePlatformMechanism) {
std::vector<Mechanism> mechanisms;
mechanisms.push_back(CreatePlatformPasskey(u"user1", std::nullopt));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_EQ(result[0].name, u"user1");
ExpectNoDeduplication();
}
// Test that a list with one password remains unchanged.
TEST_F(MechanismSorterTest, SinglePasswordMechanism) {
std::vector<Mechanism> mechanisms;
mechanisms.push_back(CreatePassword(u"user1", base::Time::Now()));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_EQ(result[0].name, u"user1");
ExpectNoDeduplication();
}
// Test deduplication: GPM Passkey preferred over Platform Passkey if newer.
TEST_F(MechanismSorterTest, DeduplicateGpmPasskeyVsPlatformPasskey_GpmNewer) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
base::Time time_older = time_now - base::Minutes(1);
mechanisms.push_back(CreatePlatformPasskey(u"user1", time_older));
mechanisms.push_back(CreateEnclavePasskey(u"user1", time_now)); // Newer
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_EQ(std::get<Mechanism::Credential>(result[0].type).value().source,
device::AuthenticatorType::kEnclave);
ExpectDeduplicationRecorded(
WebAuthnMechanismDeduplicatedType::kEnclavePasskey);
}
// Test deduplication: GPM Passkey preferred over Password if GPM Passkey is
// newer.
TEST_F(MechanismSorterTest, DeduplicateGpmPasskeyVsGpmPassword_PasskeyNewer) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
base::Time time_older = time_now - base::Minutes(1);
mechanisms.push_back(CreatePassword(u"user1", time_older));
mechanisms.push_back(CreateEnclavePasskey(u"user1", time_now)); // Newer
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_TRUE(std::holds_alternative<Mechanism::Credential>(result[0].type));
EXPECT_EQ(std::get<Mechanism::Credential>(result[0].type).value().source,
device::AuthenticatorType::kEnclave);
ExpectDeduplicationRecorded(
WebAuthnMechanismDeduplicatedType::kEnclavePasskey);
}
// Test deduplication: GPM Password preferred over GPM Passkey if Password
// is newer.
TEST_F(MechanismSorterTest, DeduplicateGpmPasskeyVsGpmPassword_PasswordNewer) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
base::Time time_older = time_now - base::Minutes(1);
mechanisms.push_back(CreateEnclavePasskey(u"user1", time_older));
mechanisms.push_back(CreatePassword(u"user1", time_now));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_TRUE(std::holds_alternative<Mechanism::Password>(result[0].type));
ExpectDeduplicationRecorded(WebAuthnMechanismDeduplicatedType::kPassword);
}
// Test deduplication: Platform Passkey preferred over Password.
TEST_F(MechanismSorterTest, DeduplicatePlatformPasskeyVsGpmPassword) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
mechanisms.push_back(CreatePassword(u"user1", time_now));
mechanisms.push_back(CreatePlatformPasskey(u"user1", std::nullopt));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 1u);
EXPECT_TRUE(std::holds_alternative<Mechanism::Credential>(result[0].type));
EXPECT_NE(std::get<Mechanism::Credential>(result[0].type).value().source,
device::AuthenticatorType::kEnclave);
ExpectDeduplicationRecorded(
WebAuthnMechanismDeduplicatedType::kPlatformPasskey);
}
// Test sorting: Most recent first.
TEST_F(MechanismSorterTest, SortByTimestamp) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
base::Time time_older = time_now - base::Minutes(1);
base::Time time_oldest = time_older - base::Minutes(1);
mechanisms.push_back(CreateEnclavePasskey(u"user_c", time_older));
mechanisms.push_back(CreateEnclavePasskey(u"user_a", time_now));
mechanisms.push_back(CreateEnclavePasskey(u"user_b", time_oldest));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 3u);
EXPECT_EQ(result[0].name, u"user_a");
EXPECT_EQ(result[1].name, u"user_c");
EXPECT_EQ(result[2].name, u"user_b");
ExpectNoDeduplication();
}
// Test sorting: Alphabetical by name if timestamps are equal.
TEST_F(MechanismSorterTest, SortByNameIfTimestampsEqual) {
std::vector<Mechanism> mechanisms;
base::Time same_time = base::Time::Now();
mechanisms.push_back(CreateEnclavePasskey(u"user_c", same_time));
mechanisms.push_back(CreateEnclavePasskey(u"user_a", same_time));
mechanisms.push_back(CreateEnclavePasskey(u"user_b", same_time));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 3u);
EXPECT_EQ(result[0].name, u"user_a");
EXPECT_EQ(result[1].name, u"user_b");
EXPECT_EQ(result[2].name, u"user_c");
ExpectNoDeduplication();
}
// Test that sorting/deduplication does not happen for non-kModalImmediate UI.
TEST_F(MechanismSorterTest, NoProcessingForOtherUIPresentations) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
base::Time time_older = time_now - base::Minutes(1);
// Order is intentionally "wrong" for kModalImmediate
mechanisms.push_back(CreateEnclavePasskey(u"user1", time_older));
mechanisms.push_back(CreatePlatformPasskey(u"user1", std::nullopt));
mechanisms.push_back(CreateEnclavePasskey(u"user2", time_now));
std::vector<Mechanism> result =
sorter_.ProcessMechanisms(std::move(mechanisms), UIPresentation::kModal);
ASSERT_EQ(result.size(), 3u);
// Expect original order and content
EXPECT_EQ(result[0].name, u"user1");
EXPECT_EQ(result[1].name, u"user1");
EXPECT_EQ(result[2].name, u"user2");
histogram_tester_.ExpectTotalCount(
"WebAuthentication.MechanismSorter.DeduplicationHappened", 0);
histogram_tester_.ExpectTotalCount(
"WebAuthentication.MechanismSorter.SelectedMechanismType", 0);
}
// Test multiple deduplications in one call.
TEST_F(MechanismSorterTest, MultipleDeduplications) {
std::vector<Mechanism> mechanisms;
base::Time time_now = base::Time::Now();
base::Time time_older = time_now - base::Minutes(1);
// User 1: platform passkey wins over password.
mechanisms.push_back(CreatePassword(u"user1", time_now));
mechanisms.push_back(CreatePlatformPasskey(u"user1", time_older));
// User 2: newer enclave passkey wins over password.
mechanisms.push_back(CreatePassword(u"user2", time_older));
mechanisms.push_back(CreateEnclavePasskey(u"user2", time_now));
std::vector<Mechanism> result = sorter_.ProcessMechanisms(
std::move(mechanisms), UIPresentation::kModalImmediate);
ASSERT_EQ(result.size(), 2u);
histogram_tester_.ExpectUniqueSample(
"WebAuthentication.MechanismSorter.DeduplicationHappened", true, 1);
histogram_tester_.ExpectTotalCount(
"WebAuthentication.MechanismSorter.SelectedMechanismType", 2);
histogram_tester_.ExpectBucketCount(
"WebAuthentication.MechanismSorter.SelectedMechanismType",
WebAuthnMechanismDeduplicatedType::kPlatformPasskey, 1);
histogram_tester_.ExpectBucketCount(
"WebAuthentication.MechanismSorter.SelectedMechanismType",
WebAuthnMechanismDeduplicatedType::kEnclavePasskey, 1);
}
} // namespace
|
