1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <utility>
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/strings/stringprintf.h"
#include "base/test/values_test_util.h"
#include "base/values.h"
#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
#include "components/version_info/version_info.h"
#include "extensions/common/constants.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/extension.h"
#include "extensions/common/features/feature_channel.h"
#include "extensions/common/file_util.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handlers/background_info.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace extensions {
namespace errors = manifest_errors;
namespace keys = manifest_keys;
using ExtensionManifestBackgroundTest = ChromeManifestTest;
// TODO(devlin): Can this file move to //extensions?
TEST_F(ExtensionManifestBackgroundTest, BackgroundPermission) {
LoadAndExpectError("background_permission.json",
errors::kBackgroundPermissionNeeded);
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundScripts) {
std::string error;
std::optional<base::Value::Dict> manifest =
LoadManifest("background_scripts.json", &error);
ASSERT_TRUE(manifest);
scoped_refptr<Extension> extension(
LoadAndExpectSuccess(ManifestData(manifest->Clone(), "")));
ASSERT_TRUE(extension.get());
const std::vector<std::string>& background_scripts =
BackgroundInfo::GetBackgroundScripts(extension.get());
ASSERT_EQ(2u, background_scripts.size());
EXPECT_EQ("foo.js", background_scripts[0u]);
EXPECT_EQ("bar/baz.js", background_scripts[1u]);
EXPECT_TRUE(BackgroundInfo::HasBackgroundPage(extension.get()));
EXPECT_EQ(
std::string("/") + kGeneratedBackgroundPageFilename,
BackgroundInfo::GetBackgroundURL(extension.get()).path());
manifest->SetByDottedPath("background.page", "monkey.html");
LoadAndExpectError(ManifestData(std::move(*manifest), ""),
errors::kInvalidBackgroundCombination);
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundServiceWorkerScript) {
std::string error;
std::optional<base::Value::Dict> manifest =
LoadManifest("background_script_sw.json", &error);
ASSERT_TRUE(manifest);
scoped_refptr<Extension> extension(
LoadAndExpectSuccess(ManifestData(manifest->Clone(), "")));
ASSERT_TRUE(extension.get());
ASSERT_TRUE(BackgroundInfo::IsServiceWorkerBased(extension.get()));
const GURL background_service_worker_script_url =
BackgroundInfo::GetBackgroundServiceWorkerScriptURL(extension.get());
const base::FilePath service_worker_script =
file_util::ExtensionURLToRelativeFilePath(
background_service_worker_script_url);
EXPECT_EQ("service_worker.js", service_worker_script.AsUTF8Unsafe());
manifest->SetByDottedPath("background.page", "monkey.html");
LoadAndExpectError(ManifestData(std::move(*manifest), ""),
errors::kInvalidBackgroundCombination);
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundPage) {
scoped_refptr<Extension> extension(
LoadAndExpectSuccess("background_page.json"));
ASSERT_TRUE(extension.get());
EXPECT_EQ("/foo.html",
BackgroundInfo::GetBackgroundURL(extension.get()).path());
EXPECT_TRUE(BackgroundInfo::AllowJSAccess(extension.get()));
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundAllowNoJsAccess) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("background_allow_no_js_access.json");
ASSERT_TRUE(extension.get());
EXPECT_FALSE(BackgroundInfo::AllowJSAccess(extension.get()));
extension = LoadAndExpectSuccess("background_allow_no_js_access2.json");
ASSERT_TRUE(extension.get());
EXPECT_FALSE(BackgroundInfo::AllowJSAccess(extension.get()));
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundPageWebRequest) {
ScopedCurrentChannel current_channel(version_info::Channel::DEV);
std::string error;
std::optional<base::Value::Dict> manifest =
LoadManifest("background_page.json", &error);
ASSERT_TRUE(manifest);
manifest->SetByDottedPath("background.persistent", false);
manifest->Set(keys::kManifestVersion, 2);
scoped_refptr<Extension> extension(
LoadAndExpectSuccess(ManifestData(manifest->Clone(), "")));
ASSERT_TRUE(extension.get());
EXPECT_TRUE(BackgroundInfo::HasLazyBackgroundPage(extension.get()));
base::Value::List permissions;
permissions.Append("webRequest");
manifest->Set(keys::kPermissions, std::move(permissions));
LoadAndExpectError(ManifestData(std::move(*manifest), ""),
errors::kWebRequestConflictsWithLazyBackground);
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundPageTransientBackground) {
ScopedCurrentChannel current_channel(version_info::Channel::DEV);
scoped_refptr<Extension> extension(
LoadAndExpectSuccess(ManifestData(base::test::ParseJson(R"(
{
"name": "test",
"manifest_version": 2,
"version": "1",
"background": {
"page": "foo.html"
}
})")
.TakeDict())));
ASSERT_TRUE(extension.get());
EXPECT_TRUE(BackgroundInfo::HasPersistentBackgroundPage(extension.get()));
LoadAndExpectError(
ManifestData(base::test::ParseJson(R"(
{
"name": "test",
"manifest_version": 2,
"version": "1",
"permissions": [
"transientBackground"
],
"background": {
"page": "foo.html"
}
})")
.TakeDict()),
errors::kTransientBackgroundConflictsWithPersistentBackground);
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundPagePersistentPlatformApp) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("background_page_persistent_app.json");
ASSERT_TRUE(extension->is_platform_app());
ASSERT_TRUE(BackgroundInfo::HasBackgroundPage(extension.get()));
EXPECT_FALSE(BackgroundInfo::HasPersistentBackgroundPage(extension.get()));
std::string error;
std::vector<InstallWarning> warnings;
ManifestHandler::ValidateExtension(extension.get(), &error, &warnings);
// Persistent background pages are not supported for packaged apps.
// The persistent flag is ignored and a warining is printed.
EXPECT_EQ(1U, warnings.size());
EXPECT_EQ(errors::kInvalidBackgroundPersistentInPlatformApp,
warnings[0].message);
}
TEST_F(ExtensionManifestBackgroundTest, BackgroundPagePersistentInvalidKey) {
std::vector<std::string> expected_warnings = {
"'background' is only allowed for extensions, legacy packaged apps, "
"hosted apps, login screen extensions, and chromeos system extensions, "
"but this is a packaged app.",
"'background.persistent' is only allowed for extensions, legacy packaged "
"apps, and login screen extensions, but this is a packaged app."};
scoped_refptr<Extension> extension = LoadAndExpectWarnings(
"background_page_invalid_persistent_key_app.json", expected_warnings);
ASSERT_TRUE(extension->is_platform_app());
ASSERT_TRUE(BackgroundInfo::HasBackgroundPage(extension.get()));
EXPECT_FALSE(BackgroundInfo::HasPersistentBackgroundPage(extension.get()));
}
// Tests channel restriction on "background.service_worker" key.
TEST_F(ExtensionManifestBackgroundTest, ServiceWorkerBasedBackgroundKey) {
// TODO(lazyboy): Add exhaustive tests here, e.g.
// - specifying a non-existent file.
// - specifying multiple files.
// - specifying invalid type (non-string) values.
{
ScopedCurrentChannel stable(version_info::Channel::STABLE);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("service_worker_based_background.json");
}
{
ScopedCurrentChannel beta(version_info::Channel::BETA);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("service_worker_based_background.json");
}
{
ScopedCurrentChannel dev(version_info::Channel::DEV);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("service_worker_based_background.json");
}
{
ScopedCurrentChannel canary(version_info::Channel::CANARY);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("service_worker_based_background.json");
}
{
ScopedCurrentChannel trunk(version_info::Channel::UNKNOWN);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("service_worker_based_background.json");
}
}
TEST_F(ExtensionManifestBackgroundTest, ManifestV3Restrictions) {
{
constexpr char kManifestBackgroundPage[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1",
"background": {
"page": "background.html"
}
})";
base::Value manifest_value = base::test::ParseJson(kManifestBackgroundPage);
scoped_refptr<Extension> extension(LoadAndExpectWarning(
ManifestData(std::move(manifest_value).TakeDict(), "background page"),
"'background.page' requires manifest version of 2 or lower."));
EXPECT_FALSE(BackgroundInfo::HasBackgroundPage(extension.get()));
}
{
constexpr char kManifestBackgroundScripts[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1",
"background": {
"scripts": ["background.js"]
}
})";
base::Value manifest_value =
base::test::ParseJson(kManifestBackgroundScripts);
scoped_refptr<Extension> extension(LoadAndExpectWarning(
ManifestData(std::move(manifest_value).TakeDict(),
"background scripts"),
"'background.scripts' requires manifest version of 2 or lower."));
EXPECT_FALSE(BackgroundInfo::HasBackgroundPage(extension.get()));
}
{
constexpr char kManifestBackgroundPersistent[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1",
"background": {
"service_worker": "worker.js",
"persistent": true
}
})";
base::Value manifest_value =
base::test::ParseJson(kManifestBackgroundPersistent);
scoped_refptr<Extension> extension(LoadAndExpectWarning(
ManifestData(std::move(manifest_value).TakeDict(),
"persistent background"),
"'background.persistent' requires manifest version of 2 or lower."));
EXPECT_FALSE(BackgroundInfo::HasBackgroundPage(extension.get()));
}
{
// An extension with no background key present should still be allowed.
constexpr char kManifestBackgroundPersistent[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1"
})";
base::Value manifest_value =
base::test::ParseJson(kManifestBackgroundPersistent);
scoped_refptr<Extension> extension(LoadAndExpectSuccess(
ManifestData(std::move(manifest_value).TakeDict(), "no background")));
EXPECT_FALSE(BackgroundInfo::HasBackgroundPage(extension.get()));
}
{
// An extension with both a background page and a service worker should
// still be allowed, with the page ignored, since other browsers still
// support background pages in MV3. This allows a developer to ship a
// single extension and for the browser to choose the appropriate key.
constexpr char kManifestBackgroundPersistent[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1",
"background": {
"service_worker": "worker.js",
"page": "background.html"
}
})";
base::Value manifest_value =
base::test::ParseJson(kManifestBackgroundPersistent);
scoped_refptr<Extension> extension(LoadAndExpectWarning(
ManifestData(std::move(manifest_value).TakeDict(),
"background page and service worker"),
"'background.page' requires manifest version of 2 or lower."));
EXPECT_TRUE(BackgroundInfo::IsServiceWorkerBased(extension.get()));
EXPECT_FALSE(BackgroundInfo::HasBackgroundPage(extension.get()));
}
{
// An extension with both background scripts and a service worker should
// still be allowed, with the scripts ignored, since other browsers still
// support background scripts in MV3. This allows a developer to ship a
// single extension and for the browser to choose the appropriate key.
constexpr char kManifestBackgroundPersistent[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1",
"background": {
"service_worker": "worker.js",
"scripts": ["background.js"]
}
})";
base::Value manifest_value =
base::test::ParseJson(kManifestBackgroundPersistent);
scoped_refptr<Extension> extension(LoadAndExpectWarning(
ManifestData(std::move(manifest_value).TakeDict(),
"background scripts and service worker"),
"'background.scripts' requires manifest version of 2 or lower."));
EXPECT_TRUE(BackgroundInfo::IsServiceWorkerBased(extension.get()));
EXPECT_FALSE(BackgroundInfo::HasBackgroundPage(extension.get()));
}
}
TEST_F(ExtensionManifestBackgroundTest, ModuleServiceWorker) {
auto get_manifest = [](const char* background_value) {
constexpr char kManifestStub[] =
R"({
"name": "MV3 Test",
"manifest_version": 3,
"version": "0.1",
"background": { %s }
})";
std::string manifest_str =
base::StringPrintf(kManifestStub, background_value);
return base::test::ParseJson(manifest_str).TakeDict();
};
{
constexpr char kWorkerTypeClassic[] =
R"("service_worker": "worker.js", "type": "classic")";
scoped_refptr<Extension> extension(LoadAndExpectSuccess(ManifestData(
get_manifest(kWorkerTypeClassic), "classic service worker")));
ASSERT_TRUE(extension);
ASSERT_TRUE(BackgroundInfo::IsServiceWorkerBased(extension.get()));
const BackgroundServiceWorkerType service_worker_type =
BackgroundInfo::GetBackgroundServiceWorkerType(extension.get());
EXPECT_EQ(BackgroundServiceWorkerType::kClassic, service_worker_type);
}
{
constexpr char kWorkerTypeModule[] =
R"("service_worker": "worker.js", "type": "module")";
scoped_refptr<Extension> extension(LoadAndExpectSuccess(ManifestData(
get_manifest(kWorkerTypeModule), "module service worker")));
ASSERT_TRUE(extension);
ASSERT_TRUE(BackgroundInfo::IsServiceWorkerBased(extension.get()));
const BackgroundServiceWorkerType service_worker_type =
BackgroundInfo::GetBackgroundServiceWorkerType(extension.get());
EXPECT_EQ(BackgroundServiceWorkerType::kModule, service_worker_type);
}
{
constexpr char kWorkerTypeInvalid[] =
R"("service_worker": "worker.js", "type": "invalid")";
LoadAndExpectError(ManifestData(get_manifest(kWorkerTypeInvalid), ""),
"Invalid value for 'background.type'.");
}
{
// An extension with no background.type key present should still be allowed.
constexpr char kWorkerTypeModule[] = R"("service_worker": "worker.js")";
scoped_refptr<Extension> extension(LoadAndExpectSuccess(
ManifestData(get_manifest(kWorkerTypeModule), "no background.type")));
ASSERT_TRUE(extension);
ASSERT_TRUE(BackgroundInfo::IsServiceWorkerBased(extension.get()));
const BackgroundServiceWorkerType service_worker_type =
BackgroundInfo::GetBackgroundServiceWorkerType(extension.get());
EXPECT_EQ(BackgroundServiceWorkerType::kClassic, service_worker_type);
}
}
} // namespace extensions
|