1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "base/files/scoped_temp_dir.h"
#include "base/strings/stringprintf.h"
#include "chrome/common/extensions/api/side_panel/side_panel_info.h"
#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
#include "content/public/test/browser_test_utils.h"
#include "extensions/common/manifest.h"
#include "extensions/common/switches.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
class SidePanelManifestTest : public ChromeManifestTest {
protected:
ManifestData GetManifestData(const std::string& side_panel,
int manifest_version = 3) {
constexpr char kManifestStub[] =
R"({
"name": "Test",
"version": "1.0",
"manifest_version": %d,
"side_panel": %s
})";
return ManifestData::FromJSON(base::StringPrintf(
kManifestStub, manifest_version, side_panel.c_str()));
}
};
// Test presence of side_panel key in manifest.json.
TEST_F(SidePanelManifestTest, All) {
// Succeed when side_panel.path is defined.
{
scoped_refptr<Extension> extension(LoadAndExpectSuccess(
GetManifestData(R"({"default_path": "panel.html"})")));
EXPECT_TRUE(SidePanelInfo::HasSidePanel(extension.get()));
}
// Error when side_panel.default_path type doesn't match.
{
std::string error =
"Error at key 'side_panel.default_path'. Type is invalid. Expected "
"string, found dictionary.";
LoadAndExpectError(GetManifestData(R"({"default_path": {}})"), error);
}
// Error when side_panel type doesn't match.
{
std::string error =
"Error at key 'side_panel'. Type is invalid. Expected dictionary, found"
" string.";
LoadAndExpectError(GetManifestData(R"("")"), error);
}
}
class SidePanelExtensionsTest : public testing::Test {
public:
void SetUp() override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); }
protected:
// Empty filepath doesn't exist test coverage.
scoped_refptr<Extension> CreateExtension(const base::Value::Dict& manifest) {
base::Value::Dict manifest_base;
manifest_base.Set("name", "test");
manifest_base.Set("version", "1.0");
manifest_base.Set("manifest_version", 3);
manifest_base.Merge(manifest.Clone());
std::string error;
return Extension::Create(temp_dir_.GetPath(),
mojom::ManifestLocation::kUnpacked, manifest_base,
Extension::NO_FLAGS, "", &error);
}
private:
base::ScopedTempDir temp_dir_;
};
// Error loading extension when filepath doesn't exist.
TEST_F(SidePanelExtensionsTest, ValidateFileDoesntExist) {
static constexpr struct {
const char* relative_path;
} test_cases[] = {
{""},
{"error"},
{"?"},
};
for (const auto& test_case : test_cases) {
std::string error;
std::vector<InstallWarning> warnings;
base::Value::Dict manifest;
base::Value::Dict side_panel;
side_panel.Set("default_path", test_case.relative_path);
manifest.Set("side_panel", base::Value(std::move(side_panel)));
auto extension = CreateExtension(manifest);
ManifestHandler::ValidateExtension(extension.get(), &error, &warnings);
ASSERT_EQ("Side panel file path must exist.", error);
}
}
} // namespace extensions
|
