1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/autofill/content/renderer/page_passwords_analyser.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "components/autofill/content/renderer/page_form_analyser_logger.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/web/web_document.h"
#include "third_party/blink/public/web/web_element_collection.h"
#include "third_party/blink/public/web/web_form_element.h"
namespace autofill {
namespace {
class MockPageFormAnalyserLogger : public PageFormAnalyserLogger {
public:
MockPageFormAnalyserLogger() : PageFormAnalyserLogger(nullptr) {}
virtual ~MockPageFormAnalyserLogger() = default;
void Send(std::string message,
ConsoleLevel level,
blink::WebNode node) override {
Send(std::move(message), level,
std::vector<blink::WebNode>{std::move(node)});
}
MOCK_METHOD3(Send,
void(std::string message,
ConsoleLevel level,
std::vector<blink::WebNode> nodes));
MOCK_METHOD0(Flush, void());
};
const char kExpectedDocumentationLink[] = " (More info: https://goo.gl/9p2vKq)";
const char kPasswordFieldNotInForm[] =
"<input type='password' autocomplete='new-password'>";
const char kPasswordFormWithoutUsernameField[] =
"<form>"
" <input type='password' autocomplete='new-password'>"
"</form>";
const char kElementsWithDuplicateIds[] =
"<input id='duplicate'>"
"<input id='duplicate'>";
const char kPasswordFormTooComplex[] =
"<form>"
" <input type='text' autocomplete='username'>"
" <input type='password' autocomplete='current-password'>"
" <input type='text' autocomplete='username'>"
" <input type='password' autocomplete='current-password'>"
" <input type='password' autocomplete='new-password'>"
" <input type='password' autocomplete='new-password'>"
"</form>";
const char kInferredPasswordAutocompleteAttributes[] =
// Login form.
"<form>"
" <input type='text'>"
" <input type='password'>"
"</form>"
// Registration form.
"<form>"
" <input type='text'>"
" <input type='password'>"
" <input type='password'>"
"</form>"
// Change password form.
"<form>"
" <input type='text'>"
" <input type='password'>"
" <input type='password'>"
" <input type='password'>"
"</form>";
const char kInferredUsernameAutocompleteAttributes[] =
// Login form.
"<form>"
" <input type='text'>"
" <input type='password' autocomplete='current-password'>"
"</form>"
// Registration form.
"<form>"
" <input type='text'>"
" <input type='password' autocomplete='new-password'>"
" <input type='password' autocomplete='new-password'>"
"</form>"
// Change password form with username.
"<form>"
" <input type='text'>"
" <input type='password' autocomplete='current-password'>"
" <input type='password' autocomplete='new-password'>"
" <input type='password' autocomplete='new-password'>"
"</form>";
const char kPasswordFieldsWithAndWithoutAutocomplete[] =
"<form>"
" <input type='password'>"
" <input type='text'>"
" <input type='password' autocomplete='current-password'>"
"</form>";
const std::string AutocompleteSuggestionString(const std::string& suggestion) {
return "Input elements should have autocomplete "
"attributes (suggested: \"" +
suggestion + "\"):";
}
class PagePasswordsAnalyserTest : public ChromeRenderViewTest {
public:
PagePasswordsAnalyserTest(const PagePasswordsAnalyserTest&) = delete;
PagePasswordsAnalyserTest& operator=(const PagePasswordsAnalyserTest&) =
delete;
protected:
PagePasswordsAnalyserTest()
: mock_logger_(new MockPageFormAnalyserLogger()) {}
void TearDown() override {
elements_.clear();
mock_logger_.reset();
page_passwords_analyser.Reset();
ChromeRenderViewTest::TearDown();
}
void LoadTestCase(const char* html) {
elements_.clear();
LoadHTML(html);
blink::WebLocalFrame* frame = GetMainFrame();
blink::WebElementCollection collection = frame->GetDocument().All();
for (blink::WebElement element = collection.FirstItem(); element;
element = collection.NextItem()) {
elements_.push_back(element);
}
// Remove the <html>, <head> and <body> elements.
elements_.erase(elements_.begin(), elements_.begin() + 3);
}
void Expect(const std::string& message,
const ConsoleLevel level,
const std::vector<size_t>& element_indices) {
std::vector<blink::WebNode> nodes;
std::string documented = message + kExpectedDocumentationLink;
for (size_t index : element_indices)
nodes.push_back(elements_[index]);
EXPECT_CALL(*mock_logger_, Send(documented, level, nodes))
.RetiresOnSaturation();
}
void RunTestCase() {
EXPECT_CALL(*mock_logger_, Flush());
page_passwords_analyser.AnalyseDocumentDOM(GetMainFrame(),
mock_logger_.get());
}
PagePasswordsAnalyser page_passwords_analyser;
private:
std::vector<blink::WebElement> elements_;
std::unique_ptr<MockPageFormAnalyserLogger> mock_logger_;
};
TEST_F(PagePasswordsAnalyserTest, PasswordFieldNotInForm) {
LoadTestCase(kPasswordFieldNotInForm);
Expect("Password field is not contained in a form:",
PageFormAnalyserLogger::kVerbose, {0});
RunTestCase();
}
TEST_F(PagePasswordsAnalyserTest, PasswordFormWithoutUsernameField) {
LoadTestCase(kPasswordFormWithoutUsernameField);
Expect(
"Password forms should have (optionally hidden) "
"username fields for accessibility:",
PageFormAnalyserLogger::kVerbose, {0});
RunTestCase();
}
TEST_F(PagePasswordsAnalyserTest, ElementsWithDuplicateIds) {
LoadTestCase(kElementsWithDuplicateIds);
Expect("Found 2 elements with non-unique id #duplicate:",
PageFormAnalyserLogger::kWarning, {0, 1});
RunTestCase();
}
TEST_F(PagePasswordsAnalyserTest, PasswordFormTooComplex) {
LoadTestCase(kPasswordFormTooComplex);
Expect(
"Multiple forms should be contained in their own "
"form elements; break up complex forms into ones that represent a "
"single action:",
PageFormAnalyserLogger::kVerbose, {0});
RunTestCase();
}
TEST_F(PagePasswordsAnalyserTest, InferredPasswordAutocompleteAttributes) {
LoadTestCase(kInferredPasswordAutocompleteAttributes);
size_t element_index = 0;
// Login form.
element_index++; // Skip form element.
element_index++; // Skip username field.
Expect(AutocompleteSuggestionString("current-password"),
PageFormAnalyserLogger::kVerbose, {element_index++});
// Registration form.
element_index++; // Skip form element.
element_index++; // Skip username field.
Expect(AutocompleteSuggestionString("new-password"),
PageFormAnalyserLogger::kVerbose, {element_index++});
Expect(AutocompleteSuggestionString("new-password"),
PageFormAnalyserLogger::kVerbose, {element_index++});
// Change password form.
element_index++; // Skip form element.
element_index++; // Skip username field.
Expect(AutocompleteSuggestionString("current-password"),
PageFormAnalyserLogger::kVerbose, {element_index++});
Expect(AutocompleteSuggestionString("new-password"),
PageFormAnalyserLogger::kVerbose, {element_index++});
Expect(AutocompleteSuggestionString("new-password"),
PageFormAnalyserLogger::kVerbose, {element_index++});
RunTestCase();
}
TEST_F(PagePasswordsAnalyserTest, InferredUsernameAutocompleteAttributes) {
LoadTestCase(kInferredUsernameAutocompleteAttributes);
size_t element_index = 0;
// Login form.
element_index++; // Skip form element.
Expect(AutocompleteSuggestionString("username"),
PageFormAnalyserLogger::kVerbose, {element_index++});
element_index++; // Skip already annotated password field.
// Registration form.
element_index++; // Skip form element.
Expect(AutocompleteSuggestionString("username"),
PageFormAnalyserLogger::kVerbose, {element_index++});
element_index++; // Skip already annotated password field.
element_index++; // Skip already annotated password field.
// Change password form with username.
element_index++; // Skip form element.
Expect(AutocompleteSuggestionString("username"),
PageFormAnalyserLogger::kVerbose, {element_index++});
element_index++; // Skip already annotated password field.
element_index++; // Skip already annotated password field.
element_index++; // Skip already annotated password field.
RunTestCase();
}
TEST_F(PagePasswordsAnalyserTest, PasswordFieldWithAndWithoutAutocomplete) {
LoadTestCase(kPasswordFieldsWithAndWithoutAutocomplete);
Expect(
"Multiple forms should be contained in their own "
"form elements; break up complex forms into ones that represent a "
"single action:",
PageFormAnalyserLogger::kVerbose, {0});
RunTestCase();
}
} // namespace
} // namespace autofill
|