1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/safe_browsing/content/renderer/phishing_classifier/phishing_dom_feature_extractor.h"
#include <memory>
#include <string_view>
#include <unordered_map>
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/memory/weak_ptr.h"
#include "base/strings/escape.h"
#include "base/time/time.h"
#include "chrome/renderer/chrome_content_renderer_client.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "components/safe_browsing/content/renderer/phishing_classifier/features.h"
#include "components/safe_browsing/content/renderer/phishing_classifier/test_utils.h"
#include "content/public/common/content_switches.h"
#include "content/public/renderer/render_frame.h"
#include "content/public/test/test_utils.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/blink/public/platform/url_conversion.h"
#include "third_party/blink/public/platform/web_runtime_features.h"
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/web/web_frame.h"
#include "third_party/blink/public/web/web_local_frame.h"
#include "third_party/blink/public/web/web_script_source.h"
#include "ui/native_theme/native_theme_utils.h"
using blink::WebRuntimeFeatures;
using ::testing::DoAll;
using ::testing::Invoke;
using ::testing::Return;
using ::testing::StrictMock;
namespace safe_browsing {
class MockTickClock : public base::TickClock {
public:
MockTickClock() = default;
~MockTickClock() override = default;
MOCK_CONST_METHOD0(NowTicks, base::TimeTicks());
};
// TestPhishingDOMFeatureExtractor has nearly identical behavior as
// PhishingDOMFeatureExtractor, except the IsExternalDomain() and
// CompleteURL() functions. This is to work around the fact that
// ChromeRenderViewTest object does not know where the html content is hosted.
class TestPhishingDOMFeatureExtractor : public PhishingDOMFeatureExtractor {
public:
void SetDocumentDomain(std::string domain) { base_domain_ = domain; }
void SetURLToFrameDomainCheckingMap(
const std::unordered_map<std::string, std::string>& checking_map) {
url_to_frame_domain_map_ = checking_map;
}
void Reset() {
base_domain_.clear();
url_to_frame_domain_map_.clear();
}
private:
// LoadHTML() function in RenderViewTest only loads html as data,
// thus cur_frame_data_->domain is empty. Therefore, in base class
// PhishingDOMFeatureExtractor::IsExternalDomain() will always return false.
// Overriding IsExternalDomain(..) to work around this problem.
bool IsExternalDomain(const GURL& url, std::string* domain) const override {
DCHECK(domain);
*domain = net::registry_controlled_domains::GetDomainAndRegistry(
url, net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);
if (domain->empty())
*domain = url.spec();
// If this html only has one frame, use base_domain_ to determine if url
// is external.
if (!base_domain_.empty()) {
return !url.DomainIs(base_domain_);
} else {
// html contains multiple frames, need to check against
// its corresponding frame's domain.
auto it = url_to_frame_domain_map_.find(url.spec());
if (it != url_to_frame_domain_map_.end()) {
const std::string document_domain = it->second;
return !url.DomainIs(document_domain);
}
NOTREACHED() << "Testing input setup is incorrect. Please check "
"url_to_frame_domain_map_ setup.";
}
}
// For similar reason as above, PhishingDOMFeatureExtractor::CompeteURL(..)
// always returns empty WebURL. Overriding this CompeteURL(..) to work around
// this issue.
blink::WebURL CompleteURL(const blink::WebElement& element,
const blink::WebString& partial_url) override {
GURL parsed_url = blink::WebStringToGURL(partial_url);
GURL full_url;
if (parsed_url.has_scheme()) {
// This is already a complete URL.
full_url = parsed_url;
} else if (!base_domain_.empty()) {
// This is a partial URL and only one frame in testing html.
full_url = GURL("http://" + base_domain_).Resolve(partial_url.Utf8());
} else {
auto it = url_to_frame_domain_map_.find(partial_url.Utf8());
if (it != url_to_frame_domain_map_.end()) {
const std::string frame_domain = it->second;
full_url = GURL("http://" + it->second).Resolve(partial_url.Utf8());
url_to_frame_domain_map_[full_url.spec()] = it->second;
}
}
return blink::WebURL(full_url);
}
// If there is only main frame, we use base_domain_ to track where
// the html content is hosted.
std::string base_domain_;
// If html contains multiple frame/iframe, we track domain of each frame by
// using this map, where keys are the urls mentioned in the html content,
// values are the domains of the corresponding frames.
std::unordered_map<std::string, std::string> url_to_frame_domain_map_;
};
class TestChromeContentRendererClient : public ChromeContentRendererClient {
public:
TestChromeContentRendererClient() = default;
~TestChromeContentRendererClient() override = default;
// Since visited_link_reader_ in ChromeContentRenderClient never get
// initiated, overrides visited link functions to prevent crashing.
uint64_t VisitedLinkHash(std::string_view canonical_url) override {
return 0;
}
uint64_t PartitionedVisitedLinkFingerprint(
std::string_view canonical_link_url,
const net::SchemefulSite& top_level_site,
const url::Origin& frame_origin) override {
return 0;
}
bool IsLinkVisited(uint64_t link_hash) override { return false; }
void AddOrUpdateVisitedLinkSalt(const url::Origin& origin,
uint64_t salt) override {
return;
}
};
class PhishingDOMFeatureExtractorTest : public ChromeRenderViewTest {
public:
PhishingDOMFeatureExtractorTest()
: success_(false), run_loop_(std::make_unique<base::RunLoop>()) {}
bool GetSuccess() { return success_; }
void ResetTest() {
success_ = false;
run_loop_ = std::make_unique<base::RunLoop>();
extractor_->Reset();
}
void ExtractFeaturesAcrossFrames(
const std::string& html_content,
FeatureMap* features,
const std::unordered_map<std::string, std::string>&
url_frame_domain_map) {
extractor_->SetURLToFrameDomainCheckingMap(url_frame_domain_map);
LoadHTML(html_content.c_str());
extractor_->ExtractFeatures(
GetMainFrame()->GetDocument(), features,
base::BindOnce(&PhishingDOMFeatureExtractorTest::AnotherExtractionDone,
weak_factory_.GetWeakPtr()));
run_loop_->Run();
}
void ExtractFeatures(const std::string& document_domain,
const std::string& html_content,
FeatureMap* features) {
extractor_->SetDocumentDomain(document_domain);
LoadHTML(html_content.c_str());
extractor_->ExtractFeatures(
GetMainFrame()->GetDocument(), features,
base::BindOnce(&PhishingDOMFeatureExtractorTest::AnotherExtractionDone,
weak_factory_.GetWeakPtr()));
run_loop_->Run();
}
// Helper for the SubframeRemoval test that posts a message to remove
// the iframe "frame1" from the document.
void ScheduleRemoveIframe() {
GetMainFrame()
->GetTaskRunner(blink::TaskType::kInternalTest)
->PostTask(
FROM_HERE,
base::BindOnce(&PhishingDOMFeatureExtractorTest::RemoveIframe,
weak_factory_.GetWeakPtr()));
}
protected:
void SetUp() override {
ChromeRenderViewTest::SetUp();
WebRuntimeFeatures::EnableOverlayScrollbars(
ui::IsOverlayScrollbarEnabled());
extractor_ = std::make_unique<TestPhishingDOMFeatureExtractor>();
}
void TearDown() override {
extractor_.reset(nullptr);
ChromeRenderViewTest::TearDown();
}
content::ContentRendererClient* CreateContentRendererClient() override {
ChromeContentRendererClient* client = new TestChromeContentRendererClient();
InitChromeContentRendererClient(client);
return client;
}
void AnotherExtractionDone(bool success) {
success_ = success;
run_loop_->QuitClosure().Run();
}
// Does the actual work of removing the iframe "frame1" from the document.
void RemoveIframe() {
blink::WebLocalFrame* main_frame = GetMainFrame();
ASSERT_TRUE(main_frame);
main_frame->ExecuteScript(blink::WebScriptSource(blink::WebString(
"document.body.removeChild(document.getElementById('frame1'));")));
}
bool success_;
std::unique_ptr<TestPhishingDOMFeatureExtractor> extractor_;
std::unique_ptr<base::RunLoop> run_loop_;
base::WeakPtrFactory<PhishingDOMFeatureExtractorTest> weak_factory_{this};
};
TEST_F(PhishingDOMFeatureExtractorTest, FormFeatures) {
FeatureMap expected_features;
expected_features.AddBooleanFeature(features::kPageHasForms);
expected_features.AddRealFeature(features::kPageActionOtherDomainFreq, 0.25);
expected_features.AddBooleanFeature(features::kPageHasTextInputs);
expected_features.AddBooleanFeature(features::kPageHasCheckInputs);
expected_features.AddBooleanFeature(features::kPageActionURL +
std::string("http://cgi.host.com/submit"));
expected_features.AddBooleanFeature(features::kPageActionURL +
std::string("http://other.com/"));
GURL url("http://host.com/query");
expected_features.AddBooleanFeature(features::kPageActionURL + url.spec());
FeatureMap features;
EXPECT_FALSE(GetSuccess());
ExtractFeatures(
"host.com",
"<html><head><body>"
"<form action=\"query\"><input type=text><input type=checkbox></form>"
"<form action=\"http://cgi.host.com/submit\"></form>"
"<form action=\"http://other.com/\"></form>"
"<form action=\"query\"></form>"
"<form></form></body></html>",
&features);
EXPECT_TRUE(GetSuccess());
ExpectFeatureMapsAreEqual(features, expected_features);
expected_features.Clear();
expected_features.AddBooleanFeature(features::kPageHasRadioInputs);
expected_features.AddBooleanFeature(features::kPageHasPswdInputs);
features.Clear();
ResetTest();
EXPECT_FALSE(GetSuccess());
ExtractFeatures("host.com",
"<html><head><body>"
"<input type=\"radio\"><input type=password></body></html>",
&features);
EXPECT_TRUE(GetSuccess());
ExpectFeatureMapsAreEqual(features, expected_features);
expected_features.Clear();
expected_features.AddBooleanFeature(features::kPageHasTextInputs);
features.Clear();
ResetTest();
EXPECT_FALSE(GetSuccess());
ExtractFeatures("host.com", "<html><head><body><input></body></html>",
&features);
EXPECT_TRUE(GetSuccess());
ExpectFeatureMapsAreEqual(features, expected_features);
expected_features.Clear();
expected_features.AddBooleanFeature(features::kPageHasTextInputs);
features.Clear();
ResetTest();
EXPECT_FALSE(GetSuccess());
ExtractFeatures("host.com",
"<html><head><body><input type=\"invalid\"></body></html>",
&features);
EXPECT_TRUE(GetSuccess());
ExpectFeatureMapsAreEqual(features, expected_features);
}
TEST_F(PhishingDOMFeatureExtractorTest, LinkFeatures) {
FeatureMap expected_features;
expected_features.AddRealFeature(features::kPageExternalLinksFreq, 0.5);
expected_features.AddRealFeature(features::kPageSecureLinksFreq, 0.0);
expected_features.AddBooleanFeature(features::kPageLinkDomain +
std::string("chromium.org"));
FeatureMap features;
ExtractFeatures("host.com",
"<html><head><body>"
"<a href=\"http://www2.host.com/abc\">link</a>"
"<a name=page_anchor></a>"
"<a href=\"http://www.chromium.org/\">chromium</a>"
"</body></html>",
&features);
ExpectFeatureMapsAreEqual(features, expected_features);
expected_features.Clear();
expected_features.AddRealFeature(features::kPageExternalLinksFreq, 0.25);
expected_features.AddRealFeature(features::kPageSecureLinksFreq, 0.25);
expected_features.AddBooleanFeature(features::kPageLinkDomain +
std::string("chromium.org"));
features.Clear();
ResetTest();
ExtractFeatures("host.com",
"<html><head><body>"
"<a href=\"login\">this is not secure</a>"
"<a href=\"http://host.com\">not secure</a>"
"<a href=\"http://chromium.org/\">also not secure</a>"
"<a href=\"https://www2.host.com/login\"> this secure</a>"
"</body></html>",
&features);
ExpectFeatureMapsAreEqual(features, expected_features);
}
TEST_F(PhishingDOMFeatureExtractorTest, ScriptAndImageFeatures) {
FeatureMap expected_features;
expected_features.AddBooleanFeature(features::kPageNumScriptTagsGTOne);
FeatureMap features;
ExtractFeatures(
"host.com",
"<html><head><script></script><script></script></head></html>",
&features);
ExpectFeatureMapsAreEqual(features, expected_features);
expected_features.Clear();
expected_features.AddBooleanFeature(features::kPageNumScriptTagsGTOne);
expected_features.AddBooleanFeature(features::kPageNumScriptTagsGTSix);
expected_features.AddRealFeature(features::kPageImgOtherDomainFreq, 0.5);
features.Clear();
ResetTest();
std::string html(
"<html><head><script></script><script></script><script></script>"
"<script></script><script></script><script></script><script></script>"
"</head><body>"
"<img src=\"file:///C:/other.png\">"
"<img src=\"img/header.png\">"
"</body></html>");
ExtractFeatures("host.com", html, &features);
ExpectFeatureMapsAreEqual(features, expected_features);
}
// A page with nested iframes.
// html
// iframe2 / \ iframe1
// \ iframe3
TEST_F(PhishingDOMFeatureExtractorTest, SubFrames) {
const char urlprefix[] = "data:text/html;charset=utf-8,";
std::unordered_map<std::string, std::string> url_iframe_map;
std::string iframe1_nested_html(
"<html><body><input type=password>"
"<a href=\"https://host3.com/submit\">link</a>"
"<a href=\"relative\">link</a>"
"</body></html>");
GURL iframe1_nested_url(urlprefix + iframe1_nested_html);
// iframe1_nested is on host1.com.
url_iframe_map["https://host3.com/submit"] = "host1.com";
url_iframe_map["relative"] = "host1.com";
std::string iframe1_html(
"<html><head><script></script><body>"
"<form action=\"http://host3.com/home\"><input type=checkbox></form>"
"<form action=\"http://host1.com/submit\"></form>"
"<a href=\"http://www.host1.com/reset\">link</a>"
"<iframe src=\"" +
base::EscapeForHTML(iframe1_nested_url.spec()) +
"\"></iframe></head></html>");
GURL iframe1_url(urlprefix + iframe1_html);
// iframe1 is on host1.com too.
url_iframe_map["http://host3.com/home"] = "host1.com";
url_iframe_map["http://host1.com/submit"] = "host1.com";
url_iframe_map["http://www.host1.com/reset"] = "host1.com";
std::string iframe2_html(
"<html><head><script></script><body>"
"<img src=\"file:///C:/other.html\">"
"</body></html>");
GURL iframe2_url(urlprefix + iframe2_html);
// iframe2 is on host2.com
url_iframe_map["file:///C:/other.html"] = "host2.com";
std::string html(
"<html><body><input type=text>"
"<a href=\"info.html\">link</a>"
"<iframe src=\"" +
base::EscapeForHTML(iframe1_url.spec()) + "\"></iframe><iframe src=\"" +
base::EscapeForHTML(iframe2_url.spec()) + "\"></iframe></body></html>");
// The entire html is hosted on host.com
url_iframe_map["info.html"] = "host.com";
FeatureMap expected_features;
expected_features.AddBooleanFeature(features::kPageHasForms);
// Form action domains are compared to the URL of the document they're in,
// not the URL of the toplevel page. So http://host1.com/ has two form
// actions, one of which is external.
expected_features.AddRealFeature(features::kPageActionOtherDomainFreq, 0.5);
expected_features.AddBooleanFeature(features::kPageHasTextInputs);
expected_features.AddBooleanFeature(features::kPageHasPswdInputs);
expected_features.AddBooleanFeature(features::kPageHasCheckInputs);
expected_features.AddRealFeature(features::kPageExternalLinksFreq, 0.25);
expected_features.AddBooleanFeature(features::kPageLinkDomain +
std::string("host3.com"));
expected_features.AddRealFeature(features::kPageSecureLinksFreq, 0.25);
expected_features.AddBooleanFeature(features::kPageNumScriptTagsGTOne);
expected_features.AddRealFeature(features::kPageImgOtherDomainFreq, 1.0);
expected_features.AddBooleanFeature(features::kPageActionURL +
std::string("http://host1.com/submit"));
expected_features.AddBooleanFeature(features::kPageActionURL +
std::string("http://host3.com/home"));
FeatureMap features;
ExtractFeaturesAcrossFrames(html, &features, url_iframe_map);
ExpectFeatureMapsAreEqual(features, expected_features);
}
TEST_F(PhishingDOMFeatureExtractorTest, Continuation) {
StrictMock<MockTickClock> tick_clock;
// This page has a total of 50 elements. For the external forms feature to
// be computed correctly, the extractor has to examine the whole document.
// Note: the empty HEAD is important -- WebKit will synthesize a HEAD if
// there isn't one present, which can be confusing for the element counts.
std::string html =
"<html><head></head><body>"
"<form action=\"ondomain\"></form>";
for (int i = 0; i < 45; ++i) {
html.append("<p>");
}
html.append("<form action=\"http://host2.com/\"></form></body></html>");
// Advance the clock 6 ms every 10 elements processed, 10 ms between chunks.
// Note that this assumes kClockCheckGranularity = 10 and
// kMaxTimePerChunkMs = 10.
base::TimeTicks now = base::TimeTicks::Now();
EXPECT_CALL(tick_clock, NowTicks())
// Time check at the start of extraction.
.WillOnce(Return(now))
// Time check at the start of the first chunk of work.
.WillOnce(Return(now))
// Time check after the first 10 elements.
.WillOnce(Return(now + base::Milliseconds(6)))
// Time check after the next 10 elements. This is over the chunk
// time limit, so a continuation task will be posted.
.WillOnce(Return(now + base::Milliseconds(12)))
// Time check at the start of the second chunk of work.
.WillOnce(Return(now + base::Milliseconds(22)))
// Time check after the next 10 elements.
.WillOnce(Return(now + base::Milliseconds(30)))
// Time check after the next 10 elements. This will trigger another
// continuation task.
.WillOnce(Return(now + base::Milliseconds(36)))
// Time check at the start of the third chunk of work.
.WillOnce(Return(now + base::Milliseconds(46)))
// Time check after the last 10 elements.
.WillOnce(Return(now + base::Milliseconds(54)));
extractor_->SetTickClockForTesting(&tick_clock);
FeatureMap expected_features;
expected_features.AddBooleanFeature(features::kPageHasForms);
expected_features.AddRealFeature(features::kPageActionOtherDomainFreq, 0.5);
expected_features.AddBooleanFeature(features::kPageActionURL +
std::string("http://host.com/ondomain"));
expected_features.AddBooleanFeature(features::kPageActionURL +
std::string("http://host2.com/"));
FeatureMap features;
ExtractFeatures("host.com", html, &features);
ExpectFeatureMapsAreEqual(features, expected_features);
// Make sure none of the mock expectations carry over to the next test.
::testing::Mock::VerifyAndClearExpectations(&tick_clock);
// Now repeat the test with the same page, but advance the clock faster so
// that the extraction time exceeds the maximum total time for the feature
// extractor. Extraction should fail. Note that this assumes
// kMaxTotalTimeMs = 500.
EXPECT_CALL(tick_clock, NowTicks())
// Time check at the start of extraction.
.WillOnce(Return(now))
// Time check at the start of the first chunk of work.
.WillOnce(Return(now))
// Time check after the first 10 elements.
.WillOnce(Return(now + base::Milliseconds(300)))
// Time check at the start of the second chunk of work.
.WillOnce(Return(now + base::Milliseconds(350)))
// Time check after the next 10 elements. This is over the limit.
.WillOnce(Return(now + base::Milliseconds(600)));
features.Clear();
ResetTest();
ExtractFeatures("host.com", html, &features);
EXPECT_FALSE(GetSuccess());
}
TEST_F(PhishingDOMFeatureExtractorTest, SubframeRemoval) {
// In this test, we'll advance the feature extractor so that it is positioned
// inside an iframe, and have it pause due to exceeding the chunk time limit.
// Then, prior to continuation, the iframe is removed from the document.
// As currently implemented, this should finish extraction from the removed
// iframe document.
const char urlprefix[] = "data:text/html;charset=utf-8,";
std::string iframe1_html(
"<html><body><p><p><p><input type=password></body></html>");
GURL iframe1_url(urlprefix + iframe1_html);
base::TimeTicks now = base::TimeTicks::Now();
StrictMock<MockTickClock> tick_clock;
EXPECT_CALL(tick_clock, NowTicks())
// Time check at the start of extraction.
.WillOnce(Return(now))
// Time check at the start of the first chunk of work.
.WillOnce(Return(now))
// Time check after the first 10 elements. Enough time has passed
// to stop extraction. Schedule the iframe removal to happen as soon as
// the feature extractor returns control to the run loop.
.WillOnce(DoAll(
Invoke(this, &PhishingDOMFeatureExtractorTest::ScheduleRemoveIframe),
Return(now + base::Milliseconds(21))))
// Time check at the start of the second chunk of work.
.WillOnce(Return(now + base::Milliseconds(25)));
extractor_->SetTickClockForTesting(&tick_clock);
FeatureMap expected_features;
expected_features.AddBooleanFeature(features::kPageHasForms);
expected_features.AddBooleanFeature(features::kPageHasPswdInputs);
FeatureMap features;
std::string html(
"<html><head></head><body>"
"<iframe src=\"" +
base::EscapeForHTML(iframe1_url.spec()) +
"\" id=\"frame1\"></iframe>"
"<form></form></body></html>");
ExtractFeatures("host.com", html, &features);
ExpectFeatureMapsAreEqual(features, expected_features);
}
} // namespace safe_browsing
|