1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
|
// Copyright 2011 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/safe_browsing/content/renderer/threat_dom_details.h"
#include <memory>
#include "base/strings/escape.h"
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "components/safe_browsing/content/common/safe_browsing.mojom.h"
#include "components/safe_browsing/core/common/features.h"
#include "components/variations/variations_associated_data.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/blink/public/platform/web_runtime_features.h"
#include "ui/native_theme/native_theme_utils.h"
namespace {
std::unique_ptr<base::test::ScopedFeatureList> SetupTagAndAttributeFeature() {
std::map<std::string, std::string> feature_params;
feature_params[std::string(safe_browsing::kTagAndAttributeParamName)] =
"div,foo,div,baz,div,attr2,div,attr3,div,longattr4,div,attr5,div,attr6";
std::unique_ptr<base::test::ScopedFeatureList> scoped_list(
new base::test::ScopedFeatureList);
scoped_list->InitWithFeaturesAndParameters(
{{safe_browsing::kThreatDomDetailsTagAndAttributeFeature,
feature_params}},
{});
return scoped_list;
}
} // namespace
using ThreatDOMDetailsTest = ChromeRenderViewTest;
using testing::ElementsAre;
TEST_F(ThreatDOMDetailsTest, Everything) {
blink::WebRuntimeFeatures::EnableOverlayScrollbars(
ui::IsOverlayScrollbarEnabled());
// Configure a field trial to collect divs with attribute foo.
std::unique_ptr<base::test::ScopedFeatureList> feature_list =
SetupTagAndAttributeFeature();
std::unique_ptr<safe_browsing::ThreatDOMDetails> details(
safe_browsing::ThreatDOMDetails::Create(GetMainRenderFrame(),
registry_.get()));
// Lower kMaxNodes and kMaxAttributes for the test. Loading 500 subframes in a
// debug build takes a while.
safe_browsing::ThreatDOMDetails::kMaxNodes = 50;
safe_browsing::ThreatDOMDetails::kMaxAttributes = 5;
const char kUrlPrefix[] = "data:text/html;charset=utf-8,";
{
// A page with an internal script
std::string html = "<html><head><script></script></head></html>";
LoadHTML(html.c_str());
base::HistogramTester histograms;
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
ASSERT_EQ(1u, params.size());
auto* param = params[0].get();
EXPECT_EQ(GURL(kUrlPrefix + base::EscapeQueryParamValue(html, false)),
param->url);
EXPECT_EQ(0, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
}
{
// A page with 2 external scripts.
// Note: This part of the test causes 2 leaks: LEAK: 5 WebCoreNode
// LEAK: 2 CachedResource.
GURL script1_url("data:text/javascript;charset=utf-8,var a=1;");
GURL script2_url("data:text/javascript;charset=utf-8,var b=2;");
std::string html = "<html><head><script src=\"" + script1_url.spec() +
"\"></script><script src=\"" + script2_url.spec() +
"\"></script></head></html>";
GURL url(kUrlPrefix + base::EscapeQueryParamValue(html, false));
LoadHTML(html.c_str());
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
ASSERT_EQ(3u, params.size());
auto* param = params[0].get();
EXPECT_EQ(script1_url, param->url);
EXPECT_EQ("SCRIPT", param->tag_name);
EXPECT_EQ(1, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
param = params[1].get();
EXPECT_EQ(script2_url, param->url);
EXPECT_EQ("SCRIPT", param->tag_name);
EXPECT_EQ(2, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
param = params[2].get();
EXPECT_EQ(url, param->url);
EXPECT_EQ(0, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
}
{
// A page with some divs containing an iframe which itself contains an
// iframe. Tag "img foo" exists to ensure we honour both the tag name and
// the attribute name when deciding which elements to collect.
// html
// \ div foo
// \ img foo, div bar
// \ div baz, iframe1
// \ iframe2
// Since ThreatDOMDetails is a RenderFrameObserver, it will only
// extract resources from the frame it assigned to (in this case,
// the main frame). Extracting resources from all frames within a
// page is covered in SafeBrowsingBlockingPageBrowserTest.
// In this example, ExtractResources() will still touch iframe1
// since it is the direct child of the main frame, but it would not
// go inside of iframe1.
// We configure the test to collect divs with attribute foo and baz, but not
// divs with attribute bar. So div foo will be collected and contain iframe1
// and div baz as children.
std::string iframe2_html = "<html><body>iframe2</body></html>";
GURL iframe2_url(kUrlPrefix + iframe2_html);
std::string iframe1_html = "<iframe src=\"" +
base::EscapeForHTML(iframe2_url.spec()) +
"\"></iframe>";
GURL iframe1_url(kUrlPrefix + iframe1_html);
std::string html =
"<html><head><div foo=1 foo2=2><img foo=1><div bar=1><div baz=1></div>"
"<iframe src=\"" +
base::EscapeForHTML(iframe1_url.spec()) +
"\"></iframe></div></div></head></html>";
GURL url(kUrlPrefix + base::EscapeQueryParamValue(html, false));
LoadHTML(html.c_str());
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
ASSERT_EQ(4u, params.size());
auto* param = params[0].get();
EXPECT_TRUE(param->url.is_empty());
EXPECT_EQ(url, param->parent);
EXPECT_EQ("DIV", param->tag_name);
// The children field contains URLs, but this mapping is not currently
// maintained among the interior nodes. The summary node is the parent of
// all elements in the frame.
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(1, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_THAT(param->child_node_ids, ElementsAre(2, 3));
EXPECT_EQ(1u, param->attributes.size());
EXPECT_EQ("foo", param->attributes[0]->name);
EXPECT_EQ("1", param->attributes[0]->value);
param = params[1].get();
EXPECT_TRUE(param->url.is_empty());
EXPECT_EQ(url, param->parent);
EXPECT_EQ("DIV", param->tag_name);
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(2, param->node_id);
EXPECT_EQ(1, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
EXPECT_EQ(1u, param->attributes.size());
EXPECT_EQ("baz", param->attributes[0]->name);
EXPECT_EQ("1", param->attributes[0]->value);
param = params[2].get();
EXPECT_EQ(iframe1_url, param->url);
EXPECT_EQ(url, param->parent);
EXPECT_EQ("IFRAME", param->tag_name);
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(3, param->node_id);
EXPECT_EQ(1, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
EXPECT_TRUE(param->attributes.empty());
param = params[3].get();
EXPECT_EQ(url, param->url);
EXPECT_EQ(GURL(), param->parent);
EXPECT_THAT(param->children, ElementsAre(iframe1_url));
EXPECT_EQ(0, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
}
{
// Test >50 subframes.
std::string html;
for (int i = 0; i < 55; ++i) {
// The iframe contents is just a number.
GURL iframe_url(base::StringPrintf("%s%d", kUrlPrefix, i));
html += "<iframe src=\"" + base::EscapeForHTML(iframe_url.spec()) +
"\"></iframe>";
}
GURL url(kUrlPrefix + html);
LoadHTML(html.c_str());
base::HistogramTester histograms;
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
ASSERT_EQ(51u, params.size());
// The element nodes should all have node IDs.
for (size_t i = 0; i < params.size() - 1; ++i) {
auto& param = *params[i];
const int expected_id = i + 1;
EXPECT_EQ(expected_id, param.node_id);
EXPECT_EQ(0, param.parent_node_id);
EXPECT_TRUE(param.child_node_ids.empty());
}
}
{
// A page with >50 scripts, to verify kMaxNodes.
std::string html;
for (int i = 0; i < 55; ++i) {
// The iframe contents is just a number.
GURL script_url(base::StringPrintf("%s%d", kUrlPrefix, i));
html += "<script src=\"" + base::EscapeForHTML(script_url.spec()) +
"\"></script>";
}
GURL url(kUrlPrefix + html);
LoadHTML(html.c_str());
base::HistogramTester histograms;
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
ASSERT_EQ(51u, params.size());
// The element nodes should all have node IDs.
for (size_t i = 0; i < params.size() - 1; ++i) {
auto& param = *params[i];
const int expected_id = i + 1;
EXPECT_EQ(expected_id, param.node_id);
EXPECT_EQ(0, param.parent_node_id);
EXPECT_TRUE(param.child_node_ids.empty());
}
}
{
// Check the limit on the number of attributes collected and their lengths.
safe_browsing::ThreatDOMDetails::kMaxAttributeStringLength = 5;
std::string html =
"<html><head><div foo=1 attr2=2 attr3=3 longattr4=4 attr5=longvalue5 "
"attr6=6></div></head></html>";
LoadHTML(html.c_str());
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
GURL url = GURL(kUrlPrefix + base::EscapeQueryParamValue(html, false));
ASSERT_EQ(2u, params.size());
auto* param = params[0].get();
EXPECT_TRUE(param->url.is_empty());
EXPECT_EQ(url, param->parent);
EXPECT_EQ("DIV", param->tag_name);
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(1, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
EXPECT_EQ(5u, param->attributes.size());
EXPECT_EQ("foo", param->attributes[0]->name);
EXPECT_EQ("1", param->attributes[0]->value);
EXPECT_EQ("attr2", param->attributes[1]->name);
EXPECT_EQ("2", param->attributes[1]->value);
EXPECT_EQ("attr3", param->attributes[2]->name);
EXPECT_EQ("3", param->attributes[2]->value);
EXPECT_EQ("longattr4", param->attributes[3]->name);
EXPECT_EQ("4", param->attributes[3]->value);
EXPECT_EQ("attr5", param->attributes[4]->name);
EXPECT_EQ("lo...", param->attributes[4]->value);
param = params[1].get();
EXPECT_EQ(url, param->url);
EXPECT_EQ(0, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
}
}
TEST_F(ThreatDOMDetailsTest, DefaultTagAndAttributesList) {
// Verify that the default tag and attribute list is initialized and used
// when the Finch feature (ThreatDomDetailsTagAttributes) is disabled.
blink::WebRuntimeFeatures::EnableOverlayScrollbars(
ui::IsOverlayScrollbarEnabled());
std::unique_ptr<base::test::ScopedFeatureList> feature_list(
new base::test::ScopedFeatureList);
feature_list->InitAndDisableFeature(
safe_browsing::kThreatDomDetailsTagAndAttributeFeature);
std::unique_ptr<safe_browsing::ThreatDOMDetails> details(
safe_browsing::ThreatDOMDetails::Create(GetMainRenderFrame(),
registry_.get()));
const char kUrlPrefix[] = "data:text/html;charset=utf-8,";
// A page with some divs containing an iframe which itself contains an
// iframe. Tag "img foo" exists to ensure we honour both the tag name and
// the attribute name when deciding which elements to collect.
// html
// \ div[data-google-query-id=foo]
// \ div[id=bar]
// \ iframe[id=baz]
// \ iframe2
// Since ThreatDOMDetails is a RenderFrameObserver, it will only
// extract resources from the frame it assigned to (in this case,
// the main frame). Extracting resources from all frames within a
// page is covered in SafeBrowsingBlockingPageBrowserTest.
// In this example, ExtractResources() will still touch iframe[baz]
// since it is the direct child of the main frame, but it would not
// go inside of the iframe.
std::string iframe2_html = "<html><body>iframe2</body></html>";
GURL iframe2_url(kUrlPrefix + iframe2_html);
std::string html =
"<html><head><div data-google-query-id=foo><div id=bar>"
"<iframe id=baz><iframe src=\"" +
base::EscapeForHTML(iframe2_url.spec()) +
"\"></iframe></iframe></div></div></head></html>";
GURL url(kUrlPrefix + base::EscapeQueryParamValue(html, false));
LoadHTML(html.c_str());
std::vector<safe_browsing::mojom::ThreatDOMDetailsNodePtr> params;
details->ExtractResources(¶ms);
ASSERT_EQ(4u, params.size());
auto* param = params[0].get();
EXPECT_TRUE(param->url.is_empty());
EXPECT_EQ(url, param->parent);
EXPECT_EQ("DIV", param->tag_name);
// The children field contains URLs, but this mapping is not currently
// maintained among the interior nodes. The summary node (last in the list) is
// the parent of all elements in the frame.
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(1, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_THAT(param->child_node_ids, ElementsAre(2));
EXPECT_EQ(1u, param->attributes.size());
EXPECT_EQ("data-google-query-id", param->attributes[0]->name);
EXPECT_EQ("foo", param->attributes[0]->value);
param = params[1].get();
EXPECT_EQ("id", param->attributes[0]->name);
EXPECT_EQ("bar", param->attributes[0]->value);
EXPECT_TRUE(param->url.is_empty());
EXPECT_EQ(url, param->parent);
EXPECT_EQ("DIV", param->tag_name);
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(2, param->node_id);
EXPECT_EQ(1, param->parent_node_id);
EXPECT_THAT(param->child_node_ids, ElementsAre(3));
EXPECT_EQ(1u, param->attributes.size());
EXPECT_EQ("id", param->attributes[0]->name);
EXPECT_EQ("bar", param->attributes[0]->value);
param = params[2].get();
EXPECT_TRUE(param->url.is_empty());
EXPECT_EQ(url, param->parent);
EXPECT_EQ("IFRAME", param->tag_name);
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(3, param->node_id);
EXPECT_EQ(2, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
EXPECT_EQ(1u, param->attributes.size());
EXPECT_EQ("id", param->attributes[0]->name);
EXPECT_EQ("baz", param->attributes[0]->value);
param = params[3].get();
EXPECT_EQ(url, param->url);
EXPECT_EQ(GURL(), param->parent);
EXPECT_TRUE(param->children.empty());
EXPECT_EQ(0, param->node_id);
EXPECT_EQ(0, param->parent_node_id);
EXPECT_TRUE(param->child_node_ids.empty());
}
TEST_F(ThreatDOMDetailsTest, CheckTagAndAttributeListIsSorted) {
std::unique_ptr<safe_browsing::ThreatDOMDetails> details(
safe_browsing::ThreatDOMDetails::Create(GetMainRenderFrame(),
registry_.get()));
std::vector<safe_browsing::TagAndAttributesItem> tag_and_attr_list =
details->GetTagAndAttributesListForTest();
bool is_sorted;
std::vector<std::string> tag_names;
EXPECT_TRUE(!tag_and_attr_list.empty());
for (auto item : tag_and_attr_list) {
tag_names.push_back(item.tag_name);
EXPECT_TRUE(!item.attributes.empty());
// Check that list of attributes is sorted.
is_sorted = std::is_sorted(item.attributes.begin(), item.attributes.end());
EXPECT_TRUE(is_sorted);
}
// Check that the tags are sorted.
is_sorted = std::is_sorted(tag_names.begin(), tag_names.end());
EXPECT_TRUE(is_sorted);
}
|
