File: sql_table_builder_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (546 lines) | stat: -rw-r--r-- 21,891 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "components/affiliations/core/browser/sql_table_builder.h"

#include <variant>
#include <vector>

#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/logging.h"
#include "base/strings/strcat.h"
#include "base/strings/stringprintf.h"
#include "base/test/mock_callback.h"
#include "sql/database.h"
#include "sql/statement.h"
#include "sql/test/test_helpers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace affiliations {
namespace {

using ::testing::Return;
using ::testing::UnorderedElementsAre;

constexpr char kChildTable[] = "child_table";
constexpr char kMyLoginTable[] = "my_logins_table";

using ColumnValue = std::variant<int, std::string>;
using TableRow = std::vector<ColumnValue>;

void CheckTableContent(sql::Database& db,
                       const char table_name[],
                       const std::vector<TableRow>& expected_rows) {
  SCOPED_TRACE(testing::Message() << "table_name = " << table_name);
  sql::Statement table_check(
      db.GetUniqueStatement(base::StrCat({"SELECT * FROM ", table_name})));
  for (const TableRow& row : expected_rows) {
    EXPECT_TRUE(table_check.Step());
    for (unsigned col = 0; col < row.size(); ++col) {
      if (const int* int_value = std::get_if<int>(&row[col])) {
        EXPECT_EQ(*int_value, table_check.ColumnInt(col)) << col;
      } else if (const std::string* string_value =
                     std::get_if<std::string>(&row[col])) {
        EXPECT_EQ(*string_value, table_check.ColumnString(col)) << col;
      } else {
        EXPECT_TRUE(false) << "Unknown type " << col;
      }
    }
  }
  EXPECT_FALSE(table_check.Step());
}

class SQLTableBuilderTest : public testing::Test {
 public:
  SQLTableBuilderTest() : builder_(kMyLoginTable), child_builder_(kChildTable) {
    Init();
  }

  ~SQLTableBuilderTest() override = default;

 protected:
  // Checks whether a column with a given |name| is listed with the given
  // |type| in the database.
  bool IsColumnOfType(const std::string& name, const std::string& type);

  // Adds a primary key to 'my_logins_table' and creates a child table
  // referencing it.
  void SetupChildTable();

  sql::Database* db() { return &db_; }

  SQLTableBuilder* builder() { return &builder_; }
  SQLTableBuilder* child_builder() { return &child_builder_; }

 private:
  // Part of constructor, needs to be a void-returning function to use ASSERTs.
  void Init();

  // Error handler for the SQL connection, prints the error code and the
  // statement details.
  void PrintDBError(int code, sql::Statement* statement);

  sql::Database db_{sql::test::kTestTag};
  SQLTableBuilder builder_;
  SQLTableBuilder child_builder_;
};

bool SQLTableBuilderTest::IsColumnOfType(const std::string& name,
                                         const std::string& type) {
  return db()->GetSchema().find(name + " " + type) != std::string::npos;
}

void SQLTableBuilderTest::SetupChildTable() {
  EXPECT_TRUE(db()->Execute("PRAGMA foreign_keys = ON"));
  builder()->AddPrimaryKeyColumn("id");
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));

  child_builder_.AddColumn("name", "TEXT");
  child_builder_.AddColumnToUniqueKey("parent_id", "INTEGER",
                                      /*parent_table=*/kMyLoginTable,
                                      "foreign_key_index");
  EXPECT_EQ(0u, child_builder_.SealVersion());
  EXPECT_TRUE(child_builder_.CreateTable(db()));
}

void SQLTableBuilderTest::Init() {
  db_.set_error_callback(base::BindRepeating(&SQLTableBuilderTest::PrintDBError,
                                             base::Unretained(this)));
  ASSERT_TRUE(db_.OpenInMemory());
  // The following column must always be present, so let's add it here.
  builder_.AddColumnToUniqueKey("signon_realm", "VARCHAR NOT NULL");
}

void SQLTableBuilderTest::PrintDBError(int code, sql::Statement* statement) {
  VLOG(0) << "DB error encountered, code = " << code;
  if (statement) {
    VLOG(0) << "statement string = " << statement->GetSQLStatement();
    VLOG(0) << "statement is " << (statement->is_valid() ? "valid" : "invalid");
  }
}

TEST_F(SQLTableBuilderTest, SealVersion_0) {
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "signon_realm"));
  EXPECT_TRUE(IsColumnOfType("signon_realm", "VARCHAR NOT NULL"));
}

TEST_F(SQLTableBuilderTest, AddColumn) {
  builder()->AddColumn("password_value", "BLOB");
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "signon_realm"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "password_value"));
  EXPECT_TRUE(IsColumnOfType("password_value", "BLOB"));
}

TEST_F(SQLTableBuilderTest, AddIndex) {
  builder()->AddIndex("my_logins_table_signon", {"signon_realm"});
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesIndexExist("my_logins_table_signon"));
}

TEST_F(SQLTableBuilderTest, AddIndexOnMultipleColumns) {
  builder()->AddColumn("column_1", "BLOB");
  builder()->AddColumn("column_2", "BLOB");
  builder()->AddIndex("my_index", {"column_1", "column_2"});
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "column_1"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "column_2"));
  EXPECT_TRUE(db()->DoesIndexExist("my_index"));
}

TEST_F(SQLTableBuilderTest, RenameColumn_InSameVersion) {
  builder()->AddColumn("old_name", "BLOB");
  builder()->RenameColumn("old_name", "password_value");
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "old_name"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "password_value"));
  EXPECT_TRUE(IsColumnOfType("password_value", "BLOB"));
}

TEST_F(SQLTableBuilderTest, RenameColumn_InNextVersion) {
  builder()->AddColumn("old_name", "BLOB");
  EXPECT_EQ(0u, builder()->SealVersion());
  builder()->RenameColumn("old_name", "password_value");
  EXPECT_EQ(1u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "old_name"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "password_value"));
  EXPECT_TRUE(IsColumnOfType("password_value", "BLOB"));
}

TEST_F(SQLTableBuilderTest, RenameColumn_SameNameInSameVersion) {
  builder()->AddColumn("name", "BLOB");
  builder()->RenameColumn("name", "name");
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "name"));
  EXPECT_TRUE(IsColumnOfType("name", "BLOB"));
}

TEST_F(SQLTableBuilderTest, RenameColumn_SameNameInNextVersion) {
  builder()->AddColumn("name", "BLOB");
  EXPECT_EQ(0u, builder()->SealVersion());
  builder()->RenameColumn("name", "name");
  EXPECT_EQ(1u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "name"));
  EXPECT_TRUE(IsColumnOfType("name", "BLOB"));
}

TEST_F(SQLTableBuilderTest, DropColumn_InSameVersion) {
  builder()->AddColumn("password_value", "BLOB");
  builder()->DropColumn("password_value");
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "password_value"));
}

TEST_F(SQLTableBuilderTest, DropColumn_InNextVersion) {
  builder()->AddColumn("password_value", "BLOB");
  EXPECT_EQ(0u, builder()->SealVersion());
  builder()->DropColumn("password_value");
  EXPECT_EQ(1u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "password_value"));
}

TEST_F(SQLTableBuilderTest, MigrateFrom) {
  // First, create a table at version 0, with some columns.
  builder()->AddColumn("for_renaming", "INTEGER DEFAULT 100");
  builder()->AddColumn("for_deletion", "INTEGER");
  builder()->AddIndex("my_signon_index", {"signon_realm"});
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));
  EXPECT_TRUE(db()->DoesTableExist(kMyLoginTable));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "for_renaming"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "for_deletion"));
  EXPECT_TRUE(db()->DoesIndexExist("my_signon_index"));
  EXPECT_TRUE(
      db()->Execute("INSERT INTO my_logins_table (signon_realm, for_renaming, "
                    "for_deletion) VALUES ('abc', 123, 456)"));
  const char retrieval[] = "SELECT * FROM my_logins_table";
  sql::Statement first_check(
      db()->GetCachedStatement(SQL_FROM_HERE, retrieval));
  EXPECT_TRUE(first_check.Step());
  EXPECT_EQ(3, first_check.ColumnCount());
  EXPECT_EQ("abc", first_check.ColumnString(0));
  EXPECT_EQ(123, first_check.ColumnInt(1));
  EXPECT_EQ(456, first_check.ColumnInt(2));
  EXPECT_FALSE(first_check.Step());
  EXPECT_TRUE(first_check.Succeeded());

  // Now, specify some modifications for version 1.
  builder()->RenameColumn("for_renaming", "renamed");
  builder()->DropColumn("for_deletion");
  builder()->AddColumn("new_column", "INTEGER DEFAULT 789");
  builder()->AddIndex("my_changing_index_v1", {"renamed", "new_column"});
  EXPECT_EQ(1u, builder()->SealVersion());

  // The migration should have the following effect:
  // * The renamed column should keep its non-default value.
  // * The succession of column removal and addition should not result in the
  //   values from the deleted column to be copied to the added one.
  // * Only the signon index and the second version of the changing index should
  //   be present in the last version.
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "for_renaming"));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "for_deletion"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "renamed"));
  EXPECT_TRUE(IsColumnOfType("renamed", "INTEGER"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "new_column"));
  EXPECT_TRUE(db()->DoesIndexExist("my_signon_index"));
  EXPECT_TRUE(db()->DoesIndexExist("my_changing_index_v1"));
  sql::Statement second_check(
      db()->GetCachedStatement(SQL_FROM_HERE, retrieval));
  EXPECT_TRUE(second_check.Step());
  EXPECT_EQ(3, second_check.ColumnCount());
  EXPECT_EQ("abc", second_check.ColumnString(0));
  EXPECT_EQ(123, second_check.ColumnInt(1));
  EXPECT_EQ(789, second_check.ColumnInt(2));
  EXPECT_FALSE(second_check.Step());
  EXPECT_TRUE(second_check.Succeeded());
}

TEST_F(SQLTableBuilderTest, MigrateFrom_RenameAndAddColumns) {
  builder()->AddPrimaryKeyColumn("id");
  builder()->AddColumn("old_name", "INTEGER");
  EXPECT_EQ(0u, builder()->SealVersion());

  EXPECT_TRUE(builder()->CreateTable(db()));

  builder()->RenameColumn("old_name", "new_name");
  EXPECT_EQ(1u, builder()->SealVersion());

  builder()->AddColumn("added", "VARCHAR");
  EXPECT_EQ(2u, builder()->SealVersion());

  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "old_name"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "id"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "added"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "new_name"));
  EXPECT_TRUE(IsColumnOfType("id", "INTEGER"));
  EXPECT_TRUE(IsColumnOfType("added", "VARCHAR"));
  EXPECT_TRUE(IsColumnOfType("new_name", "INTEGER"));
  EXPECT_EQ(4u, builder()->NumberOfColumns());
  EXPECT_EQ("signon_realm, id, new_name, added",
            builder()->ListAllColumnNames());
  EXPECT_EQ("new_name=?, added=?", builder()->ListAllNonuniqueKeyNames());
  EXPECT_EQ("signon_realm=?", builder()->ListAllUniqueKeyNames());
  EXPECT_THAT(builder()->AllPrimaryKeyNames(), UnorderedElementsAre("id"));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_RenameAndAddAndDropColumns) {
  builder()->AddPrimaryKeyColumn("pk_1");
  builder()->AddColumnToUniqueKey("uni", "VARCHAR NOT NULL");
  builder()->AddColumn("old_name", "INTEGER");
  EXPECT_EQ(0u, builder()->SealVersion());

  EXPECT_TRUE(builder()->CreateTable(db()));

  builder()->RenameColumn("old_name", "new_name");
  EXPECT_EQ(1u, builder()->SealVersion());

  builder()->AddColumn("added", "VARCHAR");
  EXPECT_EQ(2u, builder()->SealVersion());

  builder()->DropColumn("added");
  EXPECT_EQ(3u, builder()->SealVersion());

  EXPECT_TRUE(builder()->MigrateFrom(0, db()));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "old_name"));
  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "added"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "pk_1"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "uni"));
  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "new_name"));
  EXPECT_TRUE(IsColumnOfType("new_name", "INTEGER"));
  EXPECT_EQ(4u, builder()->NumberOfColumns());
  EXPECT_EQ("signon_realm, pk_1, uni, new_name",
            builder()->ListAllColumnNames());
  EXPECT_EQ("new_name=?", builder()->ListAllNonuniqueKeyNames());
  EXPECT_EQ("signon_realm=? AND uni=?", builder()->ListAllUniqueKeyNames());

  EXPECT_THAT(builder()->AllPrimaryKeyNames(), UnorderedElementsAre("pk_1"));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_AddPrimaryKey) {
  builder()->AddColumnToUniqueKey("uni", "VARCHAR NOT NULL");
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_TRUE(builder()->CreateTable(db()));

  builder()->AddPrimaryKeyColumn("pk_1");
  EXPECT_EQ(1u, builder()->SealVersion());

  EXPECT_FALSE(db()->DoesColumnExist(kMyLoginTable, "pk_1"));
  EXPECT_TRUE(db()->GetSchema().find("PRIMARY KEY (pk_1)") ==
              std::string::npos);

  EXPECT_TRUE(builder()->MigrateFrom(0, db()));

  EXPECT_TRUE(db()->DoesColumnExist(kMyLoginTable, "pk_1"));
  EXPECT_TRUE(
      db()->GetSchema().find("pk_1 INTEGER PRIMARY KEY AUTOINCREMENT") !=
      std::string::npos);
}

TEST_F(SQLTableBuilderTest, MigrateFromWithSuccessfulCallback) {
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_EQ(1u, builder()->SealVersion());

  base::MockCallback<base::RepeatingCallback<bool(sql::Database*, unsigned)>>
      migation_callback;

  EXPECT_CALL(migation_callback, Run(db(), 1u)).WillOnce(Return(true));
  EXPECT_TRUE(builder()->MigrateFrom(0, db(), migation_callback.Get()));
}

TEST_F(SQLTableBuilderTest, MigrateFromWithUnsuccessfulCallback) {
  EXPECT_EQ(0u, builder()->SealVersion());
  EXPECT_EQ(1u, builder()->SealVersion());

  base::MockCallback<base::RepeatingCallback<bool(sql::Database*, unsigned)>>
      migation_callback;

  EXPECT_CALL(migation_callback, Run(db(), 1u)).WillOnce(Return(false));
  EXPECT_FALSE(builder()->MigrateFrom(0, db(), migation_callback.Get()));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_WithForeignKey_AddColumn) {
  SetupChildTable();
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (signon_realm) VALUES ('abc.com')", kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));

  // Now, specify some modifications for version 1.
  builder()->AddColumn("new_column", "INTEGER DEFAULT 789");
  builder()->AddIndex("my_changing_index_v1", {"signon_realm", "new_column"});
  EXPECT_EQ(1u, builder()->SealVersion());

  EXPECT_TRUE(builder()->MigrateFrom(0, db()));

  CheckTableContent(*db(), kChildTable, {{"Abc Co.", 1}});
  CheckTableContent(*db(), kMyLoginTable, {{"abc.com", 1, 789}});

  // The foreign key still works.
  EXPECT_FALSE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Co.', 15)", kChildTable)));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_WithForeignKey_RenameColumn) {
  SetupChildTable();
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (signon_realm) VALUES ('abc.com')", kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));

  // Now, specify some modifications for version 1.
  builder()->RenameColumn("signon_realm", "signon_real_realm");
  EXPECT_EQ(1u, builder()->SealVersion());

  EXPECT_TRUE(builder()->MigrateFrom(0, db()));

  CheckTableContent(*db(), kChildTable, {{"Abc Co.", 1}});
  CheckTableContent(*db(), kMyLoginTable, {{"abc.com", 1}});

  // The foreign key still works.
  EXPECT_FALSE(db()->Execute(
      "INSERT INTO child_table (name, parent_id) VALUES ('Co.', 15)"));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_WithForeignKey_DropColumn) {
  SetupChildTable();
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (signon_realm) VALUES ('abc.com')", kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));

  // Now, specify some modifications for version 1.
  builder()->AddColumn("new_column", "INTEGER DEFAULT 789");
  EXPECT_EQ(1u, builder()->SealVersion());
  builder()->DropColumn("new_column");
  EXPECT_EQ(2u, builder()->SealVersion());
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));

  CheckTableContent(*db(), kChildTable, {{"Abc Co.", 1}});
  CheckTableContent(*db(), kMyLoginTable, {{"abc.com", 1}});

  // The foreign key still works.
  EXPECT_FALSE(db()->Execute(
      "INSERT INTO child_table (name, parent_id) VALUES ('Co.', 15)"));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_WithForeignKey_PreventMigration) {
  SetupChildTable();

  builder()->AddColumnToUniqueKey("new_column", "TEXT");
  EXPECT_EQ(1u, builder()->SealVersion());
  EXPECT_TRUE(builder()->MigrateFrom(0, db()));

  EXPECT_TRUE(db()->Execute(
      base::StringPrintf("INSERT INTO %s (signon_realm, new_column) "
                         "VALUES ('abc.com', 'aaa')",
                         kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(
      base::StringPrintf("INSERT INTO %s (signon_realm, new_column) "
                         "VALUES ('abc.com', 'bbb')",
                         kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Bbc Co.', 2)", kChildTable)));

  builder()->DropColumn("new_column");
  EXPECT_EQ(2u, builder()->SealVersion());
  // The migration doesn't succeed because foreign key doesn't allow referenced
  // entries to be merged.
  EXPECT_FALSE(builder()->MigrateFrom(1, db()));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_WithForeignKey_ChildTable_AddColumn) {
  SetupChildTable();
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (signon_realm) VALUES ('abc.com')", kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));

  child_builder()->AddColumn("new_column", "TEXT");
  EXPECT_EQ(1u, child_builder()->SealVersion());
  EXPECT_TRUE(child_builder()->MigrateFrom(0, db()));

  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "UPDATE %s SET new_column='value' WHERE parent_id=1", kChildTable)));

  CheckTableContent(*db(), kChildTable, {{"Abc Co.", 1, "value"}});
  CheckTableContent(*db(), kMyLoginTable, {{"abc.com", 1}});

  // The foreign key still works.
  EXPECT_FALSE(db()->Execute(
      "INSERT INTO child_table (name, parent_id) VALUES ('Co.', 15)"));
}

TEST_F(SQLTableBuilderTest,
       MigrateFrom_WithForeignKey_ChildTable_RenameColumn) {
  SetupChildTable();
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (signon_realm) VALUES ('abc.com')", kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));

  child_builder()->RenameColumn("name", "new_name");
  EXPECT_EQ(1u, child_builder()->SealVersion());
  EXPECT_TRUE(child_builder()->MigrateFrom(0, db()));

  CheckTableContent(*db(), kChildTable, {{"Abc Co.", 1}});
  CheckTableContent(*db(), kMyLoginTable, {{"abc.com", 1}});

  // The foreign key still works.
  EXPECT_FALSE(db()->Execute(
      "INSERT INTO child_table (new_name, parent_id) VALUES ('Co.', 15)"));
}

TEST_F(SQLTableBuilderTest, MigrateFrom_WithForeignKey_ChildTable_DropColumn) {
  SetupChildTable();
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (signon_realm) VALUES ('abc.com')", kMyLoginTable)));
  EXPECT_TRUE(db()->Execute(base::StringPrintf(
      "INSERT INTO %s (name, parent_id) VALUES ('Abc Co.', 1)", kChildTable)));

  child_builder()->DropColumn("name");
  EXPECT_EQ(1u, child_builder()->SealVersion());
  EXPECT_TRUE(child_builder()->MigrateFrom(0, db()));

  CheckTableContent(*db(), kChildTable, {{1}});
  CheckTableContent(*db(), kMyLoginTable, {{"abc.com", 1}});

  // The foreign key still works.
  EXPECT_FALSE(
      db()->Execute("INSERT INTO child_table (parent_id) VALUES (15)"));
}

}  // namespace
}  // namespace affiliations