1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/autofill/content/renderer/form_autofill_issues.h"
#include "base/strings/string_number_conversions.h"
#include "components/autofill/content/renderer/form_autofill_util.h"
#include "components/autofill/content/renderer/test_utils.h"
#include "components/autofill/core/common/field_data_manager.h"
#include "components/autofill/core/common/form_field_data.h"
#include "content/public/test/render_view_test.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/web/web_autofill_client.h"
#include "third_party/blink/public/web/web_form_control_element.h"
#include "third_party/blink/public/web/web_form_element.h"
#include "third_party/blink/public/web/web_local_frame.h"
using blink::WebFormControlElement;
using blink::WebFormElement;
using blink::WebLocalFrame;
using blink::WebString;
using blink::mojom::GenericIssueErrorType;
namespace autofill::form_issues {
namespace {
constexpr CallTimerState kCallTimerStateDummy = {
.call_site = CallTimerState::CallSite::kUpdateFormCache,
.last_autofill_agent_reset = {},
.last_dom_content_loaded = {},
};
// Checks if the provided list `form_issues` contains a certain issue type.
// Optionally checks whether the expected issue type has the specified
// `violating_attr`.
bool FormIssuesContainIssueType(const std::vector<FormIssue>& form_issues,
GenericIssueErrorType expected_issue,
const std::string& violating_attr = "") {
return std::ranges::any_of(form_issues, [&](const auto& form_issue) {
return form_issue.issue_type == expected_issue &&
(violating_attr.empty() ||
violating_attr == form_issue.violating_node_attribute.Utf8());
});
}
class FormAutofillIssuesTest : public content::RenderViewTest {
public:
FormAutofillIssuesTest() = default;
~FormAutofillIssuesTest() override = default;
WebFormElement GetTargetForm() {
return GetFormElementById(GetMainFrame()->GetDocument(), "target");
}
};
TEST_F(FormAutofillIssuesTest, FormLabelHasNeitherForNorNestedInput) {
LoadHTML(R"(
<form id=target>
<input>
<label> A label</label>
</form>)");
std::vector<FormIssue> form_issues = GetFormIssuesForTesting(
GetTargetForm().GetFormControlElements(), {}); // nocheck
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::kFormLabelHasNeitherForNorNestedInput));
}
TEST_F(FormAutofillIssuesTest, FormDuplicateIdForInputError) {
LoadHTML(R"(
<form id=target>
<input id=id>
<input id=id_2>
<input id=id>
<input id=id>
</form>)");
std::vector<FormIssue> form_issues = GetFormIssuesForTesting(
GetTargetForm().GetFormControlElements(), {}); // nocheck
int duplicated_ids_issue_count =
std::ranges::count_if(form_issues, [](const FormIssue& form_issue) {
return form_issue.issue_type ==
GenericIssueErrorType::kFormDuplicateIdForInputError &&
form_issue.violating_node_attribute.Utf8() == "id";
});
EXPECT_EQ(duplicated_ids_issue_count, 3);
}
TEST_F(FormAutofillIssuesTest, FormAriaLabelledByToNonExistingId) {
LoadHTML(R"(
<form id=target>
<input aria-labelledby=non_existing>
</form>)");
WebFormElement form_target = GetTargetForm();
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_target.GetFormControlElements(), {});
std::vector<FormIssue> form_issues_2 = GetFormIssuesForTesting(
form_target.GetFormControlElements(), form_issues);
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues, GenericIssueErrorType::kFormAriaLabelledByToNonExistingId,
/*violating_attr=*/"aria-labelledby"));
}
TEST_F(FormAutofillIssuesTest, FormAutocompleteAttributeEmptyError) {
LoadHTML(R"(
<form id=target>
<input autocomplete>
</form>)");
WebFormElement form_target = GetTargetForm();
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_target.GetFormControlElements(), {});
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues, GenericIssueErrorType::kFormAutocompleteAttributeEmptyError,
/*violating_attr=*/"autocomplete"));
}
TEST_F(FormAutofillIssuesTest,
FormInputHasWrongButWellIntendedAutocompleteValueError) {
LoadHTML(R"(
<form id=target>
<input autocomplete=address-line-1>
</form>)");
WebFormElement form_target = GetTargetForm();
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_target.GetFormControlElements(), {});
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::
kFormInputHasWrongButWellIntendedAutocompleteValueError,
/*violating_attr=*/"autocomplete"));
}
// Having an autocomplete attribute that is too large does not trigger issues,
// even if it contains a substring that would match a "honest" developer
// error/typo. This is done to avoid large string comparisons during form
// parsing.
TEST_F(
FormAutofillIssuesTest,
FormInputHasWrongButWellIntendedAutocompleteValueError_LargeAutocompleteString_DoNotCalculateIssue) {
std::string autocomplete(100, 'a');
autocomplete += "address-line-1";
LoadHTML(R"(
<form id=target>
<input>
</form>)");
WebFormElement form_target = GetTargetForm();
form_target.GetFormControlElements()[0].SetAttribute(
"autocomplete", WebString::FromUTF8(autocomplete));
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_target.GetFormControlElements(), {});
EXPECT_FALSE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::
kFormInputHasWrongButWellIntendedAutocompleteValueError,
/*violating_attr=*/"autocomplete"));
}
TEST_F(FormAutofillIssuesTest, FormEmptyIdAndNameAttributesForInputError) {
LoadHTML(R"(
<form id=target>
<input>
</form>)");
WebFormElement form_target = GetTargetForm();
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_target.GetFormControlElements(), {});
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::kFormEmptyIdAndNameAttributesForInputError));
}
TEST_F(FormAutofillIssuesTest,
FormInputAssignedAutocompleteValueToIdOrNameAttributeError) {
LoadHTML(R"(
<form id=target>
<input id=country>
</form>)");
WebFormElement form_target = GetTargetForm();
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_target.GetFormControlElements(), {});
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::
kFormInputAssignedAutocompleteValueToIdOrNameAttributeError,
/*violating_attr=*/"id"));
}
TEST_F(
FormAutofillIssuesTest,
FormInputAssignedAutocompleteValueToIdOrNameAttributeErrorUnownedControl) {
LoadHTML(R"(
<div>
<label for="country">Country</label>
<input id=country>
</div>)");
WebLocalFrame* web_frame = GetMainFrame();
std::vector<FormIssue> form_issues =
GetFormIssuesForTesting(form_util::GetOwnedAutofillableFormControls(
web_frame->GetDocument(), WebFormElement()),
{});
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::
kFormInputAssignedAutocompleteValueToIdOrNameAttributeError,
/*violating_attr=*/"id"));
}
TEST_F(FormAutofillIssuesTest, FormLabelForNameError) {
LoadHTML(R"(
<form id=target>
<input id=id_0 name=name_0>
<input id=id_1 name=name_1>
<input id=id_2 name=name_2>
<label for=id_0>correct label</label>
<label for=name_1>incorrect label 1</label>
<label for=name_2>incorrect label 2</label>
</form>)");
WebLocalFrame* web_frame = GetMainFrame();
FormData form_data = *form_util::ExtractFormData(
web_frame->GetDocument(), GetTargetForm(),
*base::MakeRefCounted<FieldDataManager>(), kCallTimerStateDummy,
/*button_titles_cache=*/nullptr);
std::vector<FormIssue> form_issues =
CheckForLabelsWithIncorrectForAttributeForTesting(
web_frame->GetDocument(), form_data.fields(), {});
EXPECT_EQ(form_issues.size(), 2u);
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues, GenericIssueErrorType::kFormLabelForNameError,
/*violating_attr=*/"for"));
}
TEST_F(FormAutofillIssuesTest, FormLabelForMatchesNonExistingIdError) {
LoadHTML(R"(
<form id=target>
<label for=non_existing />
<input id=id_0 name=name_0>
<label for=id_0 />"
</form>)");
WebLocalFrame* web_frame = GetMainFrame();
FormData form_data = *form_util::ExtractFormData(
web_frame->GetDocument(), GetTargetForm(),
*base::MakeRefCounted<FieldDataManager>(), kCallTimerStateDummy,
/*button_titles_cache=*/nullptr);
std::vector<FormIssue> form_issues =
CheckForLabelsWithIncorrectForAttributeForTesting(
web_frame->GetDocument(), form_data.fields(), {});
EXPECT_EQ(form_issues.size(), 1u);
EXPECT_TRUE(FormIssuesContainIssueType(
form_issues,
GenericIssueErrorType::kFormLabelForMatchesNonExistingIdError,
/*violating_attr=*/"for"));
}
} // namespace
} // namespace autofill::form_issues
|
