1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "components/bookmarks/browser/titled_url_index.h"
#include <array>
#include <memory>
#include <string>
#include <string_view>
#include <utility>
#include <vector>
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "components/bookmarks/browser/titled_url_match.h"
#include "components/bookmarks/browser/titled_url_node.h"
#include "components/bookmarks/browser/typed_count_sorter.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "components/query_parser/query_parser.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::UTF8ToUTF16;
namespace bookmarks {
namespace {
// Used for sorting in combination with TypedCountSorter.
class BookmarkClientMock : public TestBookmarkClient {
public:
explicit BookmarkClientMock(const std::map<GURL, int>& typed_count_map)
: typed_count_map_(typed_count_map) {}
BookmarkClientMock(const BookmarkClientMock&) = delete;
BookmarkClientMock& operator=(const BookmarkClientMock&) = delete;
bool SupportsTypedCountForUrls() override { return true; }
void GetTypedCountForUrls(UrlTypedCountMap* url_typed_count_map) override {
for (auto& url_typed_count_pair : *url_typed_count_map) {
const GURL* url = url_typed_count_pair.first;
if (!url)
continue;
auto found = typed_count_map_.find(*url);
if (found == typed_count_map_.end())
continue;
url_typed_count_pair.second = found->second;
}
}
private:
const std::map<GURL, int> typed_count_map_;
};
// Minimal implementation of TitledUrlNode.
class TestTitledUrlNode : public TitledUrlNode {
public:
TestTitledUrlNode(const std::u16string& title,
const GURL& url,
const std::u16string& ancestor_title)
: title_(title), url_(url), ancestor_title_(ancestor_title) {}
~TestTitledUrlNode() override = default;
const std::u16string& GetTitledUrlNodeTitle() const override {
return title_;
}
const GURL& GetTitledUrlNodeUrl() const override { return url_; }
std::vector<std::u16string_view> GetTitledUrlNodeAncestorTitles()
const override {
return {ancestor_title_};
}
private:
std::u16string title_;
GURL url_;
std::u16string ancestor_title_;
};
} // namespace
class TitledUrlIndexFake : public TitledUrlIndex {
public:
using TitledUrlIndex::ExtractQueryWords;
using TitledUrlIndex::MatchTitledUrlNodeWithQuery;
using TitledUrlIndex::RetrieveNodesMatchingAllTerms;
using TitledUrlIndex::RetrieveNodesMatchingAnyTerms;
// Helper to call `TitledUrlIndex::MatchTitledUrlNodeWithQuery` with simpler
// parameters, returning a bool indicating success.
bool MatchTitledUrlNodeWithQuery(std::u16string node_title,
std::u16string query) {
TestTitledUrlNode node{node_title, GURL("http://foo.com"), u""};
std::vector<std::u16string> query_terms =
TitledUrlIndexFake::ExtractQueryWords(query);
query_parser::QueryNodeVector query_nodes;
query_parser::QueryParser::ParseQueryNodes(
query, query_parser::MatchingAlgorithm::ALWAYS_PREFIX_SEARCH,
&query_nodes);
return MatchTitledUrlNodeWithQuery(&node, query_nodes, query_terms)
.has_value();
}
};
namespace {
class TitledUrlIndexTest : public testing::Test {
public:
const GURL kAboutBlankURL = GURL("about:blank");
TitledUrlIndexTest() { ResetNodes(); }
~TitledUrlIndexTest() override = default;
void ResetNodes() {
index_ = std::make_unique<TitledUrlIndexFake>();
owned_nodes_.clear();
owned_path_nodes_.clear();
}
std::pair<TitledUrlNode*, TitledUrlNode*> AddNode(
const std::string& title,
const GURL& url,
const std::string& ancestor_title = "") {
return AddNode(UTF8ToUTF16(title), url, UTF8ToUTF16(ancestor_title));
}
std::pair<TitledUrlNode*, TitledUrlNode*> AddNode(
const std::u16string& title,
const GURL& url,
const std::u16string& ancestor_title = std::u16string()) {
// Add the node.
owned_nodes_.push_back(
std::make_unique<TestTitledUrlNode>(title, url, ancestor_title));
index_->Add(owned_nodes_.back().get());
// Add its parent node.
owned_path_nodes_.push_back(
std::make_unique<TestTitledUrlNode>(ancestor_title, GURL{}, u""));
index_->AddPath(owned_path_nodes_.back().get());
return {owned_nodes_.back().get(), owned_path_nodes_.back().get()};
}
std::vector<TitledUrlMatch> GetResultsMatching(const std::string& query,
size_t max_count) {
return index_->GetResultsMatching(UTF8ToUTF16(query), max_count,
query_parser::MatchingAlgorithm::DEFAULT);
}
void ExpectMatches(const std::string& query,
const char** expected_titles,
size_t expected_count) {
std::vector<std::string> title_vector;
for (size_t i = 0; i < expected_count; ++i)
title_vector.push_back(expected_titles[i]);
ExpectMatches(query, query_parser::MatchingAlgorithm::DEFAULT,
title_vector);
}
void ExpectMatches(const std::string& query,
query_parser::MatchingAlgorithm matching_algorithm,
const std::vector<std::string>& expected_titles) {
std::vector<TitledUrlMatch> matches = index_->GetResultsMatching(
UTF8ToUTF16(query), 1000, matching_algorithm);
ASSERT_EQ(expected_titles.size(), matches.size());
for (const std::string& expected_title : expected_titles) {
bool found = false;
for (size_t j = 0; j < matches.size(); ++j) {
const std::u16string& title = matches[j].node->GetTitledUrlNodeTitle();
if (UTF8ToUTF16(expected_title) == title) {
matches.erase(matches.begin() + j);
found = true;
break;
}
}
ASSERT_TRUE(found);
}
}
void ExtractMatchPositions(const std::string& string,
TitledUrlMatch::MatchPositions* matches) {
for (std::string_view match : base::SplitStringPiece(
string, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
std::vector<std::string_view> chunks = base::SplitStringPiece(
match, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
ASSERT_EQ(2U, chunks.size());
matches->push_back(TitledUrlMatch::MatchPosition());
int chunks0, chunks1;
EXPECT_TRUE(base::StringToInt(chunks[0], &chunks0));
EXPECT_TRUE(base::StringToInt(chunks[1], &chunks1));
matches->back().first = chunks0;
matches->back().second = chunks1;
}
}
void ExpectMatchPositions(
const TitledUrlMatch::MatchPositions& actual_positions,
const TitledUrlMatch::MatchPositions& expected_positions) {
ASSERT_EQ(expected_positions.size(), actual_positions.size());
for (size_t i = 0; i < expected_positions.size(); ++i) {
EXPECT_EQ(expected_positions[i].first, actual_positions[i].first);
EXPECT_EQ(expected_positions[i].second, actual_positions[i].second);
}
}
void VerifyRetrieveNodesMatchingAnyTerms(
const std::string& query,
const std::vector<int> expected_node_indexes) {
SCOPED_TRACE("Query: " + query);
std::vector<std::u16string> terms =
base::SplitString(base::UTF8ToUTF16(query), u" ", base::TRIM_WHITESPACE,
base::SPLIT_WANT_ALL);
auto matches = index()->RetrieveNodesMatchingAnyTerms(
terms, query_parser::MatchingAlgorithm::DEFAULT, 3);
// Verify the correct nodes matched.
ASSERT_EQ(matches.size(), expected_node_indexes.size());
for (int index : expected_node_indexes) {
SCOPED_TRACE(
"node: " +
base::UTF16ToUTF8(owned_nodes_[index]->GetTitledUrlNodeTitle()));
EXPECT_TRUE(matches.contains(owned_nodes_[index].get()));
}
}
TitledUrlIndexFake* index() { return index_.get(); }
private:
std::vector<std::unique_ptr<TestTitledUrlNode>> owned_nodes_;
std::vector<std::unique_ptr<TestTitledUrlNode>> owned_path_nodes_;
std::unique_ptr<TitledUrlIndexFake> index_;
};
// Various permutations with differing input, queries and output that exercises
// all query paths.
TEST_F(TitledUrlIndexTest, GetResultsMatching) {
struct TestData {
const std::string titles;
const std::string query;
const std::string expected;
} data[] = {
// Trivial test case of only one term, exact match.
{"a;b", "A", "a"},
// Two terms, exact matches.
{"a b;b", "a b", "a b"},
// Prefix match, one term.
{"abcd;abc;b", "abc", "abcd;abc"},
// Prefix match, multiple terms.
{"abcd cdef;abcd;abcd cdefg", "abc cde", "abcd cdef;abcd cdefg"},
// Exact and prefix match.
{"ab cdef;abcd;abcd cdefg", "ab cdef", "ab cdef"},
// Exact and prefix match.
{"ab cdef ghij;ab;cde;cdef;ghi;cdef ab;ghij ab", "ab cde ghi",
"ab cdef ghij"},
// Title with term multiple times.
{"ab ab", "ab", "ab ab"},
// Make sure quotes don't do a prefix match.
{"think", "\"thi\"", ""},
// Prefix matches against multiple candidates.
{"abc1 abc2 abc3 abc4", "abc", "abc1 abc2 abc3 abc4"},
// Multiple prefix matches (with a lot of redundancy) against multiple
// candidates.
{"abc1 abc2 abc3 abc4 def1 def2 def3 def4",
"abc def abc def abc def abc def abc def",
"abc1 abc2 abc3 abc4 def1 def2 def3 def4"},
// Prefix match on the first term.
{"abc", "a", ""},
// Prefix match on subsequent terms.
{"abc def", "abc d", ""},
};
for (const TestData& test_data : data) {
SCOPED_TRACE("Query: " + test_data.query);
ResetNodes();
for (const std::string& title :
base::SplitString(test_data.titles, ";", base::TRIM_WHITESPACE,
base::SPLIT_WANT_ALL)) {
AddNode(title, kAboutBlankURL);
}
std::vector<std::string> expected;
if (!test_data.expected.empty()) {
expected = base::SplitString(test_data.expected, ";",
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
}
ExpectMatches(test_data.query, query_parser::MatchingAlgorithm::DEFAULT,
expected);
}
}
TEST_F(TitledUrlIndexTest, GetResultsMatchingAlwaysPrefixSearch) {
struct TestData {
const std::string titles;
const std::string query;
const std::string expected;
} data[] = {
// Trivial test case of only one term, exact match.
{"z;y", "Z", "z"},
// Prefix match, one term.
{"abcd;abc;b", "abc", "abcd;abc"},
// Prefix match, multiple terms.
{"abcd cdef;abcd;abcd cdefg", "abc cde", "abcd cdef;abcd cdefg"},
// Exact and prefix match.
{"ab cdef ghij;ab;cde;cdef;ghi;cdef ab;ghij ab", "ab cde ghi",
"ab cdef ghij"},
// Title with term multiple times.
{"ab ab", "ab", "ab ab"},
// Make sure quotes don't do a prefix match.
{"think", "\"thi\"", ""},
// Prefix matches against multiple candidates.
{"abc1 abc2 abc3 abc4", "abc", "abc1 abc2 abc3 abc4"},
// Prefix match on the first term.
{"abc", "a", "abc"},
// Prefix match on subsequent terms.
{"abc def", "abc d", "abc def"},
// Exact and prefix match.
{"ab cdef;abcd;abcd cdefg", "ab cdef", "ab cdef;abcd cdefg"},
};
for (const TestData& test_data : data) {
ResetNodes();
for (const std::string& title :
base::SplitString(test_data.titles, ";", base::TRIM_WHITESPACE,
base::SPLIT_WANT_ALL)) {
AddNode(title, kAboutBlankURL);
}
std::vector<std::string> expected;
if (!test_data.expected.empty()) {
expected = base::SplitString(test_data.expected, ";",
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
}
ExpectMatches(test_data.query,
query_parser::MatchingAlgorithm::ALWAYS_PREFIX_SEARCH,
expected);
}
}
// Analogous to GetResultsMatching, this test tests various permutations
// of title, URL, and input to see if the title/URL matches the input as
// expected.
TEST_F(TitledUrlIndexTest, GetResultsMatchingWithURLs) {
struct TestData {
const std::string query;
const std::string title;
const std::string url;
const bool should_be_retrieved;
} data[] = {
// Test single-word inputs. Include both exact matches and prefix
// matches.
{"foo", "Foo", "http://www.bar.com/", true},
{"foo", "Foodie", "http://www.bar.com/", true},
{"foo", "Bar", "http://www.foo.com/", true},
{"foo", "Bar", "http://www.foodie.com/", true},
{"foo", "Foo", "http://www.foo.com/", true},
{"foo", "Bar", "http://www.bar.com/", false},
{"foo", "Bar", "http://www.bar.com/blah/foo/blah-again/ ", true},
{"foo", "Bar", "http://www.bar.com/blah/foodie/blah-again/ ", true},
{"foo", "Bar", "http://www.bar.com/blah-foo/blah-again/ ", true},
{"foo", "Bar", "http://www.bar.com/blah-foodie/blah-again/ ", true},
{"foo", "Bar", "http://www.bar.com/blahafoo/blah-again/ ", false},
// Test multi-word inputs.
{"foo bar", "Foo Bar", "http://baz.com/", true},
{"foo bar", "Foodie Bar", "http://baz.com/", true},
{"bar foo", "Foo Bar", "http://baz.com/", true},
{"bar foo", "Foodie Barly", "http://baz.com/", true},
{"foo bar", "Foo Baz", "http://baz.com/", false},
{"foo bar", "Foo Baz", "http://bar.com/", true},
{"foo bar", "Foo Baz", "http://barly.com/", true},
{"foo bar", "Foodie Baz", "http://barly.com/", true},
{"bar foo", "Foo Baz", "http://bar.com/", true},
{"bar foo", "Foo Baz", "http://barly.com/", true},
{"foo bar", "Baz Bar", "http://blah.com/foo", true},
{"foo bar", "Baz Barly", "http://blah.com/foodie", true},
{"foo bar", "Baz Bur", "http://blah.com/foo/bar", true},
{"foo bar", "Baz Bur", "http://blah.com/food/barly", true},
{"foo bar", "Baz Bur", "http://bar.com/blah/foo", true},
{"foo bar", "Baz Bur", "http://barly.com/blah/food", true},
{"foo bar", "Baz Bur", "http://bar.com/blah/flub", false},
{"foo bar", "Baz Bur", "http://foo.com/blah/flub", false}};
for (const TestData& test_data : data) {
ResetNodes();
AddNode(test_data.title, GURL(test_data.url));
std::vector<std::string> expected;
if (test_data.should_be_retrieved)
expected.push_back(test_data.title);
ExpectMatches(test_data.query, query_parser::MatchingAlgorithm::DEFAULT,
expected);
}
}
TEST_F(TitledUrlIndexTest, GetResultsMatchingWithSymbols) {
auto does_query_match_title = [&](std::string query, std::string title) {
ResetNodes();
AddNode(title, kAboutBlankURL);
size_t num_matches = GetResultsMatching(query, 10).size();
EXPECT_LE(num_matches, 1u);
return num_matches > 0;
};
// Symbols should act as word breaks and don't need to match between the query
// and title.
EXPECT_TRUE(does_query_match_title("abc@xyz", "xyz@abc"));
EXPECT_TRUE(does_query_match_title("abc&xyz", "xyz&abc"));
EXPECT_TRUE(does_query_match_title("abc@xyz", "xyz abc"));
EXPECT_TRUE(does_query_match_title("abc xyz", "xyz@abc"));
// Treating symbols as word breaks doesn't mean simply pretending they're not
// there.
EXPECT_FALSE(does_query_match_title("xyz@abc", "xyzabc"));
EXPECT_FALSE(does_query_match_title("xyzabc", "xyz@abc"));
// '@' as the first character of the query should be treated special since it
// indicates the user likely wants search scope.
EXPECT_FALSE(does_query_match_title("@abc", "@abc"));
// Other symbols shouldn't have that exception.
EXPECT_TRUE(does_query_match_title("&abc", "@abc"));
// '@' as the first character of the node shouldn't have that exception.
EXPECT_TRUE(does_query_match_title("abc", "@abc"));
// '@' in other locations in the query shouldn't have that exception.
EXPECT_TRUE(does_query_match_title("abc @abc", "@abc"));
// '@' followed by other symbols shouldn't have that exception.
EXPECT_TRUE(does_query_match_title("@ abc", "@abc"));
EXPECT_TRUE(does_query_match_title("@@abc", "@abc"));
EXPECT_TRUE(does_query_match_title("@&abc", "@abc"));
// '@' input or title shouldn't crash.
EXPECT_FALSE(does_query_match_title("@", "@"));
}
TEST_F(TitledUrlIndexTest, Normalization) {
struct TestData {
const char* const title;
const char* const query;
} data[] = {{"fooa\xcc\x88-test", "foo\xc3\xa4-test"},
{"fooa\xcc\x88-test", "fooa\xcc\x88-test"},
{"fooa\xcc\x88-test", "foo\xc3\xa4"},
{"fooa\xcc\x88-test", "fooa\xcc\x88"},
{"fooa\xcc\x88-test", "foo"},
{"foo\xc3\xa4-test", "foo\xc3\xa4-test"},
{"foo\xc3\xa4-test", "fooa\xcc\x88-test"},
{"foo\xc3\xa4-test", "foo\xc3\xa4"},
{"foo\xc3\xa4-test", "fooa\xcc\x88"},
{"foo\xc3\xa4-test", "foo"},
{"foo", "foo"}};
for (const TestData& test_data : data) {
ResetNodes();
AddNode(test_data.title, kAboutBlankURL);
std::vector<TitledUrlMatch> matches =
GetResultsMatching(test_data.query, 10);
EXPECT_EQ(1u, matches.size());
}
}
// Makes sure match positions are updated appropriately for title matches.
TEST_F(TitledUrlIndexTest, MatchPositionsTitles) {
struct TestData {
const std::string title;
const std::string query;
const std::string expected_title_match_positions;
} data[] = {
// Trivial test case of only one term, exact match.
{"a", "A", "0,1"},
{"foo bar", "bar", "4,7"},
{"fooey bark", "bar foo", "0,3:6,9"},
// Non-trivial tests.
{"foobar foo", "foobar foo", "0,6:7,10"},
{"foobar foo", "foo foobar", "0,6:7,10"},
{"foobar foobar", "foobar foo", "0,6:7,13"},
{"foobar foobar", "foo foobar", "0,6:7,13"},
};
for (const TestData& test_data : data) {
ResetNodes();
AddNode(test_data.title, kAboutBlankURL);
std::vector<TitledUrlMatch> matches =
GetResultsMatching(test_data.query, 1000);
ASSERT_EQ(1U, matches.size());
TitledUrlMatch::MatchPositions expected_title_matches;
ExtractMatchPositions(test_data.expected_title_match_positions,
&expected_title_matches);
ExpectMatchPositions(matches[0].title_match_positions,
expected_title_matches);
}
}
// Makes sure match positions are updated appropriately for URL matches.
TEST_F(TitledUrlIndexTest, MatchPositionsURLs) {
// The encoded stuff between /wiki/ and the # is 第二次世界大戦
const std::string ja_wiki_url =
"http://ja.wikipedia.org/wiki/%E7%AC%AC%E4"
"%BA%8C%E6%AC%A1%E4%B8%96%E7%95%8C%E5%A4%A7%E6%88%A6#.E3.83.B4.E3.82.A7"
".E3.83.AB.E3.82.B5.E3.82.A4.E3.83.A6.E4.BD.93.E5.88.B6";
struct TestData {
const std::string query;
const std::string url;
const std::string expected_url_match_positions;
} data[] = {
{"foo", "http://www.foo.com/", "11,14"},
{"foo", "http://www.foodie.com/", "11,14"},
{"foo", "http://www.foofoo.com/", "11,14"},
{"www", "http://www.foo.com/", "7,10"},
{"foo", "http://www.foodie.com/blah/foo/fi", "11,14:27,30"},
{"foo", "http://www.blah.com/blah/foo/fi", "25,28"},
{"foo www", "http://www.foodie.com/blah/foo/fi", "7,10:11,14:27,30"},
{"www foo", "http://www.foodie.com/blah/foo/fi", "7,10:11,14:27,30"},
{"www bla", "http://www.foodie.com/blah/foo/fi", "7,10:22,25"},
{"http", "http://www.foo.com/", "0,4"},
{"http www", "http://www.foo.com/", "0,4:7,10"},
{"http foo", "http://www.foo.com/", "0,4:11,14"},
{"http foo", "http://www.bar.com/baz/foodie/hi", "0,4:23,26"},
{"第二次", ja_wiki_url, "29,56"},
{"ja 第二次", ja_wiki_url, "7,9:29,56"},
{"第二次 E3.8", ja_wiki_url,
"29,56:94,98:103,107:"
"112,116:121,125:"
"130,134:139,143"}};
for (const TestData& test_data : data) {
ResetNodes();
AddNode("123456", GURL(test_data.url));
std::vector<TitledUrlMatch> matches =
GetResultsMatching(test_data.query, 1000);
ASSERT_EQ(1U, matches.size()) << test_data.url << test_data.query;
TitledUrlMatch::MatchPositions expected_url_matches;
ExtractMatchPositions(test_data.expected_url_match_positions,
&expected_url_matches);
ExpectMatchPositions(matches[0].url_match_positions, expected_url_matches);
}
}
// Makes sure index is updated when a node is removed.
TEST_F(TitledUrlIndexTest, Remove) {
TitledUrlNode* n1 = AddNode("foo", GURL("http://foo")).first;
TitledUrlNode* n2 = AddNode("bar", GURL("http://bar")).first;
TitledUrlNode* n3 = AddNode("bar", GURL("http://bar/baz")).first;
ASSERT_EQ(1U, GetResultsMatching("foo", 10).size());
ASSERT_EQ(2U, GetResultsMatching("bar", 10).size());
index()->Remove(n3);
EXPECT_EQ(1U, GetResultsMatching("bar", 10).size());
EXPECT_EQ(1U, GetResultsMatching("foo", 10).size());
index()->Remove(n1);
EXPECT_EQ(1U, GetResultsMatching("bar", 10).size());
EXPECT_EQ(0U, GetResultsMatching("foo", 10).size());
index()->Remove(n2);
EXPECT_EQ(0U, GetResultsMatching("bar", 10).size());
}
// Makes sure index is updated when a node is removed.
TEST_F(TitledUrlIndexTest, Remove_PathIndex) {
auto* parent_dir = AddNode("foo", GURL("http://foo"), "folder").second;
ASSERT_EQ(1U, GetResultsMatching("foo folder", 10).size());
index()->RemovePath(parent_dir);
ASSERT_EQ(0U, GetResultsMatching("foo folder", 10).size());
ASSERT_EQ(1U, GetResultsMatching("foo", 10).size());
}
// Makes sure no more than max queries is returned.
TEST_F(TitledUrlIndexTest, HonorMax) {
AddNode("abcd", kAboutBlankURL);
AddNode("abcde", kAboutBlankURL);
EXPECT_EQ(1U, GetResultsMatching("ABc", 1).size());
}
// Makes sure if the lower case string of a bookmark title is more characters
// than the upper case string no match positions are returned.
TEST_F(TitledUrlIndexTest, EmptyMatchOnMultiwideLowercaseString) {
TitledUrlNode* n1 = AddNode(u"\u0130 i", GURL("http://www.google.com")).first;
std::vector<TitledUrlMatch> matches = GetResultsMatching("i", 100);
ASSERT_EQ(1U, matches.size());
EXPECT_EQ(n1, matches[0].node);
EXPECT_TRUE(matches[0].title_match_positions.empty());
}
TEST_F(TitledUrlIndexTest, GetResultsSortedByTypedCount) {
struct TestData {
const GURL url;
const char* title;
const int typed_count;
};
auto data = std::to_array<TestData>({
{GURL("http://www.google.com/"), "Google", 100},
{GURL("http://maps.google.com/"), "Google Maps", 40},
{GURL("http://docs.google.com/"), "Google Docs", 50},
{GURL("http://reader.google.com/"), "Google Reader", 80},
});
std::map<GURL, int> typed_count_map;
for (const TestData& test_data : data)
typed_count_map.insert(
std::make_pair(test_data.url, test_data.typed_count));
BookmarkClientMock bookmark_client(typed_count_map);
index()->SetNodeSorter(std::make_unique<TypedCountSorter>(&bookmark_client));
for (const TestData& test_data : data)
AddNode(test_data.title, GURL(test_data.url));
// Populate match nodes.
std::vector<TitledUrlMatch> matches = GetResultsMatching("google", 4);
// The resulting order should be:
// 1. Google (google.com) 100
// 2. Google Reader (google.com/reader) 80
// 3. Google Docs (docs.google.com) 50
// 4. Google Maps (maps.google.com) 40
ASSERT_EQ(4U, matches.size());
EXPECT_EQ(data[0].url, matches[0].node->GetTitledUrlNodeUrl());
EXPECT_EQ(data[3].url, matches[1].node->GetTitledUrlNodeUrl());
EXPECT_EQ(data[2].url, matches[2].node->GetTitledUrlNodeUrl());
EXPECT_EQ(data[1].url, matches[3].node->GetTitledUrlNodeUrl());
// Select top two matches.
matches = GetResultsMatching("google", 2);
ASSERT_EQ(2U, matches.size());
EXPECT_EQ(data[0].url, matches[0].node->GetTitledUrlNodeUrl());
EXPECT_EQ(data[3].url, matches[1].node->GetTitledUrlNodeUrl());
index()->SetNodeSorter(nullptr);
}
TEST_F(TitledUrlIndexTest, MatchTitledUrlNodeWithQuery) {
// When the query matches the node, should return non `nullopt`.
EXPECT_TRUE(index()->MatchTitledUrlNodeWithQuery(u"matching", u"match"));
// When the query approximately matches the node, should return `nullopt`.
EXPECT_FALSE(index()->MatchTitledUrlNodeWithQuery(u"mmmatch", u"match"));
// WHen the query doesn't match the node, should return `nullopt`.
EXPECT_FALSE(index()->MatchTitledUrlNodeWithQuery(u"natch", u"match"));
}
TEST_F(TitledUrlIndexTest, MatchTitledUrlNodeWithQuery_ApproximateNodeMatch) {
// When the query matches the node, should return non `nullopt`.
EXPECT_TRUE(index()->MatchTitledUrlNodeWithQuery(u"matching", u"match"));
// When the query approximately matches the node, should return `nullopt`.
EXPECT_FALSE(index()->MatchTitledUrlNodeWithQuery(u"mmmatch", u"match"));
// WHen the query doesn't match the node, should return `nullopt`.
EXPECT_FALSE(index()->MatchTitledUrlNodeWithQuery(u"natch", u"match"));
}
TEST_F(TitledUrlIndexTest, RetrieveNodesMatchingAllTerms) {
TitledUrlNode* node =
AddNode("term1 term2 other xyz ab", GURL("http://foo.com")).first;
struct TestData {
const std::string query;
const bool should_be_retrieved;
} data[] = {// Should return matches if all input terms match, even if not all
// node terms match.
{"term other", true},
// Should not match midword.
{"term ther", false},
// Short input terms should only return exact matches.
{"xy", false},
{"ab", true}};
for (const TestData& test_data : data) {
SCOPED_TRACE("Query: " + test_data.query);
std::vector<std::u16string> terms =
base::SplitString(base::UTF8ToUTF16(test_data.query), u" ",
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
auto matches = index()->RetrieveNodesMatchingAllTerms(
terms, query_parser::MatchingAlgorithm::DEFAULT);
if (test_data.should_be_retrieved) {
EXPECT_EQ(matches.size(), 1u);
EXPECT_TRUE(matches.contains(node));
} else
EXPECT_TRUE(matches.empty());
};
}
TEST_F(TitledUrlIndexTest, RetrieveNodesMatchingAnyTerms_PathMatch) {
ResetNodes();
AddNode("term1 term2 other xyz ab", GURL("http://foo.com"));
AddNode("no_match", GURL("http://no_match.com"), "path commo");
AddNode("common1", GURL("http://foo.com"));
AddNode("common2", GURL("http://foo.com"));
AddNode("common3", GURL("http://foo.com"));
AddNode("common4", GURL("http://foo.com"));
// Should return match even if an input term does not match, as long as it's
// in the path index.
VerifyRetrieveNodesMatchingAnyTerms("term path", {0});
// Should not return matches if any input term is neither matching nor in the
// path index.
VerifyRetrieveNodesMatchingAnyTerms("term not", {});
// If any input term is not in the path index, should do full matching (i.e.
// all input terms need to be non-path matched).
VerifyRetrieveNodesMatchingAnyTerms("term common", {});
// If all input terms are in the path index, only 1 input term needs to
// non-path match.
VerifyRetrieveNodesMatchingAnyTerms("comm path", {2, 3, 4});
// Should not return duplicate matches.
VerifyRetrieveNodesMatchingAnyTerms("term term1 term2", {0});
// Should not early exit when there are no intermediate matches.
VerifyRetrieveNodesMatchingAnyTerms("path comm", {2, 3, 4});
// Should not match midword ('ther' in 'other').
VerifyRetrieveNodesMatchingAnyTerms("ther ther", {});
// Short input terms should only return exact matches.
VerifyRetrieveNodesMatchingAnyTerms("xy xy", {});
VerifyRetrieveNodesMatchingAnyTerms("ab ab", {0});
// Allows complete title/URL matches to exceed `max_nodes` (3 in tests).
VerifyRetrieveNodesMatchingAnyTerms("commo commo", {2, 3, 4, 5});
}
TEST_F(TitledUrlIndexTest, RetrieveNodesMatchingAnyTerms_PathIndex) {
AddNode("term1 term2 other xyz ab", GURL("http://foo.com"), "parent");
AddNode("term1 term3", GURL("http://foo.com"), "parent2");
// When short-circuiting to matching all terms, should not intersect with path
// matching terms, only non-path matching terms.
// Should intersect 'term1' matches only, returning both nodes, even though
// the 1st node doesn't match 'parent2'.
VerifyRetrieveNodesMatchingAnyTerms("term1 parent2", {0, 1});
// Should intersect 'term1' and 'term2' matches returning the 1st node,
// even though it doesn't match 'parent2'.
VerifyRetrieveNodesMatchingAnyTerms("term1 term2 parent2", {0});
// Should intersect 'term2' and 'term3' matches returning 0 nodes.
VerifyRetrieveNodesMatchingAnyTerms("term2 term3 parent", {});
}
TEST_F(TitledUrlIndexTest, GetResultsMatchingAncestors) {
TitledUrlNode* node =
AddNode("leaf pare", GURL("http://foo.com"), "parent").first;
struct TestData {
const std::string query;
const bool should_be_retrieved;
const bool should_have_ancestor_match;
} data[] = {
// Should allow ancestor matches when `match_ancestor_titles` is true.
{"leaf parent", true, true},
// Should not early exit when there are no accumulated non-ancestor
// matches.
{"parent leaf", true, true},
// Should still require at least 1 non-ancestor match when
// `match_ancestor_titles` is true.
{"parent parent", false, false},
// Should set `has_ancestor_match` to true even if a term matched both an
// ancestor and title/URL.
{"pare", true, true},
// Short inputs should only match exact title or ancestor terms.
{"pa pa", false, false},
// Should not return matches if a term matches neither the title nor
// ancestor.
{"leaf not parent", false, false},
};
for (const TestData& test_data : data) {
SCOPED_TRACE("Query: " + test_data.query);
auto matches = GetResultsMatching(test_data.query, 10);
// Verify whether the match.
if (test_data.should_be_retrieved) {
EXPECT_EQ(matches.size(), 1u);
EXPECT_EQ(matches[0].node, node);
EXPECT_EQ(matches[0].has_ancestor_match,
test_data.should_have_ancestor_match);
} else
EXPECT_TRUE(matches.empty());
};
}
} // namespace
} // namespace bookmarks
|