1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/browsing_data/core/pref_names.h"
#include <gtest/gtest.h>
#include "base/test/metrics/histogram_tester.h"
#include "components/browsing_data/core/browsing_data_utils.h"
#include "components/prefs/testing_pref_service.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
namespace {
const int kPreviousDefaultTimePeriod =
static_cast<int>(browsing_data::TimePeriod::LAST_HOUR);
const int kNewDefaultTimePeriod =
static_cast<int>(browsing_data::TimePeriod::LAST_15_MINUTES);
const int kNeitherDefaultTimePeriod =
static_cast<int>(browsing_data::TimePeriod::LAST_DAY);
} // namespace
// Tests that the kDeleteTimePeriod and kCloseTabs prefs are migrated to the new
// defaults when the prefs are using the default values.
TEST(BrowsingDataPrefNamesMigrationTest,
MaybeMigrateToQuickDeletePrefValues_DefaultValues) {
base::HistogramTester histogram_tester;
sync_preferences::TestingPrefServiceSyncable prefs;
browsing_data::prefs::RegisterBrowserUserPrefs(prefs.registry());
browsing_data::prefs::MaybeMigrateToQuickDeletePrefValues(&prefs);
EXPECT_EQ(prefs.GetInteger(browsing_data::prefs::kDeleteTimePeriod),
kNewDefaultTimePeriod);
EXPECT_EQ(prefs.GetBoolean(browsing_data::prefs::kCloseTabs), true);
EXPECT_EQ(
prefs.GetBoolean(browsing_data::prefs::kMigratedToQuickDeletePrefValues),
true);
histogram_tester.ExpectUniqueSample(
"Privacy.DeleteBrowsingData.MigratedToNewDefaults", true, 1);
}
// Tests that the kDeleteTimePeriod and kCloseTabs prefs are not migrated to the
// new defaults when the prefs are not using the default values.
TEST(BrowsingDataPrefNamesMigrationTest,
MaybeMigrateToQuickDeletePrefValues_NotDefaultValues) {
base::HistogramTester histogram_tester;
sync_preferences::TestingPrefServiceSyncable prefs;
browsing_data::prefs::RegisterBrowserUserPrefs(prefs.registry());
// Set time period to another value other than the defaults.
prefs.SetInteger(browsing_data::prefs::kDeleteTimePeriod,
kNeitherDefaultTimePeriod);
browsing_data::prefs::MaybeMigrateToQuickDeletePrefValues(&prefs);
EXPECT_EQ(prefs.GetInteger(browsing_data::prefs::kDeleteTimePeriod),
kNeitherDefaultTimePeriod);
EXPECT_EQ(prefs.GetBoolean(browsing_data::prefs::kCloseTabs), false);
EXPECT_EQ(
prefs.GetBoolean(browsing_data::prefs::kMigratedToQuickDeletePrefValues),
true);
histogram_tester.ExpectUniqueSample(
"Privacy.DeleteBrowsingData.MigratedToNewDefaults", false, 1);
}
// Tests that the kDeleteTimePeriod and kCloseTabs prefs are not migrated when
// the user has already been migrated before.
TEST(BrowsingDataPrefNamesMigrationTest,
MaybeMigrateToQuickDeletePrefValues_AlreadyMigrated) {
base::HistogramTester histogram_tester;
sync_preferences::TestingPrefServiceSyncable prefs;
browsing_data::prefs::RegisterBrowserUserPrefs(prefs.registry());
// Set time period to the old default and tabs to disabled.
prefs.SetInteger(browsing_data::prefs::kDeleteTimePeriod,
kPreviousDefaultTimePeriod);
prefs.SetBoolean(browsing_data::prefs::kCloseTabs, true);
// Set the migration pref to true.
prefs.SetBoolean(browsing_data::prefs::kMigratedToQuickDeletePrefValues,
true);
browsing_data::prefs::MaybeMigrateToQuickDeletePrefValues(&prefs);
EXPECT_EQ(prefs.GetInteger(browsing_data::prefs::kDeleteTimePeriod),
kPreviousDefaultTimePeriod);
EXPECT_EQ(prefs.GetBoolean(browsing_data::prefs::kCloseTabs), true);
EXPECT_EQ(
prefs.GetBoolean(browsing_data::prefs::kMigratedToQuickDeletePrefValues),
true);
histogram_tester.ExpectUniqueSample(
"Privacy.DeleteBrowsingData.MigratedToNewDefaults", false, 0);
histogram_tester.ExpectUniqueSample(
"Privacy.DeleteBrowsingData.MigratedToNewDefaults", true, 0);
}
|
