1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/captive_portal/content/captive_portal_tab_reloader.h"
#include <memory>
#include "base/functional/callback.h"
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "components/captive_portal/content/captive_portal_service.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/test_renderer_host.h"
#include "net/base/net_errors.h"
#include "net/cert/cert_status_flags.h"
#include "net/ssl/ssl_info.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace captive_portal {
// Used for testing CaptivePortalTabReloader in isolation from the observer.
// Exposes a number of private functions and mocks out others.
class TestCaptivePortalTabReloader : public CaptivePortalTabReloader {
public:
explicit TestCaptivePortalTabReloader(content::WebContents* web_contents)
: CaptivePortalTabReloader(nullptr, web_contents, base::NullCallback()) {}
TestCaptivePortalTabReloader(const TestCaptivePortalTabReloader&) = delete;
TestCaptivePortalTabReloader& operator=(const TestCaptivePortalTabReloader&) =
delete;
~TestCaptivePortalTabReloader() override {}
bool TimerRunning() { return slow_ssl_load_timer_.IsRunning(); }
// The following methods are aliased so they can be publicly accessed by the
// unit tests.
State state() const { return CaptivePortalTabReloader::state(); }
void set_slow_ssl_load_time(base::TimeDelta slow_ssl_load_time) {
EXPECT_FALSE(TimerRunning());
CaptivePortalTabReloader::set_slow_ssl_load_time(slow_ssl_load_time);
}
// CaptivePortalTabReloader:
MOCK_METHOD0(ReloadTab, void());
MOCK_METHOD0(MaybeOpenCaptivePortalLoginTab, void());
MOCK_METHOD0(CheckForCaptivePortal, void());
};
class CaptivePortalTabReloaderTest : public content::RenderViewHostTestHarness {
public:
// testing::Test:
void SetUp() override {
content::RenderViewHostTestHarness::SetUp();
tab_reloader_ =
std::make_unique<testing::StrictMock<TestCaptivePortalTabReloader>>(
web_contents());
// Most tests don't run the message loop, so don't use a timer for them.
tab_reloader_->set_slow_ssl_load_time(base::TimeDelta());
}
void TearDown() override {
EXPECT_FALSE(tab_reloader().TimerRunning());
tab_reloader_.reset(NULL);
content::RenderViewHostTestHarness::TearDown();
}
TestCaptivePortalTabReloader& tab_reloader() { return *tab_reloader_.get(); }
private:
std::unique_ptr<TestCaptivePortalTabReloader> tab_reloader_;
};
// Simulates a slow SSL load when the Internet is connected.
TEST_F(CaptivePortalTabReloaderTest, InternetConnected) {
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
tab_reloader().OnLoadCommitted(net::OK, net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulates a slow SSL load when the Internet is connected. In this case,
// the timeout error occurs before the timer triggers. Unlikely to happen
// in practice, but best if it still works.
TEST_F(CaptivePortalTabReloaderTest, InternetConnectedTimeout) {
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulates a slow SSL load when captive portal checks return no response.
TEST_F(CaptivePortalTabReloaderTest, NoResponse) {
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
tab_reloader().OnCaptivePortalResults(RESULT_NO_RESPONSE, RESULT_NO_RESPONSE);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
tab_reloader().OnLoadCommitted(net::OK, net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulates a slow HTTP load when behind a captive portal, that eventually.
// times out. Since it's HTTP, the TabReloader should do nothing.
TEST_F(CaptivePortalTabReloaderTest, DoesNothingOnHttp) {
tab_reloader().OnLoadStart(false);
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
// The user logs in.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
// The page times out.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate the normal login process. The user logs in before the error page
// in the original tab commits.
TEST_F(CaptivePortalTabReloaderTest, Login) {
tab_reloader().OnLoadStart(true);
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The captive portal service detects a captive portal. The TabReloader
// should try and create a new login tab in response.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The user logs on from another tab, and a captive portal check is triggered.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should start an asynchronous reload.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate the normal login process. The user logs in after the tab finishes
// loading the error page.
TEST_F(CaptivePortalTabReloaderTest, LoginLate) {
tab_reloader().OnLoadStart(true);
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The captive portal service detects a captive portal. The TabReloader
// should try and create a new login tab in response.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The error page commits.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The user logs on from another tab, and a captive portal check is triggered.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate a login after the tab times out unexpectedly quickly.
TEST_F(CaptivePortalTabReloaderTest, TimeoutFast) {
tab_reloader().OnLoadStart(true);
// The error page commits, which should trigger a captive portal check,
// since the timer's still running.
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The captive portal service detects a captive portal. The TabReloader
// should try and create a new login tab in response.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The user logs on from another tab, and a captive portal check is triggered.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// The secure DNS config is misconfigured. A secure DNS network error on a
// HTTP navigation triggers a captive portal probe. The probe does not find
// a captive portal.
TEST_F(CaptivePortalTabReloaderTest, HttpBadSecureDnsConfig) {
tab_reloader().OnLoadStart(false);
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
// The page encounters a secure DNS network error. The error page commits,
// which should trigger a captive portal check, even for HTTP pages.
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
tab_reloader().OnLoadCommitted(
net::ERR_NAME_NOT_RESOLVED,
net::ResolveErrorInfo(net::ERR_CERT_COMMON_NAME_INVALID,
true /* is_secure_network_error */));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// If the only issue was the secure DNS config not being valid, the probes
// (which disable secure DNS) should indicate an internet connection.
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// The secure DNS config is misconfigured. A secure DNS network error on a
// HTTPS navigation triggers a captive portal probe before the SSL timer
// triggers. The probe does not find a captive portal.
TEST_F(CaptivePortalTabReloaderTest,
HttpsBadSecureDnsConfigPageLoadsBeforeTimerTriggers) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
// The page encounters a secure DNS network error. The error page commits,
// which should trigger a captive portal check. The SSL timer should be
// cancelled.
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
tab_reloader().OnLoadCommitted(
net::ERR_NAME_NOT_RESOLVED,
net::ResolveErrorInfo(net::ERR_CERT_COMMON_NAME_INVALID,
true /* is_secure_network_error */));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// If the only issue was the secure DNS config not being valid, the probes
// (which disable secure DNS) should indicate an internet connection.
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// The secure DNS config is misconfigured. The SSL timer triggers a captive
// portal probe, which does not complete before the page loads with a secure
// DNS network error. The probe does not find a captive portal.
TEST_F(CaptivePortalTabReloaderTest,
HttpsBadSecureDnsConfigPageLoadsBeforeTimerTriggeredResults) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The page encounters a secure DNS network error. The error page commits.
// Since a probe is already scheduled, we don't schedule another one.
tab_reloader().OnLoadCommitted(
net::ERR_NAME_NOT_RESOLVED,
net::ResolveErrorInfo(net::ERR_CERT_COMMON_NAME_INVALID,
true /* is_secure_network_error */));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// If the only issue was the secure DNS config not being valid, the probes
// (which disable secure DNS) should indicate an internet connection.
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// The secure DNS config is misconfigured. The SSL timer triggers a captive
// portal probe, which completes before the page loads with a secure DNS
// network error, which triggers another captive portal probe. The probe does
// not find a captive portal.
TEST_F(CaptivePortalTabReloaderTest,
HttpsBadSecureDnsConfigPageLoadsAfterTimerTriggeredResults) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(2);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// If the only issue was the secure DNS config not being valid, the probes
// (which disable secure DNS) should indicate an internet connection.
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
// The page encounters a secure DNS network error. The error page commits,
// which triggers another captive portal check.
tab_reloader().OnLoadCommitted(
net::ERR_NAME_NOT_RESOLVED,
net::ResolveErrorInfo(net::ERR_CERT_COMMON_NAME_INVALID,
true /* is_secure_network_error */));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
}
// The secure DNS config is configured correctly. The SSL timer triggers a
// captive portal probe. This probe finds a captive portal and completes before
// the page loads with a secure DNS network error, which does not trigger
// another captive portal probe. The user then logs in, causing a page reload.
TEST_F(CaptivePortalTabReloaderTest,
HttpsSecureDnsConfigPageLoadsAfterTimerTriggeredResults) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The probe finds a captive portal and opens a login page.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The original navigation encounters a secure DNS network error. The error
// page commits but does not trigger another captive portal check.
tab_reloader().OnLoadCommitted(
net::ERR_NAME_NOT_RESOLVED,
net::ResolveErrorInfo(net::ERR_CERT_COMMON_NAME_INVALID,
true /* is_secure_network_error */));
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The user logs on from another tab, and the page is reloaded.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// The user logs in in a different tab, before the page loads with a secure
// DNS network error. A reload should occur when the page commits.
TEST_F(CaptivePortalTabReloaderTest, HttpsSecureDnsConfigErrorAlreadyLoggedIn) {
tab_reloader().OnLoadStart(true);
// The user logs in from another tab before the tab errors out.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should trigger a reload.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnLoadCommitted(
net::ERR_NAME_NOT_RESOLVED,
net::ResolveErrorInfo(net::ERR_CERT_COMMON_NAME_INVALID,
true /* is_secure_network_error */));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// An SSL protocol error triggers a captive portal check behind a captive
// portal. The user then logs in.
TEST_F(CaptivePortalTabReloaderTest, SSLProtocolError) {
tab_reloader().OnLoadStart(true);
// The error page commits, which should trigger a captive portal check,
// since the timer's still running.
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
tab_reloader().OnLoadCommitted(net::ERR_SSL_PROTOCOL_ERROR,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The captive portal service detects a captive portal. The TabReloader
// should try and create a new login tab in response.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The user logs on from another tab, and a captive portal check is triggered.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// An SSL protocol error triggers a captive portal check behind a captive
// portal. The user logs in before the results from the captive portal check
// completes.
TEST_F(CaptivePortalTabReloaderTest, SSLProtocolErrorFastLogin) {
tab_reloader().OnLoadStart(true);
// The error page commits, which should trigger a captive portal check,
// since the timer's still running.
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
tab_reloader().OnLoadCommitted(net::ERR_SSL_PROTOCOL_ERROR,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The user has logged in from another tab. The tab automatically reloads.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// An SSL protocol error triggers a captive portal check behind a captive
// portal. The user logs in before the results from the captive portal check
// completes. This case is probably not too likely, but should be handled.
TEST_F(CaptivePortalTabReloaderTest, SSLProtocolErrorAlreadyLoggedIn) {
tab_reloader().OnLoadStart(true);
// The user logs in from another tab before the tab errors out.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should trigger a reload.
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
tab_reloader().OnLoadCommitted(net::ERR_SSL_PROTOCOL_ERROR,
net::ResolveErrorInfo(net::OK));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate the case that a user has already logged in before the tab receives a
// captive portal result, but a RESULT_BEHIND_CAPTIVE_PORTAL was received
// before the tab started loading.
TEST_F(CaptivePortalTabReloaderTest, AlreadyLoggedIn) {
tab_reloader().OnLoadStart(true);
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The user has already logged in. Since the last result found a captive
// portal, the tab will be reloaded if a timeout is committed.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should start an asynchronous reload.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Same as above, except the result is received even before the timer triggers,
// due to a captive portal test request from some external source, like a login
// tab.
TEST_F(CaptivePortalTabReloaderTest, AlreadyLoggedInBeforeTimerTriggers) {
tab_reloader().OnLoadStart(true);
// The user has already logged in. Since the last result indicated there is
// a captive portal, the tab will be reloaded if it times out.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The error page commits, which should start an asynchronous reload.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate the user logging in while the timer is still running. May happen
// if the tab is reloaded just before logging in on another tab.
TEST_F(CaptivePortalTabReloaderTest, LoginWhileTimerRunning) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
// The user has already logged in.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should start an asynchronous reload.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate a captive portal being detected while the time is still running.
// The captive portal check triggered by the timer detects the captive portal
// again, and then the user logs in.
TEST_F(CaptivePortalTabReloaderTest, BehindPortalResultWhileTimerRunning) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
// The user is behind a captive portal, but since the tab hasn't timed out,
// the message is ignored.
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
// The rest proceeds as normal.
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The captive portal service detects a captive portal, and this time the
// tab tries to create a login tab.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The user logs on from another tab, and a captive portal check is triggered.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should start an asynchronous reload.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// The CaptivePortalService detects the user has logged in to a captive portal
// while the timer is still running, but the original load succeeds, so no
// reload is done.
TEST_F(CaptivePortalTabReloaderTest, LogInWhileTimerRunningNoError) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
// The user has already logged in.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The page successfully commits, so no reload is triggered.
tab_reloader().OnLoadCommitted(net::OK, net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate an HTTP redirect to HTTPS, when the Internet is connected.
TEST_F(CaptivePortalTabReloaderTest, HttpToHttpsRedirectInternetConnected) {
tab_reloader().OnLoadStart(false);
// There should be no captive portal check pending.
base::RunLoop().RunUntilIdle();
// HTTP to HTTPS redirect.
tab_reloader().OnRedirect(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_TRUE(tab_reloader().TimerRunning());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
tab_reloader().OnLoadCommitted(net::OK, net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate an HTTP redirect to HTTPS and subsequent Login, when the user logs
// in before the original page commits.
TEST_F(CaptivePortalTabReloaderTest, HttpToHttpsRedirectLogin) {
tab_reloader().OnLoadStart(false);
// There should be no captive portal check pending.
base::RunLoop().RunUntilIdle();
// HTTP to HTTPS redirect.
tab_reloader().OnRedirect(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), CheckForCaptivePortal()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(tab_reloader().TimerRunning());
EXPECT_EQ(CaptivePortalTabReloader::STATE_MAYBE_BROKEN_BY_PORTAL,
tab_reloader().state());
// The captive portal service detects a captive portal. The TabReloader
// should try and create a new login tab in response.
EXPECT_CALL(tab_reloader(), MaybeOpenCaptivePortalLoginTab()).Times(1);
tab_reloader().OnCaptivePortalResults(RESULT_INTERNET_CONNECTED,
RESULT_BEHIND_CAPTIVE_PORTAL);
EXPECT_EQ(CaptivePortalTabReloader::STATE_BROKEN_BY_PORTAL,
tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// The user logs on from another tab, and a captive portal check is triggered.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
// The error page commits, which should start an asynchronous reload.
tab_reloader().OnLoadCommitted(net::ERR_CONNECTION_TIMED_OUT,
net::ResolveErrorInfo(net::OK));
EXPECT_EQ(CaptivePortalTabReloader::STATE_NEEDS_RELOAD,
tab_reloader().state());
EXPECT_CALL(tab_reloader(), ReloadTab()).Times(1);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Simulate the case where an HTTPs page redirects to an HTTPS page, before
// the timer triggers.
TEST_F(CaptivePortalTabReloaderTest, HttpsToHttpRedirect) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
tab_reloader().OnRedirect(false);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// There should be no captive portal check pending after the redirect.
base::RunLoop().RunUntilIdle();
// Logging in shouldn't do anything.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
// Check that an HTTPS to HTTPS redirect results in no timer running.
TEST_F(CaptivePortalTabReloaderTest, HttpsToHttpsRedirect) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
tab_reloader().OnRedirect(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// Nothing should happen.
base::RunLoop().RunUntilIdle();
}
// Check that an HTTPS to HTTP to HTTPS redirect results in no timer running.
TEST_F(CaptivePortalTabReloaderTest, HttpsToHttpToHttpsRedirect) {
tab_reloader().OnLoadStart(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_TIMER_RUNNING,
tab_reloader().state());
tab_reloader().OnRedirect(false);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
tab_reloader().OnRedirect(true);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// Nothing should happen.
base::RunLoop().RunUntilIdle();
}
// Check that an HTTP to HTTP redirect results in the timer not running.
TEST_F(CaptivePortalTabReloaderTest, HttpToHttpRedirect) {
tab_reloader().OnLoadStart(false);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
tab_reloader().OnRedirect(false);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
EXPECT_FALSE(tab_reloader().TimerRunning());
// There should be no captive portal check pending after the redirect.
base::RunLoop().RunUntilIdle();
// Logging in shouldn't do anything.
tab_reloader().OnCaptivePortalResults(RESULT_BEHIND_CAPTIVE_PORTAL,
RESULT_INTERNET_CONNECTED);
EXPECT_EQ(CaptivePortalTabReloader::STATE_NONE, tab_reloader().state());
}
} // namespace captive_portal
|