1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/cronet/android/cronet_base_feature.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/test/scoped_feature_list.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cronet {
namespace {
using ::org::chromium::net::httpflags::BaseFeatureOverrides;
using ::testing::IsEmpty;
using ::testing::Pair;
using ::testing::UnorderedElementsAre;
constexpr char kTestFeatureDisabledByDefaultName[] =
"CronetBaseFeatureTestFeatureDisabledByDefault";
BASE_FEATURE(kTestFeatureDisabledByDefault,
kTestFeatureDisabledByDefaultName,
base::FEATURE_DISABLED_BY_DEFAULT);
constexpr char kTestFeatureEnabledByDefaultName[] =
"CronetBaseFeatureTestFeatureEnabledByDefault";
BASE_FEATURE(kTestFeatureEnabledByDefault,
kTestFeatureEnabledByDefaultName,
base::FEATURE_ENABLED_BY_DEFAULT);
constexpr char kTestFeatureWithParamsName[] =
"CronetBaseFeatureTestFeatureWithParams";
BASE_FEATURE(kTestFeatureWithParams,
kTestFeatureWithParamsName,
base::FEATURE_DISABLED_BY_DEFAULT);
constexpr char kTestParamName[] = "test_param";
constexpr char kTestParamDefaultValue[] = "test_param_default_value";
constexpr base::FeatureParam<std::string> kTestParam{
&kTestFeatureWithParams, kTestParamName, kTestParamDefaultValue};
TEST(ApplyBaseFeatureOverrides, NoOpOnEmptyOverrides) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
ApplyBaseFeatureOverrides(BaseFeatureOverrides());
EXPECT_FALSE(base::FeatureList::IsEnabled(kTestFeatureDisabledByDefault));
EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureEnabledByDefault));
}
TEST(ApplyBaseFeatureOverrides, OverridesFeatureToEnabled) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
BaseFeatureOverrides overrides;
(*overrides.mutable_feature_states())[kTestFeatureDisabledByDefaultName]
.set_enabled(true);
ApplyBaseFeatureOverrides(overrides);
EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureDisabledByDefault));
}
TEST(ApplyBaseFeatureOverrides, OverridesFeatureToDisabled) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
BaseFeatureOverrides overrides;
(*overrides.mutable_feature_states())[kTestFeatureEnabledByDefaultName]
.set_enabled(false);
ApplyBaseFeatureOverrides(overrides);
EXPECT_FALSE(base::FeatureList::IsEnabled(kTestFeatureEnabledByDefault));
}
TEST(ApplyBaseFeatureOverrides, DoesNotOverrideFeature) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
BaseFeatureOverrides overrides;
(*overrides.mutable_feature_states())[kTestFeatureEnabledByDefaultName];
ApplyBaseFeatureOverrides(overrides);
EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureEnabledByDefault));
}
TEST(ApplyBaseFeatureOverrides, NoOpIfBaseFeatureAlreadyInitialized) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithEmptyFeatureAndFieldTrialLists();
BaseFeatureOverrides overrides;
(*overrides.mutable_feature_states())[kTestFeatureDisabledByDefaultName]
.set_enabled(true);
ApplyBaseFeatureOverrides(overrides);
EXPECT_FALSE(base::FeatureList::IsEnabled(kTestFeatureDisabledByDefault));
}
TEST(ApplyBaseFeatureOverrides,
DoesNotAssociateFeatureParamsIfNoParamsAreProvided) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
BaseFeatureOverrides overrides;
(*overrides.mutable_feature_states())[kTestFeatureWithParamsName].set_enabled(
true);
ApplyBaseFeatureOverrides(overrides);
base::FieldTrialParams params;
EXPECT_FALSE(
base::GetFieldTrialParamsByFeature(kTestFeatureWithParams, ¶ms));
EXPECT_THAT(params, IsEmpty());
EXPECT_EQ(kTestParam.Get(), kTestParamDefaultValue);
}
TEST(ApplyBaseFeatureOverrides, AssociatesFeatureParams) {
base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
BaseFeatureOverrides overrides;
constexpr char kParamValue[] = "test_param_value";
auto& feature_state =
(*overrides.mutable_feature_states())[kTestFeatureWithParamsName];
feature_state.set_enabled(true);
(*feature_state.mutable_params())[kTestParamName] = kParamValue;
ApplyBaseFeatureOverrides(overrides);
base::FieldTrialParams params;
EXPECT_TRUE(
base::GetFieldTrialParamsByFeature(kTestFeatureWithParams, ¶ms));
EXPECT_THAT(params, UnorderedElementsAre(Pair(kTestParamName, kParamValue)));
EXPECT_EQ(kTestParam.Get(), kParamValue);
}
} // namespace
} // namespace cronet
|
