File: collaboration_group_sync_bridge_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (472 lines) | stat: -rw-r--r-- 18,602 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "components/data_sharing/internal/collaboration_group_sync_bridge.h"

#include <algorithm>
#include <memory>
#include <set>

#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/mock_callback.h"
#include "base/test/protobuf_matchers.h"
#include "base/test/task_environment.h"
#include "components/sync/model/data_batch.h"
#include "components/sync/model/data_type_store.h"
#include "components/sync/protocol/collaboration_group_specifics.pb.h"
#include "components/sync/test/data_type_store_test_util.h"
#include "components/sync/test/mock_data_type_local_change_processor.h"
#include "components/sync/test/test_matchers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace data_sharing {
namespace {

using base::test::EqualsProto;
using syncer::HasInitialSyncDone;
using syncer::IsEmptyMetadataBatch;
using syncer::NoModelError;
using testing::_;
using testing::ElementsAre;
using testing::Eq;
using testing::InvokeWithoutArgs;
using testing::IsEmpty;
using testing::IsNull;
using testing::Sequence;
using testing::SizeIs;
using testing::UnorderedElementsAre;

sync_pb::CollaborationGroupSpecifics MakeSpecifics(
    const GroupId& id,
    const base::Time& changed_at = base::Time::Now()) {
  sync_pb::CollaborationGroupSpecifics result;
  result.set_collaboration_id(id.value());
  result.set_changed_at_timestamp_millis_since_unix_epoch(
      changed_at.InMillisecondsSinceUnixEpoch());
  return result;
}

syncer::EntityData EntityDataFromSpecifics(
    const sync_pb::CollaborationGroupSpecifics& specifics) {
  syncer::EntityData entity_data;
  *entity_data.specifics.mutable_collaboration_group() = specifics;
  entity_data.name = specifics.collaboration_id();
  return entity_data;
}

std::unique_ptr<syncer::EntityChange> EntityChangeAddFromSpecifics(
    const sync_pb::CollaborationGroupSpecifics& specifics) {
  return syncer::EntityChange::CreateAdd(specifics.collaboration_id(),
                                         EntityDataFromSpecifics(specifics));
}

std::unique_ptr<syncer::EntityChange> EntityChangeUpdateFromSpecifics(
    const sync_pb::CollaborationGroupSpecifics& specifics) {
  return syncer::EntityChange::CreateUpdate(specifics.collaboration_id(),
                                            EntityDataFromSpecifics(specifics));
}

std::unique_ptr<syncer::EntityChange> EntityChangeDeleteFromSpecifics(
    const sync_pb::CollaborationGroupSpecifics& specifics) {
  return syncer::EntityChange::CreateDelete(specifics.collaboration_id(),
                                            syncer::EntityData());
}

std::vector<sync_pb::CollaborationGroupSpecifics> ExtractSpecificsFromDataBatch(
    std::unique_ptr<syncer::DataBatch> data_batch) {
  std::vector<sync_pb::CollaborationGroupSpecifics> result;
  while (data_batch->HasNext()) {
    result.push_back(
        data_batch->Next().second->specifics.collaboration_group());
  }
  return result;
}

class MockObserver : public CollaborationGroupSyncBridge::Observer {
 public:
  MockObserver() = default;
  ~MockObserver() override = default;

  MOCK_METHOD(void,
              OnGroupsUpdated,
              (const std::vector<GroupId>&,
               const std::vector<GroupId>&,
               const std::vector<GroupId>&),
              (override));
  MOCK_METHOD(void, OnCollaborationGroupSyncDataLoaded, (), (override));
  MOCK_METHOD(void, OnSyncBridgeUpdateTypeChanged, (SyncBridgeUpdateType));
};

class CollaborationGroupSyncBridgeTest : public testing::Test {
 public:
  CollaborationGroupSyncBridgeTest()
      : data_type_store_(
            syncer::DataTypeStoreTestUtil::CreateInMemoryStoreForTest()) {}
  ~CollaborationGroupSyncBridgeTest() override = default;

  void TearDown() override { bridge_->RemoveObserver(&observer_); }

  void CreateBridgeAndWaitForReadyToSync() {
    base::RunLoop run_loop;
    ON_CALL(mock_processor_, ModelReadyToSync)
        .WillByDefault(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));

    bridge_ = std::make_unique<CollaborationGroupSyncBridge>(
        mock_processor_.CreateForwardingProcessor(),
        syncer::DataTypeStoreTestUtil::FactoryForForwardingStore(
            data_type_store_.get()));

    bridge_->AddObserver(&observer_);

    // Wait for ready to sync.
    run_loop.Run();
  }

  void RestartBridgeAndWaitForReadyToSync() {
    bridge_->RemoveObserver(&observer_);
    CreateBridgeAndWaitForReadyToSync();
  }

  CollaborationGroupSyncBridge& bridge() { return *bridge_; }

  testing::NiceMock<syncer::MockDataTypeLocalChangeProcessor>&
  mock_processor() {
    return mock_processor_;
  }

  testing::NiceMock<MockObserver>& observer() { return observer_; }

  syncer::DataTypeStore& data_type_store() { return *data_type_store_; }

  std::vector<sync_pb::CollaborationGroupSpecifics> GetBridgeSpecifics() {
    return ExtractSpecificsFromDataBatch(bridge().GetAllDataForDebugging());
  }

 private:
  base::test::SingleThreadTaskEnvironment task_environment_;

  std::unique_ptr<syncer::DataTypeStore> data_type_store_;
  testing::NiceMock<syncer::MockDataTypeLocalChangeProcessor> mock_processor_;
  testing::NiceMock<MockObserver> observer_;
  std::unique_ptr<CollaborationGroupSyncBridge> bridge_;
};

TEST_F(CollaborationGroupSyncBridgeTest, ShouldReturnClientTag) {
  CreateBridgeAndWaitForReadyToSync();
  EXPECT_TRUE(bridge().SupportsGetClientTag());
  const GroupId id("collaboration1");
  EXPECT_THAT(bridge().GetClientTag(EntityDataFromSpecifics(MakeSpecifics(id))),
              Eq(id.value()));
}

TEST_F(CollaborationGroupSyncBridgeTest, ShouldReturnStorageKey) {
  CreateBridgeAndWaitForReadyToSync();
  EXPECT_TRUE(bridge().SupportsGetStorageKey());
  const GroupId id("collaboration1");
  EXPECT_THAT(
      bridge().GetStorageKey(EntityDataFromSpecifics(MakeSpecifics(id))),
      Eq(id.value()));
}

TEST_F(CollaborationGroupSyncBridgeTest, ShouldValidateEntityData) {
  CreateBridgeAndWaitForReadyToSync();
  EXPECT_TRUE(bridge().IsEntityDataValid(
      EntityDataFromSpecifics(MakeSpecifics(GroupId("id")))));
  // Specifics without `collaboration_id` considered invalid.
  EXPECT_FALSE(bridge().IsEntityDataValid(
      EntityDataFromSpecifics(sync_pb::CollaborationGroupSpecifics())));
}

TEST_F(CollaborationGroupSyncBridgeTest, ShouldMergeFullSyncData) {
  CreateBridgeAndWaitForReadyToSync();

  const GroupId id1("id1");
  const GroupId id2("id2");

  const sync_pb::CollaborationGroupSpecifics specifics1 =
      MakeSpecifics(id1, base::Time::FromMillisecondsSinceUnixEpoch(1000));
  const sync_pb::CollaborationGroupSpecifics specifics2 =
      MakeSpecifics(id2, base::Time::FromMillisecondsSinceUnixEpoch(2000));

  syncer::EntityChangeList entity_changes;
  entity_changes.push_back(EntityChangeAddFromSpecifics(specifics1));
  entity_changes.push_back(EntityChangeAddFromSpecifics(specifics2));

  Sequence s;
  EXPECT_CALL(observer(), OnSyncBridgeUpdateTypeChanged(
                              Eq(SyncBridgeUpdateType::kInitialMerge)))
      .InSequence(s);
  EXPECT_CALL(observer(), OnSyncBridgeUpdateTypeChanged(
                              Eq(SyncBridgeUpdateType::kDefaultState)))
      .InSequence(s);

  // Mimics initial sync with two entities described above.
  bridge().MergeFullSyncData(bridge().CreateMetadataChangeList(),
                             std::move(entity_changes));

  // Verify that bridge stores these two entities and nothing else.
  EXPECT_THAT(
      GetBridgeSpecifics(),
      UnorderedElementsAre(EqualsProto(specifics1), EqualsProto(specifics2)));
  EXPECT_THAT(bridge().GetCollaborationGroupIds(),
              UnorderedElementsAre(id1, id2));
}

TEST_F(CollaborationGroupSyncBridgeTest,
       ShouldApplyIncrementalSyncChangesAndNotifyObserver) {
  EXPECT_CALL(observer(), OnCollaborationGroupSyncDataLoaded);
  CreateBridgeAndWaitForReadyToSync();
  testing::Mock::VerifyAndClearExpectations(&observer());

  const GroupId id1("id1");
  const GroupId id2("id2");

  const sync_pb::CollaborationGroupSpecifics specifics1 =
      MakeSpecifics(id1, base::Time::FromMillisecondsSinceUnixEpoch(1000));
  sync_pb::CollaborationGroupSpecifics specifics2 =
      MakeSpecifics(id2, base::Time::FromMillisecondsSinceUnixEpoch(2000));

  syncer::EntityChangeList intitial_entity_changes;
  intitial_entity_changes.push_back(EntityChangeAddFromSpecifics(specifics1));
  intitial_entity_changes.push_back(EntityChangeAddFromSpecifics(specifics2));

  // Mimics initial sync with two entities described above.
  EXPECT_CALL(observer(),
              OnGroupsUpdated(
                  /*added_group_ids*/ UnorderedElementsAre(id1, id2), _, _));
  bridge().MergeFullSyncData(bridge().CreateMetadataChangeList(),
                             std::move(intitial_entity_changes));
  testing::Mock::VerifyAndClearExpectations(&observer());

  // Verify that bridge stores these two entities and nothing else.
  EXPECT_THAT(
      GetBridgeSpecifics(),
      UnorderedElementsAre(EqualsProto(specifics1), EqualsProto(specifics2)));

  // Mimic incremental update: `specifics1` is deleted, `specifics2` is updated,
  // `specifics3` is added.
  const GroupId id3("id3");
  const sync_pb::CollaborationGroupSpecifics specifics3 =
      MakeSpecifics(id3, base::Time::FromMillisecondsSinceUnixEpoch(3000));
  specifics2.set_changed_at_timestamp_millis_since_unix_epoch(4000);

  syncer::EntityChangeList incremental_changes;
  incremental_changes.push_back(EntityChangeDeleteFromSpecifics(specifics1));
  incremental_changes.push_back(EntityChangeUpdateFromSpecifics(specifics2));
  incremental_changes.push_back(EntityChangeAddFromSpecifics(specifics3));

  EXPECT_CALL(observer(),
              OnGroupsUpdated(/*added_group_ids*/ ElementsAre(id3),
                              /*updated_group_ids*/ ElementsAre(id2),
                              /*deleted_group_ids*/ ElementsAre(id1)));
  bridge().ApplyIncrementalSyncChanges(bridge().CreateMetadataChangeList(),
                                       std::move(incremental_changes));

  // Verify that bridge stores`specifics3` and updated `specifics2`.
  EXPECT_THAT(
      GetBridgeSpecifics(),
      UnorderedElementsAre(EqualsProto(specifics2), EqualsProto(specifics3)));
  EXPECT_THAT(bridge().GetCollaborationGroupIds(),
              UnorderedElementsAre(id2, id3));
}

TEST_F(CollaborationGroupSyncBridgeTest, ShouldStoreAndLoadMetadata) {
  // The first call is expected in the very beginning when there is no metadata
  // yet. Use InSequence to guarantee the sequence of the expected calls.
  testing::InSequence sequence;
  EXPECT_CALL(mock_processor(), ModelReadyToSync(IsEmptyMetadataBatch()));

  CreateBridgeAndWaitForReadyToSync();

  // Simulate the initial sync merge.
  std::unique_ptr<syncer::MetadataChangeList> metadata_changes =
      bridge().CreateMetadataChangeList();
  sync_pb::DataTypeState data_type_state;
  data_type_state.set_initial_sync_state(
      sync_pb::DataTypeState::INITIAL_SYNC_DONE);
  metadata_changes->UpdateDataTypeState(data_type_state);
  bridge().MergeFullSyncData(std::move(metadata_changes),
                             syncer::EntityChangeList());

  // The following call should happen on the second initialization, and it
  // should have non-empty metadata.
  EXPECT_CALL(mock_processor(),
              ModelReadyToSync(MetadataBatchContains(HasInitialSyncDone(),
                                                     /*entities*/ IsEmpty())));
  // Simulate restarting the sync bridge.
  CreateBridgeAndWaitForReadyToSync();
}

TEST_F(CollaborationGroupSyncBridgeTest, ShouldStoreAndLoadData) {
  CreateBridgeAndWaitForReadyToSync();

  const GroupId id1("id1");
  const GroupId id2("id2");

  const sync_pb::CollaborationGroupSpecifics specifics1 =
      MakeSpecifics(id1, base::Time::FromMillisecondsSinceUnixEpoch(1000));
  sync_pb::CollaborationGroupSpecifics specifics2 =
      MakeSpecifics(id2, base::Time::FromMillisecondsSinceUnixEpoch(2000));

  syncer::EntityChangeList intitial_entity_changes;
  intitial_entity_changes.push_back(EntityChangeAddFromSpecifics(specifics1));
  intitial_entity_changes.push_back(EntityChangeAddFromSpecifics(specifics2));

  // Mimics initial sync with two entities described above.
  bridge().MergeFullSyncData(bridge().CreateMetadataChangeList(),
                             std::move(intitial_entity_changes));

  // Simulate restarting the sync bridge.
  RestartBridgeAndWaitForReadyToSync();

  // Verify that bridge still stores these two entities.
  EXPECT_THAT(
      GetBridgeSpecifics(),
      UnorderedElementsAre(EqualsProto(specifics1), EqualsProto(specifics2)));
  EXPECT_THAT(bridge().GetCollaborationGroupIds(),
              UnorderedElementsAre(id1, id2));
}

TEST_F(CollaborationGroupSyncBridgeTest, ShouldApplyDisableSyncChanges) {
  CreateBridgeAndWaitForReadyToSync();

  const GroupId id1("id1");
  const GroupId id2("id2");

  // Mimics initial sync with some entities and metadata.
  std::unique_ptr<syncer::MetadataChangeList> metadata_changes =
      bridge().CreateMetadataChangeList();
  sync_pb::DataTypeState data_type_state;
  data_type_state.set_initial_sync_state(
      sync_pb::DataTypeState::INITIAL_SYNC_DONE);
  metadata_changes->UpdateDataTypeState(data_type_state);

  syncer::EntityChangeList intitial_entity_changes;
  intitial_entity_changes.push_back(
      EntityChangeAddFromSpecifics(MakeSpecifics(id1)));
  intitial_entity_changes.push_back(
      EntityChangeAddFromSpecifics(MakeSpecifics(id2)));

  // Mimics initial sync with some entities and metadata.
  bridge().MergeFullSyncData(std::move(metadata_changes),
                             std::move(intitial_entity_changes));

  testing::Mock::VerifyAndClearExpectations(&observer());
  EXPECT_CALL(
      observer(),
      OnGroupsUpdated(/*added_group_ids*/ IsEmpty(),
                      /*updated_group_ids*/ IsEmpty(),
                      /*deleted_group_ids*/ UnorderedElementsAre(id1, id2)));
  Sequence s;
  EXPECT_CALL(observer(), OnSyncBridgeUpdateTypeChanged(
                              Eq(SyncBridgeUpdateType::kDisableSync)))
      .InSequence(s);
  EXPECT_CALL(observer(), OnSyncBridgeUpdateTypeChanged(
                              Eq(SyncBridgeUpdateType::kDefaultState)))
      .InSequence(s);

  // Should clear all data and metadata, `delete_metadata_change_list` is not
  // relevant for this implementation, so nullptr is okay.
  bridge().ApplyDisableSyncChanges(/*delete_metadata_change_list=*/nullptr);

  // Verify that bridge doesn't store specifics.
  EXPECT_THAT(GetBridgeSpecifics(), IsEmpty());

  // Verify that data and metadata was removed from disk as well.
  {
    base::RunLoop run_loop;
    base::MockOnceCallback<syncer::DataTypeStore::ReadAllDataCallback::RunType>
        get_all_data_callback;
    EXPECT_CALL(get_all_data_callback,
                Run(NoModelError(), /*data_records*/ Pointee(IsEmpty())))
        .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
    data_type_store().ReadAllData(get_all_data_callback.Get());
    run_loop.Run();
  }

  // Verify that metadata was removed from disk.
  {
    base::RunLoop run_loop;
    base::MockOnceCallback<syncer::DataTypeStore::ReadMetadataCallback::RunType>
        get_metadata_callback;
    EXPECT_CALL(get_metadata_callback,
                Run(NoModelError(), IsEmptyMetadataBatch()))
        .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
    data_type_store().ReadAllMetadata(get_metadata_callback.Get());
    run_loop.Run();
  }
}

TEST(CollaborationGroupSyncBridgeNoFixtureTest, ShouldReportIsDataLoaded) {
  base::test::SingleThreadTaskEnvironment task_environment;

  std::unique_ptr<syncer::DataTypeStore> data_type_store =
      syncer::DataTypeStoreTestUtil::CreateInMemoryStoreForTest();
  testing::NiceMock<syncer::MockDataTypeLocalChangeProcessor> mock_processor;
  testing::NiceMock<MockObserver> observer;

  CollaborationGroupSyncBridge bridge(
      mock_processor.CreateForwardingProcessor(),
      syncer::DataTypeStoreTestUtil::FactoryForForwardingStore(
          data_type_store.get()));
  bridge.AddObserver(&observer);

  base::RunLoop run_loop;
  ON_CALL(mock_processor, ModelReadyToSync)
      .WillByDefault(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));

  // Loading is asynchronous, so data loading shouldn't happen yet.
  EXPECT_FALSE(bridge.IsDataLoaded());

  // Data should be loaded by the time ModelReadyToSync() is called.
  EXPECT_CALL(observer, OnCollaborationGroupSyncDataLoaded);
  run_loop.Run();
  EXPECT_TRUE(bridge.IsDataLoaded());
}

TEST_F(CollaborationGroupSyncBridgeTest, RemoveGroupLocally) {
  EXPECT_CALL(observer(), OnCollaborationGroupSyncDataLoaded);
  CreateBridgeAndWaitForReadyToSync();
  testing::Mock::VerifyAndClearExpectations(&observer());

  const GroupId id1("id1");
  const GroupId id2("id2");

  const sync_pb::CollaborationGroupSpecifics specifics1 =
      MakeSpecifics(id1, base::Time::FromMillisecondsSinceUnixEpoch(1000));
  sync_pb::CollaborationGroupSpecifics specifics2 =
      MakeSpecifics(id2, base::Time::FromMillisecondsSinceUnixEpoch(2000));

  syncer::EntityChangeList intitial_entity_changes;
  intitial_entity_changes.push_back(EntityChangeAddFromSpecifics(specifics1));
  intitial_entity_changes.push_back(EntityChangeAddFromSpecifics(specifics2));

  // Mimics initial sync with two entities described above.
  EXPECT_CALL(observer(),
              OnGroupsUpdated(
                  /*added_group_ids*/ UnorderedElementsAre(id1, id2), _, _));
  bridge().MergeFullSyncData(bridge().CreateMetadataChangeList(),
                             std::move(intitial_entity_changes));
  testing::Mock::VerifyAndClearExpectations(&observer());

  // Verify that bridge stores these two entities and nothing else.
  EXPECT_THAT(
      GetBridgeSpecifics(),
      UnorderedElementsAre(EqualsProto(specifics1), EqualsProto(specifics2)));

  EXPECT_CALL(observer(),
              OnGroupsUpdated(/*added_group_ids*/ IsEmpty(),
                              /*updated_group_ids*/ IsEmpty(),
                              /*deleted_group_ids*/ ElementsAre(id2)));
  bridge().RemoveGroupLocally(id2);

  // Verify that bridge stores`specifics3` and updated `specifics2`.
  EXPECT_THAT(GetBridgeSpecifics(), ElementsAre(EqualsProto(specifics1)));
  EXPECT_THAT(bridge().GetCollaborationGroupIds(), ElementsAre(id1));
}

}  // namespace
}  // namespace data_sharing