1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/data_sharing/internal/group_data_model.h"
#include <cstdint>
#include <memory>
#include "base/files/scoped_temp_dir.h"
#include "base/files/scoped_temp_file.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/gmock_callback_support.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "components/data_sharing/internal/collaboration_group_sync_bridge.h"
#include "components/data_sharing/public/features.h"
#include "components/data_sharing/public/group_data.h"
#include "components/data_sharing/test_support/fake_data_sharing_sdk_delegate.h"
#include "components/sync/model/entity_change.h"
#include "components/sync/test/data_type_store_test_util.h"
#include "components/sync/test/mock_data_type_local_change_processor.h"
#include "google_apis/gaia/gaia_id.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace data_sharing {
namespace {
using base::test::RunClosure;
using testing::_;
using testing::ElementsAre;
using testing::Eq;
using testing::IsEmpty;
using testing::Optional;
bool OptionalGroupMetadataDataMatches(std::optional<GroupData> a,
std::optional<GroupData> b) {
if (!a.has_value() && !b.has_value()) {
return true;
}
if (a.has_value() != b.has_value()) {
return false;
}
// Both have values, compare the GroupData.
return a->group_token.group_id == b->group_token.group_id &&
a->group_token.access_token == b->group_token.access_token &&
a->display_name == b->display_name;
}
MATCHER_P(OptionalGroupMetadataDataEq, expected_group_data, "") {
return OptionalGroupMetadataDataMatches(expected_group_data, arg);
}
// TODO(crbug.com/301390275): move helpers to work with CollaborationGroup
// entities to test utils files, they are used across multiple files.
sync_pb::CollaborationGroupSpecifics MakeSpecifics(
const GroupId& id,
const int64_t& changed_at_millis_since_unix_epoch) {
sync_pb::CollaborationGroupSpecifics result;
result.set_collaboration_id(id.value());
result.set_changed_at_timestamp_millis_since_unix_epoch(
changed_at_millis_since_unix_epoch);
result.set_consistency_token(
base::NumberToString(changed_at_millis_since_unix_epoch));
return result;
}
syncer::EntityData EntityDataFromSpecifics(
const sync_pb::CollaborationGroupSpecifics& specifics) {
syncer::EntityData entity_data;
*entity_data.specifics.mutable_collaboration_group() = specifics;
entity_data.name = specifics.collaboration_id();
return entity_data;
}
std::unique_ptr<syncer::EntityChange> EntityChangeAddFromSpecifics(
const sync_pb::CollaborationGroupSpecifics& specifics) {
return syncer::EntityChange::CreateAdd(specifics.collaboration_id(),
EntityDataFromSpecifics(specifics));
}
std::unique_ptr<syncer::EntityChange> EntityChangeUpdateFromSpecifics(
const sync_pb::CollaborationGroupSpecifics& specifics) {
return syncer::EntityChange::CreateUpdate(specifics.collaboration_id(),
EntityDataFromSpecifics(specifics));
}
std::unique_ptr<syncer::EntityChange> EntityChangeDeleteFromSpecifics(
const sync_pb::CollaborationGroupSpecifics& specifics) {
return syncer::EntityChange::CreateDelete(specifics.collaboration_id(),
syncer::EntityData());
}
MATCHER(NotNullTime, "") {
return !arg.is_null();
}
MATCHER_P(HasDisplayName, expected_name, "") {
return arg.display_name == expected_name;
}
MATCHER_P(HasMemberWithGaiaId, expected_gaia_id, "") {
for (const auto& member : arg.members) {
if (member.gaia_id == expected_gaia_id) {
return true;
}
}
return false;
}
MATCHER_P3(GroupEventIs, group_id, event_type, affected_member_gaia_id, "") {
return arg.group_id == group_id && arg.event_type == event_type &&
arg.affected_member_gaia_id == affected_member_gaia_id &&
!arg.event_time.is_null();
}
class MockModelObserver : public GroupDataModel::Observer {
public:
MockModelObserver() = default;
~MockModelObserver() override = default;
MOCK_METHOD(void, OnModelLoaded, (), (override));
MOCK_METHOD(void,
OnGroupAdded,
(const GroupId& group_id, const base::Time& event_time),
(override));
MOCK_METHOD(void,
OnGroupUpdated,
(const GroupId& group_id, const base::Time& event_time),
(override));
MOCK_METHOD(void,
OnGroupDeleted,
(const GroupId& group_id,
const std::optional<GroupData>& group_data,
const base::Time& event_time),
(override));
MOCK_METHOD(void,
OnMemberAdded,
(const GroupId&, const GaiaId&, const base::Time&),
(override));
MOCK_METHOD(void,
OnMemberRemoved,
(const GroupId&, const GaiaId&, const base::Time&),
(override));
MOCK_METHOD(void, OnSyncBridgeUpdateTypeChanged, (SyncBridgeUpdateType));
};
class GroupDataModelTest : public testing::Test {
public:
GroupDataModelTest()
: data_type_store_(
syncer::DataTypeStoreTestUtil::CreateInMemoryStoreForTest()) {
EXPECT_TRUE(data_sharing_dir_.CreateUniqueTempDir());
}
~GroupDataModelTest() override = default;
void SetUp() override {
base::RunLoop run_loop;
ON_CALL(mock_processor_, ModelReadyToSync)
.WillByDefault(RunClosure(run_loop.QuitClosure()));
collaboration_group_bridge_ =
std::make_unique<CollaborationGroupSyncBridge>(
mock_processor_.CreateForwardingProcessor(),
syncer::DataTypeStoreTestUtil::FactoryForForwardingStore(
data_type_store_.get()));
run_loop.Run();
// Mimic that initial sync is completed with no data.
collaboration_group_bridge_->MergeFullSyncData(
collaboration_group_bridge_->CreateMetadataChangeList(),
syncer::EntityChangeList());
model_ = std::make_unique<GroupDataModel>(data_sharing_dir_.GetPath(),
collaboration_group_bridge_.get(),
&sdk_delegate_);
model_->AddObserver(&observer_);
}
void TearDown() override {
// Needed to ensure that `data_sharing_dir_` outlives DB tasks, that runs on
// a dedicated sequence.
ShutdownModel();
}
GroupDataModel& model() { return *model_; }
testing::NiceMock<MockModelObserver>& model_observer() { return observer_; }
FakeDataSharingSDKDelegate& sdk_delegate() { return sdk_delegate_; }
CollaborationGroupSyncBridge& collaboration_group_bridge() {
return *collaboration_group_bridge_;
}
void WaitForModelLoaded() {
if (model_->IsModelLoaded()) {
return;
}
base::RunLoop run_loop;
EXPECT_CALL(observer_, OnModelLoaded)
.WillOnce(RunClosure(run_loop.QuitClosure()));
run_loop.Run();
}
GroupId MimicGroupAddedServerSide(const std::string& display_name) {
const GroupId id = sdk_delegate_.AddGroupAndReturnId(display_name);
syncer::EntityChangeList entity_changes;
entity_changes.push_back(EntityChangeAddFromSpecifics(
MakeSpecifics(id, next_changed_at_millis_since_unix_epoch_++)));
collaboration_group_bridge_->ApplyIncrementalSyncChanges(
collaboration_group_bridge_->CreateMetadataChangeList(),
std::move(entity_changes));
return id;
}
std::vector<GroupId> MimicMultipleGroupsAddedServerSide(
size_t number_of_groups) {
syncer::EntityChangeList entity_changes;
std::vector<GroupId> group_ids;
for (size_t i = 0; i < number_of_groups; i++) {
std::string display_name = "Group" + base::NumberToString(i);
const GroupId id = sdk_delegate_.AddGroupAndReturnId(display_name);
group_ids.emplace_back(id);
entity_changes.push_back(EntityChangeAddFromSpecifics(
MakeSpecifics(id, next_changed_at_millis_since_unix_epoch_++)));
}
collaboration_group_bridge_->ApplyIncrementalSyncChanges(
collaboration_group_bridge_->CreateMetadataChangeList(),
std::move(entity_changes));
return group_ids;
}
void WaitForGroupAdded(const GroupId& group_id) {
base::RunLoop run_loop;
EXPECT_CALL(observer_, OnGroupAdded(group_id, NotNullTime()))
.WillOnce(RunClosure(run_loop.QuitClosure()));
run_loop.Run();
}
void WaitForMultipleGroupsAdded(size_t number_of_groups) {
base::RunLoop run_loop;
size_t call_count = 0;
EXPECT_CALL(observer_, OnGroupAdded(_, NotNullTime()))
.Times(::testing::AtLeast(0))
.WillRepeatedly(::testing::DoAll(::testing::Invoke([&]() {
++call_count;
if (call_count == number_of_groups) {
run_loop.Quit();
}
})));
run_loop.Run();
}
void MimicMemberAddedServerSide(const GroupId& group_id,
const GaiaId& member_gaia_id) {
auto iter = sdk_delegate_.groups()->find(group_id);
ASSERT_TRUE(iter != sdk_delegate_.groups()->end());
data_sharing_pb::GroupMember member;
member.set_gaia_id(member_gaia_id.ToString());
member.set_role(data_sharing_pb::MEMBER_ROLE_MEMBER);
member.set_last_updated_time_unix_epoch_millis(
next_changed_at_millis_since_unix_epoch_++);
*iter->second.add_members() = member;
syncer::EntityChangeList entity_changes;
entity_changes.push_back(EntityChangeUpdateFromSpecifics(
MakeSpecifics(group_id, next_changed_at_millis_since_unix_epoch_++)));
collaboration_group_bridge_->ApplyIncrementalSyncChanges(
collaboration_group_bridge_->CreateMetadataChangeList(),
std::move(entity_changes));
}
void MimicMemberRemovedServerSide(const GroupId& group_id,
const GaiaId& member_gaia_id) {
sdk_delegate_.RemoveMember(group_id, member_gaia_id);
auto iter = sdk_delegate_.groups()->find(group_id);
ASSERT_TRUE(iter != sdk_delegate_.groups()->end());
data_sharing_pb::GroupMember member;
member.set_gaia_id(member_gaia_id.ToString());
member.set_role(data_sharing_pb::MEMBER_ROLE_FORMER_MEMBER);
member.set_last_updated_time_unix_epoch_millis(
next_changed_at_millis_since_unix_epoch_++);
*iter->second.add_former_members() = member;
syncer::EntityChangeList entity_changes;
entity_changes.push_back(EntityChangeUpdateFromSpecifics(
MakeSpecifics(group_id, next_changed_at_millis_since_unix_epoch_++)));
collaboration_group_bridge_->ApplyIncrementalSyncChanges(
collaboration_group_bridge_->CreateMetadataChangeList(),
std::move(entity_changes));
}
void WaitForGroupUpdated(const GroupId& group_id) {
base::RunLoop run_loop;
EXPECT_CALL(observer_, OnGroupUpdated(group_id, NotNullTime()))
.WillOnce(RunClosure(run_loop.QuitClosure()));
run_loop.Run();
}
void MimicGroupDeletedServerSide(const GroupId& group_id) {
sdk_delegate_.RemoveGroup(group_id);
syncer::EntityChangeList entity_changes;
entity_changes.push_back(EntityChangeDeleteFromSpecifics(
MakeSpecifics(group_id, next_changed_at_millis_since_unix_epoch_++)));
collaboration_group_bridge_->ApplyIncrementalSyncChanges(
collaboration_group_bridge_->CreateMetadataChangeList(),
std::move(entity_changes));
}
void WaitForGroupDeleted(const GroupId& group_id) {
// Unlike additions/updates deletions might be handled synchronously, so we
// need to check whether the group was already deleted.
std::optional<GroupData> group_data = model().GetGroup(group_id);
if (!group_data.has_value()) {
return;
}
ASSERT_TRUE(group_data.has_value());
base::RunLoop run_loop;
EXPECT_CALL(
observer_,
OnGroupDeleted(group_id, OptionalGroupMetadataDataEq(group_data),
NotNullTime()))
.WillOnce(RunClosure(run_loop.QuitClosure()));
run_loop.Run();
}
void ShutdownModel() {
base::RunLoop run_loop;
model_->GetGroupDataStoreForTesting().SetShutdownCallbackForTesting(
run_loop.QuitClosure());
model_->RemoveObserver(&observer_);
model_.reset();
// Wait for DB shutdown tasks completion.
run_loop.Run();
}
void RestartModel() {
model_ = std::make_unique<GroupDataModel>(data_sharing_dir_.GetPath(),
collaboration_group_bridge_.get(),
&sdk_delegate_);
model_->AddObserver(&observer_);
}
void FastForwardBy(const base::TimeDelta& time_delta) {
task_environment_.FastForwardBy(time_delta);
}
private:
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
base::ScopedTempDir data_sharing_dir_;
std::unique_ptr<syncer::DataTypeStore> data_type_store_;
testing::NiceMock<syncer::MockDataTypeLocalChangeProcessor> mock_processor_;
std::unique_ptr<CollaborationGroupSyncBridge> collaboration_group_bridge_;
FakeDataSharingSDKDelegate sdk_delegate_;
std::unique_ptr<GroupDataModel> model_;
// Used to ensure that changed_at_timestamp_millis_since_unix_epoch is always
// advanced when changes are made (base::Time::Now() doesn't guarantee that in
// some cases).
int64_t next_changed_at_millis_since_unix_epoch_ = 1000;
testing::NiceMock<MockModelObserver> observer_;
};
TEST_F(GroupDataModelTest, ShouldGetGroup) {
WaitForModelLoaded();
EXPECT_FALSE(model().GetGroup(GroupId("non-existing-group-id")).has_value());
const std::string group_display_name = "group";
const GroupId group_id = MimicGroupAddedServerSide(group_display_name);
WaitForGroupAdded(group_id);
EXPECT_THAT(model().GetGroup(group_id),
Optional(HasDisplayName(group_display_name)));
}
TEST_F(GroupDataModelTest, ShouldGetAllGroups) {
WaitForModelLoaded();
EXPECT_TRUE(model().GetAllGroups().empty());
const std::string group_display_name1 = "group1";
const GroupId group_id1 = MimicGroupAddedServerSide(group_display_name1);
WaitForGroupAdded(group_id1);
EXPECT_THAT(model().GetAllGroups(),
ElementsAre(HasDisplayName(group_display_name1)));
const std::string group_display_name2 = "group2";
const GroupId group_id2 = MimicGroupAddedServerSide(group_display_name2);
WaitForGroupAdded(group_id2);
EXPECT_THAT(model().GetAllGroups(),
ElementsAre(HasDisplayName(group_display_name1),
HasDisplayName(group_display_name2)));
}
TEST_F(GroupDataModelTest, FetchWorksCorrectlyForLargeNumberOfGroups) {
WaitForModelLoaded();
EXPECT_TRUE(model().GetAllGroups().empty());
size_t number_of_groups = 250;
const std::vector<GroupId> group_ids =
MimicMultipleGroupsAddedServerSide(number_of_groups);
ASSERT_EQ(number_of_groups, group_ids.size());
WaitForMultipleGroupsAdded(number_of_groups);
EXPECT_EQ(number_of_groups, model().GetAllGroups().size());
for (const GroupId& group_id : group_ids) {
EXPECT_TRUE(model().GetGroup(group_id).has_value());
}
}
TEST_F(GroupDataModelTest, ShouldUpdateGroup) {
WaitForModelLoaded();
const GroupId group_id = MimicGroupAddedServerSide("group");
WaitForGroupAdded(group_id);
const GaiaId member_gaia_id("gaia_id");
MimicMemberAddedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
EXPECT_THAT(model().GetGroup(group_id),
Optional(HasMemberWithGaiaId(member_gaia_id)));
}
TEST_F(GroupDataModelTest, ShouldHandlePartialReadGroupsFailure) {
WaitForModelLoaded();
// Both groups are in CollaborationGroupSyncBridge, but only one is in
// DataSharingSDKDelegate.
const std::string display_name = "group";
const GroupId group_id1 = sdk_delegate().AddGroupAndReturnId(display_name);
const GroupId group_id2 = GroupId("non_existent_group_id");
syncer::EntityChangeList entity_changes;
entity_changes.push_back(EntityChangeAddFromSpecifics(
MakeSpecifics(group_id1, /*changed_at_millis_since_unix_epoch=*/1000)));
entity_changes.push_back(EntityChangeAddFromSpecifics(
MakeSpecifics(group_id2, /*changed_at_millis_since_unix_epoch=*/1000)));
collaboration_group_bridge().ApplyIncrementalSyncChanges(
collaboration_group_bridge().CreateMetadataChangeList(),
std::move(entity_changes));
// First group should be successfully read.
base::RunLoop run_loop;
EXPECT_CALL(model_observer(), OnGroupAdded(group_id1, NotNullTime()))
.WillOnce(RunClosure(run_loop.QuitClosure()));
run_loop.Run();
EXPECT_THAT(model().GetGroup(group_id1),
Optional(HasDisplayName(display_name)));
EXPECT_FALSE(model().GetGroup(group_id2).has_value());
}
TEST_F(GroupDataModelTest, ShouldNotifyAboutGroupChanges) {
WaitForModelLoaded();
const GroupId group_id = MimicGroupAddedServerSide("group");
WaitForGroupAdded(group_id);
// Test that OnMemberAdded() is called when a member is added.
const GaiaId member_gaia_id("gaia_id");
EXPECT_CALL(model_observer(),
OnMemberAdded(group_id, member_gaia_id,
base::Time::FromMillisecondsSinceUnixEpoch(1001)));
MimicMemberAddedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
testing::Mock::VerifyAndClearExpectations(&model_observer());
// Test that OnMemberRemoved() is called when a member is removed.
EXPECT_CALL(
model_observer(),
OnMemberRemoved(group_id, member_gaia_id,
base::Time::FromMillisecondsSinceUnixEpoch(1003)));
MimicMemberRemovedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
}
TEST_F(GroupDataModelTest,
ShouldNotifyAboutGroupChanges_MultipleMembersAddedRemoved) {
WaitForModelLoaded();
const GroupId group_id = MimicGroupAddedServerSide("group");
WaitForGroupAdded(group_id);
// Test that OnMemberAdded() is called when a member is added.
const GaiaId member_gaia_id1("gaia_id99");
EXPECT_CALL(model_observer(),
OnMemberAdded(group_id, member_gaia_id1,
base::Time::FromMillisecondsSinceUnixEpoch(1001)));
MimicMemberAddedServerSide(group_id, member_gaia_id1);
WaitForGroupUpdated(group_id);
testing::Mock::VerifyAndClearExpectations(&model_observer());
const GaiaId member_gaia_id2("gaia_id2");
EXPECT_CALL(model_observer(),
OnMemberAdded(group_id, member_gaia_id2,
base::Time::FromMillisecondsSinceUnixEpoch(1003)));
MimicMemberAddedServerSide(group_id, member_gaia_id2);
WaitForGroupUpdated(group_id);
testing::Mock::VerifyAndClearExpectations(&model_observer());
// Test that OnMemberRemoved() is called when a member is removed.
EXPECT_CALL(
model_observer(),
OnMemberRemoved(group_id, member_gaia_id1,
base::Time::FromMillisecondsSinceUnixEpoch(1005)));
MimicMemberRemovedServerSide(group_id, member_gaia_id1);
WaitForGroupUpdated(group_id);
}
TEST_F(GroupDataModelTest, ShouldNotifyOnSyncBridgeUpdateTypeChanged) {
EXPECT_CALL(model_observer(), OnSyncBridgeUpdateTypeChanged(
Eq(SyncBridgeUpdateType::kDisableSync)))
.Times(1);
model().OnSyncBridgeUpdateTypeChanged(SyncBridgeUpdateType::kDisableSync);
}
TEST_F(GroupDataModelTest, ShouldDeleteGroup) {
WaitForModelLoaded();
const GroupId group_id = MimicGroupAddedServerSide("group");
WaitForGroupAdded(group_id);
std::optional<GroupData> group_data = model().GetGroup(group_id);
ASSERT_TRUE(group_data.has_value());
// Unlike additions/updates deletions are handled synchronously, once
// CollaborationGroupSyncBridge received the update - no need to wait for
// observer call with RunLoop.
EXPECT_CALL(model_observer(),
OnGroupDeleted(group_id, OptionalGroupMetadataDataEq(group_data),
NotNullTime()));
MimicGroupDeletedServerSide(group_id);
EXPECT_FALSE(model().GetGroup(group_id).has_value());
}
TEST_F(GroupDataModelTest, ShouldPersistDataAcrossRestart) {
WaitForModelLoaded();
const std::string group_display_name = "group";
const GroupId group_id = MimicGroupAddedServerSide(group_display_name);
WaitForGroupAdded(group_id);
ASSERT_THAT(model().GetGroup(group_id),
Optional(HasDisplayName(group_display_name)));
ShutdownModel();
RestartModel();
WaitForModelLoaded();
EXPECT_THAT(model().GetGroup(group_id),
Optional(HasDisplayName(group_display_name)));
}
TEST_F(GroupDataModelTest, ShouldHandleNewGroupsAfterRestart) {
WaitForModelLoaded();
ShutdownModel();
// Mimic that new group addition was only partially handled:
// CollaborationGroupSyncBridge is still running and will persist changes, but
// model is shut down so it can't process them.
const std::string group_display_name = "group";
const GroupId group_id = MimicGroupAddedServerSide(group_display_name);
RestartModel();
WaitForModelLoaded();
WaitForGroupAdded(group_id);
EXPECT_THAT(model().GetGroup(group_id),
Optional(HasDisplayName(group_display_name)));
}
TEST_F(GroupDataModelTest, ShouldHandleUpdatesAfterRestart) {
WaitForModelLoaded();
const std::string group_display_name = "group";
const GroupId group_id = MimicGroupAddedServerSide(group_display_name);
WaitForGroupAdded(group_id);
ASSERT_THAT(model().GetGroup(group_id),
Optional(HasDisplayName(group_display_name)));
// Mimic that new group addition was only partially handled:
// CollaborationGroupSyncBridge is still running and will persist changes, but
// model is shut down so it can't process them.
ShutdownModel();
const GaiaId member_gaia_id("gaia_id");
MimicMemberAddedServerSide(group_id, member_gaia_id);
RestartModel();
WaitForModelLoaded();
WaitForGroupUpdated(group_id);
EXPECT_THAT(model().GetGroup(group_id),
Optional(HasMemberWithGaiaId(member_gaia_id)));
}
TEST_F(GroupDataModelTest, ShouldHandleDeletionsAfterRestart) {
WaitForModelLoaded();
const std::string group_display_name = "group";
const GroupId group_id = MimicGroupAddedServerSide(group_display_name);
WaitForGroupAdded(group_id);
ASSERT_THAT(model().GetGroup(group_id),
Optional(HasDisplayName(group_display_name)));
ShutdownModel();
// Mimic that deletion was only partially handled:
// CollaborationGroupSyncBridge is still running and will persist changes, but
// model is shut down so it can't process them.
MimicGroupDeletedServerSide(group_id);
RestartModel();
WaitForModelLoaded();
EXPECT_FALSE(model().GetGroup(group_id).has_value());
}
TEST_F(GroupDataModelTest, ShouldGetPossiblyRemovedGroupMember) {
WaitForModelLoaded();
const GroupId group_id = MimicGroupAddedServerSide("group");
WaitForGroupAdded(group_id);
const GaiaId member_gaia_id("gaia_id");
MimicMemberAddedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
// Existing member should be returned.
const auto member_data_opt =
model().GetPossiblyRemovedGroupMember(group_id, member_gaia_id);
ASSERT_TRUE(member_data_opt.has_value());
EXPECT_EQ(member_data_opt->gaia_id, member_gaia_id);
// Group never existed, nullopt should be returned.
EXPECT_FALSE(model()
.GetPossiblyRemovedGroupMember(GroupId("non-existing-group"),
member_gaia_id)
.has_value());
// Member never existed, nullopt should be returned.
EXPECT_FALSE(model()
.GetPossiblyRemovedGroupMember(group_id,
GaiaId("non-existing-member"))
.has_value());
// TODO(crbug.com/373628741): add coverage for the scenario when member was
// removed from the group once it is properly supported (i.e. removed members
// data is temporarily stored).
}
TEST(GroupDataModelTestNoFixture, ShouldRecordDBInitFailure) {
base::test::TaskEnvironment task_environment;
// Boilerplate to create a bridge / SDK delegate (required to create a model,
// but otherwise not relevant for this test)
std::unique_ptr<syncer::DataTypeStore> data_type_store(
syncer::DataTypeStoreTestUtil::CreateInMemoryStoreForTest());
testing::NiceMock<syncer::MockDataTypeLocalChangeProcessor> mock_processor;
auto collaboration_group_bridge =
std::make_unique<CollaborationGroupSyncBridge>(
mock_processor.CreateForwardingProcessor(),
syncer::DataTypeStoreTestUtil::FactoryForForwardingStore(
data_type_store.get()));
FakeDataSharingSDKDelegate sdk_delegate;
// Model expects a directory, not a file and this will cause DB init failure.
base::ScopedTempFile temp_file;
ASSERT_TRUE(temp_file.Create());
GroupDataModel model(temp_file.path(), collaboration_group_bridge.get(),
&sdk_delegate);
base::HistogramTester histogram_tester;
base::RunLoop run_loop;
model.SetGroupDataStoreLoadedCallbackForTesting(run_loop.QuitClosure());
run_loop.Run();
histogram_tester.ExpectUniqueSample("DataSharing.GroupDBInitSuccess", false,
1);
}
TEST_F(GroupDataModelTest, ShouldRecordDBInitSuccess) {
base::HistogramTester histogram_tester;
WaitForModelLoaded();
histogram_tester.ExpectUniqueSample("DataSharing.GroupDBInitSuccess", true,
1);
}
TEST_F(GroupDataModelTest, ShouldRecordGroupEvents) {
WaitForModelLoaded();
// Verify that group addition is recorded.
const GroupId group_id = MimicGroupAddedServerSide("group1");
WaitForGroupAdded(group_id);
EXPECT_THAT(model().GetGroupEventsSinceStartup(),
ElementsAre(GroupEventIs(
group_id, GroupEvent::EventType::kGroupAdded, std::nullopt)));
// Verify that member addition is recorded.
const GaiaId member_gaia_id("gaia_id");
MimicMemberAddedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
EXPECT_THAT(
model().GetGroupEventsSinceStartup(),
ElementsAre(GroupEventIs(group_id, GroupEvent::EventType::kGroupAdded,
std::nullopt),
GroupEventIs(group_id, GroupEvent::EventType::kMemberAdded,
member_gaia_id)));
// Verify that member removal is recorded.
MimicMemberRemovedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
EXPECT_THAT(
model().GetGroupEventsSinceStartup(),
ElementsAre(GroupEventIs(group_id, GroupEvent::EventType::kGroupAdded,
std::nullopt),
GroupEventIs(group_id, GroupEvent::EventType::kMemberAdded,
member_gaia_id),
GroupEventIs(group_id, GroupEvent::EventType::kMemberRemoved,
member_gaia_id)));
// Verify that group removal is recorded.
MimicGroupDeletedServerSide(group_id);
WaitForGroupDeleted(group_id);
EXPECT_THAT(
model().GetGroupEventsSinceStartup(),
ElementsAre(GroupEventIs(group_id, GroupEvent::EventType::kGroupAdded,
std::nullopt),
GroupEventIs(group_id, GroupEvent::EventType::kMemberAdded,
member_gaia_id),
GroupEventIs(group_id, GroupEvent::EventType::kMemberRemoved,
member_gaia_id),
GroupEventIs(group_id, GroupEvent::EventType::kGroupRemoved,
std::nullopt)));
}
TEST_F(GroupDataModelTest, ShouldDoPeriodicPolling) {
WaitForModelLoaded();
const GroupId group_id = MimicGroupAddedServerSide("group1");
WaitForGroupAdded(group_id);
const GaiaId member_gaia_id("gaia_id");
MimicMemberAddedServerSide(group_id, member_gaia_id);
WaitForGroupUpdated(group_id);
{
std::optional<GroupData> group_data = model().GetGroup(group_id);
ASSERT_TRUE(group_data.has_value());
ASSERT_THAT(*group_data, HasMemberWithGaiaId(member_gaia_id));
}
// Mimic that member was removed from the group without updating
// CollaborationGroup (thus model doesn't know about it).
sdk_delegate().RemoveMember(group_id, member_gaia_id);
FastForwardBy(base::Hours(1));
{
// One hour is not long enough to trigger periodic polling, so the group
// member should still be present.
std::optional<GroupData> group_data = model().GetGroup(group_id);
ASSERT_TRUE(group_data.has_value());
ASSERT_THAT(*group_data, HasMemberWithGaiaId(member_gaia_id));
}
// There will be extra OnGroupUpdated() call after periodic polling, so to
// avoid unexpected call errors, verify and clear expectations.
testing::Mock::VerifyAndClearExpectations(&model_observer());
base::RunLoop run_loop;
EXPECT_CALL(model_observer(),
OnMemberRemoved(group_id, member_gaia_id, NotNullTime()))
.WillOnce(RunClosure(run_loop.QuitClosure()));
// Periodic polling is attempted once per hour and only effective for groups
// that were updated more that kDataSharingGroupDataPeriodicPollingInterval
// ago, so advance time by the sum of both.
FastForwardBy(features::kDataSharingGroupDataPeriodicPollingInterval.Get() +
base::Hours(1));
run_loop.Run();
{
// Now model should be aware of the member removal.
std::optional<GroupData> group_data = model().GetGroup(group_id);
ASSERT_TRUE(group_data.has_value());
EXPECT_TRUE(group_data->members.empty());
}
}
} // namespace
} // namespace data_sharing
|