1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/dom_distiller/content/browser/distiller_page_web_contents.h"
#include <utility>
#include "base/functional/bind.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/single_thread_task_runner.h"
#include "base/values.h"
#include "build/build_config.h"
#include "components/dom_distiller/content/browser/distiller_javascript_utils.h"
#include "components/dom_distiller/content/browser/test/test_util.h"
#include "components/dom_distiller/core/distiller_page.h"
#include "components/dom_distiller/core/proto/distilled_article.pb.h"
#include "components/dom_distiller/core/proto/distilled_page.pb.h"
#include "components/dom_distiller/core/viewer.h"
#include "components/strings/grit/components_strings.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/isolated_world_ids.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/content_browser_test.h"
#include "content/shell/browser/shell.h"
#include "net/test/embedded_test_server/controllable_http_response.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "third_party/dom_distiller_js/dom_distiller.pb.h"
#include "ui/base/l10n/l10n_util.h"
using content::ContentBrowserTest;
using testing::ContainsRegex;
using testing::HasSubstr;
using testing::Not;
namespace {
// Helper class to know how far in the loading process the current WebContents
// has come. It will call the callback either after
// DidCommitProvisionalLoadForFrame or DOMContentLoaded is called for the
// main frame, based on the value of |wait_for_document_loaded|.
class WebContentsMainFrameHelper : public content::WebContentsObserver {
public:
WebContentsMainFrameHelper(content::WebContents* web_contents,
base::OnceClosure callback,
bool wait_for_document_loaded)
: WebContentsObserver(web_contents),
callback_(std::move(callback)),
wait_for_document_loaded_(wait_for_document_loaded) {}
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override {
if (wait_for_document_loaded_ || !callback_)
return;
if (navigation_handle->HasCommitted() && navigation_handle->IsInMainFrame())
std::move(callback_).Run();
}
void DOMContentLoaded(content::RenderFrameHost* render_frame_host) override {
if (wait_for_document_loaded_ && callback_) {
if (!render_frame_host->GetParent())
std::move(callback_).Run();
}
}
private:
base::OnceClosure callback_;
bool wait_for_document_loaded_;
};
} // namespace
namespace dom_distiller {
const char* kSimpleArticlePath = "/simple_article.html";
const char* kVideoArticlePath = "/video_article.html";
class DistillerPageWebContentsTest : public ContentBrowserTest {
public:
// ContentBrowserTest:
void SetUpOnMainThread() override {
if (!DistillerJavaScriptWorldIdIsSet()) {
SetDistillerJavaScriptWorldId(content::ISOLATED_WORLD_ID_CONTENT_END);
}
AddComponentsResources();
SetUpTestServer(embedded_test_server());
ContentBrowserTest::SetUpOnMainThread();
}
void DistillPage(base::OnceClosure quit_closure, const std::string& url) {
distiller_page_->DistillPage(
embedded_test_server()->GetURL(url),
dom_distiller::proto::DomDistillerOptions(),
base::BindOnce(
&DistillerPageWebContentsTest::OnPageDistillationFinished,
base::Unretained(this), std::move(quit_closure)));
}
void OnPageDistillationFinished(
base::OnceClosure quit_closure,
std::unique_ptr<proto::DomDistillerResult> distiller_result,
bool distillation_successful) {
distiller_result_ = std::move(distiller_result);
std::move(quit_closure).Run();
}
protected:
void RunUseCurrentWebContentsTest(const std::string& url,
bool expect_new_web_contents,
bool wait_for_document_loaded);
raw_ptr<DistillerPageWebContents, DanglingUntriaged> distiller_page_;
std::unique_ptr<proto::DomDistillerResult> distiller_result_;
};
// Use this class to be able to leak the WebContents, which is needed for when
// the current WebContents is used for distillation.
class TestDistillerPageWebContents : public DistillerPageWebContents {
public:
TestDistillerPageWebContents(
content::BrowserContext* browser_context,
const gfx::Size& render_view_size,
std::unique_ptr<SourcePageHandleWebContents> optional_web_contents_handle,
bool expect_new_web_contents)
: DistillerPageWebContents(browser_context,
render_view_size,
std::move(optional_web_contents_handle)),
expect_new_web_contents_(expect_new_web_contents),
new_web_contents_created_(false) {}
void CreateNewWebContents(const GURL& url) override {
ASSERT_EQ(true, expect_new_web_contents_);
new_web_contents_created_ = true;
DistillerPageWebContents::CreateNewWebContents(url);
}
bool new_web_contents_created() { return new_web_contents_created_; }
private:
bool expect_new_web_contents_;
bool new_web_contents_created_;
};
#if BUILDFLAG(IS_WIN)
#define MAYBE_BasicDistillationWorks DISABLED_BasicDistillationWorks
#else
#define MAYBE_BasicDistillationWorks BasicDistillationWorks
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_BasicDistillationWorks) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::unique_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), kSimpleArticlePath);
run_loop.Run();
EXPECT_EQ("Test Page Title", distiller_result_->title());
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("Lorem ipsum"));
EXPECT_THAT(distiller_result_->distilled_content().html(),
Not(HasSubstr("questionable content")));
EXPECT_EQ("", distiller_result_->pagination_info().next_page());
EXPECT_EQ("", distiller_result_->pagination_info().prev_page());
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_HandlesRelativeLinks DISABLED_HandlesRelativeLinks
#else
#define MAYBE_HandlesRelativeLinks HandlesRelativeLinks
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_HandlesRelativeLinks) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::unique_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), kSimpleArticlePath);
run_loop.Run();
// A relative link should've been updated.
EXPECT_THAT(distiller_result_->distilled_content().html(),
ContainsRegex("href=\"http://127.0.0.1:.*/relativelink.html\""));
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("href=\"http://www.google.com/absolutelink.html\""));
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_HandlesRelativeImages DISABLED_HandlesRelativeImages
#else
#define MAYBE_HandlesRelativeImages HandlesRelativeImages
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_HandlesRelativeImages) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::unique_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), kSimpleArticlePath);
run_loop.Run();
// A relative link should've been updated.
EXPECT_THAT(distiller_result_->distilled_content().html(),
ContainsRegex("src=\"http://127.0.0.1:.*/relativeimage.png\""));
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("src=\"http://www.google.com/absoluteimage.png\""));
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_HandlesRelativeVideos DISABLED_HandlesRelativeVideos
#else
#define MAYBE_HandlesRelativeVideos HandlesRelativeVideos
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_HandlesRelativeVideos) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::unique_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), kVideoArticlePath);
run_loop.Run();
// A relative source/track should've been updated.
EXPECT_THAT(distiller_result_->distilled_content().html(),
ContainsRegex("src=\"http://127.0.0.1:.*/relative_video.webm\""));
EXPECT_THAT(
distiller_result_->distilled_content().html(),
ContainsRegex("src=\"http://127.0.0.1:.*/relative_track_en.vtt\""));
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("src=\"http://www.google.com/absolute_video.ogg\""));
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("src=\"http://www.google.com/absolute_track_fr.vtt\""));
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_VisibilityDetection DISABLED_VisibilityDetection
#else
#define MAYBE_VisibilityDetection VisibilityDetection
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_VisibilityDetection) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::unique_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
// visble_style.html and invisible_style.html only differ by the visibility
// internal stylesheet.
{
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), "/visible_style.html");
run_loop.Run();
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("Lorem ipsum"));
}
{
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), "/invisible_style.html");
run_loop.Run();
EXPECT_THAT(distiller_result_->distilled_content().html(),
Not(HasSubstr("Lorem ipsum")));
}
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_UsingCurrentWebContentsWrongUrl \
DISABLED_UsingCurrentWebContentsWrongUrl
#else
#define MAYBE_UsingCurrentWebContentsWrongUrl UsingCurrentWebContentsWrongUrl
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_UsingCurrentWebContentsWrongUrl) {
std::string url("/bogus");
bool expect_new_web_contents = true;
bool wait_for_document_loaded = true;
RunUseCurrentWebContentsTest(url, expect_new_web_contents,
wait_for_document_loaded);
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_UsingCurrentWebContentsNotFinishedLoadingYet \
DISABLED_UsingCurrentWebContentsNotFinishedLoadingYet
#else
#define MAYBE_UsingCurrentWebContentsNotFinishedLoadingYet \
UsingCurrentWebContentsNotFinishedLoadingYet
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_UsingCurrentWebContentsNotFinishedLoadingYet) {
std::string url(kSimpleArticlePath);
bool expect_new_web_contents = false;
bool wait_for_document_loaded = false;
RunUseCurrentWebContentsTest(url, expect_new_web_contents,
wait_for_document_loaded);
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_UsingCurrentWebContentsReadyForDistillation \
DISABLED_UsingCurrentWebContentsReadyForDistillation
#else
#define MAYBE_UsingCurrentWebContentsReadyForDistillation \
UsingCurrentWebContentsReadyForDistillation
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_UsingCurrentWebContentsReadyForDistillation) {
std::string url(kSimpleArticlePath);
bool expect_new_web_contents = false;
bool wait_for_document_loaded = true;
RunUseCurrentWebContentsTest(url, expect_new_web_contents,
wait_for_document_loaded);
}
void DistillerPageWebContentsTest::RunUseCurrentWebContentsTest(
const std::string& url,
bool expect_new_web_contents,
bool wait_for_document_loaded) {
content::WebContents* current_web_contents = shell()->web_contents();
base::RunLoop url_loaded_runner;
WebContentsMainFrameHelper main_frame_loaded(current_web_contents,
url_loaded_runner.QuitClosure(),
wait_for_document_loaded);
current_web_contents->GetController().LoadURL(
embedded_test_server()->GetURL(url), content::Referrer(),
ui::PAGE_TRANSITION_TYPED, std::string());
url_loaded_runner.Run();
std::unique_ptr<SourcePageHandleWebContents> source_page_handle(
new SourcePageHandleWebContents(current_web_contents, false));
TestDistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::move(source_page_handle), expect_new_web_contents);
distiller_page_ = &distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), kSimpleArticlePath);
run_loop.Run();
// Sanity check of distillation process.
EXPECT_EQ(expect_new_web_contents, distiller_page.new_web_contents_created());
EXPECT_EQ("Test Page Title", distiller_result_->title());
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_PageDestroyedBeforeFinishDistillation \
DISABLED_PageDestroyedBeforeFinishDistillation
#else
#define MAYBE_PageDestroyedBeforeFinishDistillation \
PageDestroyedBeforeFinishDistillation
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
MAYBE_PageDestroyedBeforeFinishDistillation) {
content::WebContents* current_web_contents = shell()->web_contents();
base::RunLoop url_loaded_runner;
WebContentsMainFrameHelper main_frame_loaded(
current_web_contents, url_loaded_runner.QuitClosure(), true);
current_web_contents->GetController().LoadURL(
embedded_test_server()->GetURL(kSimpleArticlePath), content::Referrer(),
ui::PAGE_TRANSITION_TYPED, std::string());
url_loaded_runner.Run();
std::unique_ptr<SourcePageHandleWebContents> source_page_handle(
new SourcePageHandleWebContents(current_web_contents, false));
TestDistillerPageWebContents* distiller_page(new TestDistillerPageWebContents(
current_web_contents->GetBrowserContext(),
current_web_contents->GetContainerBounds().size(),
std::move(source_page_handle), false));
distiller_page_ = distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), kSimpleArticlePath);
// It can not crash the loop when returning the result.
delete distiller_page_;
// Make sure the test ends when it does not crash.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostDelayedTask(
FROM_HERE, run_loop.QuitClosure(), base::Seconds(2));
run_loop.Run();
}
#if BUILDFLAG(IS_WIN)
#define MAYBE_MarkupInfo DISABLED_MarkupInfo
#else
#define MAYBE_MarkupInfo MarkupInfo
#endif
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, MAYBE_MarkupInfo) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
shell()->web_contents()->GetContainerBounds().size(),
std::unique_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), "/markup_article.html");
run_loop.Run();
EXPECT_THAT(distiller_result_->distilled_content().html(),
HasSubstr("Lorem ipsum"));
EXPECT_EQ("Marked-up Markup Test Page Title", distiller_result_->title());
const proto::MarkupInfo markup_info = distiller_result_->markup_info();
EXPECT_EQ("Marked-up Markup Test Page Title", markup_info.title());
EXPECT_EQ("Article", markup_info.type());
EXPECT_EQ("http://test/markup.html", markup_info.url());
EXPECT_EQ("This page tests Markup Info.", markup_info.description());
EXPECT_EQ("Whoever Published", markup_info.publisher());
EXPECT_EQ("Copyright 2000-2014 Whoever Copyrighted", markup_info.copyright());
EXPECT_EQ("Whoever Authored", markup_info.author());
const proto::MarkupArticle markup_article = markup_info.article();
EXPECT_EQ("Whatever Section", markup_article.section());
EXPECT_EQ("July 23, 2014", markup_article.published_time());
EXPECT_EQ("2014-07-23T23:59", markup_article.modified_time());
EXPECT_EQ("", markup_article.expiration_time());
ASSERT_EQ(1, markup_article.authors_size());
EXPECT_EQ("Whoever Authored", markup_article.authors(0));
ASSERT_EQ(2, markup_info.images_size());
const proto::MarkupImage markup_image1 = markup_info.images(0);
EXPECT_EQ("http://test/markup1.jpeg", markup_image1.url());
EXPECT_EQ("https://test/markup1.jpeg", markup_image1.secure_url());
EXPECT_EQ("jpeg", markup_image1.type());
EXPECT_EQ("", markup_image1.caption());
EXPECT_EQ(600, markup_image1.width());
EXPECT_EQ(400, markup_image1.height());
const proto::MarkupImage markup_image2 = markup_info.images(1);
EXPECT_EQ("http://test/markup2.gif", markup_image2.url());
EXPECT_EQ("https://test/markup2.gif", markup_image2.secure_url());
EXPECT_EQ("gif", markup_image2.type());
EXPECT_EQ("", markup_image2.caption());
EXPECT_EQ(1000, markup_image2.width());
EXPECT_EQ(600, markup_image2.height());
}
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
TestNoContentDoesNotCrash) {
const std::string no_content =
l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_NO_DATA_CONTENT);
{ // Test zero pages.
std::unique_ptr<DistilledArticleProto> article_proto(
new DistilledArticleProto());
std::string js = viewer::GetUnsafeArticleContentJs(article_proto.get());
EXPECT_THAT(js, HasSubstr(no_content));
}
{ // Test empty content.
std::unique_ptr<DistilledArticleProto> article_proto(
new DistilledArticleProto());
(*(article_proto->add_pages())).set_html("");
std::string js = viewer::GetUnsafeArticleContentJs(article_proto.get());
EXPECT_THAT(js, HasSubstr(no_content));
}
}
} // namespace dom_distiller
|