1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/exo/drag_drop_operation.h"
#include <memory>
#include <vector>
#include "ash/drag_drop/drag_drop_controller.h"
#include "ash/shell.h"
#include "ash/test_shell_delegate.h"
#include "base/files/file_util.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/task/sequenced_task_runner.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "components/exo/buffer.h"
#include "components/exo/data_exchange_delegate.h"
#include "components/exo/data_source.h"
#include "components/exo/data_source_delegate.h"
#include "components/exo/shell_surface.h"
#include "components/exo/surface.h"
#include "components/exo/test/exo_test_base.h"
#include "components/exo/test/exo_test_data_exchange_delegate.h"
#include "components/exo/test/shell_surface_builder.h"
#include "components/exo/test/test_data_source_delegate.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/aura/client/drag_drop_client.h"
#include "ui/base/data_transfer_policy/data_transfer_endpoint.h"
#include "ui/base/dragdrop/mojom/drag_drop_types.mojom-shared.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/point_f.h"
#include "url/gurl.h"
namespace exo {
namespace {
using test::TestDataSourceDelegate;
using ::testing::_;
using ::testing::NiceMock;
using ::testing::Property;
using ::testing::Return;
constexpr char kTextMimeType[] = "text/plain";
constexpr char kWindowDragMimeType[] = "chromium/x-window-drag";
} // namespace
class DragDropOperationTest : public test::ExoTestBase,
public aura::client::DragDropClientObserver {
public:
DragDropOperationTest() = default;
~DragDropOperationTest() override = default;
DragDropOperationTest(const DragDropOperationTest&) = delete;
DragDropOperationTest& operator=(const DragDropOperationTest&) = delete;
void SetUp() override {
test::ExoTestBase::SetUp();
aura::client::GetDragDropClient(ash::Shell::GetPrimaryRootWindow())
->AddObserver(this);
}
void TearDown() override {
aura::client::GetDragDropClient(ash::Shell::GetPrimaryRootWindow())
->RemoveObserver(this);
test::ExoTestBase::TearDown();
}
// aura::client::DragDropClientObserver:
void OnDragStarted() override {
drag_start_count_++;
if (!drag_blocked_callback_.is_null()) {
base::SequencedTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE, std::move(drag_blocked_callback_));
}
}
void OnDragCompleted(const ui::DropTargetEvent& event) override {
drag_end_count_++;
}
void OnDragCancelled() override { drag_end_count_++; }
protected:
void set_drag_blocked_callback(base::OnceClosure callback) {
drag_blocked_callback_ = std::move(callback);
}
int GetDragStartCountAndReset() {
int result = drag_start_count_;
drag_start_count_ = 0;
return result;
}
int GetDragEndCountAndReset() {
int result = drag_end_count_;
drag_end_count_ = 0;
return result;
}
private:
// Callback running inside the nested RunLoop in StartDragAndDrop().
base::OnceClosure drag_blocked_callback_;
int drag_start_count_ = 0;
int drag_end_count_ = 0;
};
TEST_F(DragDropOperationTest, DeleteDataSourceDuringDragging) {
TestDataExchangeDelegate data_exchange_delegate;
auto delegate = std::make_unique<TestDataSourceDelegate>();
auto data_source = std::make_unique<DataSource>(delegate.get());
data_source->Offer(kTextMimeType);
auto origin_surface = std::make_unique<Surface>();
ash::Shell::GetPrimaryRootWindow()->AddChild(origin_surface->window());
gfx::Size buffer_size(100, 100);
auto buffer = test::ExoTestHelper::CreateBuffer(buffer_size);
auto icon_surface = std::make_unique<Surface>();
icon_surface->Attach(buffer.get());
auto operation = DragDropOperation::Create(
&data_exchange_delegate, data_source.get(), origin_surface.get(),
icon_surface.get(), gfx::PointF(), ui::mojom::DragEventSource::kMouse);
icon_surface->Commit();
base::RunLoop run_loop;
set_drag_blocked_callback(base::BindOnce(
[](std::unique_ptr<DataSource> data_source,
base::WeakPtr<DragDropOperation> operation,
base::OnceClosure quit_closure) {
// This function runs inside the nested RunLoop in
// ash::DragDropController::StartDragAndDrop().
EXPECT_TRUE(operation);
// Deleting DataSource causes DragDropOperation to be deleted as well.
data_source.reset();
EXPECT_FALSE(operation);
std::move(quit_closure).Run();
},
std::move(data_source), operation, run_loop.QuitClosure()));
run_loop.Run();
EXPECT_FALSE(operation);
}
namespace {
class MockShellDelegate : public ash::TestShellDelegate {
public:
MockShellDelegate() = default;
~MockShellDelegate() override = default;
MOCK_METHOD(bool, IsTabDrag, (const ui::OSExchangeData&), (override));
};
} // namespace
class DragDropOperationTestWithWebUITabStripTest
: public DragDropOperationTest {
public:
DragDropOperationTestWithWebUITabStripTest() = default;
// DragDropOperationTest:
void SetUp() override {
auto mock_shell_delegate = std::make_unique<NiceMock<MockShellDelegate>>();
mock_shell_delegate_ = mock_shell_delegate.get();
set_shell_delegate(std::move(mock_shell_delegate));
DragDropOperationTest::SetUp();
}
MockShellDelegate* mock_shell_delegate() { return mock_shell_delegate_; }
private:
raw_ptr<NiceMock<MockShellDelegate>, DanglingUntriaged> mock_shell_delegate_ =
nullptr;
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(DragDropOperationTestWithWebUITabStripTest,
DeleteSurfaceDuringDragging) {
TestDataExchangeDelegate data_exchange_delegate;
auto delegate = std::make_unique<TestDataSourceDelegate>();
auto data_source = std::make_unique<DataSource>(delegate.get());
data_source->Offer(kWindowDragMimeType);
delegate->SetData(kWindowDragMimeType, std::string());
ON_CALL(*mock_shell_delegate(), IsTabDrag(_)).WillByDefault(Return(true));
auto shell_surface =
test::ShellSurfaceBuilder({100, 100}).BuildShellSurface();
auto* origin_surface = shell_surface->surface_for_testing();
gfx::Size buffer_size(100, 100);
auto buffer = test::ExoTestHelper::CreateBuffer(buffer_size);
auto icon_surface = std::make_unique<Surface>();
icon_surface->Attach(buffer.get());
auto operation = DragDropOperation::Create(
&data_exchange_delegate, data_source.get(), origin_surface,
icon_surface.get(), gfx::PointF(), ui::mojom::DragEventSource::kMouse);
icon_surface->Commit();
base::RunLoop run_loop;
set_drag_blocked_callback(base::BindOnce(
[](std::unique_ptr<DataSource> data_source,
std::unique_ptr<ShellSurface> shell_surface,
base::WeakPtr<DragDropOperation> operation,
base::OnceClosure quit_closure) {
// This function runs inside the nested RunLoop in
// ash::DragDropController::StartDragAndDrop().
EXPECT_TRUE(operation);
// Deleting ShellSurface causes DragDropOperation to be deleted as well.
shell_surface.reset();
EXPECT_FALSE(operation);
std::move(quit_closure).Run();
},
std::move(data_source), std::move(shell_surface), operation,
run_loop.QuitClosure()));
run_loop.Run();
EXPECT_FALSE(operation);
}
TEST_F(DragDropOperationTest, DragDropFromPopup) {
static_cast<ash::DragDropController*>(
aura::client::GetDragDropClient(ash::Shell::GetPrimaryRootWindow()))
->set_should_block_during_drag_drop(false);
TestDataExchangeDelegate data_exchange_delegate;
auto delegate = std::make_unique<TestDataSourceDelegate>();
auto data_source = std::make_unique<DataSource>(delegate.get());
data_source->Offer(kTextMimeType);
auto origin_shell_surface = test::ShellSurfaceBuilder(gfx::Size(100, 100))
.SetNoCommit()
.BuildShellSurface();
origin_shell_surface->SetPopup();
origin_shell_surface->Grab();
int closed_count = 0;
origin_shell_surface->set_close_callback(
base::BindLambdaForTesting([&]() { closed_count++; }));
auto* origin_surface = origin_shell_surface->root_surface();
origin_surface->Commit();
gfx::Size buffer_size(32, 32);
auto buffer = test::ExoTestHelper::CreateBuffer(buffer_size);
auto icon_surface = std::make_unique<Surface>();
icon_surface->Attach(buffer.get());
base::RunLoop run_loop;
set_drag_blocked_callback(run_loop.QuitClosure());
ui::test::EventGenerator generator(origin_surface->window()->GetRootWindow(),
origin_surface->window());
generator.PressLeftButton();
gfx::Point location =
generator.current_screen_location() -
origin_surface->window()->GetBoundsInScreen().OffsetFromOrigin();
auto operation = DragDropOperation::Create(
&data_exchange_delegate, data_source.get(),
origin_shell_surface->root_surface(), icon_surface.get(),
gfx::PointF(location), ui::mojom::DragEventSource::kMouse);
icon_surface->Commit();
run_loop.Run();
EXPECT_EQ(1, GetDragStartCountAndReset());
EXPECT_EQ(0, GetDragEndCountAndReset());
EXPECT_EQ(0, closed_count);
generator.MoveMouseBy(150, 150);
EXPECT_EQ(0, GetDragStartCountAndReset());
EXPECT_EQ(0, GetDragEndCountAndReset());
generator.ReleaseLeftButton();
EXPECT_EQ(0, GetDragStartCountAndReset());
EXPECT_EQ(1, GetDragEndCountAndReset());
}
TEST_F(DragDropOperationTest, DragDropFromNestedPopup) {
static_cast<ash::DragDropController*>(
aura::client::GetDragDropClient(ash::Shell::GetPrimaryRootWindow()))
->set_should_block_during_drag_drop(false);
TestDataExchangeDelegate data_exchange_delegate;
auto parent_shell_surface = test::ShellSurfaceBuilder(gfx::Size(100, 100))
.SetNoCommit()
.BuildShellSurface();
parent_shell_surface->SetPopup();
parent_shell_surface->Grab();
parent_shell_surface->root_surface()->Commit();
auto delegate = std::make_unique<TestDataSourceDelegate>();
auto data_source = std::make_unique<DataSource>(delegate.get());
data_source->Offer(kTextMimeType);
auto origin_shell_surface = test::ShellSurfaceBuilder(gfx::Size(100, 100))
.SetNoCommit()
.SetParent(parent_shell_surface.get())
.BuildShellSurface();
origin_shell_surface->SetPopup();
origin_shell_surface->Grab();
auto* origin_surface = origin_shell_surface->root_surface();
origin_surface->Commit();
gfx::Size buffer_size(32, 32);
auto buffer = test::ExoTestHelper::CreateBuffer(buffer_size);
auto icon_surface = std::make_unique<Surface>();
icon_surface->Attach(buffer.get());
base::RunLoop run_loop;
set_drag_blocked_callback(run_loop.QuitClosure());
ui::test::EventGenerator generator(origin_surface->window()->GetRootWindow(),
origin_surface->window());
generator.PressLeftButton();
gfx::Point location =
generator.current_screen_location() -
origin_surface->window()->GetBoundsInScreen().OffsetFromOrigin();
auto operation = DragDropOperation::Create(
&data_exchange_delegate, data_source.get(),
origin_shell_surface->root_surface(), icon_surface.get(),
gfx::PointF(location), ui::mojom::DragEventSource::kMouse);
icon_surface->Commit();
run_loop.Run();
EXPECT_EQ(1, GetDragStartCountAndReset());
EXPECT_EQ(0, GetDragEndCountAndReset());
generator.MoveMouseBy(150, 150);
EXPECT_EQ(0, GetDragStartCountAndReset());
EXPECT_EQ(0, GetDragEndCountAndReset());
// Hide the origin_shell_surface -- that will update the capture but shouldn't
// stop the drag&drop session. Note: do not remove |origin_shell_surface|
// itself, as the testing shell surface will also remove the root surface
// which will stop the drag&drop while root surface remains normally.
origin_shell_surface->GetWidget()->Hide();
EXPECT_EQ(0, GetDragStartCountAndReset());
EXPECT_EQ(0, GetDragEndCountAndReset());
generator.ReleaseLeftButton();
EXPECT_EQ(0, GetDragStartCountAndReset());
EXPECT_EQ(1, GetDragEndCountAndReset());
}
} // namespace exo
|
