1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/favicon/content/content_favicon_driver.h"
#include <memory>
#include <vector>
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "components/favicon/core/favicon_client.h"
#include "components/favicon/core/favicon_handler.h"
#include "components/favicon/core/test/favicon_driver_impl_test_helper.h"
#include "components/favicon/core/test/mock_favicon_service.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/test_renderer_host.h"
#include "content/public/test/web_contents_tester.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/mojom/favicon/favicon_url.mojom.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/gfx/favicon_size.h"
namespace favicon {
namespace {
using testing::_;
using testing::Return;
using testing::SizeIs;
void TestFetchFaviconForPage(
content::WebContents* web_contents,
const GURL& page_url,
const std::vector<blink::mojom::FaviconURLPtr>& candidates) {
ContentFaviconDriver* favicon_driver =
ContentFaviconDriver::FromWebContents(web_contents);
content::WebContentsTester::For(web_contents)->NavigateAndCommit(page_url);
static_cast<content::WebContentsObserver*>(favicon_driver)
->DidUpdateFaviconURL(web_contents->GetPrimaryMainFrame(), candidates);
base::RunLoop().RunUntilIdle();
}
class ContentFaviconDriverTest : public content::RenderViewHostTestHarness {
protected:
const std::vector<gfx::Size> kEmptyIconSizes;
const std::vector<SkBitmap> kEmptyIcons;
const GURL kPageURL = GURL("http://www.google.com/");
const GURL kIconURL = GURL("http://www.google.com/favicon.ico");
const GURL kFakeManifestURL = GURL("http://www.google.com/manifest.json");
ContentFaviconDriverTest() {
ON_CALL(favicon_service_, UpdateFaviconMappingsAndFetch)
.WillByDefault([](auto, auto, auto, auto,
favicon_base::FaviconResultsCallback callback,
base::CancelableTaskTracker* tracker) {
return tracker->PostTask(
base::SingleThreadTaskRunner::GetCurrentDefault().get(),
FROM_HERE,
base::BindOnce(
std::move(callback),
std::vector<favicon_base::FaviconRawBitmapResult>()));
});
ON_CALL(favicon_service_, GetFaviconForPageURL)
.WillByDefault([](auto, auto, auto,
favicon_base::FaviconResultsCallback callback,
base::CancelableTaskTracker* tracker) {
return tracker->PostTask(
base::SingleThreadTaskRunner::GetCurrentDefault().get(),
FROM_HERE,
base::BindOnce(
std::move(callback),
std::vector<favicon_base::FaviconRawBitmapResult>()));
});
}
~ContentFaviconDriverTest() override = default;
// content::RenderViewHostTestHarness:
void SetUp() override {
RenderViewHostTestHarness::SetUp();
ContentFaviconDriver::CreateForWebContents(web_contents(),
&favicon_service_);
}
content::WebContentsTester* web_contents_tester() {
return content::WebContentsTester::For(web_contents());
}
testing::NiceMock<MockFaviconService> favicon_service_;
};
// Test that a download is initiated when there isn't a favicon in the database
// for either the page URL or the icon URL.
TEST_F(ContentFaviconDriverTest, ShouldCauseImageDownload) {
// Mimic a page load.
std::vector<blink::mojom::FaviconURLPtr> favicon_urls;
favicon_urls.push_back(blink::mojom::FaviconURL::New(
kIconURL, blink::mojom::FaviconIconType::kFavicon, kEmptyIconSizes,
/*is_default_icon=*/false));
TestFetchFaviconForPage(web_contents(), kPageURL, favicon_urls);
EXPECT_TRUE(web_contents_tester()->TestDidDownloadImage(
kIconURL, 200, kEmptyIcons, kEmptyIconSizes));
}
// Ensures that we do not consider a manifest URL if it arrives before the
// onload handler has fired.
// TODO(crbug.com/40180290): This may not necessarily the desired behavior, but
// this test will prevent unintentional behavioral changes until the issue is
// resolved.
TEST_F(ContentFaviconDriverTest, IgnoreManifestURLBeforeOnLoad) {
ContentFaviconDriver* favicon_driver =
ContentFaviconDriver::FromWebContents(web_contents());
auto navigation = content::NavigationSimulator::CreateBrowserInitiated(
kPageURL, web_contents());
navigation->SetKeepLoading(true);
navigation->Commit();
GURL manifest_url = kFakeManifestURL;
auto* rfh_tester = content::RenderFrameHostTester::For(
web_contents()->GetPrimaryMainFrame());
rfh_tester->SimulateManifestURLUpdate(manifest_url);
static_cast<content::WebContentsObserver*>(favicon_driver)
->DidUpdateWebManifestURL(web_contents()->GetPrimaryMainFrame(),
manifest_url);
EXPECT_EQ(GURL(), favicon_driver->GetManifestURL(
web_contents()->GetPrimaryMainFrame()));
}
// Ensures that we use a manifest URL if it arrives after the onload handler
// has fired. See crbug.com/1205018 for details.
TEST_F(ContentFaviconDriverTest, UseManifestURLAFterOnLoad) {
ContentFaviconDriver* favicon_driver =
ContentFaviconDriver::FromWebContents(web_contents());
auto navigation = content::NavigationSimulator::CreateBrowserInitiated(
kPageURL, web_contents());
navigation->SetKeepLoading(true);
navigation->Commit();
navigation->StopLoading();
GURL manifest_url = kFakeManifestURL;
auto* rfh_tester = content::RenderFrameHostTester::For(
web_contents()->GetPrimaryMainFrame());
rfh_tester->SimulateManifestURLUpdate(manifest_url);
static_cast<content::WebContentsObserver*>(favicon_driver)
->DidUpdateWebManifestURL(web_contents()->GetPrimaryMainFrame(),
manifest_url);
EXPECT_EQ(kFakeManifestURL, favicon_driver->GetManifestURL(
web_contents()->GetPrimaryMainFrame()));
}
// Test that no download is initiated when
// DocumentOnLoadCompletedInPrimaryMainFrame() is not triggered (e.g. user
// stopped an ongoing page load).
TEST_F(ContentFaviconDriverTest, ShouldNotCauseImageDownload) {
ContentFaviconDriver* favicon_driver =
ContentFaviconDriver::FromWebContents(web_contents());
auto navigation = content::NavigationSimulator::CreateBrowserInitiated(
kPageURL, web_contents());
navigation->SetKeepLoading(true);
navigation->Commit();
std::vector<blink::mojom::FaviconURLPtr> favicon_urls;
favicon_urls.push_back(blink::mojom::FaviconURL::New(
kIconURL, blink::mojom::FaviconIconType::kFavicon, kEmptyIconSizes,
/*is_default_icon=*/false));
static_cast<content::WebContentsObserver*>(favicon_driver)
->DidUpdateFaviconURL(web_contents()->GetPrimaryMainFrame(),
favicon_urls);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(web_contents_tester()->HasPendingDownloadImage(kIconURL));
}
// Test that Favicon is not requested repeatedly during the same session if
// the favicon is known to be unavailable (e.g. due to HTTP 404 status).
TEST_F(ContentFaviconDriverTest, ShouldNotRequestRepeatedlyIfUnavailable) {
ON_CALL(favicon_service_, WasUnableToDownloadFavicon(kIconURL))
.WillByDefault(Return(true));
// Mimic a page load.
std::vector<blink::mojom::FaviconURLPtr> favicon_urls;
favicon_urls.push_back(blink::mojom::FaviconURL::New(
kIconURL, blink::mojom::FaviconIconType::kFavicon, kEmptyIconSizes,
/*is_default_icon=*/false));
TestFetchFaviconForPage(web_contents(), kPageURL, favicon_urls);
// Verify that no download request is pending for the image.
EXPECT_FALSE(web_contents_tester()->HasPendingDownloadImage(kIconURL));
}
TEST_F(ContentFaviconDriverTest, ShouldDownloadSecondIfFirstUnavailable) {
const GURL kOtherIconURL = GURL("http://www.google.com/other-favicon.ico");
ON_CALL(favicon_service_, WasUnableToDownloadFavicon(kIconURL))
.WillByDefault(Return(true));
// Mimic a page load.
std::vector<blink::mojom::FaviconURLPtr> favicon_urls;
favicon_urls.push_back(blink::mojom::FaviconURL::New(
kIconURL, blink::mojom::FaviconIconType::kFavicon, kEmptyIconSizes,
/*is_default_icon=*/false));
favicon_urls.push_back(blink::mojom::FaviconURL::New(
kOtherIconURL, blink::mojom::FaviconIconType::kFavicon, kEmptyIconSizes,
/*is_default_icon=*/false));
TestFetchFaviconForPage(web_contents(), kPageURL, favicon_urls);
// Verify a download request is pending for the second image.
EXPECT_FALSE(web_contents_tester()->HasPendingDownloadImage(kIconURL));
EXPECT_TRUE(web_contents_tester()->HasPendingDownloadImage(kOtherIconURL));
}
using ContentFaviconDriverTestNoFaviconService =
content::RenderViewHostTestHarness;
// This test verifies a crash doesn't happen during deletion of the
// WebContents. The crash occurred because ~WebContentsImpl would trigger
// running callbacks for manifests. This mean FaviconHandler would be called
// while ContentFaviconDriver::web_contents() was null, which is unexpected and
// crashed. See https://crbug.com/1114237 for more.
TEST_F(ContentFaviconDriverTestNoFaviconService,
WebContentsDeletedWithInProgressManifestRequest) {
ContentFaviconDriver::CreateForWebContents(web_contents(), nullptr);
// Manifests are only downloaded with TOUCH_LARGEST. Force creating this
// handler so code path is exercised on all platforms.
favicon::ContentFaviconDriver* driver =
favicon::ContentFaviconDriver::FromWebContents(web_contents());
FaviconDriverImplTestHelper::RecreateHandlerForType(
driver, FaviconDriverObserver::TOUCH_LARGEST);
// Mimic a page load.
std::vector<blink::mojom::FaviconURLPtr> favicon_urls;
favicon_urls.push_back(blink::mojom::FaviconURL::New(
GURL("http://www.google.com/favicon.ico"),
blink::mojom::FaviconIconType::kTouchIcon, std::vector<gfx::Size>(),
/*is_default_icon=*/false));
TestFetchFaviconForPage(web_contents(), GURL("http://www.google.com/"),
favicon_urls);
// Trigger downloading a manifest.
static_cast<content::WebContentsObserver*>(driver)->DidUpdateWebManifestURL(
web_contents()->GetPrimaryMainFrame(), GURL("http://bad.manifest.com"));
// The request for the manifest is still pending, delete the WebContents,
// which should trigger notifying the callback for the manifest and *not*
// crash.
DeleteContents();
}
} // namespace
} // namespace favicon
|
