1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "components/favicon/core/favicon_database.h"
#include <stddef.h>
#include <algorithm>
#include <vector>
#include "base/files/file_enumerator.h"
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ref_counted_memory.h"
#include "base/path_service.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "components/favicon_base/favicon_types.h"
#include "components/history/core/test/database_test_utils.h"
#include "sql/database.h"
#include "sql/recovery.h"
#include "sql/test/scoped_error_expecter.h"
#include "sql/test/test_helpers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
#include "url/origin.h"
using testing::AllOf;
using testing::ElementsAre;
using testing::Field;
using testing::Pair;
using testing::Return;
namespace favicon {
namespace {
// Blobs for the bitmap tests. These aren't real bitmaps. Golden
// database files store the same blobs (see VersionN tests).
const unsigned char kBlob1[] =
"12346102356120394751634516591348710478123649165419234519234512349134";
const unsigned char kBlob2[] =
"goiwuegrqrcomizqyzkjalitbahxfjytrqvpqeroicxmnlkhlzunacxaneviawrtxcywhgef";
const gfx::Size kSmallSize = gfx::Size(16, 16);
const gfx::Size kLargeSize = gfx::Size(32, 32);
// Verify that the up-to-date database has the expected tables and
// columns. Functional tests only check whether the things which
// should be there are, but do not check if extraneous items are
// present. Any extraneous items have the potential to interact
// negatively with future schema changes.
void VerifyTablesAndColumns(sql::Database* db) {
// [meta], [favicons], [favicon_bitmaps], and [icon_mapping].
EXPECT_EQ(4u, sql::test::CountSQLTables(db));
// Implicit index on [meta], index on [favicons], index on
// [favicon_bitmaps], two indices on [icon_mapping].
EXPECT_EQ(5u, sql::test::CountSQLIndices(db));
// [key] and [value].
EXPECT_EQ(2u, sql::test::CountTableColumns(db, "meta"));
// [id], [url], and [icon_type].
EXPECT_EQ(3u, sql::test::CountTableColumns(db, "favicons"));
// [id], [icon_id], [last_updated], [image_data], [width], [height] and
// [last_requested].
EXPECT_EQ(7u, sql::test::CountTableColumns(db, "favicon_bitmaps"));
// [id], [page_url], [icon_id], and [page_url_type].
EXPECT_EQ(4u, sql::test::CountTableColumns(db, "icon_mapping"));
}
// Adds a favicon at `icon_url` with `icon_type` with default bitmap data and
// maps `page_url` to `icon_url`.
void AddAndMapFaviconSimple(FaviconDatabase* db,
const GURL& page_url,
const GURL& icon_url,
favicon_base::IconType icon_type,
PageUrlType page_url_type) {
scoped_refptr<base::RefCountedStaticMemory> data(
new base::RefCountedStaticMemory(kBlob1));
favicon_base::FaviconID favicon_id =
db->AddFavicon(icon_url, icon_type, data, FaviconBitmapType::ON_VISIT,
base::Time::Now(), gfx::Size());
db->AddIconMapping(page_url, favicon_id, page_url_type);
}
void VerifyDatabaseEmpty(sql::Database* db) {
size_t rows = 0;
EXPECT_TRUE(sql::test::CountTableRows(db, "favicons", &rows));
EXPECT_EQ(0u, rows);
EXPECT_TRUE(sql::test::CountTableRows(db, "favicon_bitmaps", &rows));
EXPECT_EQ(0u, rows);
EXPECT_TRUE(sql::test::CountTableRows(db, "icon_mapping", &rows));
EXPECT_EQ(0u, rows);
}
// Helper to check that an expected mapping exists.
[[nodiscard]] bool CheckPageHasIcon(FaviconDatabase* db,
const GURL& page_url,
favicon_base::IconType expected_icon_type,
const GURL& expected_icon_url,
const gfx::Size& expected_icon_size,
size_t expected_icon_contents_size,
const unsigned char* expected_icon_contents,
PageUrlType expected_page_url_type) {
std::vector<IconMapping> icon_mappings;
if (!db->GetIconMappingsForPageURL(page_url, &icon_mappings)) {
ADD_FAILURE() << "failed GetIconMappingsForPageURL()";
return false;
}
// Scan for the expected type.
std::vector<IconMapping>::const_iterator iter = icon_mappings.begin();
for (; iter != icon_mappings.end(); ++iter) {
if (iter->icon_type == expected_icon_type) {
break;
}
}
if (iter == icon_mappings.end()) {
ADD_FAILURE() << "failed to find `expected_icon_type`";
return false;
}
if (expected_icon_url != iter->icon_url) {
EXPECT_EQ(expected_icon_url, iter->icon_url);
return false;
}
std::vector<FaviconBitmap> favicon_bitmaps;
if (!db->GetFaviconBitmaps(iter->icon_id, &favicon_bitmaps)) {
ADD_FAILURE() << "failed GetFaviconBitmaps()";
return false;
}
if (1 != favicon_bitmaps.size()) {
EXPECT_EQ(1u, favicon_bitmaps.size());
return false;
}
if (expected_icon_size != favicon_bitmaps[0].pixel_size) {
EXPECT_EQ(expected_icon_size, favicon_bitmaps[0].pixel_size);
return false;
}
if (expected_icon_contents_size != favicon_bitmaps[0].bitmap_data->size()) {
EXPECT_EQ(expected_icon_contents_size,
favicon_bitmaps[0].bitmap_data->size());
return false;
}
if (memcmp(favicon_bitmaps[0].bitmap_data->front(), expected_icon_contents,
expected_icon_contents_size)) {
ADD_FAILURE() << "failed to match `expected_icon_contents`";
return false;
}
if (expected_page_url_type != iter->page_url_type) {
EXPECT_EQ(expected_page_url_type, iter->page_url_type);
return false;
}
return true;
}
bool CompareIconMappingIconUrl(const IconMapping& a, const IconMapping& b) {
return a.icon_url < b.icon_url;
}
void SortMappingsByIconUrl(std::vector<IconMapping>* mappings) {
std::sort(mappings->begin(), mappings->end(), &CompareIconMappingIconUrl);
}
base::Time GetLastUpdated(FaviconDatabase* db, favicon_base::FaviconID icon) {
base::Time last_updated;
EXPECT_TRUE(db->GetFaviconLastUpdatedTime(icon, &last_updated));
return last_updated;
}
} // namespace
class FaviconDatabaseTest : public testing::Test {
public:
FaviconDatabaseTest() = default;
~FaviconDatabaseTest() override = default;
// Initialize a favicon database instance from the SQL file at
// `golden_path` in the "History/" subdirectory of test data.
std::unique_ptr<FaviconDatabase> LoadFromGolden(const char* golden_path) {
if (!history::CreateDatabaseFromSQL(file_name_, golden_path)) {
ADD_FAILURE() << "Failed loading " << golden_path;
return nullptr;
}
std::unique_ptr<FaviconDatabase> db = std::make_unique<FaviconDatabase>();
EXPECT_EQ(sql::INIT_OK, db->Init(file_name_));
db->BeginTransaction();
return db;
}
protected:
void SetUp() override {
// Get a temporary directory for the test DB files.
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
file_name_ = temp_dir_.GetPath().AppendASCII("TestFavicons.db");
}
// Page and icon urls shared by tests. Present in golden database files (see
// VersionN tests).
const GURL kPageUrl1{"http://google.com/"};
const GURL kPageUrl2{"http://yahoo.com/"};
const GURL kPageUrl3{"http://www.google.com/"};
const GURL kPageUrl4{"http://www.google.com/blank.html"};
const GURL kPageUrl5{"http://www.bing.com/"};
const GURL kIconUrl1{"http://www.google.com/favicon.ico"};
const GURL kIconUrl2{"http://www.yahoo.com/favicon.ico"};
const GURL kIconUrl3{"http://www.google.com/touch.ico"};
const GURL kIconUrl5{"http://www.bing.com/favicon.ico"};
base::ScopedTempDir temp_dir_;
base::FilePath file_name_;
};
TEST_F(FaviconDatabaseTest, AddIconMapping) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com");
base::Time time = base::Time::Now();
favicon_base::FaviconID id =
db.AddFavicon(url, favicon_base::IconType::kTouchIcon, favicon,
FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(0, id);
EXPECT_NE(0, db.AddIconMapping(url, id, PageUrlType::kRedirect));
std::vector<IconMapping> icon_mappings;
EXPECT_TRUE(db.GetIconMappingsForPageURL(url, &icon_mappings));
EXPECT_EQ(1u, icon_mappings.size());
EXPECT_EQ(url, icon_mappings.front().page_url);
EXPECT_EQ(id, icon_mappings.front().icon_id);
EXPECT_EQ(PageUrlType::kRedirect, icon_mappings.front().page_url_type);
}
TEST_F(FaviconDatabaseTest, AddOnDemandFaviconBitmapCreatesCorrectTimestamps) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time add_time;
ASSERT_TRUE(
base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &add_time));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
ASSERT_NE(0, icon);
FaviconBitmapID bitmap = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_DEMAND, add_time, gfx::Size());
ASSERT_NE(0, bitmap);
base::Time last_updated;
base::Time last_requested;
ASSERT_TRUE(db.GetFaviconBitmap(bitmap, &last_updated, &last_requested,
nullptr, nullptr));
EXPECT_EQ(base::Time(), last_updated);
EXPECT_EQ(add_time, last_requested);
}
TEST_F(FaviconDatabaseTest, AddFaviconBitmapCreatesCorrectTimestamps) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time add_time;
ASSERT_TRUE(
base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &add_time));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
ASSERT_NE(0, icon);
FaviconBitmapID bitmap = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_VISIT, add_time, gfx::Size());
ASSERT_NE(0, bitmap);
base::Time last_updated;
base::Time last_requested;
ASSERT_TRUE(db.GetFaviconBitmap(bitmap, &last_updated, &last_requested,
nullptr, nullptr));
EXPECT_EQ(add_time, last_updated);
EXPECT_EQ(base::Time(), last_requested);
}
TEST_F(FaviconDatabaseTest, GetFaviconLastUpdatedTimeReturnsFalseForNoBitmaps) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
ASSERT_NE(0, icon);
base::Time last_updated;
ASSERT_FALSE(db.GetFaviconLastUpdatedTime(icon, &last_updated));
}
TEST_F(FaviconDatabaseTest, GetFaviconLastUpdatedTimeReturnsMaxTime) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time add_time1;
ASSERT_TRUE(
base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &add_time1));
base::Time add_time2 = add_time1 - base::Seconds(1);
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
ASSERT_NE(0, icon);
FaviconBitmapID bitmap1 = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_VISIT, add_time1, gfx::Size());
ASSERT_NE(0, bitmap1);
FaviconBitmapID bitmap2 = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_VISIT, add_time2, gfx::Size());
ASSERT_NE(0, bitmap2);
base::Time last_updated;
ASSERT_TRUE(db.GetFaviconLastUpdatedTime(icon, &last_updated));
EXPECT_EQ(add_time1, last_updated);
}
TEST_F(FaviconDatabaseTest, TouchUpdatesOnDemandFavicons) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
// Create an on-demand favicon.
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
ASSERT_NE(0, icon);
FaviconBitmapID bitmap = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_DEMAND, start, gfx::Size());
ASSERT_NE(0, bitmap);
base::Time end = start + base::Days(kFaviconUpdateLastRequestedAfterDays);
EXPECT_TRUE(db.TouchOnDemandFavicon(url, end));
base::Time last_updated;
base::Time last_requested;
EXPECT_TRUE(db.GetFaviconBitmap(bitmap, &last_updated, &last_requested,
nullptr, nullptr));
// Does not mess with the last_updated field.
EXPECT_EQ(base::Time(), last_updated);
EXPECT_EQ(end, last_requested); // Updates the last_requested field.
}
TEST_F(FaviconDatabaseTest, TouchUpdatesOnlyInfrequently) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
// Create an on-demand favicon.
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
ASSERT_NE(0, icon);
FaviconBitmapID bitmap = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_DEMAND, start, gfx::Size());
ASSERT_NE(0, bitmap);
base::Time end = start + base::Minutes(1);
EXPECT_TRUE(db.TouchOnDemandFavicon(url, end));
base::Time last_requested;
EXPECT_TRUE(
db.GetFaviconBitmap(bitmap, nullptr, &last_requested, nullptr, nullptr));
EXPECT_EQ(start, last_requested); // No update.
}
TEST_F(FaviconDatabaseTest, TouchDoesNotUpdateStandardFavicons) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
// Create a standard favicon.
GURL url("http://google.com");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
EXPECT_NE(0, icon);
FaviconBitmapID bitmap = db.AddFaviconBitmap(
icon, favicon, FaviconBitmapType::ON_VISIT, start, gfx::Size());
EXPECT_NE(0, bitmap);
base::Time end = start + base::Days(kFaviconUpdateLastRequestedAfterDays);
db.TouchOnDemandFavicon(url, end);
base::Time last_updated;
base::Time last_requested;
EXPECT_TRUE(db.GetFaviconBitmap(bitmap, &last_updated, &last_requested,
nullptr, nullptr));
EXPECT_EQ(start, last_updated); // Does not mess with last_updated.
EXPECT_EQ(base::Time(), last_requested); // No update.
}
// Test that FaviconDatabase::GetOldOnDemandFavicons() returns on-demand icons
// which were requested prior to the passed in timestamp.
TEST_F(FaviconDatabaseTest, GetOldOnDemandFaviconsReturnsOld) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com/favicon.ico");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_DEMAND, start, gfx::Size());
ASSERT_NE(0, icon);
// Associate two different URLs with the icon.
GURL page_url1("http://google.com/1");
ASSERT_NE(0, db.AddIconMapping(page_url1, icon, PageUrlType::kRegular));
GURL page_url2("http://google.com/2");
ASSERT_NE(0, db.AddIconMapping(page_url2, icon, PageUrlType::kRegular));
base::Time get_older_than = start + base::Seconds(1);
auto map = db.GetOldOnDemandFavicons(get_older_than);
// The icon is returned.
EXPECT_THAT(map, ElementsAre(Pair(
icon, AllOf(Field(&IconMappingsForExpiry::icon_url, url),
Field(&IconMappingsForExpiry::page_urls,
ElementsAre(page_url1, page_url2))))));
}
// Test that FaviconDatabase::GetOldOnDemandFavicons() returns on-visit icons
// if the on-visit icons have expired. We need this behavior in order to delete
// icons stored via HistoryService::SetOnDemandFavicons() prior to on-demand
// icons setting the "last_requested" time.
TEST_F(FaviconDatabaseTest, GetOldOnDemandFaviconsDoesNotReturnExpired) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com/favicon.ico");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_VISIT, start, gfx::Size());
ASSERT_NE(0, icon);
GURL page_url("http://google.com/");
ASSERT_NE(0, db.AddIconMapping(page_url, icon, PageUrlType::kRegular));
ASSERT_TRUE(db.SetFaviconOutOfDate(icon));
base::Time get_older_than = start + base::Seconds(1);
auto map = db.GetOldOnDemandFavicons(get_older_than);
// No icon is returned.
EXPECT_TRUE(map.empty());
}
// Test that FaviconDatabase::GetOldOnDemandFavicons() does not return
// on-demand icons which were requested after the passed in timestamp.
TEST_F(FaviconDatabaseTest, GetOldOnDemandFaviconsDoesNotReturnFresh) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com/favicon.ico");
favicon_base::FaviconID icon =
db.AddFavicon(url, favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_DEMAND, start, gfx::Size());
ASSERT_NE(0, icon);
ASSERT_NE(0, db.AddIconMapping(GURL("http://google.com/"), icon,
PageUrlType::kRegular));
// Touch the icon 3 weeks later.
base::Time now = start + base::Days(21);
EXPECT_TRUE(db.TouchOnDemandFavicon(url, now));
base::Time get_older_than = start + base::Seconds(1);
auto map = db.GetOldOnDemandFavicons(get_older_than);
// No icon is returned.
EXPECT_TRUE(map.empty());
}
// Test that FaviconDatabase::GetOldOnDemandFavicons() does not return
// non-expired on-visit icons.
TEST_F(FaviconDatabaseTest, GetOldOnDemandFaviconsDoesNotDeleteStandard) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time start;
ASSERT_TRUE(base::Time::FromUTCExploded({2017, 5, 0, 1, 0, 0, 0, 0}, &start));
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
favicon_base::FaviconID icon = db.AddFavicon(
GURL("http://google.com/favicon.ico"), favicon_base::IconType::kFavicon,
favicon, FaviconBitmapType::ON_VISIT, start, gfx::Size());
ASSERT_NE(0, icon);
ASSERT_NE(0, db.AddIconMapping(GURL("http://google.com/"), icon,
PageUrlType::kRegular));
base::Time get_older_than = start + base::Seconds(1);
auto map = db.GetOldOnDemandFavicons(get_older_than);
// No icon is returned.
EXPECT_TRUE(map.empty());
}
TEST_F(FaviconDatabaseTest, DeleteIconMappings) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com");
favicon_base::FaviconID id =
db.AddFavicon(url, favicon_base::IconType::kTouchIcon);
base::Time time = base::Time::Now();
db.AddFaviconBitmap(id, favicon, FaviconBitmapType::ON_VISIT, time,
gfx::Size());
EXPECT_LT(0, db.AddIconMapping(url, id, PageUrlType::kRegular));
favicon_base::FaviconID id2 =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
EXPECT_LT(0, db.AddIconMapping(url, id2, PageUrlType::kRegular));
ASSERT_NE(id, id2);
std::vector<IconMapping> icon_mapping;
EXPECT_TRUE(db.GetIconMappingsForPageURL(url, &icon_mapping));
ASSERT_EQ(2u, icon_mapping.size());
EXPECT_EQ(icon_mapping.front().icon_type, favicon_base::IconType::kTouchIcon);
EXPECT_TRUE(db.GetIconMappingsForPageURL(
url, {favicon_base::IconType::kFavicon}, nullptr));
db.DeleteIconMappings(url);
EXPECT_FALSE(db.GetIconMappingsForPageURL(url, nullptr));
EXPECT_FALSE(db.GetIconMappingsForPageURL(
url, {favicon_base::IconType::kFavicon}, nullptr));
}
TEST_F(FaviconDatabaseTest, GetIconMappingsForPageURL) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL url("http://google.com");
favicon_base::FaviconID id1 =
db.AddFavicon(url, favicon_base::IconType::kTouchIcon);
base::Time time = base::Time::Now();
db.AddFaviconBitmap(id1, favicon, FaviconBitmapType::ON_VISIT, time,
kSmallSize);
db.AddFaviconBitmap(id1, favicon, FaviconBitmapType::ON_VISIT, time,
kLargeSize);
EXPECT_LT(0, db.AddIconMapping(url, id1, PageUrlType::kRegular));
favicon_base::FaviconID id2 =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
EXPECT_NE(id1, id2);
db.AddFaviconBitmap(id2, favicon, FaviconBitmapType::ON_VISIT, time,
kSmallSize);
EXPECT_LT(0, db.AddIconMapping(url, id2, PageUrlType::kRegular));
std::vector<IconMapping> icon_mappings;
EXPECT_TRUE(db.GetIconMappingsForPageURL(url, &icon_mappings));
ASSERT_EQ(2u, icon_mappings.size());
EXPECT_EQ(id1, icon_mappings[0].icon_id);
EXPECT_EQ(id2, icon_mappings[1].icon_id);
}
TEST_F(FaviconDatabaseTest, RetainDataForPageUrls) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
// Build a database mapping
// kPageUrl1 -> kIconUrl1
// kPageUrl2 -> kIconUrl2
// kPageUrl3 -> kIconUrl1
// kPageUrl4 -> kIconUrl1
// kPageUrl5 -> kIconUrl5
// Then retain kPageUrl1, kPageUrl3, and kPageUrl5. kPageUrl2
// and kPageUrl4 should go away, but the others should be retained
// correctly.
// TODO(shess): This would probably make sense as a golden file.
scoped_refptr<base::RefCountedStaticMemory> favicon1(
new base::RefCountedStaticMemory(kBlob1));
scoped_refptr<base::RefCountedStaticMemory> favicon2(
new base::RefCountedStaticMemory(kBlob2));
favicon_base::FaviconID kept_id1 =
db.AddFavicon(kIconUrl1, favicon_base::IconType::kFavicon);
db.AddFaviconBitmap(kept_id1, favicon1, FaviconBitmapType::ON_VISIT,
base::Time::Now(), kLargeSize);
db.AddIconMapping(kPageUrl1, kept_id1, PageUrlType::kRegular);
db.AddIconMapping(kPageUrl3, kept_id1, PageUrlType::kRegular);
db.AddIconMapping(kPageUrl4, kept_id1, PageUrlType::kRegular);
favicon_base::FaviconID unkept_id =
db.AddFavicon(kIconUrl2, favicon_base::IconType::kFavicon);
db.AddFaviconBitmap(unkept_id, favicon1, FaviconBitmapType::ON_VISIT,
base::Time::Now(), kLargeSize);
db.AddIconMapping(kPageUrl2, unkept_id, PageUrlType::kRegular);
favicon_base::FaviconID kept_id2 =
db.AddFavicon(kIconUrl5, favicon_base::IconType::kFavicon);
db.AddFaviconBitmap(kept_id2, favicon2, FaviconBitmapType::ON_VISIT,
base::Time::Now(), kLargeSize);
db.AddIconMapping(kPageUrl5, kept_id2, PageUrlType::kRedirect);
// RetainDataForPageUrls() uses schema manipulations for efficiency.
// Grab a copy of the schema to make sure the final schema matches.
const std::string original_schema = db.db_.GetSchema();
std::vector<GURL> pages_to_keep;
pages_to_keep.push_back(kPageUrl1);
pages_to_keep.push_back(kPageUrl3);
pages_to_keep.push_back(kPageUrl5);
EXPECT_TRUE(db.RetainDataForPageUrls(pages_to_keep));
// Mappings from the retained urls should be left.
EXPECT_TRUE(CheckPageHasIcon(&db, kPageUrl1, favicon_base::IconType::kFavicon,
kIconUrl1, kLargeSize, sizeof(kBlob1), kBlob1,
PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(&db, kPageUrl3, favicon_base::IconType::kFavicon,
kIconUrl1, kLargeSize, sizeof(kBlob1), kBlob1,
PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(&db, kPageUrl5, favicon_base::IconType::kFavicon,
kIconUrl5, kLargeSize, sizeof(kBlob2), kBlob2,
PageUrlType::kRedirect));
// The ones not retained should be missing.
EXPECT_FALSE(db.GetIconMappingsForPageURL(kPageUrl2, nullptr));
EXPECT_FALSE(db.GetIconMappingsForPageURL(kPageUrl4, nullptr));
// Schema should be the same.
EXPECT_EQ(original_schema, db.db_.GetSchema());
}
// Test that RetainDataForPageUrls() expires retained favicons.
TEST_F(FaviconDatabaseTest, RetainDataForPageUrlsExpiresRetainedFavicons) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
scoped_refptr<base::RefCountedStaticMemory> favicon1(
new base::RefCountedStaticMemory(kBlob1));
favicon_base::FaviconID kept_id = db.AddFavicon(
kIconUrl1, favicon_base::IconType::kFavicon, favicon1,
FaviconBitmapType::ON_VISIT, base::Time::Now(), gfx::Size());
db.AddIconMapping(kPageUrl1, kept_id, PageUrlType::kRegular);
EXPECT_TRUE(db.RetainDataForPageUrls(std::vector<GURL>(1u, kPageUrl1)));
favicon_base::FaviconID new_favicon_id =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon);
ASSERT_NE(0, new_favicon_id);
std::vector<FaviconBitmap> new_favicon_bitmaps;
db.GetFaviconBitmaps(new_favicon_id, &new_favicon_bitmaps);
ASSERT_EQ(1u, new_favicon_bitmaps.size());
EXPECT_EQ(0, new_favicon_bitmaps[0].last_updated.ToInternalValue());
}
// Tests that deleting a favicon deletes the favicon row and favicon bitmap
// rows from the database.
TEST_F(FaviconDatabaseTest, DeleteFavicon) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
std::vector<unsigned char> data1(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon1(
new base::RefCountedBytes(data1));
std::vector<unsigned char> data2(kBlob2, kBlob2 + sizeof(kBlob2));
scoped_refptr<base::RefCountedBytes> favicon2(
new base::RefCountedBytes(data2));
GURL url("http://google.com");
favicon_base::FaviconID id =
db.AddFavicon(url, favicon_base::IconType::kFavicon);
base::Time last_updated = base::Time::Now();
db.AddFaviconBitmap(id, favicon1, FaviconBitmapType::ON_VISIT, last_updated,
kSmallSize);
db.AddFaviconBitmap(id, favicon2, FaviconBitmapType::ON_VISIT, last_updated,
kLargeSize);
EXPECT_TRUE(db.GetFaviconBitmaps(id, nullptr));
EXPECT_TRUE(db.DeleteFavicon(id));
EXPECT_FALSE(db.GetFaviconBitmaps(id, nullptr));
}
TEST_F(FaviconDatabaseTest, GetIconMappingsForPageURLForReturnOrder) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
// Add a favicon
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
GURL page_url("http://google.com");
GURL icon_url("http://google.com/favicon.ico");
base::Time time = base::Time::Now();
favicon_base::FaviconID id =
db.AddFavicon(icon_url, favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(0, db.AddIconMapping(page_url, id, PageUrlType::kRegular));
std::vector<IconMapping> icon_mappings;
EXPECT_TRUE(db.GetIconMappingsForPageURL(page_url, &icon_mappings));
EXPECT_EQ(page_url, icon_mappings.front().page_url);
EXPECT_EQ(id, icon_mappings.front().icon_id);
EXPECT_EQ(favicon_base::IconType::kFavicon, icon_mappings.front().icon_type);
EXPECT_EQ(icon_url, icon_mappings.front().icon_url);
// Add a touch icon
std::vector<unsigned char> data2(kBlob2, kBlob2 + sizeof(kBlob2));
scoped_refptr<base::RefCountedBytes> favicon2 =
new base::RefCountedBytes(data);
favicon_base::FaviconID id2 =
db.AddFavicon(icon_url, favicon_base::IconType::kTouchIcon, favicon2,
FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(0, db.AddIconMapping(page_url, id2, PageUrlType::kRegular));
icon_mappings.clear();
EXPECT_TRUE(db.GetIconMappingsForPageURL(page_url, &icon_mappings));
EXPECT_EQ(page_url, icon_mappings.front().page_url);
EXPECT_EQ(id2, icon_mappings.front().icon_id);
EXPECT_EQ(favicon_base::IconType::kTouchIcon,
icon_mappings.front().icon_type);
EXPECT_EQ(icon_url, icon_mappings.front().icon_url);
// Add a touch precomposed icon
scoped_refptr<base::RefCountedBytes> favicon3 =
new base::RefCountedBytes(data2);
favicon_base::FaviconID id3 =
db.AddFavicon(icon_url, favicon_base::IconType::kTouchPrecomposedIcon,
favicon3, FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(0, db.AddIconMapping(page_url, id3, PageUrlType::kRegular));
icon_mappings.clear();
EXPECT_TRUE(db.GetIconMappingsForPageURL(page_url, &icon_mappings));
EXPECT_EQ(page_url, icon_mappings.front().page_url);
EXPECT_EQ(id3, icon_mappings.front().icon_id);
EXPECT_EQ(favicon_base::IconType::kTouchPrecomposedIcon,
icon_mappings.front().icon_type);
EXPECT_EQ(icon_url, icon_mappings.front().icon_url);
}
// Test that when multiple icon types are passed to GetIconMappingsForPageURL()
// that the results are filtered according to the passed in types.
TEST_F(FaviconDatabaseTest, GetIconMappingsForPageURLWithIconTypes) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
const GURL kPageUrl("http://www.google.com");
AddAndMapFaviconSimple(&db, kPageUrl, kIconUrl1,
favicon_base::IconType::kFavicon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kPageUrl, kIconUrl2,
favicon_base::IconType::kTouchIcon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kPageUrl, kIconUrl3,
favicon_base::IconType::kTouchIcon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kPageUrl, kIconUrl5,
favicon_base::IconType::kTouchPrecomposedIcon,
PageUrlType::kRegular);
// Only the mappings for kFavicon and kTouchIcon should be returned.
std::vector<IconMapping> icon_mappings;
EXPECT_TRUE(db.GetIconMappingsForPageURL(
kPageUrl,
{favicon_base::IconType::kFavicon, favicon_base::IconType::kTouchIcon},
&icon_mappings));
SortMappingsByIconUrl(&icon_mappings);
ASSERT_EQ(3u, icon_mappings.size());
EXPECT_EQ(kIconUrl1, icon_mappings[0].icon_url);
EXPECT_EQ(kIconUrl3, icon_mappings[1].icon_url);
EXPECT_EQ(kIconUrl2, icon_mappings[2].icon_url);
}
TEST_F(FaviconDatabaseTest, FindBestPageURLForHost) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
const GURL kPageUrlHttp("http://www.google.com");
const GURL kPageUrlHttps("https://www.google.com");
const GURL kPageUrlHttpsSamePrefix("https://www.google.com.au");
const GURL kPageUrlHttpsSameSuffix("https://m.www.google.com");
const GURL kPageUrlInPath("https://www.example.com/www.google.com/");
EXPECT_FALSE(db.FindBestPageURLForHost(
kPageUrlHttps,
{favicon_base::IconType::kFavicon, favicon_base::IconType::kTouchIcon}));
AddAndMapFaviconSimple(&db, kPageUrlHttpsSamePrefix, kIconUrl1,
favicon_base::IconType::kFavicon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kPageUrlHttpsSameSuffix, kIconUrl2,
favicon_base::IconType::kFavicon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kPageUrlInPath, kIconUrl3,
favicon_base::IconType::kTouchIcon,
PageUrlType::kRegular);
// There should be no matching host for www.google.com when no matching host
// exists with the required icon types.
EXPECT_FALSE(db.FindBestPageURLForHost(kPageUrlHttps,
{favicon_base::IconType::kFavicon}));
// Register the HTTP url in the database as a touch icon.
AddAndMapFaviconSimple(&db, kPageUrlHttp, kIconUrl5,
favicon_base::IconType::kTouchIcon,
PageUrlType::kRegular);
EXPECT_FALSE(db.FindBestPageURLForHost(kPageUrlHttps,
{favicon_base::IconType::kFavicon}));
// Expect a match when we search for a TouchIcon.
std::optional<GURL> result = db.FindBestPageURLForHost(
kPageUrlHttps,
{favicon_base::IconType::kFavicon, favicon_base::IconType::kTouchIcon});
EXPECT_EQ(kPageUrlHttp, result.value());
// Expect that when we query for icon mappings with the result, we retrieve
// the correct icon URL.
std::vector<IconMapping> icon_mappings;
EXPECT_TRUE(db.GetIconMappingsForPageURL(
result.value(),
{favicon_base::IconType::kFavicon, favicon_base::IconType::kTouchIcon},
&icon_mappings));
ASSERT_EQ(1u, icon_mappings.size());
EXPECT_EQ(kIconUrl5, icon_mappings[0].icon_url);
}
TEST_F(FaviconDatabaseTest, FindBestPageURLForHostRedirect) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
const GURL kHostUrl("https://www.google.com/");
const GURL kDestinationUrl("https://www.example.com/");
const GURL kHostRedirectUrl("https://www.google.com/url?q=www.example.com");
const GURL kHostUnmappedUrl("https://www.google.com/search?q=cats");
AddAndMapFaviconSimple(&db, kHostUrl, kIconUrl1,
favicon_base::IconType::kFavicon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kDestinationUrl, kIconUrl2,
favicon_base::IconType::kWebManifestIcon,
PageUrlType::kRegular);
AddAndMapFaviconSimple(&db, kHostRedirectUrl, kIconUrl2,
favicon_base::IconType::kWebManifestIcon,
PageUrlType::kRedirect);
// Populate database in order to test that database entries of
// PageUrlType::kRegular but lower favicon_base::IconType have higher
// priority over database entries of PageUrlType::kRedirect and higher
// favicon_base::IconType.
std::optional<GURL> result = db.FindBestPageURLForHost(
kHostUnmappedUrl, {favicon_base::IconType::kFavicon,
favicon_base::IconType::kWebManifestIcon});
EXPECT_EQ(kHostUrl, *result);
}
TEST_F(FaviconDatabaseTest, HasMappingFor) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
// Add a favicon which will have icon_mappings
base::Time time = base::Time::Now();
favicon_base::FaviconID id1 =
db.AddFavicon(GURL("http://google.com"), favicon_base::IconType::kFavicon,
favicon, FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(id1, 0);
// Add another type of favicon
time = base::Time::Now();
favicon_base::FaviconID id2 = db.AddFavicon(
GURL("http://www.google.com/icon"), favicon_base::IconType::kTouchIcon,
favicon, FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(id2, 0);
// Add 3rd favicon
time = base::Time::Now();
favicon_base::FaviconID id3 = db.AddFavicon(
GURL("http://www.google.com/icon"), favicon_base::IconType::kTouchIcon,
favicon, FaviconBitmapType::ON_VISIT, time, gfx::Size());
EXPECT_NE(id3, 0);
// Add 2 icon mapping
GURL page_url("http://www.google.com");
EXPECT_TRUE(db.AddIconMapping(page_url, id1, PageUrlType::kRegular));
EXPECT_TRUE(db.AddIconMapping(page_url, id2, PageUrlType::kRegular));
EXPECT_TRUE(db.HasMappingFor(id1));
EXPECT_TRUE(db.HasMappingFor(id2));
EXPECT_FALSE(db.HasMappingFor(id3));
// Remove all mappings
db.DeleteIconMappings(page_url);
EXPECT_FALSE(db.HasMappingFor(id1));
EXPECT_FALSE(db.HasMappingFor(id2));
EXPECT_FALSE(db.HasMappingFor(id3));
}
// Test loading version 3 database.
TEST_F(FaviconDatabaseTest, Version3) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v3.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
// Version 3 is deprecated, the data should all be gone.
VerifyDatabaseEmpty(&db->db_);
}
// Test loading version 4 database.
TEST_F(FaviconDatabaseTest, Version4) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v4.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
// Version 4 is deprecated, the data should all be gone.
VerifyDatabaseEmpty(&db->db_);
}
// Test loading version 5 database.
TEST_F(FaviconDatabaseTest, Version5) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v5.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
// Version 5 is deprecated, the data should all be gone.
VerifyDatabaseEmpty(&db->db_);
}
// Test loading version 6 database.
TEST_F(FaviconDatabaseTest, Version6) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v6.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
// Version 6 is deprecated, the data should all be gone.
VerifyDatabaseEmpty(&db->db_);
}
// Test loading version 7 database.
TEST_F(FaviconDatabaseTest, Version7) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v7.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
// Version 7 is deprecated, the data should all be gone.
VerifyDatabaseEmpty(&db->db_);
}
// Test loading version 8 database.
TEST_F(FaviconDatabaseTest, Version8) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v8.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1,
kLargeSize, sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2,
kLargeSize, sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl3, favicon_base::IconType::kFavicon, kIconUrl1,
kLargeSize, sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl3, favicon_base::IconType::kTouchIcon, kIconUrl3,
kLargeSize, sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
}
// Test loading version 9 database.
TEST_F(FaviconDatabaseTest, Version9) {
std::unique_ptr<FaviconDatabase> db = LoadFromGolden("Favicons.v9.sql");
ASSERT_TRUE(db);
VerifyTablesAndColumns(&db->db_);
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1,
kLargeSize, sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2,
kLargeSize, sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl3, favicon_base::IconType::kFavicon, kIconUrl1,
kLargeSize, sizeof(kBlob1), kBlob1, PageUrlType::kRedirect));
EXPECT_TRUE(CheckPageHasIcon(
db.get(), kPageUrl3, favicon_base::IconType::kTouchIcon, kIconUrl3,
kLargeSize, sizeof(kBlob2), kBlob2, PageUrlType::kRedirect));
}
TEST_F(FaviconDatabaseTest, RecoveryLatest) {
// Create an example database.
{
EXPECT_TRUE(history::CreateDatabaseFromSQL(file_name_, "Favicons.v9.sql"));
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
VerifyTablesAndColumns(&raw_db);
}
// Test that the contents make sense after clean open.
{
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1, kLargeSize,
sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2, kLargeSize,
sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
}
// Corrupt the `icon_mapping.page_url` index by zeroing its root page.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
ASSERT_EQ("ok", sql::test::IntegrityCheck(raw_db));
}
static const char kIndexName[] = "icon_mapping_page_url_idx";
ASSERT_TRUE(sql::test::CorruptIndexRootPage(file_name_, kIndexName));
// Database should be corrupt at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
EXPECT_NE("ok", sql::test::IntegrityCheck(raw_db));
}
// Open the database and access the corrupt index.
{
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
// Accessing the index will throw SQLITE_CORRUPT. The corruption handler
// will recover the database and poison the handle, so the outer call
// fails.
EXPECT_FALSE(db.GetIconMappingsForPageURL(kPageUrl2, nullptr));
ASSERT_TRUE(expecter.SawExpectedErrors());
}
}
// Check that the database is recovered at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
ASSERT_EQ("ok", sql::test::IntegrityCheck(raw_db));
// Check that the expected tables exist.
VerifyTablesAndColumns(&raw_db);
}
// Database should also be recovered at higher levels. Recovery should have
// regenerated the index with no data loss.
{
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1, kLargeSize,
sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2, kLargeSize,
sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
}
// Corrupt the database again by adjusting the header.
EXPECT_TRUE(sql::test::CorruptSizeInHeader(file_name_));
// Database is unusable at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
EXPECT_FALSE(raw_db.Open(file_name_));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
EXPECT_EQ("ok", sql::test::IntegrityCheck(raw_db));
}
// Database should be recovered during open.
{
FaviconDatabase db;
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
ASSERT_TRUE(expecter.SawExpectedErrors());
}
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1, kLargeSize,
sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2, kLargeSize,
sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
}
}
TEST_F(FaviconDatabaseTest, Recovery8) {
// Create an example database without loading into FaviconDatabase which would
// upgrade it.
EXPECT_TRUE(history::CreateDatabaseFromSQL(file_name_, "Favicons.v8.sql"));
// Corrupt the `icon_mapping.page_url` index by zeroing its root page.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
ASSERT_EQ("ok", sql::test::IntegrityCheck(raw_db));
}
static const char kIndexName[] = "icon_mapping_page_url_idx";
ASSERT_TRUE(sql::test::CorruptIndexRootPage(file_name_, kIndexName));
// Database should be corrupt at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
EXPECT_NE("ok", sql::test::IntegrityCheck(raw_db));
}
// Open the database and access the corrupt index. Note that this upgrades
// the database.
{
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
// Accessing the index will throw SQLITE_CORRUPT. The corruption handler
// will recover the database and poison the handle, so the outer call
// fails.
EXPECT_FALSE(db.GetIconMappingsForPageURL(kPageUrl2, nullptr));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
}
// Check that the database is recovered at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
ASSERT_EQ("ok", sql::test::IntegrityCheck(raw_db));
// Check that the expected tables exist.
VerifyTablesAndColumns(&raw_db);
}
// Database should also be recovered at higher levels. Recovery should have
// regenerated the index with no data loss.
{
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1, kLargeSize,
sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2, kLargeSize,
sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
}
// Corrupt the database again by adjusting the header.
EXPECT_TRUE(sql::test::CorruptSizeInHeader(file_name_));
// Database is unusable at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
ASSERT_FALSE(raw_db.Open(file_name_));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
EXPECT_EQ("ok", sql::test::IntegrityCheck(raw_db));
}
// Database should be recovered during open.
{
FaviconDatabase db;
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl1, favicon_base::IconType::kFavicon, kIconUrl1, kLargeSize,
sizeof(kBlob1), kBlob1, PageUrlType::kRegular));
EXPECT_TRUE(CheckPageHasIcon(
&db, kPageUrl2, favicon_base::IconType::kFavicon, kIconUrl2, kLargeSize,
sizeof(kBlob2), kBlob2, PageUrlType::kRegular));
}
}
TEST_F(FaviconDatabaseTest, Recovery7) {
// Create an example database without loading into FaviconDatabase
// (which would upgrade it).
EXPECT_TRUE(history::CreateDatabaseFromSQL(file_name_, "Favicons.v7.sql"));
// Corrupt the database by adjusting the header. This form of corruption will
// cause immediate failures during Open(), before the database is razed due to
// its version being deprecated for being too old.
EXPECT_TRUE(sql::test::CorruptSizeInHeader(file_name_));
// Database is unusable at the SQLite level.
{
sql::Database raw_db(sql::test::kTestTag);
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
EXPECT_FALSE(raw_db.Open(file_name_));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
EXPECT_EQ("ok", sql::test::IntegrityCheck(raw_db));
}
// Database open should succeed.
{
FaviconDatabase db;
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(sql::SqliteResultCode::kCorrupt);
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
EXPECT_TRUE(expecter.SawExpectedErrors());
}
// The database should be usable at the SQLite level, with a current schema
// and no data.
{
sql::Database raw_db(sql::test::kTestTag);
EXPECT_TRUE(raw_db.Open(file_name_));
ASSERT_EQ("ok", sql::test::IntegrityCheck(raw_db));
// Check that the expected tables exist.
VerifyTablesAndColumns(&raw_db);
// Version 7 recovery is deprecated, the data should all be gone.
VerifyDatabaseEmpty(&raw_db);
}
}
// Test that various broken schema found in the wild can be opened
// successfully, and result in the correct schema.
TEST_F(FaviconDatabaseTest, WildSchema) {
base::FilePath sql_path;
EXPECT_TRUE(history::GetTestDataHistoryDir(&sql_path));
sql_path = sql_path.AppendASCII("thumbnail_wild");
base::FileEnumerator fe(sql_path, false, base::FileEnumerator::FILES,
FILE_PATH_LITERAL("*.sql"));
for (base::FilePath name = fe.Next(); !name.empty(); name = fe.Next()) {
SCOPED_TRACE(name.BaseName().AsUTF8Unsafe());
// Generate a database path based on the golden's basename.
base::FilePath db_base_name =
name.BaseName().ReplaceExtension(FILE_PATH_LITERAL("db"));
base::FilePath db_path = file_name_.DirName().Append(db_base_name);
ASSERT_TRUE(sql::test::CreateDatabaseFromSQL(db_path, name));
// All schema flaws should be cleaned up by Init().
// TODO(shess): Differentiate between databases which need Raze()
// and those which can be salvaged.
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(db_path));
// Verify that the resulting schema is correct, whether it
// involved razing the file or fixing things in place.
VerifyTablesAndColumns(&db.db_);
}
}
TEST(FaviconDatabaseIconTypeTest, ShouldBeBackwardCompatible) {
EXPECT_EQ(0, FaviconDatabase::ToPersistedIconType(
favicon_base::IconType::kInvalid));
EXPECT_EQ(1, FaviconDatabase::ToPersistedIconType(
favicon_base::IconType::kFavicon));
EXPECT_EQ(2, FaviconDatabase::ToPersistedIconType(
favicon_base::IconType::kTouchIcon));
EXPECT_EQ(4, FaviconDatabase::ToPersistedIconType(
favicon_base::IconType::kTouchPrecomposedIcon));
EXPECT_EQ(8, FaviconDatabase::ToPersistedIconType(
favicon_base::IconType::kWebManifestIcon));
EXPECT_EQ(favicon_base::IconType::kInvalid,
FaviconDatabase::FromPersistedIconType(0));
EXPECT_EQ(favicon_base::IconType::kFavicon,
FaviconDatabase::FromPersistedIconType(1));
EXPECT_EQ(favicon_base::IconType::kTouchIcon,
FaviconDatabase::FromPersistedIconType(2));
EXPECT_EQ(favicon_base::IconType::kTouchPrecomposedIcon,
FaviconDatabase::FromPersistedIconType(4));
EXPECT_EQ(favicon_base::IconType::kWebManifestIcon,
FaviconDatabase::FromPersistedIconType(8));
EXPECT_EQ(favicon_base::IconType::kInvalid,
FaviconDatabase::FromPersistedIconType(16));
}
TEST_F(FaviconDatabaseTest, GetFaviconsLastUpdatedBefore) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
// Add two favicons, 10 seconds apart. `time1` is after `time2`.
GURL url("http://google.com");
const base::Time time1 = base::Time::Now();
favicon_base::FaviconID id1 =
db.AddFavicon(url, favicon_base::IconType::kTouchIcon, favicon,
FaviconBitmapType::ON_VISIT, time1, gfx::Size());
EXPECT_NE(0u, id1);
const base::Time time2 = time1 - base::Seconds(10);
favicon_base::FaviconID id2 =
db.AddFavicon(url, favicon_base::IconType::kTouchIcon, favicon,
FaviconBitmapType::ON_VISIT, time2, gfx::Size());
EXPECT_NE(0u, id2);
EXPECT_NE(id1, id2);
// There should be no favicons before `time2`.
EXPECT_TRUE(
db.GetFaviconsLastUpdatedBefore(time2 - base::Seconds(1), 10).empty());
// Requesting a time after `time2` should return `id2`.
auto ids = db.GetFaviconsLastUpdatedBefore(time2 + base::Seconds(1), 10);
ASSERT_EQ(1u, ids.size());
EXPECT_EQ(id2, ids[0]);
// There should two favicons when using a time after `time1`.
ids = db.GetFaviconsLastUpdatedBefore(time1 + base::Seconds(1), 10);
ASSERT_EQ(2u, ids.size());
// `id2` is before `id1`, so it should be returned first.
EXPECT_EQ(id2, ids[0]);
EXPECT_EQ(id1, ids[1]);
// Repeat previous, but cap the max at 1.
ids = db.GetFaviconsLastUpdatedBefore(time1 + base::Seconds(1), 1);
ASSERT_EQ(1u, ids.size());
// `id2` is before `id1`, so it should be returned first.
EXPECT_EQ(id2, ids[0]);
}
TEST_F(FaviconDatabaseTest, SetFaviconsOutOfDateBetween) {
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
base::Time t1 = base::Time::Now() - base::Minutes(3);
base::Time t2 = base::Time::Now() - base::Minutes(2);
base::Time t3 = base::Time::Now() - base::Minutes(1);
std::vector<unsigned char> data(kBlob1, kBlob1 + sizeof(kBlob1));
scoped_refptr<base::RefCountedBytes> favicon(new base::RefCountedBytes(data));
favicon_base::FaviconID icon1 =
db.AddFavicon(GURL("http://a.example.com/favicon.ico"),
favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_VISIT, t1, gfx::Size());
favicon_base::FaviconID icon2 =
db.AddFavicon(GURL("http://b.example.com/favicon.ico"),
favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_VISIT, t2, gfx::Size());
favicon_base::FaviconID icon3 =
db.AddFavicon(GURL("http://c.example.com/favicon.ico"),
favicon_base::IconType::kFavicon, favicon,
FaviconBitmapType::ON_VISIT, t3, gfx::Size());
EXPECT_EQ(t1, GetLastUpdated(&db, icon1));
EXPECT_EQ(t2, GetLastUpdated(&db, icon2));
EXPECT_EQ(t3, GetLastUpdated(&db, icon3));
db.SetFaviconsOutOfDateBetween(t2, t3);
EXPECT_EQ(t1, GetLastUpdated(&db, icon1));
EXPECT_EQ(base::Time(), GetLastUpdated(&db, icon2));
EXPECT_EQ(t3, GetLastUpdated(&db, icon3));
db.SetFaviconsOutOfDateBetween(base::Time(), base::Time::Max());
EXPECT_EQ(base::Time(), GetLastUpdated(&db, icon1));
EXPECT_EQ(base::Time(), GetLastUpdated(&db, icon2));
EXPECT_EQ(base::Time(), GetLastUpdated(&db, icon3));
}
// Test that GetFaviconIDForFaviconURL can filter by origin.
TEST_F(FaviconDatabaseTest, GetFaviconIDForFaviconURLOriginFilter) {
// Setup DB with `kPageUrl1` mapped to `kIconUrl1`.
FaviconDatabase db;
ASSERT_EQ(sql::INIT_OK, db.Init(file_name_));
db.BeginTransaction();
scoped_refptr<base::RefCountedStaticMemory> favicon1(
new base::RefCountedStaticMemory(kBlob1));
const auto icon_id = db.AddFavicon(
kIconUrl1, favicon_base::IconType::kFavicon, favicon1,
FaviconBitmapType::ON_VISIT, base::Time::Now(), gfx::Size());
db.AddIconMapping(kPageUrl1, icon_id, PageUrlType::kRegular);
ASSERT_NE(0, icon_id);
// We should be able to find the `icon_id` via the non-filtered function.
auto icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon);
ASSERT_EQ(icon_id, icon_id_found);
// We should be able to find the `icon_id` via a the origin of `kPageUrl1`.
icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon,
url::Origin::Create(kPageUrl1));
ASSERT_EQ(icon_id, icon_id_found);
// We shouldn't be able to find the `icon_id` via a the origin of `kPageUrl2`.
icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon,
url::Origin::Create(kPageUrl2));
ASSERT_EQ(0, icon_id_found);
// We shouldn't be able to find the `icon_id` via a the origin of `kPageUrl3`.
icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon,
url::Origin::Create(kPageUrl3));
ASSERT_EQ(0, icon_id_found);
// If we map `kPageUrl2` then the situation changes.
db.AddIconMapping(kPageUrl2, icon_id, PageUrlType::kRegular);
// We should be able to find the `icon_id` via a the origin of `kPageUrl1`.
icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon,
url::Origin::Create(kPageUrl1));
ASSERT_EQ(icon_id, icon_id_found);
// We should be able to find the `icon_id` via a the origin of `kPageUrl2`.
icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon,
url::Origin::Create(kPageUrl2));
ASSERT_EQ(icon_id, icon_id_found);
// We shouldn't be able to find the `icon_id` via a the origin of `kPageUrl3`.
icon_id_found =
db.GetFaviconIDForFaviconURL(kIconUrl1, favicon_base::IconType::kFavicon,
url::Origin::Create(kPageUrl3));
ASSERT_EQ(0, icon_id_found);
}
} // namespace favicon
|