1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/history_clusters/core/config.h"
#include "base/command_line.h"
#include "base/containers/contains.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/no_destructor.h"
#include "base/strings/string_split.h"
#include "build/build_config.h"
#include "components/history_clusters/core/features.h"
#include "components/history_clusters/core/on_device_clustering_features.h"
#include "components/search/ntp_features.h"
#include "ui/base/l10n/l10n_util.h"
namespace history_clusters {
namespace {
Config& GetConfigInternal() {
static base::NoDestructor<Config> s_config;
return *s_config;
}
} // namespace
namespace switches {
const char kShouldShowAllClustersOnProminentUiSurfaces[] =
"history-clusters-should-show-all-clusters-on-prominent-ui-surfaces";
} // namespace switches
Config::Config() {
// Override any parameters that may be provided by Finch.
// The `kJourneys` feature and child params.
{
is_journeys_enabled_no_locale_check =
base::FeatureList::IsEnabled(internal::kJourneys);
max_visits_to_cluster = base::GetFieldTrialParamByFeatureAsInt(
internal::kJourneys, "JourneysMaxVisitsToCluster",
max_visits_to_cluster);
max_keyword_phrases = base::GetFieldTrialParamByFeatureAsInt(
internal::kJourneys, "JourneysMaxKeywordPhrases", max_keyword_phrases);
min_score_to_always_show_above_the_fold =
base::GetFieldTrialParamByFeatureAsDouble(
internal::kJourneys, "JourneysMinScoreToAlwaysShowAboveTheFold",
min_score_to_always_show_above_the_fold);
num_visits_to_always_show_above_the_fold =
base::GetFieldTrialParamByFeatureAsInt(
internal::kJourneys, "JourneysNumVisitsToAlwaysShowAboveTheFold",
num_visits_to_always_show_above_the_fold);
rescore_visits_within_clusters_for_query =
base::GetFieldTrialParamByFeatureAsBool(
internal::kJourneys, "JourneysRescoreVisitsWithinClustersForQuery",
rescore_visits_within_clusters_for_query);
sort_clusters_within_batch_for_query =
base::GetFieldTrialParamByFeatureAsBool(
internal::kJourneys, "JourneysSortClustersWithinBatchForQuery",
sort_clusters_within_batch_for_query);
}
// The `kJourneysImages` feature.
{
images = base::FeatureList::IsEnabled(internal::kJourneysImages);
images_cover = GetFieldTrialParamByFeatureAsBool(
internal::kJourneysImages, "JourneysImagesCover", images_cover);
}
// The `kOmniboxAction` feature and child params.
{
omnibox_action = base::FeatureList::IsEnabled(internal::kOmniboxAction);
omnibox_action_with_pedals = base::GetFieldTrialParamByFeatureAsBool(
internal::kOmniboxAction, "omnibox_action_with_pedals",
omnibox_action_with_pedals);
omnibox_action_on_navigation_intents =
base::GetFieldTrialParamByFeatureAsBool(
internal::kOmniboxAction, "omnibox_action_on_navigation_intents",
omnibox_action_on_navigation_intents);
omnibox_action_navigation_intent_score_threshold =
base::GetFieldTrialParamByFeatureAsInt(
internal::kOmniboxAction,
"omnibox_action_on_navigation_intent_score_threshold",
omnibox_action_navigation_intent_score_threshold);
}
// The `kOmniboxHistoryClusterProvider` feature and child params.
{
omnibox_history_cluster_provider =
base::FeatureList::IsEnabled(internal::kOmniboxHistoryClusterProvider);
omnibox_history_cluster_provider_counterfactual =
base::GetFieldTrialParamByFeatureAsBool(
internal::kOmniboxHistoryClusterProvider,
"omnibox_history_cluster_provider_counterfactual",
omnibox_history_cluster_provider_counterfactual);
omnibox_history_cluster_provider_score =
base::GetFieldTrialParamByFeatureAsInt(
internal::kOmniboxHistoryClusterProvider,
"omnibox_history_cluster_provider_score",
omnibox_history_cluster_provider_score);
omnibox_history_cluster_provider_inherit_search_match_score =
base::GetFieldTrialParamByFeatureAsBool(
internal::kOmniboxHistoryClusterProvider,
"omnibox_history_cluster_provider_inherit_search_match_score",
omnibox_history_cluster_provider_inherit_search_match_score);
omnibox_history_cluster_provider_navigation_intent_score_threshold =
base::GetFieldTrialParamByFeatureAsInt(
internal::kOmniboxHistoryClusterProvider,
"omnibox_history_cluster_provider_navigation_intent_score_"
"threshold",
omnibox_history_cluster_provider_navigation_intent_score_threshold);
omnibox_history_cluster_provider_on_navigation_intents =
base::GetFieldTrialParamByFeatureAsBool(
internal::kOmniboxHistoryClusterProvider,
"omnibox_history_cluster_provider_on_navigation_intents",
omnibox_history_cluster_provider_on_navigation_intents);
}
// The `kOnDeviceClusteringKeywordFiltering` feature and child params.
{
keyword_filter_on_entity_aliases = base::GetFieldTrialParamByFeatureAsBool(
history_clusters::features::kOnDeviceClusteringKeywordFiltering,
"keyword_filter_on_entity_aliases", keyword_filter_on_entity_aliases);
max_entity_aliases_in_keywords = base::GetFieldTrialParamByFeatureAsInt(
history_clusters::features::kOnDeviceClusteringKeywordFiltering,
"max_entity_aliases_in_keywords", max_entity_aliases_in_keywords);
if (max_entity_aliases_in_keywords <= 0) {
max_entity_aliases_in_keywords = SIZE_MAX;
}
keyword_filter_on_noisy_visits = GetFieldTrialParamByFeatureAsBool(
history_clusters::features::kOnDeviceClusteringKeywordFiltering,
"keyword_filter_on_noisy_visits", keyword_filter_on_noisy_visits);
max_num_keywords_per_cluster = GetFieldTrialParamByFeatureAsInt(
features::kOnDeviceClusteringKeywordFiltering,
"max_num_keywords_per_cluster", max_num_keywords_per_cluster);
}
// The `kOnDeviceClustering` feature and child params.
{
cluster_navigation_time_cutoff =
base::Minutes(GetFieldTrialParamByFeatureAsInt(
features::kOnDeviceClustering, "navigation_time_cutoff_minutes",
cluster_navigation_time_cutoff.InMinutes()));
entity_relevance_threshold = GetFieldTrialParamByFeatureAsInt(
features::kOnDeviceClustering, "entity_relevance_threshold",
entity_relevance_threshold);
// Ensure that the value is [0 and 100].
DCHECK_GE(entity_relevance_threshold, 0);
DCHECK_LE(entity_relevance_threshold, 100);
content_visibility_threshold = GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClustering, "content_visibility_threshold", 0.5);
// Ensure that the value is [0.0 and 1.0].
DCHECK_GE(content_visibility_threshold, 0.0f);
DCHECK_LE(content_visibility_threshold, 1.0f);
noisy_cluster_visits_engagement_threshold =
GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClustering,
"noisy_cluster_visit_engagement_threshold",
noisy_cluster_visits_engagement_threshold);
number_interesting_visits_filter_threshold =
GetFieldTrialParamByFeatureAsInt(
features::kOnDeviceClustering,
"num_interesting_visits_filter_threshold",
number_interesting_visits_filter_threshold);
}
// The `kHistoryClustersVisitDeduping` feature and child params.
{
use_host_for_visit_deduping = GetFieldTrialParamByFeatureAsBool(
internal::kHistoryClustersVisitDeduping, "use_host_for_visit_deduping",
use_host_for_visit_deduping);
}
// The `kOnDeviceClusteringVisitRanking` feature and child params.
{
visit_duration_ranking_weight = GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClusteringVisitRanking,
"visit_duration_ranking_weight", visit_duration_ranking_weight);
DCHECK_GE(visit_duration_ranking_weight, 0.0f);
foreground_duration_ranking_weight = GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClusteringVisitRanking,
"foreground_duration_ranking_weight",
foreground_duration_ranking_weight);
DCHECK_GE(foreground_duration_ranking_weight, 0.0f);
bookmark_ranking_weight = GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClusteringVisitRanking, "bookmark_ranking_weight",
bookmark_ranking_weight);
DCHECK_GE(bookmark_ranking_weight, 0.0f);
search_results_page_ranking_weight = GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClusteringVisitRanking,
"search_results_page_ranking_weight",
search_results_page_ranking_weight);
DCHECK_GE(search_results_page_ranking_weight, 0.0f);
has_url_keyed_image_ranking_weight = GetFieldTrialParamByFeatureAsDouble(
features::kOnDeviceClusteringVisitRanking,
"has_url_keyed_image_ranking_weight",
has_url_keyed_image_ranking_weight);
DCHECK_GE(has_url_keyed_image_ranking_weight, 0.0f);
}
// The `kHistoryClustersNavigationContextClustering` feature and child params.
{
use_navigation_context_clusters = base::FeatureList::IsEnabled(
internal::kHistoryClustersNavigationContextClustering);
context_clustering_clean_up_duration =
base::Minutes(GetFieldTrialParamByFeatureAsInt(
internal::kHistoryClustersNavigationContextClustering,
"clean_up_duration_minutes",
context_clustering_clean_up_duration.InMinutes()));
cluster_triggerability_cutoff_duration =
base::Minutes(GetFieldTrialParamByFeatureAsInt(
internal::kHistoryClustersNavigationContextClustering,
"cluster_triggerability_cutoff_duration_minutes",
cluster_triggerability_cutoff_duration.InMinutes()));
}
// Lonely features without child params.
{
non_user_visible_debug =
base::FeatureList::IsEnabled(internal::kNonUserVisibleDebug);
user_visible_debug =
base::FeatureList::IsEnabled(internal::kUserVisibleDebug);
history_clusters_internals_page =
base::FeatureList::IsEnabled(internal::kHistoryClustersInternalsPage);
should_check_hosts_to_skip_clustering_for =
base::FeatureList::IsEnabled(features::kOnDeviceClusteringBlocklists);
should_show_all_clusters_unconditionally_on_prominent_ui_surfaces =
base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kShouldShowAllClustersOnProminentUiSurfaces);
}
}
Config::Config(const Config& other) = default;
Config::~Config() = default;
void SetConfigForTesting(const Config& config) {
GetConfigInternal() = config;
}
bool IsApplicationLocaleSupportedByJourneys(
const std::string& application_locale) {
// Application locale support should be checked only if the Journeys feature
// is enabled.
DCHECK(GetConfig().is_journeys_enabled_no_locale_check);
// Note, we now set a default value for the allowlist, which means that when
// the feature parameter is undefined, the below allowlist is enabled.
const base::FeatureParam<std::string> kLocaleOrLanguageAllowlist{
&internal::kJourneys, "JourneysLocaleOrLanguageAllowlist",
"de:en:es:fr:it:nl:pt:tr"};
// To allow for using any locale, we also interpret the special '*' value.
auto allowlist_string = kLocaleOrLanguageAllowlist.Get();
if (allowlist_string == "*")
return true;
// Allow comma and colon as delimiters to the language list.
auto allowlist = base::SplitString(
allowlist_string, ",:", base::WhitespaceHandling::TRIM_WHITESPACE,
base::SplitResult::SPLIT_WANT_NONEMPTY);
// Allow any exact locale matches, and also allow any users where the
// primary language subtag, e.g. "en" from "en-US" to match any element of
// the list.
return allowlist.empty() || base::Contains(allowlist, application_locale) ||
base::Contains(allowlist, l10n_util::GetLanguage(application_locale));
}
const Config& GetConfig() {
return GetConfigInternal();
}
} // namespace history_clusters
|