1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/history_embeddings/sql_database.h"
#include <array>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/task_environment.h"
#include "base/test/test_future.h"
#include "components/history_embeddings/history_embeddings_features.h"
#include "components/history_embeddings/proto/history_embeddings.pb.h"
#include "components/os_crypt/async/browser/test_utils.h"
#include "components/os_crypt/async/common/encryptor.h"
#include "components/passage_embeddings/passage_embeddings_types.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace history_embeddings {
using passage_embeddings::Embedding;
namespace {
constexpr int64_t kEmbeddingsVersion = 1;
constexpr size_t kEmbeddingsSize = 768ul;
Embedding FakeEmbedding() {
Embedding embedding(std::vector<float>(kEmbeddingsSize, 1.0f));
embedding.Normalize();
return embedding;
}
} // namespace
class HistoryEmbeddingsSqlDatabaseTest : public testing::Test {
public:
HistoryEmbeddingsSqlDatabaseTest()
: os_crypt_(os_crypt_async::GetTestOSCryptAsyncForTesting()) {}
void SetUp() override {
CHECK(history_dir_.CreateUniqueTempDir());
}
void TearDown() override {
CHECK(history_dir_.Delete());
}
std::unique_ptr<SqlDatabase> MakeDatabase() {
return std::make_unique<SqlDatabase>(
history_dir_.GetPath(),
GetFeatureParameters().erase_non_ascii_characters,
GetFeatureParameters().delete_embeddings);
}
// Adds mock data for url_id = 1 tied to visit_id = 10, and url_id = 2 tied to
// visit_id = 11.
void AddBasicMockData(SqlDatabase* sql_database) {
{
UrlData url_data_1(1, 10, base::Time::Now());
url_data_1.passages.add_passages("fake passage 1");
url_data_1.passages.add_passages("fake passage 2");
url_data_1.embeddings.emplace_back(
std::vector<float>(kEmbeddingsSize, 1.0f));
url_data_1.embeddings.emplace_back(
std::vector<float>(kEmbeddingsSize, 1.0f));
ASSERT_TRUE(sql_database->AddUrlData(url_data_1));
}
{
UrlData url_data_2(2, 11, base::Time::Now());
url_data_2.passages.add_passages("fake passage 3");
url_data_2.passages.add_passages("fake passage 4");
url_data_2.embeddings.emplace_back(
std::vector<float>(kEmbeddingsSize, 1.0f));
url_data_2.embeddings.emplace_back(
std::vector<float>(kEmbeddingsSize, 1.0f));
ASSERT_TRUE(sql_database->AddUrlData(url_data_2));
}
ASSERT_TRUE(sql_database->GetPassages(1));
ASSERT_TRUE(sql_database->GetPassages(2));
ASSERT_EQ(GetEmbeddingCount(sql_database), 2U);
}
size_t GetEmbeddingCount(SqlDatabase* sql_database) {
auto iterator = sql_database->MakeUrlDataIterator({});
EXPECT_TRUE(iterator);
size_t count = 0;
while (iterator->Next()) {
count++;
}
return count;
}
protected:
os_crypt_async::Encryptor GetEncryptorInstance() {
base::test::TestFuture<os_crypt_async::Encryptor> future;
os_crypt_->GetInstance(future.GetCallback());
return future.Take();
}
base::test::TaskEnvironment env_;
std::unique_ptr<os_crypt_async::OSCryptAsync> os_crypt_;
base::ScopedTempDir history_dir_;
};
TEST_F(HistoryEmbeddingsSqlDatabaseTest, WriteCloseAndThenReadPassages) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Write passages
UrlData url_passages(1, 1, base::Time::Now());
url_passages.passages.add_passages("fake passage 1");
url_passages.passages.add_passages("fake passage 2");
url_passages.embeddings.push_back(FakeEmbedding());
url_passages.embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_passages));
// Reset and reload.
sql_database.reset();
sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Read passages
auto read_proto = sql_database->GetPassages(1);
ASSERT_TRUE(read_proto);
ASSERT_EQ(read_proto->passages_size(), 2);
EXPECT_EQ(read_proto->passages()[0], "fake passage 1");
EXPECT_EQ(read_proto->passages()[1], "fake passage 2");
sql_database.reset();
EXPECT_TRUE(
base::PathExists(history_dir_.GetPath().Append(kHistoryEmbeddingsName)))
<< "DB file is still there after destruction.";
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, WriteCloseAndThenReadUrlData) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Write embeddings.
auto url_datas = std::to_array<UrlData>({
UrlData(1, 1, base::Time::Now()),
UrlData(2, 2, base::Time::Now()),
});
url_datas[0].passages.add_passages("data 0 passage 0");
url_datas[0].embeddings.push_back(FakeEmbedding());
url_datas[1].passages.add_passages("data 1 passage 0");
url_datas[1].passages.add_passages("data 1 passage 1");
url_datas[1].embeddings.push_back(FakeEmbedding());
url_datas[1].embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_datas[0]));
EXPECT_TRUE(sql_database->AddUrlData(url_datas[1]));
// Reset and reload.
sql_database.reset();
sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Read embeddings.
{
// Block scope destructs iterator before database is closed.
std::unique_ptr<VectorDatabase::UrlDataIterator> iterator =
sql_database->MakeUrlDataIterator({});
EXPECT_TRUE(iterator);
for (const UrlData& url_data : url_datas) {
const UrlData* read_url_data = iterator->Next();
EXPECT_TRUE(read_url_data);
EXPECT_EQ(*read_url_data, url_data);
}
EXPECT_FALSE(iterator->Next());
}
sql_database.reset();
EXPECT_TRUE(
base::PathExists(history_dir_.GetPath().Append(kHistoryEmbeddingsName)))
<< "DB file is still there after destruction.";
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, TimeRangeNarrowsSearchResult) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Write embeddings.
const base::Time now = base::Time::Now();
for (size_t i = 0; i < 3; i++) {
UrlData url_data(i + 1, i + 1, now + base::Minutes(i));
for (size_t j = 0; j < 3; j++) {
url_data.passages.add_passages("fake passage");
url_data.embeddings.push_back(FakeEmbedding());
}
sql_database->AddUrlData(url_data);
}
Embedding query = FakeEmbedding();
SearchParams search_params;
// An ordinary search with full results:
{
std::vector<ScoredUrl> scored_urls =
sql_database
->FindNearest({}, 3, search_params, query,
base::BindRepeating([]() { return false; }))
.scored_urls;
CHECK_EQ(scored_urls.size(), 3u);
}
// Narrowed searches with time range.
{
std::vector<ScoredUrl> scored_urls =
sql_database
->FindNearest(now, 3, search_params, query,
base::BindRepeating([]() { return false; }))
.scored_urls;
CHECK_EQ(scored_urls.size(), 3u);
}
{
std::vector<ScoredUrl> scored_urls =
sql_database
->FindNearest(now + base::Seconds(30), 3, search_params, query,
base::BindRepeating([]() { return false; }))
.scored_urls;
CHECK_EQ(scored_urls.size(), 2u);
}
{
std::vector<ScoredUrl> scored_urls =
sql_database
->FindNearest(now + base::Seconds(90), 3, search_params, query,
base::BindRepeating([]() { return false; }))
.scored_urls;
CHECK_EQ(scored_urls.size(), 1u);
}
{
std::vector<ScoredUrl> scored_urls =
sql_database
->FindNearest(now + base::Minutes(2), 3, search_params, query,
base::BindRepeating([]() { return false; }))
.scored_urls;
CHECK_EQ(scored_urls.size(), 1u);
}
{
std::vector<ScoredUrl> scored_urls =
sql_database
->FindNearest(now + base::Seconds(121), 3, search_params, query,
base::BindRepeating([]() { return false; }))
.scored_urls;
CHECK_EQ(scored_urls.size(), 0u);
}
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, InsertOrReplacePassages) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
UrlData url_data(1, 1, base::Time::Now());
url_data.passages.add_passages("fake passage 1");
url_data.passages.add_passages("fake passage 2");
url_data.embeddings.push_back(FakeEmbedding());
url_data.embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_data));
url_data.visit_id = 2;
url_data.passages.add_passages("fake passage 3");
url_data.embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_data));
// Verify that the new one has replaced the old one.
auto read_proto = sql_database->GetPassages(1);
ASSERT_TRUE(read_proto);
ASSERT_EQ(read_proto->passages_size(), 3);
EXPECT_EQ(read_proto->passages()[0], "fake passage 1");
EXPECT_EQ(read_proto->passages()[1], "fake passage 2");
EXPECT_EQ(read_proto->passages()[2], "fake passage 3");
EXPECT_FALSE(sql_database->GetPassages(2));
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, IteratorMaySafelyOutliveDatabase) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
AddBasicMockData(sql_database.get());
// Without database reset, iteration reads data.
{
std::unique_ptr<VectorDatabase::UrlDataIterator> iterator =
sql_database->MakeUrlDataIterator({});
EXPECT_TRUE(iterator);
EXPECT_TRUE(iterator->Next());
}
// With database reset, iteration gracefully ends.
{
std::unique_ptr<VectorDatabase::UrlDataIterator> iterator =
sql_database->MakeUrlDataIterator({});
EXPECT_TRUE(iterator);
// Reset database while iterator is still in scope.
sql_database.reset();
// Iterator access with dead database doesn't crash, just ends iteration.
EXPECT_FALSE(iterator->Next());
}
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, DeleteDataForUrlId) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
AddBasicMockData(sql_database.get());
EXPECT_TRUE(sql_database->DeleteDataForUrlId(3))
<< "Deleting a non-existing url_id = 3 should return true but do "
"nothing.";
EXPECT_TRUE(sql_database->GetPassages(1));
EXPECT_TRUE(sql_database->GetPassages(2));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 2U);
EXPECT_TRUE(sql_database->DeleteDataForUrlId(2))
<< "Succeeds. url_id = 2 does exist.";
EXPECT_TRUE(sql_database->GetPassages(1));
EXPECT_FALSE(sql_database->GetPassages(2));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 1U);
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, DeleteDataForVisitId) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
AddBasicMockData(sql_database.get());
EXPECT_TRUE(sql_database->DeleteDataForVisitId(40))
<< "Deleting a non-existing visit_id = 40 should return true but do "
"nothing.";
EXPECT_TRUE(sql_database->GetPassages(1));
EXPECT_TRUE(sql_database->GetPassages(2));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 2U);
EXPECT_TRUE(sql_database->DeleteDataForVisitId(11))
<< "Succeeds. visit_id = 11 does exist.";
EXPECT_TRUE(sql_database->GetPassages(1));
EXPECT_FALSE(sql_database->GetPassages(2));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 1U);
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, DeleteAllData) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
AddBasicMockData(sql_database.get());
EXPECT_TRUE(sql_database->DeleteAllData(true, true));
EXPECT_FALSE(sql_database->GetPassages(1));
EXPECT_FALSE(sql_database->GetPassages(2));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 0U);
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, DeleteDataWithoutEmbedderMetadata) {
UrlData url_data(1, 10, base::Time::Now());
url_data.passages.add_passages("fake passage 1");
url_data.embeddings.emplace_back(std::vector<float>(kEmbeddingsSize, 1.0f));
{
auto sql_database = MakeDatabase();
// Adding data is expected to fail because the database can't initialize
// fully without embedder metadata.
ASSERT_FALSE(sql_database->AddUrlData(url_data));
// With metadata set, now adding the data succeeds.
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
ASSERT_TRUE(sql_database->AddUrlData(url_data));
// Don't delete yet. That would succeed as normal. Close with data resident.
EXPECT_TRUE(sql_database->GetPassages(1));
}
{
// Initialize database again, to see that we can still get it only when
// metadata is provided.
auto sql_database = MakeDatabase();
EXPECT_FALSE(sql_database->GetPassages(1));
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
EXPECT_TRUE(sql_database->GetPassages(1));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 1U);
// Again deletion would work as normal here.
}
{
// Initialize database again, with no embedder metadata.
auto sql_database = MakeDatabase();
EXPECT_FALSE(sql_database->GetPassages(1));
// Deletion succeeds even with no metadata provided.
EXPECT_TRUE(sql_database->DeleteAllData(true, true));
// Now there's no data to retrieve, even after metadata is provided.
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
EXPECT_FALSE(sql_database->GetPassages(1));
EXPECT_EQ(GetEmbeddingCount(sql_database.get()), 0U);
}
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, GetUrlData) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
{
UrlData url_data(1, 1, base::Time::Now());
url_data.passages.add_passages("fake passage 1");
url_data.passages.add_passages("fake passage 2");
url_data.passages.add_passages("fake passage 3");
url_data.embeddings.push_back(FakeEmbedding());
url_data.embeddings.push_back(FakeEmbedding());
url_data.embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_data));
}
{
UrlData data = sql_database->GetUrlData(1).value();
CHECK_EQ(data.url_id, 1);
CHECK_EQ(data.visit_id, 1);
CHECK_EQ(data.passages.passages_size(), 3);
CHECK_EQ(data.embeddings.size(), 3u);
EXPECT_EQ(data.passages.passages(0), "fake passage 1");
EXPECT_EQ(data.passages.passages(1), "fake passage 2");
EXPECT_EQ(data.passages.passages(2), "fake passage 3");
}
// It's also possible to have passages but no embeddings, for example
// during a database rebuild.
sql_database->DeleteAllData(false, true);
{
UrlData data = sql_database->GetUrlData(1).value();
CHECK_EQ(data.url_id, 1);
CHECK_EQ(data.visit_id, 1);
CHECK_EQ(data.passages.passages_size(), 3);
CHECK_EQ(data.embeddings.size(), 0u);
EXPECT_EQ(data.passages.passages(0), "fake passage 1");
EXPECT_EQ(data.passages.passages(1), "fake passage 2");
EXPECT_EQ(data.passages.passages(2), "fake passage 3");
}
// Absent `url_id` returns std::nullopt.
EXPECT_FALSE(sql_database->GetUrlData(2).has_value());
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, IterationSkipsAndReportsMismatches) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Write embeddings.
auto url_datas = std::to_array<UrlData>({
UrlData(1, 1, base::Time::Now()),
UrlData(2, 2, base::Time::Now()),
});
url_datas[0].passages.add_passages("data 0 passage 0");
url_datas[0].embeddings.push_back(FakeEmbedding());
url_datas[1].passages.add_passages("data 1 passage 0");
url_datas[1].passages.add_passages("data 1 passage 1");
url_datas[1].embeddings.push_back(FakeEmbedding());
url_datas[1].embeddings.push_back(FakeEmbedding());
// Add one too many embeddings to trigger a mismatch.
url_datas[1].embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_datas[0]));
EXPECT_TRUE(sql_database->AddAnyUrlDataForTesting(url_datas[1]));
base::HistogramTester histogram_tester;
int observed = 0;
{
// Iterate through stored data once.
std::unique_ptr<VectorDatabase::UrlDataIterator> iterator =
sql_database->MakeUrlDataIterator({});
EXPECT_TRUE(iterator);
while (iterator->Next()) {
observed++;
}
}
EXPECT_EQ(observed, 1);
histogram_tester.ExpectUniqueSample(
"History.Embeddings.DatabaseIterationSkippedMismatches", 1, 1);
histogram_tester.ExpectUniqueSample(
"History.Embeddings.DatabaseIterationYielded", 1, 1);
}
TEST_F(HistoryEmbeddingsSqlDatabaseTest, OldVisitsAreExpired) {
auto sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Write embeddings; one for an old visit, one for a new visit.
auto url_datas = std::to_array<UrlData>({
UrlData(/*url_id=*/1, /*visit_id=*/1,
base::Time::Now() - base::Days(100)),
UrlData(/*url_id=*/2, /*visit_id=*/2, base::Time::Now()),
});
url_datas[0].passages.add_passages("data 0 passage 0");
url_datas[0].embeddings.push_back(FakeEmbedding());
url_datas[1].passages.add_passages("data 1 passage 0");
url_datas[1].embeddings.push_back(FakeEmbedding());
EXPECT_TRUE(sql_database->AddUrlData(url_datas[0]));
EXPECT_TRUE(sql_database->AddUrlData(url_datas[1]));
// Reset and reload.
sql_database.reset();
sql_database = MakeDatabase();
sql_database->SetEmbedderMetadata({kEmbeddingsVersion, kEmbeddingsSize},
GetEncryptorInstance());
// Read embeddings; only last visit will be found because first expired.
EXPECT_FALSE(sql_database->GetUrlData(/*url_id=*/1).has_value());
EXPECT_TRUE(sql_database->GetUrlData(/*url_id=*/2).has_value());
sql_database.reset();
EXPECT_TRUE(
base::PathExists(history_dir_.GetPath().Append(kHistoryEmbeddingsName)));
}
} // namespace history_embeddings
|