1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/input/tap_suppression_controller.h"
#include <memory>
#include "base/time/time.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace input {
class MockTapSuppressionController : public TapSuppressionController {
public:
using TapSuppressionController::DISABLED;
using TapSuppressionController::LAST_CANCEL_STOPPED_FLING;
using TapSuppressionController::NOTHING;
using TapSuppressionController::SUPPRESSING_TAPS;
enum Action {
NONE = 0,
TAP_DOWN_FORWARDED = 1 << 0,
TAP_DOWN_SUPPRESSED = 1 << 1,
TAP_UP_SUPPRESSED = 1 << 2,
TAP_UP_FORWARDED = 1 << 3,
};
MockTapSuppressionController(const TapSuppressionController::Config& config)
: TapSuppressionController(config), last_actions_(NONE), time_() {}
MockTapSuppressionController(const MockTapSuppressionController&) = delete;
MockTapSuppressionController& operator=(const MockTapSuppressionController&) =
delete;
~MockTapSuppressionController() override = default;
void NotifyGestureFlingCancelStoppedFling() {
last_actions_ = NONE;
GestureFlingCancelStoppedFling();
}
void SendTapDown() {
last_actions_ = NONE;
if (ShouldSuppressTapDown()) {
last_actions_ |= TAP_DOWN_SUPPRESSED;
} else {
last_actions_ |= TAP_DOWN_FORWARDED;
}
}
void SendTapUp() {
last_actions_ = NONE;
if (ShouldSuppressTapEnd()) {
last_actions_ |= TAP_UP_SUPPRESSED;
} else {
last_actions_ |= TAP_UP_FORWARDED;
}
}
void AdvanceTime(const base::TimeDelta& delta) {
last_actions_ = NONE;
time_ += delta;
}
State state() { return state_; }
int last_actions() { return last_actions_; }
protected:
base::TimeTicks Now() override { return time_; }
private:
// Hiding some derived public methods
using TapSuppressionController::GestureFlingCancelStoppedFling;
using TapSuppressionController::ShouldSuppressTapDown;
using TapSuppressionController::ShouldSuppressTapEnd;
int last_actions_;
base::TimeTicks time_;
};
class TapSuppressionControllerTest : public testing::Test {
public:
TapSuppressionControllerTest() = default;
~TapSuppressionControllerTest() override = default;
protected:
// testing::Test
void SetUp() override {
tap_suppression_controller_ =
std::make_unique<MockTapSuppressionController>(GetConfig());
}
void TearDown() override { tap_suppression_controller_.reset(); }
static TapSuppressionController::Config GetConfig() {
TapSuppressionController::Config config;
config.enabled = true;
config.max_cancel_to_down_time = base::Milliseconds(10);
return config;
}
std::unique_ptr<MockTapSuppressionController> tap_suppression_controller_;
};
// Test TapSuppressionController for when GestureFlingCancel actually stops
// fling and the tap down event arrives without any delay.
TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapFast) {
// Notify the controller that the GFC has stooped an active fling.
tap_suppression_controller_->NotifyGestureFlingCancelStoppedFling();
EXPECT_EQ(MockTapSuppressionController::NONE,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::LAST_CANCEL_STOPPED_FLING,
tap_suppression_controller_->state());
// Send TapDown. This TapDown should be suppressed.
tap_suppression_controller_->SendTapDown();
EXPECT_EQ(MockTapSuppressionController::TAP_DOWN_SUPPRESSED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
// Send TapUp. This TapUp should be suppressed.
tap_suppression_controller_->SendTapUp();
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
// Test TapSuppressionController for when GestureFlingCancel actually stops
// fling but there is a small delay between the Ack and TapDown.
TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapInsufficientlyLateTapDown) {
// Notify the controller that the GFC has stooped an active fling.
tap_suppression_controller_->NotifyGestureFlingCancelStoppedFling();
EXPECT_EQ(MockTapSuppressionController::NONE,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::LAST_CANCEL_STOPPED_FLING,
tap_suppression_controller_->state());
// Wait less than allowed delay between GestureFlingCancel and TapDown, so the
// TapDown is still considered associated with the GestureFlingCancel.
tap_suppression_controller_->AdvanceTime(base::Milliseconds(7));
EXPECT_EQ(MockTapSuppressionController::NONE,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::LAST_CANCEL_STOPPED_FLING,
tap_suppression_controller_->state());
// Send TapDown. This TapDown should be suppressed.
tap_suppression_controller_->SendTapDown();
EXPECT_EQ(MockTapSuppressionController::TAP_DOWN_SUPPRESSED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
// Send TapUp. This TapUp should be suppressed.
tap_suppression_controller_->SendTapUp();
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
// Test TapSuppressionController for when GestureFlingCancel actually stops
// fling but there is a long delay between the Ack and TapDown.
TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapSufficientlyLateTapDown) {
// Notify the controller that the GFC has stooped an active fling.
tap_suppression_controller_->NotifyGestureFlingCancelStoppedFling();
EXPECT_EQ(MockTapSuppressionController::NONE,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::LAST_CANCEL_STOPPED_FLING,
tap_suppression_controller_->state());
// Wait more than allowed delay between GestureFlingCancel and TapDown, so the
// TapDown is not considered associated with the GestureFlingCancel.
tap_suppression_controller_->AdvanceTime(base::Milliseconds(13));
EXPECT_EQ(MockTapSuppressionController::NONE,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::LAST_CANCEL_STOPPED_FLING,
tap_suppression_controller_->state());
// Send TapDown. This TapDown should not be suppressed.
tap_suppression_controller_->SendTapDown();
EXPECT_EQ(MockTapSuppressionController::TAP_DOWN_FORWARDED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::NOTHING,
tap_suppression_controller_->state());
// Send MouseUp. This MouseUp should not be suppressed.
tap_suppression_controller_->SendTapUp();
EXPECT_EQ(MockTapSuppressionController::TAP_UP_FORWARDED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::NOTHING,
tap_suppression_controller_->state());
}
// Test that no suppression occurs if the TapSuppressionController is disabled.
TEST_F(TapSuppressionControllerTest, NoSuppressionIfDisabled) {
TapSuppressionController::Config disabled_config;
disabled_config.enabled = false;
tap_suppression_controller_ =
std::make_unique<MockTapSuppressionController>(disabled_config);
// Send GestureFlingCancel Ack.
tap_suppression_controller_->NotifyGestureFlingCancelStoppedFling();
EXPECT_EQ(MockTapSuppressionController::NONE,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::DISABLED,
tap_suppression_controller_->state());
// Send TapDown. This TapDown should not be suppressed.
tap_suppression_controller_->SendTapDown();
EXPECT_EQ(MockTapSuppressionController::TAP_DOWN_FORWARDED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::DISABLED,
tap_suppression_controller_->state());
// Send TapUp. This TapUp should not be suppressed.
tap_suppression_controller_->SendTapUp();
EXPECT_EQ(MockTapSuppressionController::TAP_UP_FORWARDED,
tap_suppression_controller_->last_actions());
EXPECT_EQ(MockTapSuppressionController::DISABLED,
tap_suppression_controller_->state());
}
} // namespace input
|
