1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/shortcuts_provider.h"
#include <math.h>
#include <stddef.h>
#include <algorithm>
#include <functional>
#include <memory>
#include <optional>
#include <set>
#include <string>
#include <vector>
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "components/history/core/browser/url_database.h"
#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/autocomplete_provider.h"
#include "components/omnibox/browser/autocomplete_result.h"
#include "components/omnibox/browser/fake_autocomplete_provider_client.h"
#include "components/omnibox/browser/in_memory_url_index.h"
#include "components/omnibox/browser/omnibox_triggered_feature_service.h"
#include "components/omnibox/browser/shortcuts_backend.h"
#include "components/omnibox/browser/shortcuts_provider_test_util.h"
#include "components/omnibox/common/omnibox_feature_configs.h"
#include "components/omnibox/common/omnibox_features.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/metrics_proto/omnibox_event.pb.h"
#include "third_party/metrics_proto/omnibox_focus_type.pb.h"
#include "third_party/omnibox_proto/groups.pb.h"
using base::ASCIIToUTF16;
using ExpectedURLs = std::vector<ExpectedURLAndAllowedToBeDefault>;
namespace {
// Returns up to 99,999 incrementing GUIDs of the format
// "BD85DBA2-8C29-49F9-84AE-48E1E_____E0".
std::string GetGuid() {
static int currentGuid = 0;
currentGuid++;
DCHECK_LE(currentGuid, 99999);
return base::StringPrintf("BD85DBA2-8C29-49F9-84AE-48E1E%05dE0", currentGuid);
}
// Don't add more shortcuts here. It's difficult to reuse shortcuts for
// different tests, so each test ends up adding new shortcuts, and this list
// keeps growing with no reuse benefit. Add shortcuts locally in each test.
struct TestShortcutData shortcut_test_db[] = {
{GetGuid(), "goog", "www.google.com", "http://www.google.com/",
AutocompleteMatch::DocumentType::NONE, "Google", "0,1,4,0", "Google",
"0,3,4,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL,
"", 1, 100},
{GetGuid(), "slash", "slashdot.org", "http://slashdot.org/",
AutocompleteMatch::DocumentType::NONE, "slashdot.org", "0,3,5,1",
"Slashdot - News for nerds, stuff that matters", "0,2,5,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 0, 100},
{GetGuid(), "news", "slashdot.org", "http://slashdot.org/",
AutocompleteMatch::DocumentType::NONE, "slashdot.org", "0,1",
"Slashdot - News for nerds, stuff that matters", "0,0,11,2,15,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 0, 5},
{GetGuid(), "news", "sports.yahoo.com", "http://sports.yahoo.com/",
AutocompleteMatch::DocumentType::NONE, "sports.yahoo.com", "0,1",
"Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more",
"0,0,23,2,27,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 2, 5},
{GetGuid(), "news weather", "www.cnn.com/index.html",
"http://www.cnn.com/index.html", AutocompleteMatch::DocumentType::NONE,
"www.cnn.com/index.html", "0,1",
"CNN.com - Breaking News, U.S., World, Weather, Entertainment & Video",
"0,0,19,2,23,0,38,2,45,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 1, 10},
{GetGuid(), "nhl scores", "sports.yahoo.com", "http://sports.yahoo.com/",
AutocompleteMatch::DocumentType::NONE, "sports.yahoo.com", "0,1",
"Yahoo! Sports - Sports News, Scores, Rumors, Fantasy Games, and more",
"0,0,29,2,35,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_BODY, "", 1, 10},
{GetGuid(), "nhl scores", "www.nhl.com/scores/index.html",
"http://www.nhl.com/scores/index.html",
AutocompleteMatch::DocumentType::NONE, "www.nhl.com/scores/index.html",
"0,1,4,3,7,1", "January 13, 2010 - NHL.com - Scores",
"0,0,19,2,22,0,29,2,35,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 5, 1},
{GetGuid(), "just", "www.testsite.com/a.html",
"http://www.testsite.com/a.html", AutocompleteMatch::DocumentType::NONE,
"www.testsite.com/a.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 5, 1},
{GetGuid(), "just", "www.testsite.com/b.html",
"http://www.testsite.com/b.html", AutocompleteMatch::DocumentType::NONE,
"www.testsite.com/b.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 5, 2},
{GetGuid(), "just", "www.testsite.com/c.html",
"http://www.testsite.com/c.html", AutocompleteMatch::DocumentType::NONE,
"www.testsite.com/c.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 8, 1},
{GetGuid(), "just a", "www.testsite.com/d.html",
"http://www.testsite.com/d.html", AutocompleteMatch::DocumentType::NONE,
"www.testsite.com/d.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1},
{GetGuid(), "just a t", "www.testsite.com/e.html",
"http://www.testsite.com/e.html", AutocompleteMatch::DocumentType::NONE,
"www.testsite.com/e.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1},
{GetGuid(), "just a te", "www.testsite.com/f.html",
"http://www.testsite.com/f.html", AutocompleteMatch::DocumentType::NONE,
"www.testsite.com/f.html", "0,1", "Test - site - just a test",
"0,0,14,2,18,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_TITLE, "", 12, 1},
{GetGuid(), "ago", "www.daysagotest.com/a.html",
"http://www.daysagotest.com/a.html", AutocompleteMatch::DocumentType::NONE,
"www.daysagotest.com/a.html", "0,1,8,3,11,1", "Test - site", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 1},
{GetGuid(), "ago", "www.daysagotest.com/b.html",
"http://www.daysagotest.com/b.html", AutocompleteMatch::DocumentType::NONE,
"www.daysagotest.com/b.html", "0,1,8,3,11,1", "Test - site", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 2, 1},
{GetGuid(), "ago", "www.daysagotest.com/c.html",
"http://www.daysagotest.com/c.html", AutocompleteMatch::DocumentType::NONE,
"www.daysagotest.com/c.html", "0,1,8,3,11,1", "Test - site", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 3, 1},
{GetGuid(), "ago", "www.daysagotest.com/d.html",
"http://www.daysagotest.com/d.html", AutocompleteMatch::DocumentType::NONE,
"www.daysagotest.com/d.html", "0,1,8,3,11,1", "Test - site", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 4, 1},
{GetGuid(), "abcdef.com", "http://abcdef.com", "http://abcdef.com/",
AutocompleteMatch::DocumentType::NONE, "Abcdef", "0,1,4,0", "Abcdef",
"0,3,4,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL,
"", 1, 100},
{GetGuid(), "query", "query", "https://www.google.com/search?q=query",
AutocompleteMatch::DocumentType::NONE, "query", "0,0", "Google Search",
"0,4", ui::PAGE_TRANSITION_GENERATED,
AutocompleteMatchType::SEARCH_HISTORY, "google.com", 1, 100},
{GetGuid(), "word", "www.word", "https://www.google.com/search?q=www.word",
AutocompleteMatch::DocumentType::NONE, "www.word", "0,0", "Google Search",
"0,4", ui::PAGE_TRANSITION_GENERATED,
AutocompleteMatchType::SEARCH_HISTORY, "google.com", 1, 100},
{GetGuid(), "about:o", "chrome://omnibox", "chrome://omnibox/",
AutocompleteMatch::DocumentType::NONE, "about:omnibox", "0,3,10,1", "", "",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::NAVSUGGEST, "", 1, 100},
{GetGuid(), "www/real sp", "http://www/real space/long-url-with-space.html",
"http://www/real%20space/long-url-with-space.html",
AutocompleteMatch::DocumentType::NONE,
"www/real space/long-url-with-space.html", "0,3,11,1",
"Page With Space; Input with Space", "0,0", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 100},
{GetGuid(), "duplicate", "http://duplicate.com", "http://duplicate.com/",
AutocompleteMatch::DocumentType::NONE, "Duplicate", "0,1", "Duplicate",
"0,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
1, 100},
{GetGuid(), "dupl", "http://duplicate.com", "http://duplicate.com/",
AutocompleteMatch::DocumentType::NONE, "Duplicate", "0,1", "Duplicate",
"0,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
1, 100},
{GetGuid(), "notrailing.com/", "http://notrailing.com",
"http://notrailing.com/", AutocompleteMatch::DocumentType::NONE,
"No Trailing Slash", "0,1", "No Trailing Slash on fill_into_edit", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
{GetGuid(), "http:///foo.com", "http://foo.com", "http://foo.com/",
AutocompleteMatch::DocumentType::NONE, "Foo - Typo in Input", "0,1",
"Foo - Typo in Input Corrected in fill_into_edit", "0,1",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 100},
{GetGuid(), "trailing1 ", "http://trailing1.com", "http://trailing1.com/",
AutocompleteMatch::DocumentType::NONE, "Trailing1 - Space in Shortcut",
"0,1", "Trailing1 - Space in Shortcut", "0,1", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, "", 1, 100},
{GetGuid(), "about:trailing2 ", "chrome://trailing2blah",
"chrome://trailing2blah/", AutocompleteMatch::DocumentType::NONE,
"Trailing2 - Space in Shortcut", "0,1", "Trailing2 - Space in Shortcut",
"0,1", ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "",
1, 100},
};
ShortcutsDatabase::Shortcut MakeShortcut(
std::u16string text,
const base::Time& last_access_time = base::Time::Now(),
int number_of_hits = 1) {
return {std::string(), text,
ShortcutsDatabase::Shortcut::MatchCore(
u"www.test.com", GURL("http://www.test.com"),
AutocompleteMatch::DocumentType::NONE, u"www.test.com",
"0,1,4,3,8,1", u"A test", "0,0,2,2", ui::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL, std::u16string()),
last_access_time, number_of_hits};
}
// Helpers to create `TestShortcutData`.
TestShortcutData MakeShortcutData(std::string text,
std::string destination_url = "",
int days_from_now = 0,
int number_of_hits = 0) {
if (destination_url.empty())
destination_url =
"https://" + text + ".com/" + base::NumberToString(number_of_hits);
return {GetGuid(),
text,
text,
destination_url,
AutocompleteMatch::DocumentType::NONE,
"",
"",
"",
"",
ui::PageTransition::PAGE_TRANSITION_TYPED,
AutocompleteMatchType::HISTORY_URL,
"",
days_from_now,
number_of_hits};
}
TestShortcutData MakeShortcutData(std::string text, int number_of_hits) {
return MakeShortcutData(text, "", 0, number_of_hits);
}
// Verifies the values and order of match `destination_url`s.
void VerifyMatches(ACMatches matches,
std::vector<std::string> expected_destination_urls) {
std::string debug = "matches: \n";
for (auto match : matches)
debug += base::StringPrintf(" %s\n", match.destination_url.spec().c_str());
ASSERT_EQ(matches.size(), expected_destination_urls.size()) << debug;
for (size_t i = 0; i < matches.size(); ++i)
EXPECT_EQ(matches[i].destination_url.spec(), expected_destination_urls[i])
<< debug;
}
} // namespace
class MockHistoryService : public history::HistoryService {
public:
MockHistoryService() = default;
MOCK_METHOD1(DeleteURLs, void(const std::vector<GURL>&));
};
// ShortcutsProviderTest ------------------------------------------------------
class ShortcutsProviderTest : public testing::Test {
public:
ShortcutsProviderTest();
protected:
void SetUp() override;
void TearDown() override;
// Passthrough to the private `CreateScoredShortcutMatch` function in
// provider_.
int CalculateAggregateScore(
size_t input_length,
const std::vector<const ShortcutsDatabase::Shortcut*>& shortcuts);
// Passthrough to the private `DoAutocomplete`. Enables populating scoring
// signals.
void DoAutocompleteWithScoringSignals(const AutocompleteInput& input);
// ScopedFeatureList needs to be defined before TaskEnvironment, so that it is
// destroyed after TaskEnvironment, to prevent data races on the
// ScopedFeatureList.
base::test::ScopedFeatureList scoped_feature_list_;
base::test::TaskEnvironment task_environment_;
std::unique_ptr<FakeAutocompleteProviderClient> client_;
scoped_refptr<ShortcutsProvider> provider_;
};
ShortcutsProviderTest::ShortcutsProviderTest() {
// `scoped_feature_list_` needs to be initialized as early as possible, to
// avoid data races caused by tasks on other threads accessing it.
scoped_feature_list_.Reset();
scoped_feature_list_.InitAndEnableFeature(omnibox::kLogUrlScoringSignals);
}
void ShortcutsProviderTest::SetUp() {
client_ = std::make_unique<FakeAutocompleteProviderClient>();
client_->set_history_service(std::make_unique<MockHistoryService>());
auto shortcuts_backend = base::MakeRefCounted<ShortcutsBackend>(
client_->GetTemplateURLService(), std::make_unique<SearchTermsData>(),
client_->GetHistoryService(), base::FilePath(), true);
shortcuts_backend->Init();
client_->set_shortcuts_backend(std::move(shortcuts_backend));
ASSERT_TRUE(client_->GetShortcutsBackend());
provider_ = base::MakeRefCounted<ShortcutsProvider>(client_.get());
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcut_test_db,
std::size(shortcut_test_db));
}
void ShortcutsProviderTest::TearDown() {
provider_ = nullptr;
client_.reset();
task_environment_.RunUntilIdle();
scoped_feature_list_.Reset();
RichAutocompletionParams::ClearParamsForTesting();
}
int ShortcutsProviderTest::CalculateAggregateScore(
size_t input_length,
const std::vector<const ShortcutsDatabase::Shortcut*>& shortcuts) {
const int max_relevance =
ShortcutsProvider::kShortcutsProviderDefaultMaxRelevance;
return provider_
->CreateScoredShortcutMatch(input_length,
/*stripped_destination_url=*/GURL(),
shortcuts, max_relevance)
.relevance;
}
void ShortcutsProviderTest::DoAutocompleteWithScoringSignals(
const AutocompleteInput& input) {
provider_->matches_.clear();
provider_->DoAutocomplete(input, /*populate_scoring_signals=*/true);
}
// Actual tests ---------------------------------------------------------------
TEST_F(ShortcutsProviderTest, SimpleSingleMatch) {
std::u16string text(u"go");
std::string expected_url("http://www.google.com/");
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u"ogle");
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
u"ogle.com");
// A pair of analogous tests where the shortcut ends at the end of
// |fill_into_edit|. This exercises the inline autocompletion and default
// match code.
text = u"abcdef.com";
expected_url = "http://abcdef.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
std::u16string());
// With prevent inline autocomplete, the suggestion should be the same
// (because there is no completion).
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
std::u16string());
// Another test, simply for a query match type, not a navigation URL match
// type.
text = u"que";
expected_url = "https://www.google.com/search?q=query";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u"ry");
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
u"ry");
// A pair of analogous tests where the shortcut ends at the end of
// |fill_into_edit|. This exercises the inline autocompletion and default
// match code.
text = u"query";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
std::u16string());
// With prevent inline autocomplete, the suggestion should be the same
// (because there is no completion).
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
std::u16string());
// Now the shortcut ends at the end of |fill_into_edit| but has a
// non-droppable prefix. ("www.", for instance, is not droppable for
// queries.)
text = u"word";
expected_url = "https://www.google.com/search?q=www.word";
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
std::u16string());
}
// These tests are like those in SimpleSingleMatch but more complex,
// involving URLs that need to be fixed up to match properly.
TEST_F(ShortcutsProviderTest, TrickySingleMatch) {
// Test that about: URLs are fixed up/transformed to chrome:// URLs.
std::u16string text(u"about:o");
std::string expected_url("chrome://omnibox/");
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u"mnibox");
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
u"mnibox");
// Test that an input with a space can match URLs with a (escaped) space.
// This would fail if we didn't try to lookup the un-fixed-up string.
text = u"www/real sp";
expected_url = "http://www/real%20space/long-url-with-space.html";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u"ace/long-url-with-space.html");
// Same test with prevent inline autocomplete.
expected_urls.clear();
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, false));
// The match will have an |inline_autocompletion| set, but the value will not
// be used because |allowed_to_be_default_match| will be false.
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
u"ace/long-url-with-space.html");
// Test when the user input has a typo that can be fixed up for matching
// fill_into_edit. This should still be allowed to be default.
text = u"http:///foo.com";
expected_url = "http://foo.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, true, expected_urls, expected_url,
std::u16string());
// A foursome of tests to verify that trailing spaces does not prevent the
// shortcut from being allowed to be the default match. For each of two tests,
// we try the input with and without the trailing whitespace.
text = u"trailing1";
expected_url = "http://trailing1.com/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u" - Space in Shortcut");
text = u"trailing1 ";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u"- Space in Shortcut");
text = u"about:trailing2";
expected_url = "chrome://trailing2blah/";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u" ");
text = u"about:trailing2 ";
expected_urls.clear();
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(expected_url, true));
RunShortcutsProviderTest(provider_, text, false, expected_urls, expected_url,
u"");
}
TEST_F(ShortcutsProviderTest, SimpleSingleMatchKeyword) {
// Add a non-default search engine.
TemplateURLData data;
data.SetShortName(u"yahoo");
data.SetKeyword(u"yahoo.com");
data.SetURL("http://www.yahoo.com/{searchTerms}");
client_->GetTemplateURLService()->Add(std::make_unique<TemplateURL>(data));
// Add 4 shortcuts with various keyword states to the db.
const auto create_keyword_shortcut =
[&](std::string fill_into_edit, std::string keyword,
std::string destination_url, bool explicit_keyword,
bool search) -> TestShortcutData {
const ui::PageTransition transition =
explicit_keyword ? ui::PageTransition(ui::PAGE_TRANSITION_TYPED |
ui::PAGE_TRANSITION_KEYWORD)
: ui::PAGE_TRANSITION_TYPED;
return {GetGuid(),
fill_into_edit,
fill_into_edit,
destination_url,
AutocompleteMatch::DocumentType::NONE,
"",
"0,1",
"",
"0,1",
transition,
search ? AutocompleteMatchType::SEARCH_HISTORY
: AutocompleteMatchType::HISTORY_URL,
keyword,
1,
10};
};
TestShortcutData shortcuts[] = {
create_keyword_shortcut("yahoo.com explicit keyword", "yahoo.com",
"https://yahoo.com/explicit-keyword", true, true),
create_keyword_shortcut("google.com non-explicit keyword", "google.com",
"https://google.com/non-explicit-keyword", false,
true),
create_keyword_shortcut("google.com navigation", "",
"https://google.com/navigation", false, false),
create_keyword_shortcut("yahoo.com search on google.com", "google.com",
"https://google.com/q=yahoo.com", true, true),
create_keyword_shortcut("search on yahoo.com", "yahoo.com",
"https://yahoo.com/q=search", false, true),
create_keyword_shortcut("search on google.com", "google.com",
"https://google.com/q=search", false, true),
};
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcuts, std::size(shortcuts));
const auto test = [&](const std::u16string text, bool prefer_keyword,
std::string expected_url, bool allowed_to_be_default,
std::u16string expected_autocompletion) {
AutocompleteInput input(text, metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
input.set_prefer_keyword(prefer_keyword);
ExpectedURLs expected_urls;
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault(expected_url, allowed_to_be_default));
RunShortcutsProviderTest(provider_, input, expected_urls, expected_url,
expected_autocompletion);
};
// When the input is in keyword mode, a match with the same keyword may be
// default.
test(u"yahoo.com exp", true, "https://yahoo.com/explicit-keyword", true,
u"licit keyword");
// When the input is in keyword mode, a match with a different keyword can not
// be default.
test(u"yahoo.com search ", true, "https://google.com/q=yahoo.com", false,
u"");
// When the input is in keyword mode, a match without a keyword can not be
// default.
test(u"google.com navigat", true, "https://google.com/navigation", false,
u"");
// When the input is in keyword mode, a match with a keyword hint can not be
// default.
test(u"google.com non-e", true, "https://google.com/non-explicit-keyword",
false, u"");
// When the input is NOT in keyword mode, a match with a keyword can not be
// default.
test(u"yahoo.com ex", false, "https://yahoo.com/explicit-keyword", false,
u"");
// When the input is NOT in keyword mode, a match with a keyword hint can be
// default.
test(u"google.com non-ex", false, "https://google.com/non-explicit-keyword",
true, u"plicit keyword");
// When the input is NOT in keyword mode, a match without a keyword can be
// default.
test(u"google.com navigat", false, "https://google.com/navigation", true,
u"ion");
// When the input is NOT in keyword mode, a match from a keyword other than
// default search provider can not be default.
test(u"search on y", false, "https://yahoo.com/q=search", false, u"");
// When the input is NOT in keyword mode, a match from the default search
// provider can be default.
test(u"search on g", false, "https://google.com/q=search", true,
u"oogle.com");
}
TEST_F(ShortcutsProviderTest, MultiMatch) {
TestShortcutData shortcut_data[] = {
MakeShortcutData("not-prefix", 10),
MakeShortcutData("prefix-short", 1),
MakeShortcutData("prefix-medium-length", 1),
MakeShortcutData("prefix-long-shortcut-text-length", 2),
};
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcut_data, std::size(shortcut_data));
AutocompleteInput input(u"prefix", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto matches = provider_->matches();
VerifyMatches(matches, {
// The shortcut with the most hits should be 1st
// even though it has less % of
// text matched.
"https://prefix-long-shortcut-text-length.com/2",
// Given equal hits, shorter texts have higher %
// matched and should score
// higher.
"https://prefix-short.com/1",
"https://prefix-medium-length.com/1",
});
}
TEST_F(ShortcutsProviderTest, RemoveDuplicates) {
std::u16string text(u"dupl");
ExpectedURLs expected_urls;
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://duplicate.com/", true));
// Make sure the URL only appears once in the output list.
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://duplicate.com/", u"icate");
}
TEST_F(ShortcutsProviderTest, TypedCountMatches) {
std::u16string text(u"just");
ExpectedURLs expected_urls;
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.testsite.com/b.html", true));
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.testsite.com/a.html", true));
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.testsite.com/c.html", true));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://www.testsite.com/b.html", std::u16string());
}
TEST_F(ShortcutsProviderTest, FragmentLengthMatches) {
std::u16string text(u"just a");
ExpectedURLs expected_urls;
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.testsite.com/d.html", true));
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.testsite.com/e.html", true));
expected_urls.push_back(
ExpectedURLAndAllowedToBeDefault("http://www.testsite.com/f.html", true));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://www.testsite.com/d.html", std::u16string());
}
TEST_F(ShortcutsProviderTest, DaysAgoMatches) {
std::u16string text(u"ago");
ExpectedURLs expected_urls;
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.daysagotest.com/a.html", true));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.daysagotest.com/b.html", true));
expected_urls.push_back(ExpectedURLAndAllowedToBeDefault(
"http://www.daysagotest.com/c.html", true));
RunShortcutsProviderTest(provider_, text, false, expected_urls,
"http://www.daysagotest.com/a.html",
std::u16string());
}
TEST_F(ShortcutsProviderTest, DeleteMatch) {
TestShortcutData shortcuts_to_test_delete[] = {
{GetGuid(), "delete", "www.deletetest.com/1",
"http://www.deletetest.com/1", AutocompleteMatch::DocumentType::NONE,
"http://www.deletetest.com/1", "0,2", "Erase this shortcut!", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 1},
{GetGuid(), "erase", "www.deletetest.com/1",
"http://www.deletetest.com/1", AutocompleteMatch::DocumentType::NONE,
"http://www.deletetest.com/1", "0,2", "Erase this shortcut!", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 1,
1},
{GetGuid(), "keep", "www.deletetest.com/1/2",
"http://www.deletetest.com/1/2", AutocompleteMatch::DocumentType::NONE,
"http://www.deletetest.com/1/2", "0,2", "Keep this shortcut!", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_TITLE, "", 1,
1},
{GetGuid(), "delete", "www.deletetest.com/2",
"http://www.deletetest.com/2", AutocompleteMatch::DocumentType::NONE,
"http://www.deletetest.com/2", "0,2", "Erase this shortcut!", "0,0",
ui::PAGE_TRANSITION_TYPED, AutocompleteMatchType::HISTORY_URL, "", 1, 1},
};
scoped_refptr<ShortcutsBackend> backend = client_->GetShortcutsBackend();
size_t original_shortcuts_count = backend->shortcuts_map().size();
PopulateShortcutsBackendWithTestData(backend, shortcuts_to_test_delete,
std::size(shortcuts_to_test_delete));
EXPECT_EQ(original_shortcuts_count + 4, backend->shortcuts_map().size());
EXPECT_FALSE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(u"delete"));
EXPECT_FALSE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(u"erase"));
AutocompleteMatch match(provider_.get(), 1200, true,
AutocompleteMatchType::HISTORY_TITLE);
match.destination_url = GURL(shortcuts_to_test_delete[0].destination_url);
match.contents = ASCIIToUTF16(shortcuts_to_test_delete[0].contents);
match.description = ASCIIToUTF16(shortcuts_to_test_delete[0].description);
provider_->DeleteMatch(match);
// shortcuts_to_test_delete[0] and shortcuts_to_test_delete[1] should be
// deleted, but not shortcuts_to_test_delete[2] or
// shortcuts_to_test_delete[3], which have different URLs.
EXPECT_EQ(original_shortcuts_count + 2, backend->shortcuts_map().size());
EXPECT_FALSE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(u"delete"));
EXPECT_TRUE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(u"erase"));
match.destination_url = GURL(shortcuts_to_test_delete[3].destination_url);
match.contents = ASCIIToUTF16(shortcuts_to_test_delete[3].contents);
match.description = ASCIIToUTF16(shortcuts_to_test_delete[3].description);
provider_->DeleteMatch(match);
EXPECT_EQ(original_shortcuts_count + 1, backend->shortcuts_map().size());
EXPECT_TRUE(backend->shortcuts_map().end() ==
backend->shortcuts_map().find(u"delete"));
}
TEST_F(ShortcutsProviderTest, DoesNotProvideOnFocus) {
AutocompleteInput input(u"about:o", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
input.set_focus_type(metrics::OmniboxFocusType::INTERACTION_FOCUS);
provider_->Start(input, false);
EXPECT_TRUE(provider_->matches().empty());
}
TEST_F(ShortcutsProviderTest, DoAutocompleteAggregateShortcuts) {
TestShortcutData shortcut_data[] = {
MakeShortcutData("wi", "https://wikipedia.org/wilson7", 1, 1),
MakeShortcutData("wilson7", "https://wikipedia.org/wilson7", 2, 2),
MakeShortcutData("wilson8", "https://wikipedia.org/wilson8", 1, 10),
MakeShortcutData("wilsonBoosted", "https://wikipedia.org/boosted", 0, 20),
// To verify the interaction with the provider limit.
MakeShortcutData("zebra1", "https://wikipedia.org/zebra-a", 1, 1),
MakeShortcutData("zebra2", "https://wikipedia.org/zebra-a", 1, 2),
MakeShortcutData("zebra3", "https://wikipedia.org/zebra-a", 1, 3),
MakeShortcutData("zebra4", "https://wikipedia.org/zebra-a", 1, 4),
MakeShortcutData("zebra5", "https://wikipedia.org/zebra-b", 1, 6),
MakeShortcutData("zebra6", "https://wikipedia.org/zebra-b", 1, 4),
MakeShortcutData("zebra7", "https://wikipedia.org/zebra-c", 1, 10),
MakeShortcutData("zebra8", "https://wikipedia.org/zebra-d", 1, 10),
};
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcut_data, std::size(shortcut_data));
{
SCOPED_TRACE("Input 'wi'");
// When multiple shortcuts with the same destination URL match the input,
// they should be scored together (i.e. their visit counts summed, the most
// recent visit date and shortest text considered).
AutocompleteInput input(u"wi", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
VerifyMatches(matches, {
"https://wikipedia.org/boosted",
"https://wikipedia.org/wilson8",
"https://wikipedia.org/wilson7",
});
// Boosted 1414 + number of hits.
EXPECT_EQ(matches[0].relevance, 1434);
EXPECT_EQ(matches[1].relevance, 1424);
EXPECT_EQ(matches[2].relevance, 1417); // Aggregate number of hits: 1 + 2.
}
{
SCOPED_TRACE("Input 'wilson'");
// When multiple shortcuts have the same destination URL but only 1 matches
// the input, they should not be scored together.
AutocompleteInput input(u"wilson", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
VerifyMatches(matches, {
"https://wikipedia.org/boosted",
"https://wikipedia.org/wilson8",
"https://wikipedia.org/wilson7",
});
EXPECT_EQ(matches[0].relevance, 1434);
EXPECT_EQ(matches[1].relevance, 1424);
EXPECT_EQ(matches[2].relevance, 1416); // Un-aggregated number of hits: 2.
}
{
SCOPED_TRACE("Input 'zebra'");
// The provider limit should not affect number of shortcuts aggregated, only
// the matches returned, i.e. the number of aggregate shortcuts. There are
// 8 shortcuts matching the input with 4 unique URLs. The top 3 aggregate
// shortcuts have the same aggregate score factors and should be scored the
// same (other than the `+ 1` limitation). The 4th match is above the
// provider limit and should not be returned.
AutocompleteInput input(u"zebra", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
VerifyMatches(matches, {
"https://wikipedia.org/zebra-c",
"https://wikipedia.org/zebra-a",
"https://wikipedia.org/zebra-b",
});
EXPECT_EQ(matches[0].relevance, 1424);
EXPECT_EQ(matches[1].relevance, 1423);
EXPECT_EQ(matches[2].relevance, 1422);
}
{
SCOPED_TRACE("ML Signals");
// The provider should not limit the number of suggestions when ML scoring
// w/increased candidates is enabled. Any matches beyond the limit should be
// marked as culled_by_provider and have a relevance of 0.
scoped_feature_list_.Reset();
scoped_feature_list_.InitWithFeaturesAndParameters(
/*enabled_features=*/
{{omnibox::kUrlScoringModel, {}},
{omnibox::kMlUrlScoring,
{{"MlUrlScoringUnlimitedNumCandidates", "true"}}}},
/*disabled_features=*/{});
OmniboxFieldTrial::ScopedMLConfigForTesting scoped_ml_config;
AutocompleteInput input(u"zebra", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 4u);
// Matches below the limit.
EXPECT_FALSE(matches[0].culled_by_provider);
EXPECT_GT(matches[0].relevance, 0);
// Matches that would've originally been culled above the limit should be
// marked as such and have a zero relevance score.
EXPECT_TRUE(matches[3].culled_by_provider);
EXPECT_EQ(matches[3].relevance, 0);
// Unlimited matches should ignore the provider max matches, even if the
// `kMlUrlScoringMaxMatchesByProvider` param is set.
scoped_ml_config.GetMLConfig().ml_url_scoring_max_matches_by_provider =
"*:2";
provider_->Start(input, false);
const auto& new_matches = provider_->matches();
EXPECT_EQ(new_matches.size(), 4u);
}
}
TEST_F(ShortcutsProviderTest, DoAutocompleteWithScoringSignals) {
OmniboxFieldTrial::ScopedMLConfigForTesting scoped_ml_config;
scoped_ml_config.GetMLConfig().log_url_scoring_signals = true;
TestShortcutData shortcut_data[] = {
MakeShortcutData("wikipedia", "https://wikipedia.org/wilson7", 1, 1),
MakeShortcutData("wilson7", "https://wikipedia.org/wilson7", 2, 2),
MakeShortcutData("winston", "https://wikipedia.org/winston", 1, 3),
MakeShortcutData("wilson7", "https://wikipedia.org/wilson7-other", 2, 2),
};
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcut_data, std::size(shortcut_data));
// When multiple shortcuts with the same destination URL match the input,
// they should be scored together (i.e. their visit counts summed, the most
// recent visit date and shortest text considered).
AutocompleteInput input(u"wi", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
DoAutocompleteWithScoringSignals(input);
auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 3u);
// These matches are all HISTORY_URL type, so should have scoring signals
// attached.
EXPECT_TRUE(matches[0].IsMlSignalLoggingEligible());
EXPECT_TRUE(matches[0].scoring_signals.has_value());
EXPECT_TRUE(matches[1].IsMlSignalLoggingEligible());
EXPECT_TRUE(matches[1].scoring_signals.has_value());
EXPECT_TRUE(matches[2].IsMlSignalLoggingEligible());
EXPECT_TRUE(matches[2].scoring_signals.has_value());
// There are 2 shortcuts with the wilson7 url which have the same aggregate
// text length, visit count, and last visit as the 1 winston shortcut.
EXPECT_EQ(matches[0].scoring_signals->shortcut_visit_count(), 3);
EXPECT_EQ(matches[0].scoring_signals->typed_count(), 3);
EXPECT_EQ(matches[0].scoring_signals->visit_count(), 3);
EXPECT_EQ(matches[0].scoring_signals->shortest_shortcut_len(), 7);
EXPECT_EQ(matches[1].scoring_signals->shortcut_visit_count(), 3);
EXPECT_EQ(matches[1].scoring_signals->typed_count(), 3);
EXPECT_EQ(matches[1].scoring_signals->visit_count(), 3);
EXPECT_EQ(matches[1].scoring_signals->shortest_shortcut_len(), 7);
EXPECT_EQ(matches[2].scoring_signals->shortcut_visit_count(), 2);
EXPECT_EQ(matches[2].scoring_signals->typed_count(), 2);
EXPECT_EQ(matches[2].scoring_signals->visit_count(), 2);
EXPECT_EQ(matches[2].scoring_signals->shortest_shortcut_len(), 7);
// Check with (SEARCH_HISTORY) type match and confirm that the match has
// scoring signals attached.
AutocompleteInput input2(u"que", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
DoAutocompleteWithScoringSignals(input2);
EXPECT_EQ(matches.size(), 1u);
EXPECT_TRUE(matches[0].IsMlSignalLoggingEligible());
EXPECT_TRUE(matches[0].scoring_signals.has_value());
}
TEST_F(ShortcutsProviderTest, Score) {
const auto days_ago = [](int n) { return base::Time::Now() - base::Days(n); };
// Aggregate score should consider the shortest text length, most recent visit
// time, and sum of visit counts.
// It's not possible to have shortcuts with 0 hits. But using realistic values
// would trigger shortcut boosting while we want to test the unboosted scores.
auto shortcut_a_short = MakeShortcut(u"size______12", days_ago(3), 0);
auto shortcut_a_frequent = MakeShortcut(u"size__________16", days_ago(3), 1);
auto shortcut_a_recent = MakeShortcut(u"size__________16", days_ago(1), 0);
auto score_a = CalculateAggregateScore(
1, {&shortcut_a_short, &shortcut_a_frequent, &shortcut_a_recent});
auto shortcut_b = MakeShortcut(u"size______12", days_ago(1), 1);
auto score_b = CalculateAggregateScore(1, {&shortcut_b});
EXPECT_EQ(score_a, score_b);
EXPECT_GT(score_a, 0);
EXPECT_LT(score_a, 1414);
// Typing more of the text increases score.
auto score_b_long_query = CalculateAggregateScore(2, {&shortcut_b});
EXPECT_GT(score_b_long_query, score_b);
// When creating or updating shortcuts, their text is set longer than the user
// input (see `ShortcutBackend::AddOrUpdateShortcut()`). So `CalculateScore()`
// permits up to 10 missing chars before beginning to decrease scores.
EXPECT_EQ(CalculateAggregateScore(6, {&shortcut_a_frequent}),
CalculateAggregateScore(14, {&shortcut_a_frequent}));
// Make sure there's no negative or weird scores when the shortcut text is
// shorter than the 10 char adjustment.
const auto shortcut = MakeShortcut(u"test");
const int kMaxScore = CalculateAggregateScore(4, {&shortcut});
const auto short_shortcut = MakeShortcut(u"ab");
EXPECT_EQ(CalculateAggregateScore(2, {&short_shortcut}), kMaxScore);
EXPECT_EQ(CalculateAggregateScore(1, {&short_shortcut}), kMaxScore);
// More recent shortcuts should be scored higher.
auto shortcut_b_old = MakeShortcut(u"size______12", days_ago(2), 1);
auto score_b_old = CalculateAggregateScore(1, {&shortcut_b_old});
EXPECT_LT(score_b_old, score_b);
// Shortcuts with higher visit counts should be scored higher.
auto shortcut_b_infrequent = MakeShortcut(u"size______12", days_ago(1), 0);
auto score_b_infrequent =
CalculateAggregateScore(1, {&shortcut_b_infrequent});
EXPECT_LT(score_b_infrequent, score_b);
}
TEST_F(ShortcutsProviderTest, ScoreBoost) {
// The max score a shortcut can have if not boosted.
const int kMaxUnboostedScore = 1199;
auto create_shortcut_data = [](std::string text, bool is_search,
int visit_count) -> TestShortcutData {
std::string destination_string =
"https://" + text + ".com/" + base::NumberToString(visit_count);
return {GetGuid(),
text,
text,
destination_string,
AutocompleteMatch::DocumentType::NONE,
"",
"",
"",
"",
ui::PageTransition::PAGE_TRANSITION_TYPED,
is_search ? AutocompleteMatchType::SEARCH_SUGGEST
: AutocompleteMatchType::HISTORY_URL,
is_search ? "google" : "",
1,
visit_count};
};
TestShortcutData shortcut_data[] = {
create_shortcut_data("only-searches", true, 1),
create_shortcut_data("only-urls", false, 2),
create_shortcut_data("only-urls", false, 1),
create_shortcut_data("searches-before-urls", true, 2),
create_shortcut_data("searches-before-urls", false, 1),
create_shortcut_data("urls-before-searches", false, 2),
create_shortcut_data("urls-before-searches", true, 1),
create_shortcut_data("urls-saddling-searches-low-visits-a", false, 1),
create_shortcut_data("urls-saddling-searches-low-visits-b", true, 1),
create_shortcut_data("urls-saddling-searches-low-visits-c", false, 1),
create_shortcut_data("urls-saddling-searches-high-visits", false, 6),
create_shortcut_data("urls-saddling-searches-high-visits", true, 5),
create_shortcut_data("urls-saddling-searches-high-visits", false, 4),
};
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
shortcut_data, std::size(shortcut_data));
{
// Searches shouldn't be boosted since the appropriate param is not set.
AutocompleteInput input(u"only-searches", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 1u);
EXPECT_EQ(matches[0].destination_url.spec(), "https://only-searches.com/1");
EXPECT_LE(matches[0].relevance, kMaxUnboostedScore);
}
{
// Only the 1st URL should be boosted.
AutocompleteInput input(u"only-urls", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 2u);
EXPECT_EQ(matches[0].destination_url.spec(), "https://only-urls.com/2");
EXPECT_EQ(matches[1].destination_url.spec(), "https://only-urls.com/1");
EXPECT_EQ(matches[0].relevance, 1416);
EXPECT_LE(matches[1].relevance, kMaxUnboostedScore);
}
{
// URLs should only boosted if they're 1st of all matches (including
// searches).
AutocompleteInput input(u"searches-before-urls",
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 2u);
EXPECT_EQ(matches[0].destination_url.spec(),
"https://searches-before-urls.com/2");
EXPECT_EQ(matches[1].destination_url.spec(),
"https://searches-before-urls.com/1");
EXPECT_LE(matches[0].relevance, kMaxUnboostedScore);
EXPECT_LE(matches[1].relevance, kMaxUnboostedScore);
}
{
// URLs should only boosted if they're 1st of all matches (including
// searches).
AutocompleteInput input(u"urls-before-searches",
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 2u);
EXPECT_EQ(matches[0].destination_url.spec(),
"https://urls-before-searches.com/2");
EXPECT_EQ(matches[1].destination_url.spec(),
"https://urls-before-searches.com/1");
EXPECT_EQ(matches[0].relevance, 1416);
EXPECT_LE(matches[1].relevance, kMaxUnboostedScore);
}
{
// All URLs meeting `ShortcutBoostNonTopHitThreshold` should be boosted.
AutocompleteInput input(u"urls-saddling-searches-high-visits",
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 3u);
EXPECT_EQ(matches[0].destination_url.spec(),
"https://urls-saddling-searches-high-visits.com/6");
EXPECT_EQ(matches[1].destination_url.spec(),
"https://urls-saddling-searches-high-visits.com/4");
EXPECT_EQ(matches[2].destination_url.spec(),
"https://urls-saddling-searches-high-visits.com/5");
EXPECT_EQ(matches[0].relevance, 1420);
EXPECT_EQ(matches[1].relevance, 1418);
EXPECT_LE(matches[2].relevance, kMaxUnboostedScore);
}
{
// URLs not meeting `ShortcutBoostNonTopHitThreshold` should not be boosted
// except for the top shortcut.
AutocompleteInput input(u"urls-saddling-searches-low-visits",
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto& matches = provider_->matches();
EXPECT_EQ(matches.size(), 3u);
EXPECT_EQ(matches[0].destination_url.spec(),
"https://urls-saddling-searches-low-visits-a.com/1");
EXPECT_EQ(matches[1].destination_url.spec(),
"https://urls-saddling-searches-low-visits-c.com/1");
EXPECT_EQ(matches[2].destination_url.spec(),
"https://urls-saddling-searches-low-visits-b.com/1");
EXPECT_EQ(matches[0].relevance, 1414);
EXPECT_LE(matches[1].relevance, kMaxUnboostedScore);
EXPECT_LE(matches[2].relevance, kMaxUnboostedScore);
}
}
#if !BUILDFLAG(IS_IOS)
TEST_F(ShortcutsProviderTest, HistoryClusterSuggestions) {
const auto create_test_data =
[](std::string text, bool is_history_cluster) -> TestShortcutData {
return {GetGuid(), text, "fill_into_edit",
// Use unique URLs to avoid deduping.
"http://www.destination_url.com/" + text,
AutocompleteMatch::DocumentType::NONE, "contents", "0,0",
"description", "0,0", ui::PAGE_TRANSITION_TYPED,
is_history_cluster ? AutocompleteMatchType::HISTORY_CLUSTER
: AutocompleteMatchType::HISTORY_URL,
/*keyword=*/"",
/*days_from_now=*/1,
/*number_of_hits=*/1};
};
// `provider_max_matches_` is 3. Create more than 3 cluster and non-cluster
// shortcuts.
TestShortcutData test_data[] = {
create_test_data("text_history_0", false),
create_test_data("text_history_1", false),
create_test_data("text_history_2", false),
create_test_data("text_history_3", false),
create_test_data("text_cluster_0", true),
create_test_data("text_cluster_1", true),
create_test_data("text_cluster_2", true),
create_test_data("text_cluster_3", true),
};
PopulateShortcutsBackendWithTestData(client_->GetShortcutsBackend(),
test_data, std::size(test_data));
AutocompleteInput input(u"tex", metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
provider_->Start(input, false);
const auto matches = provider_->matches();
// Expect 3 (i.e. `provider_max_matches_`) non-cluster matches, and all
// cluster matches. Expect only the non-cluster matches to be allowed to be
// default.
ASSERT_EQ(matches.size(), 7u);
EXPECT_EQ(matches[0].type, AutocompleteMatchType::HISTORY_URL);
EXPECT_EQ(matches[0].allowed_to_be_default_match, true);
EXPECT_EQ(matches[1].type, AutocompleteMatchType::HISTORY_URL);
EXPECT_EQ(matches[1].allowed_to_be_default_match, true);
EXPECT_EQ(matches[2].type, AutocompleteMatchType::HISTORY_URL);
EXPECT_EQ(matches[2].allowed_to_be_default_match, true);
EXPECT_EQ(matches[3].type, AutocompleteMatchType::HISTORY_CLUSTER);
EXPECT_EQ(matches[3].allowed_to_be_default_match, false);
EXPECT_EQ(matches[4].type, AutocompleteMatchType::HISTORY_CLUSTER);
EXPECT_EQ(matches[4].allowed_to_be_default_match, false);
EXPECT_EQ(matches[5].type, AutocompleteMatchType::HISTORY_CLUSTER);
EXPECT_EQ(matches[5].allowed_to_be_default_match, false);
EXPECT_EQ(matches[6].type, AutocompleteMatchType::HISTORY_CLUSTER);
EXPECT_EQ(matches[6].allowed_to_be_default_match, false);
// Expect only non-cluster matches to have capped decrementing scores.
// Approximate scores should be 1414, 900, 900-1, 900, 900, 900, 900. I.e. the
// 1st shortcut is boosted to 1414. The rest are scored traditionally. The 3rd
// is decremented by 1 to avoid equal scores. The cluster shortcuts are not
// decremented.
EXPECT_LT(matches[1].relevance, matches[0].relevance - 1);
EXPECT_EQ(matches[2].relevance, matches[1].relevance - 1);
EXPECT_EQ(matches[3].relevance, matches[1].relevance);
EXPECT_EQ(matches[4].relevance, matches[1].relevance);
EXPECT_EQ(matches[5].relevance, matches[1].relevance);
EXPECT_EQ(matches[6].relevance, matches[1].relevance);
// Expect cluster matches to not have grouping.
EXPECT_EQ(matches[0].suggestion_group_id, std::nullopt);
EXPECT_EQ(matches[1].suggestion_group_id, std::nullopt);
EXPECT_EQ(matches[2].suggestion_group_id, std::nullopt);
EXPECT_EQ(matches[3].suggestion_group_id, std::nullopt);
EXPECT_EQ(matches[4].suggestion_group_id, std::nullopt);
EXPECT_EQ(matches[5].suggestion_group_id, std::nullopt);
EXPECT_EQ(matches[6].suggestion_group_id, std::nullopt);
}
#endif // !BUILDFLAG(IS_IOS)
|