1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/segmentation_platform/internal/database/database_maintenance_impl.h"
#include <cstdint>
#include <memory>
#include <utility>
#include <vector>
#include "base/metrics/metrics_hashes.h"
#include "base/notreached.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/gmock_callback_support.h"
#include "base/test/simple_test_clock.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "components/prefs/testing_pref_service.h"
#include "components/segmentation_platform/internal/constants.h"
#include "components/segmentation_platform/internal/database/mock_signal_database.h"
#include "components/segmentation_platform/internal/database/mock_signal_storage_config.h"
#include "components/segmentation_platform/internal/database/mock_ukm_database.h"
#include "components/segmentation_platform/internal/database/signal_storage_config.h"
#include "components/segmentation_platform/internal/database/storage_service.h"
#include "components/segmentation_platform/internal/database/test_segment_info_database.h"
#include "components/segmentation_platform/internal/mock_ukm_data_manager.h"
#include "components/segmentation_platform/public/config.h"
#include "components/segmentation_platform/public/proto/aggregation.pb.h"
#include "components/segmentation_platform/public/proto/segmentation_platform.pb.h"
#include "components/segmentation_platform/public/proto/types.pb.h"
#include "components/segmentation_platform/public/segmentation_platform_service.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::base::test::RunOnceCallback;
using ::testing::_;
using ::testing::Return;
using ::testing::SetArgReferee;
namespace segmentation_platform {
using SegmentId = proto::SegmentId;
using SignalType = proto::SignalType;
using Aggregation = proto::Aggregation;
using SignalIdentifier = std::pair<uint64_t, SignalType>;
namespace {
constexpr uint64_t kLatestCompactionDaysAgo = 2;
constexpr uint64_t kEarliestCompactionDaysAgo = 60;
// Event hash for non UKM signals.
static const uint64_t kNonUkmEventHash = 0;
std::string kTestSegmentationKey = "some_key";
struct SignalData {
SegmentId target;
proto::SignalType signal_type;
std::string name;
uint64_t name_hash;
uint64_t bucket_count;
uint64_t tensor_length;
Aggregation aggregation;
base::Time earliest_needed_timestamp;
bool success;
};
} // namespace
std::set<DatabaseMaintenanceImpl::SignalIdentifier> GetSignalIds(
std::vector<SignalData> signal_datas) {
std::set<DatabaseMaintenanceImpl::SignalIdentifier> signal_ids;
for (auto& sd : signal_datas)
signal_ids.emplace(sd.name_hash, sd.signal_type);
return signal_ids;
}
std::vector<CleanupItem> GetCleanupItems(std::vector<SignalData> signal_datas) {
std::vector<CleanupItem> cleanup_items;
for (auto& sd : signal_datas) {
cleanup_items.emplace_back(sd.name_hash, kNonUkmEventHash, sd.signal_type,
sd.earliest_needed_timestamp);
}
return cleanup_items;
}
class DatabaseMaintenanceImplTest : public testing::Test {
public:
DatabaseMaintenanceImplTest() = default;
~DatabaseMaintenanceImplTest() override = default;
void SetUp() override {
SegmentationPlatformService::RegisterProfilePrefs(prefs_.registry());
auto segment_info_database =
std::make_unique<test::TestSegmentInfoDatabase>();
segment_info_database_ = segment_info_database.get();
auto signal_database = std::make_unique<MockSignalDatabase>();
signal_database_ = signal_database.get();
auto signal_storage_config = std::make_unique<MockSignalStorageConfig>();
signal_storage_config_ = signal_storage_config.get();
mock_ukm_data_manager_ = std::make_unique<MockUkmDataManager>();
mock_ukm_database_ = std::unique_ptr<MockUkmDatabase>();
storage_service_ = std::make_unique<StorageService>(
std::move(segment_info_database), std::move(signal_database),
std::move(signal_storage_config), nullptr, nullptr,
mock_ukm_data_manager_.get());
base::flat_set<SegmentId> segment_ids = {
SegmentId::OPTIMIZATION_TARGET_SEGMENTATION_NEW_TAB,
SegmentId::OPTIMIZATION_TARGET_SEGMENTATION_SHARE};
database_maintenance_ = std::make_unique<DatabaseMaintenanceImpl>(
segment_ids, &clock_, storage_service_.get(), &prefs_);
clock_.SetNow(base::Time::Now());
}
void TearDown() override {
database_maintenance_.reset();
segment_info_database_ = nullptr;
signal_database_ = nullptr;
signal_storage_config_ = nullptr;
storage_service_.reset();
mock_ukm_data_manager_.reset();
mock_ukm_database_.reset();
}
// Adds the provided features to the SegmentInfoDatabase.
void AddFeatures(std::vector<SignalData> signal_datas) {
for (auto& sd : signal_datas) {
switch (sd.signal_type) {
case SignalType::HISTOGRAM_VALUE: {
segment_info_database_->AddHistogramValueFeature(
sd.target, sd.name, sd.bucket_count, sd.tensor_length,
sd.aggregation);
break;
}
case SignalType::HISTOGRAM_ENUM: {
segment_info_database_->AddHistogramEnumFeature(
sd.target, sd.name, sd.bucket_count, sd.tensor_length,
sd.aggregation, {});
break;
}
case SignalType::USER_ACTION: {
segment_info_database_->AddUserActionFeature(
sd.target, sd.name, sd.bucket_count, sd.tensor_length,
sd.aggregation);
break;
}
default: {
NOTREACHED() << "Incorrect SignalType";
}
}
}
}
void TestMaintenanceTasksScheduling(uint64_t earliest_days_ago) {
std::vector<SignalData> signal_datas = {
{SegmentId::OPTIMIZATION_TARGET_SEGMENTATION_NEW_TAB,
SignalType::HISTOGRAM_VALUE, "Foo", base::HashMetricName("Foo"), 44, 1,
Aggregation::COUNT, clock_.Now() - base::Days(10), true},
{SegmentId::OPTIMIZATION_TARGET_SEGMENTATION_SHARE,
SignalType::HISTOGRAM_ENUM, "Bar", base::HashMetricName("Bar"), 33, 1,
Aggregation::COUNT, clock_.Now() - base::Days(5), true},
{SegmentId::OPTIMIZATION_TARGET_SEGMENTATION_SHARE,
SignalType::USER_ACTION, "Failed", base::HashMetricName("Failed"), 22,
1, Aggregation::COUNT, clock_.Now() - base::Days(1), false},
};
// Prepare test setup.
AddFeatures(signal_datas);
std::set<DatabaseMaintenanceImpl::SignalIdentifier> signal_ids =
GetSignalIds(signal_datas);
std::vector<CleanupItem> cleanup_items = GetCleanupItems(signal_datas);
// Ensure we return the correct signals.
ON_CALL(*signal_storage_config_, GetSignalsForCleanup(_, _))
.WillByDefault(SetArgReferee<1>(cleanup_items));
// We should try to delete each signal.
for (auto& sd : signal_datas) {
EXPECT_CALL(*signal_database_,
DeleteSamples(sd.signal_type, sd.name_hash,
sd.earliest_needed_timestamp, _))
.WillOnce(RunOnceCallback<3>(sd.success));
}
// The Failed signal failed to clean up, so we should not be updating it,
// but the rest should be updated.
cleanup_items.erase(
std::remove_if(cleanup_items.begin(), cleanup_items.end(),
[](CleanupItem item) {
return item.name_hash ==
base::HashMetricName("Failed");
}),
cleanup_items.end());
EXPECT_CALL(*signal_storage_config_,
UpdateSignalsForCleanup(cleanup_items));
// Verify that for each of the signal data, we get a compaction request for
// each day within the correct range.
for (auto& sd : signal_datas) {
for (uint64_t days_ago = kLatestCompactionDaysAgo;
days_ago <= earliest_days_ago; ++days_ago) {
EXPECT_CALL(
*signal_database_,
CompactSamplesForDay(sd.signal_type, sd.name_hash,
clock_.Now().UTCMidnight() + base::Days(1) -
base::Seconds(1) - base::Days(days_ago),
_))
.WillOnce(RunOnceCallback<3>(/*success=*/sd.success));
}
}
}
base::test::TaskEnvironment task_environment_;
std::unique_ptr<Config> config_;
base::SimpleTestClock clock_;
std::unique_ptr<MockUkmDatabase> mock_ukm_database_;
std::unique_ptr<MockUkmDataManager> mock_ukm_data_manager_;
std::unique_ptr<StorageService> storage_service_;
raw_ptr<test::TestSegmentInfoDatabase> segment_info_database_;
raw_ptr<MockSignalDatabase> signal_database_;
raw_ptr<MockSignalStorageConfig> signal_storage_config_;
std::unique_ptr<DatabaseMaintenanceImpl> database_maintenance_;
TestingPrefServiceSimple prefs_;
};
TEST_F(DatabaseMaintenanceImplTest, ExecuteMaintenanceTasks) {
TestMaintenanceTasksScheduling(kEarliestCompactionDaysAgo);
// Kick off all tasks.
database_maintenance_->ExecuteMaintenanceTasks();
}
TEST_F(DatabaseMaintenanceImplTest, NoCompactionForDataAlreadyCompacted) {
// Simulate that a maintenance task has compacted all samples 4 days ago.
prefs_.SetTime(kSegmentationLastDBCompactionTimePref,
clock_.Now().UTCMidnight() - base::Days(3) - base::Seconds(1));
TestMaintenanceTasksScheduling(3);
// Kick off all tasks.
database_maintenance_->ExecuteMaintenanceTasks();
}
} // namespace segmentation_platform
|