1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/sharing_message/sharing_device_source_sync.h"
#include <memory>
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "base/uuid.h"
#include "components/send_tab_to_self/features.h"
#include "components/send_tab_to_self/target_device_info.h"
#include "components/sharing_message/fake_device_info.h"
#include "components/sharing_message/features.h"
#include "components/sharing_message/sharing_constants.h"
#include "components/sharing_message/sharing_utils.h"
#include "components/sync/test/test_sync_service.h"
#include "components/sync_device_info/device_info.h"
#include "components/sync_device_info/fake_device_info_sync_service.h"
#include "components/sync_device_info/fake_device_info_tracker.h"
#include "components/sync_device_info/fake_local_device_info_provider.h"
#include "components/sync_device_info/local_device_info_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
const char kSenderIdFCMToken[] = "sharing_fcm_token";
const char kSenderIdP256dh[] = "sharing_p256dh";
const char kSenderIdAuthSecret[] = "sharing_auth_secret";
const char kChimeRepresentativeTargetId[] = "chime_rep_id";
std::unique_ptr<syncer::DeviceInfo> CreateDeviceInfo(
const std::string& client_name,
sync_pb::SharingSpecificFields::EnabledFeatures enabled_feature,
const std::string& manufacturer_name = "manufacturer",
const std::string& model_name = "model",
syncer::DeviceInfo::SharingTargetInfo sender_id_target_info =
{kSenderIdFCMToken, kSenderIdP256dh, kSenderIdAuthSecret},
const std::string& chime_rep_id = kChimeRepresentativeTargetId) {
syncer::DeviceInfo::SharingInfo sharing_info(std::move(sender_id_target_info),
chime_rep_id, {enabled_feature});
return CreateFakeDeviceInfo(
base::Uuid::GenerateRandomV4().AsLowercaseString(), client_name,
std::move(sharing_info), sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
syncer::DeviceInfo::OsType::kLinux,
syncer::DeviceInfo::FormFactor::kDesktop, manufacturer_name, model_name);
}
class SharingDeviceSourceSyncTest : public testing::Test {
public:
std::unique_ptr<SharingDeviceSourceSync> CreateDeviceSource(
bool wait_until_ready) {
auto device_source = std::make_unique<SharingDeviceSourceSync>(
&test_sync_service_, &fake_local_device_info_provider_,
&fake_device_info_tracker_);
if (!wait_until_ready) {
return device_source;
}
if (!fake_device_info_tracker_.IsSyncing()) {
fake_device_info_tracker_.Add(local_device_info_);
}
fake_local_device_info_provider_.SetReady(true);
// Wait until local personalizable device
base::RunLoop run_loop;
device_source->AddReadyCallback(run_loop.QuitClosure());
run_loop.Run();
return device_source;
}
protected:
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
base::test::ScopedFeatureList scoped_feature_list_;
syncer::TestSyncService test_sync_service_;
syncer::FakeDeviceInfoSyncService fake_device_info_sync_service_;
syncer::FakeLocalDeviceInfoProvider fake_local_device_info_provider_;
syncer::FakeDeviceInfoTracker fake_device_info_tracker_;
raw_ptr<const syncer::DeviceInfo> local_device_info_ =
fake_local_device_info_provider_.GetLocalDeviceInfo();
};
} // namespace
TEST_F(SharingDeviceSourceSyncTest, RunsReadyCallback) {
fake_local_device_info_provider_.SetReady(false);
EXPECT_FALSE(fake_device_info_tracker_.IsSyncing());
EXPECT_FALSE(fake_local_device_info_provider_.GetLocalDeviceInfo());
auto device_source = CreateDeviceSource(/*wait_until_ready=*/false);
base::RunLoop run_loop;
bool did_run_callback = false;
device_source->AddReadyCallback(
base::BindLambdaForTesting([&did_run_callback, &run_loop]() {
did_run_callback = true;
run_loop.Quit();
}));
EXPECT_FALSE(did_run_callback);
// Make DeviceInfoTracker ready.
fake_device_info_tracker_.Add(local_device_info_);
EXPECT_FALSE(did_run_callback);
// Set LocalDeviceInfoProvider ready.
fake_local_device_info_provider_.SetReady(true);
EXPECT_FALSE(did_run_callback);
// Wait until local device name is ready.
run_loop.Run();
EXPECT_TRUE(did_run_callback);
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceByGuid_Ready) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
EXPECT_TRUE(device_source->GetDeviceByGuid(local_device_info_->guid()));
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceByGuid_NotReady) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/false);
fake_device_info_tracker_.Add(local_device_info_);
// Even if local device is not ready we should be able to query devices.
EXPECT_TRUE(device_source->GetDeviceByGuid(local_device_info_->guid()));
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceByGuid_UnknownGuid) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
EXPECT_FALSE(device_source->GetDeviceByGuid("unknown"));
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceByGuid_SyncDisabled) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
test_sync_service_.SetSignedOut();
EXPECT_FALSE(device_source->GetDeviceByGuid(local_device_info_->guid()));
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_Ready) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
auto device_info = CreateDeviceInfo(
"client_name", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
fake_device_info_tracker_.Add(device_info.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
ASSERT_EQ(1u, devices.size());
EXPECT_EQ(device_info->guid(), devices[0].guid());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_NotReady) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/false);
auto device_info = CreateDeviceInfo(
"client_name", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
fake_device_info_tracker_.Add(device_info.get());
// Local device needs to be ready for deduplication.
EXPECT_TRUE(device_source
->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2)
.empty());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_Deduplicated) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
// Add two devices with the same |client_name| without hardware info.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_1 = CreateDeviceInfo(
"client_name_1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
fake_device_info_tracker_.Add(device_info_1.get());
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_2 = CreateDeviceInfo(
"client_name_1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
fake_device_info_tracker_.Add(device_info_2.get());
// Add two devices with the same hardware info.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_3 = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 1", "model 1");
fake_device_info_tracker_.Add(device_info_3.get());
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_4 = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 1", "model 1");
fake_device_info_tracker_.Add(device_info_4.get());
// Add a device with the same info as the local device.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_5 =
CreateDeviceInfo(local_device_info_->client_name(),
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
local_device_info_->manufacturer_name(),
local_device_info_->model_name());
fake_device_info_tracker_.Add(device_info_5.get());
// Add a device with the local personalizable device name as client_name to
// simulate old versions without hardware info.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_6 =
CreateDeviceInfo(syncer::GetPersonalizableDeviceNameBlocking(),
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
fake_device_info_tracker_.Add(device_info_6.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
ASSERT_EQ(2u, devices.size());
EXPECT_EQ(device_info_4->guid(), devices[0].guid());
EXPECT_EQ(device_info_2->guid(), devices[1].guid());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_DeviceNaming) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_1 = CreateDeviceInfo(
"client_name", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
fake_device_info_tracker_.Add(device_info_1.get());
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_2 = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 1", "model 1");
fake_device_info_tracker_.Add(device_info_2.get());
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_3 = CreateDeviceInfo(
"model 2", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 1", "model 2");
fake_device_info_tracker_.Add(device_info_3.get());
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_4 = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 2", "model 1");
fake_device_info_tracker_.Add(device_info_4.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
ASSERT_EQ(4u, devices.size());
EXPECT_EQ(
send_tab_to_self::GetSharingDeviceNames(device_info_4.get()).short_name,
devices[0].client_name());
EXPECT_EQ(
send_tab_to_self::GetSharingDeviceNames(device_info_3.get()).full_name,
devices[1].client_name());
EXPECT_EQ(
send_tab_to_self::GetSharingDeviceNames(device_info_2.get()).full_name,
devices[2].client_name());
EXPECT_EQ(
send_tab_to_self::GetSharingDeviceNames(device_info_1.get()).short_name,
devices[3].client_name());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_Expired) {
// Create device in advance so we can forward time before calling
// GetDeviceCandidates.
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
auto device_info = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 2", "model 1");
fake_device_info_tracker_.Add(device_info.get());
// Forward time until device expires.
task_environment_.FastForwardBy(kSharingDeviceExpiration +
base::Milliseconds(1));
std::vector<SharingTargetDeviceInfo> candidates =
device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
EXPECT_TRUE(candidates.empty());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_MissingRequirements) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
// Create device in with Click to call feature.
auto device_info = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 2", "model 1");
fake_device_info_tracker_.Add(device_info.get());
// Requires shared clipboard feature.
std::vector<SharingTargetDeviceInfo> candidates =
device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::SHARED_CLIPBOARD_V2);
EXPECT_TRUE(candidates.empty());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_RenameAfterFiltering) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
// This device will be filtered out because its older than |min_updated_time|.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_1 = CreateDeviceInfo(
"model 3", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 2", "model 3");
fake_device_info_tracker_.Add(device_info_1.get());
// This device will be displayed with its short name.
task_environment_.FastForwardBy(kSharingDeviceExpiration);
auto device_info_2 = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 1", "model 1");
fake_device_info_tracker_.Add(device_info_2.get());
// This device will be filtered out since click to call is not enabled.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_3 = CreateDeviceInfo(
"model 1", sync_pb::SharingSpecificFields::SHARED_CLIPBOARD_V2,
"manufacturer 1", "model 1");
fake_device_info_tracker_.Add(device_info_3.get());
// This device will be displayed with its short name.
task_environment_.FastForwardBy(base::Seconds(10));
auto device_info_4 = CreateDeviceInfo(
"model 2", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer 2", "model 2");
fake_device_info_tracker_.Add(device_info_4.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
ASSERT_EQ(2u, devices.size());
EXPECT_EQ(device_info_4->guid(), devices[0].guid());
EXPECT_EQ(
send_tab_to_self::GetSharingDeviceNames(device_info_4.get()).short_name,
devices[0].client_name());
EXPECT_EQ(device_info_2->guid(), devices[1].guid());
EXPECT_EQ(
send_tab_to_self::GetSharingDeviceNames(device_info_2.get()).short_name,
devices[1].client_name());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_NoChannel) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
auto device_info = CreateDeviceInfo(
"client_name", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer", "model",
/*sender_id_target_info=*/{});
fake_device_info_tracker_.Add(device_info.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
EXPECT_TRUE(devices.empty());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_FCMChannel) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
auto device_info = CreateDeviceInfo(
"client_name", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer", "model",
/*sender_id_target_info=*/{});
fake_device_info_tracker_.Add(device_info.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
// FCM channel is not supported.
ASSERT_EQ(0u, devices.size());
}
TEST_F(SharingDeviceSourceSyncTest, GetDeviceCandidates_SenderIDChannel) {
auto device_source = CreateDeviceSource(/*wait_until_ready=*/true);
auto device_info = CreateDeviceInfo(
"client_name", sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2,
"manufacturer", "model",
{kSenderIdFCMToken, kSenderIdP256dh, kSenderIdAuthSecret});
fake_device_info_tracker_.Add(device_info.get());
auto devices = device_source->GetDeviceCandidates(
sync_pb::SharingSpecificFields::CLICK_TO_CALL_V2);
ASSERT_EQ(1u, devices.size());
EXPECT_EQ(device_info->guid(), devices[0].guid());
}
|
