1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/site_isolation/site_isolation_policy.h"
#include "base/base_switches.h"
#include "base/command_line.h"
#include "base/json/values_util.h"
#include "base/memory/raw_ptr.h"
#include "base/no_destructor.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/system/sys_info.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/mock_entropy_provider.h"
#include "base/test/scoped_feature_list.h"
#include "base/time/time.h"
#include "build/branding_buildflags.h"
#include "build/build_config.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "components/prefs/testing_pref_service.h"
#include "components/site_isolation/features.h"
#include "components/site_isolation/pref_names.h"
#include "components/site_isolation/preloaded_isolated_origins.h"
#include "components/user_prefs/user_prefs.h"
#include "components/variations/variations_switches.h"
#include "content/public/browser/child_process_security_policy.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/site_isolation_policy.h"
#include "content/public/common/content_client.h"
#include "content/public/common/content_features.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_renderer_host.h"
#include "content/public/test/test_utils.h"
#include "content/public/test/web_contents_tester.h"
#include "net/http/http_response_headers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace site_isolation {
namespace {
using IsolatedOriginSource =
content::ChildProcessSecurityPolicy::IsolatedOriginSource;
// Some command-line switches override field trials - the tests need to be
// skipped in this case.
bool ShouldSkipBecauseOfConflictingCommandLineSwitches() {
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSitePerProcess)) {
return true;
}
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableSiteIsolation)) {
return true;
}
return false;
}
// Simulate navigation to a URL that serves an Origin-Agent-Cluster header.
std::unique_ptr<content::NavigationSimulator>
SimulateNavigationToURLWithOriginAgentClusterHeader(
GURL url,
content::WebContents* web_contents) {
std::unique_ptr<content::NavigationSimulator> simulator =
content::NavigationSimulator::CreateBrowserInitiated(url, web_contents);
simulator->Start();
auto response_headers =
base::MakeRefCounted<net::HttpResponseHeaders>("HTTP/1.1 200 OK");
response_headers->SetHeader("Origin-Agent-Cluster", "?1");
simulator->SetResponseHeaders(response_headers);
simulator->Commit();
return simulator;
}
} // namespace
// Base class for site isolation tests which handles setting a
// ContentBrowserClient with logic for enabling/disabling site isolation.
class BaseSiteIsolationTest : public testing::Test {
public:
BaseSiteIsolationTest() {
original_client_ = content::SetBrowserClientForTesting(&browser_client_);
SetEnableStrictSiteIsolation(
original_client_->ShouldEnableStrictSiteIsolation());
}
~BaseSiteIsolationTest() override {
content::SetBrowserClientForTesting(original_client_);
}
void SetUp() override {
SiteIsolationPolicy::SetDisallowMemoryThresholdCachingForTesting(true);
}
void TearDown() override {
SiteIsolationPolicy::SetDisallowMemoryThresholdCachingForTesting(false);
}
protected:
void SetEnableStrictSiteIsolation(bool enable) {
browser_client_.strict_isolation_enabled_ = enable;
}
private:
class SiteIsolationContentBrowserClient
: public content::ContentBrowserClient {
public:
bool ShouldEnableStrictSiteIsolation() override {
return strict_isolation_enabled_;
}
bool ShouldDisableSiteIsolation(
content::SiteIsolationMode site_isolation_mode) override {
return SiteIsolationPolicy::
ShouldDisableSiteIsolationDueToMemoryThreshold(site_isolation_mode);
}
std::vector<url::Origin> GetOriginsRequiringDedicatedProcess() override {
return GetBrowserSpecificBuiltInIsolatedOrigins();
}
bool ShouldDisableOriginIsolation() override {
return site_isolation::SiteIsolationPolicy::
ShouldDisableOriginIsolationDueToMemoryThreshold();
}
bool strict_isolation_enabled_ = false;
};
SiteIsolationContentBrowserClient browser_client_;
raw_ptr<content::ContentBrowserClient> original_client_ = nullptr;
};
class OriginIsolationForJsOptExceptionsTest : public BaseSiteIsolationTest {};
// IsOriginIsolationForJsOptExceptionsEnabled returns false when any of :
// kOriginIsolationForJsOptExceptions is disabled
// SiteIsolationPolicy::IsStrictOriginIsolationEnabled() returns
// false AreDynamicIsolatedOriginsEnabled() is true
// AreOriginKeyedProcessesEnabledByDefault returns true
TEST_F(OriginIsolationForJsOptExceptionsTest,
ReturnsFalseWhenFeatureIsDisabled) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndDisableFeature(
site_isolation::features::kOriginIsolationForJsOptExceptions);
EXPECT_FALSE(
SiteIsolationPolicy::IsOriginIsolationForJsOptExceptionsEnabled());
}
TEST_F(OriginIsolationForJsOptExceptionsTest, ReturnsTrueWhenFeatureEnabled) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(
site_isolation::features::kOriginIsolationForJsOptExceptions);
EXPECT_TRUE(
SiteIsolationPolicy::IsOriginIsolationForJsOptExceptionsEnabled());
}
TEST_F(OriginIsolationForJsOptExceptionsTest,
ReturnsFalseWhenStrictOriginIsolationEnabled) {
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures(
{site_isolation::features::kOriginIsolationForJsOptExceptions,
::features::kStrictOriginIsolation},
{});
EXPECT_FALSE(
SiteIsolationPolicy::IsOriginIsolationForJsOptExceptionsEnabled());
}
TEST_F(OriginIsolationForJsOptExceptionsTest,
ReturnsFalseWhenOriginKeyedProcessesEnabledByDefault) {
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures(
{site_isolation::features::kOriginIsolationForJsOptExceptions,
::features::kOriginKeyedProcessesByDefault},
{::features::kStrictOriginIsolation});
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kSitePerProcess);
SetEnableStrictSiteIsolation(true);
EXPECT_FALSE(
SiteIsolationPolicy::IsOriginIsolationForJsOptExceptionsEnabled());
}
#if BUILDFLAG(IS_ANDROID)
class OriginIsolationForJsOptExceptionsLowMemoryTest
: public OriginIsolationForJsOptExceptionsTest {
public:
void SetUp() override {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
// Without strict site isolation, AreOriginKeyedProcessesByDefaultEnabled()
// will always be false. This is needed to run the test on Android.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kSitePerProcess);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
OriginIsolationForJsOptExceptionsTest::SetUp();
}
};
TEST_F(OriginIsolationForJsOptExceptionsLowMemoryTest,
ReturnsFalseOnLowMemoryDevice) {
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures(
{site_isolation::features::kOriginIsolationForJsOptExceptions},
{::features::kStrictOriginIsolation,
::features::kOriginKeyedProcessesByDefault});
EXPECT_FALSE(
SiteIsolationPolicy::IsOriginIsolationForJsOptExceptionsEnabled());
}
#endif
// Tests with OriginKeyedProcessesByDefault enabled.
class OriginKeyedProcessesByDefaultSiteIsolationPolicyTest
: public BaseSiteIsolationTest {
public:
OriginKeyedProcessesByDefaultSiteIsolationPolicyTest() {
feature_list_.InitWithFeatures(
/*enabled_features=*/{::features::kOriginKeyedProcessesByDefault},
/*disabled_features=*/{});
}
private:
base::test::ScopedFeatureList feature_list_;
};
// Make sure AreOriginKeyedProcessesEnabledByDefault() only returns true when
// StrictSiteIsolation is enabled.
TEST_F(OriginKeyedProcessesByDefaultSiteIsolationPolicyTest,
RequiresStrictSiteIsolation) {
SetEnableStrictSiteIsolation(false);
// Even though we've disabled ShouldEnableStrictSiteIsolation via the test
// ContentBrowserClient, if this test runs on a bot where --site-per-process
// is specified on the command line, UseDedicatedProcessesForAllSites() will
// still be true, which will enable AreOriginKeyedProcessesEnabledByDefault().
EXPECT_EQ(
content::SiteIsolationPolicy::UseDedicatedProcessesForAllSites(),
content::SiteIsolationPolicy::AreOriginKeyedProcessesEnabledByDefault());
SetEnableStrictSiteIsolation(true);
// When this runs on Android, the return value from
// SiteIsolationContentBrowserClient::ShouldDisableSiteIsolation() may still
// override our attempt to SetEnableStrictSiteIsolation(true).
EXPECT_EQ(
content::SiteIsolationPolicy::UseDedicatedProcessesForAllSites(),
content::SiteIsolationPolicy::AreOriginKeyedProcessesEnabledByDefault());
}
class SiteIsolationPolicyTest : public BaseSiteIsolationTest {
public:
explicit SiteIsolationPolicyTest(
content::BrowserTaskEnvironment::TimeSource time_source =
content::BrowserTaskEnvironment::TimeSource::DEFAULT)
: task_environment_(time_source) {
prefs_.registry()->RegisterListPref(prefs::kUserTriggeredIsolatedOrigins);
prefs_.registry()->RegisterDictionaryPref(
prefs::kWebTriggeredIsolatedOrigins);
user_prefs::UserPrefs::Set(&browser_context_, &prefs_);
}
SiteIsolationPolicyTest(const SiteIsolationPolicyTest&) = delete;
SiteIsolationPolicyTest& operator=(const SiteIsolationPolicyTest&) = delete;
protected:
content::BrowserContext* browser_context() { return &browser_context_; }
PrefService* prefs() { return &prefs_; }
content::BrowserTaskEnvironment* task_environment() {
return &task_environment_;
}
private:
content::BrowserTaskEnvironment task_environment_;
content::TestBrowserContext browser_context_;
TestingPrefServiceSimple prefs_;
};
class WebTriggeredIsolatedOriginsPolicyTest : public SiteIsolationPolicyTest {
public:
WebTriggeredIsolatedOriginsPolicyTest()
: SiteIsolationPolicyTest(
content::BrowserTaskEnvironment::TimeSource::MOCK_TIME) {}
WebTriggeredIsolatedOriginsPolicyTest(
const WebTriggeredIsolatedOriginsPolicyTest&) = delete;
WebTriggeredIsolatedOriginsPolicyTest& operator=(
const WebTriggeredIsolatedOriginsPolicyTest&) = delete;
void PersistOrigin(const std::string& origin) {
SiteIsolationPolicy::PersistIsolatedOrigin(
browser_context(), url::Origin::Create(GURL(origin)),
IsolatedOriginSource::WEB_TRIGGERED);
task_environment()->FastForwardBy(base::Milliseconds(1));
}
std::vector<std::string> GetStoredOrigins() {
std::vector<std::string> origins;
const auto& dict = user_prefs::UserPrefs::Get(browser_context())
->GetDict(prefs::kWebTriggeredIsolatedOrigins);
for (auto pair : dict) {
origins.push_back(pair.first);
}
return origins;
}
protected:
void SetUp() override {
// Set up the COOP isolation feature with persistence enabled and a maximum
// of 3 stored sites.
base::test::FeatureRefAndParams coop_feature = {
::features::kSiteIsolationForCrossOriginOpenerPolicy,
{{::features::kSiteIsolationForCrossOriginOpenerPolicyMaxSitesParam
.name,
base::NumberToString(3)},
{::features::kSiteIsolationForCrossOriginOpenerPolicyShouldPersistParam
.name,
"true"}}};
std::vector<base::test::FeatureRefAndParams> enabled_features = {
coop_feature};
#if BUILDFLAG(IS_ANDROID)
// Some machines running this test may be below the default memory
// threshold. To ensure that COOP isolation is also enabled on those
// machines, set a very low 128MB threshold.
base::test::FeatureRefAndParams memory_threshold_feature = {
site_isolation::features::kSiteIsolationMemoryThresholdsAndroid,
{ {site_isolation::features::
kPartialSiteIsolationMemoryThresholdParamName,
"128"} }};
enabled_features.push_back(memory_threshold_feature);
#endif // BUILDFLAG(IS_ANDROID)
feature_list_.InitWithFeaturesAndParameters(enabled_features,
/* disabled_features = */ {});
// Disable strict site isolation to observe effects of COOP isolation.
SetEnableStrictSiteIsolation(false);
SiteIsolationPolicyTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list_;
};
// Verify that persisting web-triggered isolated origins properly saves the
// origins to prefs and respects the maximum number of entries (3 in this
// test).
TEST_F(WebTriggeredIsolatedOriginsPolicyTest, PersistIsolatedOrigin) {
PersistOrigin("https://foo1.com");
PersistOrigin("https://foo2.com");
PersistOrigin("https://foo3.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo1.com", "https://foo2.com", "https://foo3.com"));
// Adding foo4.com should evict the oldest entry (foo1.com).
PersistOrigin("https://foo4.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo2.com", "https://foo3.com", "https://foo4.com"));
// Adding foo5.com and foo6.com should evict the next two oldest entries.
PersistOrigin("https://foo5.com");
PersistOrigin("https://foo6.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo4.com", "https://foo5.com", "https://foo6.com"));
// Updating the timestamp on foo5.com should keep the current three entries.
PersistOrigin("https://foo5.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo4.com", "https://foo5.com", "https://foo6.com"));
// Adding two new entries should now evict foo4.com and foo6.com, since
// foo5.com has a more recent timestamp.
PersistOrigin("https://foo7.com");
PersistOrigin("https://foo8.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo5.com", "https://foo7.com", "https://foo8.com"));
}
// Verify that when origins stored in prefs contain more than the current
// maximum number of entries, we clean up older entries when adding a new one
// to go back under the size limit.
TEST_F(WebTriggeredIsolatedOriginsPolicyTest, UpdatedMaxSize) {
// Populate the pref manually with more entries than the 3 allowed by the
// field trial param.
ScopedDictPrefUpdate update(
user_prefs::UserPrefs::Get(browser_context()),
site_isolation::prefs::kWebTriggeredIsolatedOrigins);
base::Value::Dict& dict = update.Get();
dict.Set("https://foo1.com", base::TimeToValue(base::Time::Now()));
dict.Set("https://foo2.com", base::TimeToValue(base::Time::Now()));
dict.Set("https://foo3.com", base::TimeToValue(base::Time::Now()));
dict.Set("https://foo4.com", base::TimeToValue(base::Time::Now()));
dict.Set("https://foo5.com", base::TimeToValue(base::Time::Now()));
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo1.com", "https://foo2.com", "https://foo3.com",
"https://foo4.com", "https://foo5.com"));
// Now, attempt to save a new origin. This should evict the three oldest
// entries to make room for the new origin.
PersistOrigin("https://foo6.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo4.com", "https://foo5.com", "https://foo6.com"));
}
// Verify that when origins stored in prefs expire, we don't apply them when
// loading persisted isolated origins, and we remove them from prefs.
TEST_F(WebTriggeredIsolatedOriginsPolicyTest, Expiration) {
// Running this test with a command-line --site-per-process flag (which might
// be the case on some bots) conflicts with the feature configuration in this
// test.
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSitePerProcess)) {
return;
}
EXPECT_TRUE(content::SiteIsolationPolicy::IsSiteIsolationForCOOPEnabled());
EXPECT_TRUE(content::SiteIsolationPolicy::ShouldPersistIsolatedCOOPSites());
// Persist two origins which will eventually expire.
PersistOrigin("https://foo1.com");
PersistOrigin("https://foo2.com");
EXPECT_THAT(GetStoredOrigins(), testing::UnorderedElementsAre(
"https://foo1.com", "https://foo2.com"));
// Fast-forward time so we exceed the default expiration timeout.
base::TimeDelta default_timeout =
::features::kSiteIsolationForCrossOriginOpenerPolicyExpirationTimeoutParam
.default_value;
task_environment()->FastForwardBy(default_timeout + base::Days(1));
// foo1.com and foo2.com should still be in prefs. (Expired entries are only
// removed when we try to load them from prefs.)
EXPECT_THAT(GetStoredOrigins(), testing::UnorderedElementsAre(
"https://foo1.com", "https://foo2.com"));
// Persist another origin which should remain below expiration threshold.
PersistOrigin("https://foo3.com");
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre(
"https://foo1.com", "https://foo2.com", "https://foo3.com"));
// Loading persisted isolated origins should only load foo3.com. Also,
// it should remove foo1.com and foo2.com from prefs.
SiteIsolationPolicy::ApplyPersistedIsolatedOrigins(browser_context());
auto* cpsp = content::ChildProcessSecurityPolicy::GetInstance();
std::vector<url::Origin> isolated_origins = cpsp->GetIsolatedOrigins(
IsolatedOriginSource::WEB_TRIGGERED, browser_context());
EXPECT_THAT(isolated_origins,
testing::UnorderedElementsAre(
url::Origin::Create(GURL("https://foo3.com"))));
EXPECT_THAT(GetStoredOrigins(),
testing::UnorderedElementsAre("https://foo3.com"));
}
// Helper class that enables site isolation for password sites.
class PasswordSiteIsolationPolicyTest : public SiteIsolationPolicyTest {
public:
PasswordSiteIsolationPolicyTest() = default;
PasswordSiteIsolationPolicyTest(const PasswordSiteIsolationPolicyTest&) =
delete;
PasswordSiteIsolationPolicyTest& operator=(
const PasswordSiteIsolationPolicyTest&) = delete;
protected:
void SetUp() override {
feature_list_.InitAndEnableFeature(
features::kSiteIsolationForPasswordSites);
SetEnableStrictSiteIsolation(false);
SiteIsolationPolicyTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list_;
};
// Verifies that SiteIsolationPolicy::ApplyPersistedIsolatedOrigins applies
// stored isolated origins correctly when using site isolation for password
// sites.
TEST_F(PasswordSiteIsolationPolicyTest, ApplyPersistedIsolatedOrigins) {
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Add foo.com and bar.com to stored isolated origins.
{
ScopedListPrefUpdate update(prefs(), prefs::kUserTriggeredIsolatedOrigins);
base::Value::List& list = update.Get();
list.Append("http://foo.com");
list.Append("https://bar.com");
}
// New SiteInstances for foo.com and bar.com shouldn't require a dedicated
// process to start with. An exception is if this test runs with a
// command-line --site-per-process flag (which might be the case on some
// bots). This will override the feature configuration in this test and make
// all sites isolated.
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSitePerProcess)) {
scoped_refptr<content::SiteInstance> foo_instance =
content::SiteInstance::CreateForURL(browser_context(),
GURL("http://foo.com/1"));
EXPECT_FALSE(foo_instance->RequiresDedicatedProcess());
scoped_refptr<content::SiteInstance> bar_instance =
content::SiteInstance::CreateForURL(browser_context(),
GURL("https://baz.bar.com/2"));
EXPECT_FALSE(bar_instance->RequiresDedicatedProcess());
}
// Apply isolated origins and ensure that they take effect for SiteInstances
// in new BrowsingInstances.
base::HistogramTester histograms;
SiteIsolationPolicy::ApplyPersistedIsolatedOrigins(browser_context());
histograms.ExpectUniqueSample(
"SiteIsolation.SavedUserTriggeredIsolatedOrigins.Size", 2, 1);
{
scoped_refptr<content::SiteInstance> foo_instance =
content::SiteInstance::CreateForURL(browser_context(),
GURL("http://foo.com/1"));
EXPECT_TRUE(foo_instance->RequiresDedicatedProcess());
scoped_refptr<content::SiteInstance> bar_instance =
content::SiteInstance::CreateForURL(browser_context(),
GURL("https://baz.bar.com/2"));
EXPECT_TRUE(bar_instance->RequiresDedicatedProcess());
}
}
// Helper class that disables strict site isolation as well as site isolation
// for password sites.
class NoPasswordSiteIsolationPolicyTest : public SiteIsolationPolicyTest {
public:
NoPasswordSiteIsolationPolicyTest() = default;
NoPasswordSiteIsolationPolicyTest(const NoPasswordSiteIsolationPolicyTest&) =
delete;
NoPasswordSiteIsolationPolicyTest& operator=(
const NoPasswordSiteIsolationPolicyTest&) = delete;
protected:
void SetUp() override {
feature_list_.InitAndDisableFeature(
features::kSiteIsolationForPasswordSites);
SetEnableStrictSiteIsolation(false);
SiteIsolationPolicyTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list_;
};
// Verifies that SiteIsolationPolicy::ApplyPersistedIsolatedOrigins ignores
// stored isolated origins when site isolation for password sites is off.
TEST_F(NoPasswordSiteIsolationPolicyTest,
PersistedIsolatedOriginsIgnoredWithoutPasswordIsolation) {
// Running this test with a command-line --site-per-process flag (which might
// be the case on some bots) doesn't make sense, as that will make all sites
// isolated, overriding the feature configuration in this test.
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSitePerProcess)) {
return;
}
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Add foo.com to stored isolated origins.
{
ScopedListPrefUpdate update(prefs(), prefs::kUserTriggeredIsolatedOrigins);
update->Append("http://foo.com");
}
// Applying saved isolated origins should have no effect, since site
// isolation for password sites is off.
SiteIsolationPolicy::ApplyPersistedIsolatedOrigins(browser_context());
scoped_refptr<content::SiteInstance> foo_instance =
content::SiteInstance::CreateForURL(browser_context(),
GURL("http://foo.com/"));
EXPECT_FALSE(foo_instance->RequiresDedicatedProcess());
}
enum class OriginIsolationProcessMemoryThreshold {
kNone,
k128MB,
k768MB,
};
struct OriginIsolationMemoryThresholdBrowserTestParams {
OriginIsolationProcessMemoryThreshold threshold;
bool enabled;
};
class OriginIsolationMemoryThresholdBrowserTest
: public BaseSiteIsolationTest,
public ::testing::WithParamInterface<
OriginIsolationMemoryThresholdBrowserTestParams> {
public:
OriginIsolationMemoryThresholdBrowserTest() {
switch (GetParam().threshold) {
case OriginIsolationProcessMemoryThreshold::kNone:
break;
case OriginIsolationProcessMemoryThreshold::k128MB:
threshold_feature_.InitAndEnableFeatureWithParameters(
features::kOriginIsolationMemoryThreshold,
{{features::kOriginIsolationMemoryThresholdParamName, "128"}});
break;
case OriginIsolationProcessMemoryThreshold::k768MB:
threshold_feature_.InitAndEnableFeatureWithParameters(
features::kOriginIsolationMemoryThreshold,
{{features::kOriginIsolationMemoryThresholdParamName, "768"}});
break;
}
if (GetParam().enabled) {
mode_feature_.InitAndEnableFeature(
::features::kOriginKeyedProcessesByDefault);
} else {
mode_feature_.InitAndDisableFeature(
::features::kOriginKeyedProcessesByDefault);
}
}
OriginIsolationMemoryThresholdBrowserTest(
const OriginIsolationMemoryThresholdBrowserTest&) = delete;
OriginIsolationMemoryThresholdBrowserTest& operator=(
const OriginIsolationMemoryThresholdBrowserTest&) = delete;
void SetUp() override {
// This way the test always sees the same amount of physical memory
// (kLowMemoryDeviceThresholdMB = 512MB), regardless of how much memory is
// available in the testing environment.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
// Without strict site isolation, AreOriginKeyedProcessesByDefaultEnabled()
// will always be false. This is needed to run the test on Android.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kSitePerProcess);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
BaseSiteIsolationTest::SetUp();
}
private:
base::test::ScopedFeatureList threshold_feature_;
base::test::ScopedFeatureList mode_feature_;
}; // class OriginIsolationMemoryThresholdBrowserTest
TEST_P(OriginIsolationMemoryThresholdBrowserTest, IsolationThresholds) {
// OAC opt-in is enabled by default, and since the test forces strict site
// isolation on, we expect OAC opt-in process isolation to always work.
bool expected_oac_optin_process = true;
#if BUILDFLAG(IS_ANDROID)
// Android doesn't enable kOriginKeyedProcessesByDefault, so if it's on it's
// because it was explicitly enable, in which case we don't do memory checks.
bool expected_process_origin_isolation = GetParam().enabled;
#else
// If enabled, two of the three threshold settings are compatible with the
// kLowEndDeviceMode switch, which simulated 512MB or RAM.
OriginIsolationProcessMemoryThreshold threshold = GetParam().threshold;
bool expected_process_origin_isolation =
GetParam().enabled &&
(threshold == OriginIsolationProcessMemoryThreshold::kNone ||
threshold == OriginIsolationProcessMemoryThreshold::k128MB);
#endif
EXPECT_EQ(expected_oac_optin_process,
content::SiteIsolationPolicy::
IsProcessIsolationForOriginAgentClusterEnabled());
EXPECT_EQ(
expected_process_origin_isolation,
content::SiteIsolationPolicy::AreOriginKeyedProcessesEnabledByDefault());
}
INSTANTIATE_TEST_SUITE_P(
All,
OriginIsolationMemoryThresholdBrowserTest,
testing::Values(
OriginIsolationMemoryThresholdBrowserTestParams{
OriginIsolationProcessMemoryThreshold::kNone, true},
OriginIsolationMemoryThresholdBrowserTestParams{
OriginIsolationProcessMemoryThreshold::k128MB, true},
OriginIsolationMemoryThresholdBrowserTestParams{
OriginIsolationProcessMemoryThreshold::k768MB, true},
OriginIsolationMemoryThresholdBrowserTestParams{
OriginIsolationProcessMemoryThreshold::kNone, false},
OriginIsolationMemoryThresholdBrowserTestParams{
OriginIsolationProcessMemoryThreshold::k128MB, false},
OriginIsolationMemoryThresholdBrowserTestParams{
OriginIsolationProcessMemoryThreshold::k768MB, false}),
[](const testing::TestParamInfo<
OriginIsolationMemoryThresholdBrowserTestParams>& info) {
std::string threshold_str;
switch (info.param.threshold) {
case OriginIsolationProcessMemoryThreshold::kNone:
threshold_str = "none";
break;
case OriginIsolationProcessMemoryThreshold::k128MB:
threshold_str = "128MB";
break;
case OriginIsolationProcessMemoryThreshold::k768MB:
threshold_str = "768MB";
break;
}
std::string label = base::StringPrintf(
"OriginIsolationThresholdTest_%s_Threshold_%s",
(info.param.enabled ? "Enabled" : "Disabled"), threshold_str.c_str());
return label;
});
enum class SitePerProcessMemoryThreshold {
kNone,
#if BUILDFLAG(IS_ANDROID)
k128MB,
k768MB,
#endif // BUILDFLAG(IS_ANDROID)
};
enum class SitePerProcessMode {
kDisabled,
kEnabled,
kIsolatedOrigin,
};
struct SitePerProcessMemoryThresholdBrowserTestParams {
SitePerProcessMemoryThreshold threshold;
SitePerProcessMode mode;
};
const url::Origin& GetTrialOrigin() {
static base::NoDestructor<url::Origin> origin{
url::Origin::Create(GURL("http://foo.com/"))};
return *origin;
}
// Helper class to run tests on a simulated 512MB low-end device.
class SitePerProcessMemoryThresholdBrowserTest
: public BaseSiteIsolationTest,
public ::testing::WithParamInterface<
SitePerProcessMemoryThresholdBrowserTestParams> {
public:
SitePerProcessMemoryThresholdBrowserTest() {
// When a memory threshold is specified, set it for both strict site
// isolation and partial site isolation modes, since these tests care about
// both. For example, UseDedicatedProcessesForAllSites() depends on the
// former, while isolated origins specified via field trials use the
// latter.
switch (GetParam().threshold) {
case SitePerProcessMemoryThreshold::kNone:
break;
#if BUILDFLAG(IS_ANDROID)
case SitePerProcessMemoryThreshold::k128MB:
threshold_feature_.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kStrictSiteIsolationMemoryThresholdParamName, "128"},
{features::kPartialSiteIsolationMemoryThresholdParamName, "128"}});
break;
case SitePerProcessMemoryThreshold::k768MB:
threshold_feature_.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kStrictSiteIsolationMemoryThresholdParamName, "768"},
{features::kPartialSiteIsolationMemoryThresholdParamName, "768"}});
break;
#endif // BUILDFLAG(IS_ANDROID)
}
switch (GetParam().mode) {
case SitePerProcessMode::kDisabled:
SetEnableStrictSiteIsolation(false);
break;
case SitePerProcessMode::kEnabled:
SetEnableStrictSiteIsolation(true);
break;
case SitePerProcessMode::kIsolatedOrigin:
mode_feature_.InitAndEnableFeatureWithParameters(
::features::kIsolateOrigins,
{{::features::kIsolateOriginsFieldTrialParamName,
GetTrialOrigin().Serialize()}});
break;
}
}
SitePerProcessMemoryThresholdBrowserTest(
const SitePerProcessMemoryThresholdBrowserTest&) = delete;
SitePerProcessMemoryThresholdBrowserTest& operator=(
const SitePerProcessMemoryThresholdBrowserTest&) = delete;
void SetUp() override {
// This way the test always sees the same amount of physical memory
// (kLowMemoryDeviceThresholdMB = 512MB), regardless of how much memory is
// available in the testing environment.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
// On Android official builds, we expect to isolate an additional set of
// built-in origins.
expected_embedder_origins_ = GetBrowserSpecificBuiltInIsolatedOrigins();
BaseSiteIsolationTest::SetUp();
}
protected:
content::BrowserTaskEnvironment task_environment_;
// These are the origins we expect to be returned by
// content::ChildProcessSecurityPolicy::GetIsolatedOrigins() even if
// ContentBrowserClient::ShouldDisableSiteIsolation() returns true.
std::vector<url::Origin> expected_embedder_origins_;
#if BUILDFLAG(IS_ANDROID)
// On Android we don't expect any trial origins because the 512MB
// physical memory used for testing is below the Android specific
// hardcoded 1024MB memory limit that disables site isolation.
const std::size_t kExpectedTrialOrigins = 0;
#else
// All other platforms expect the single trial origin to be returned because
// they don't have the memory limit that disables site isolation.
const std::size_t kExpectedTrialOrigins = 1;
#endif
private:
base::test::ScopedFeatureList threshold_feature_;
base::test::ScopedFeatureList mode_feature_;
};
using SitePerProcessMemoryThresholdBrowserTestNoIsolation =
SitePerProcessMemoryThresholdBrowserTest;
TEST_P(SitePerProcessMemoryThresholdBrowserTestNoIsolation, NoIsolation) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Isolation should be disabled given the set of parameters used to
// instantiate these tests.
EXPECT_FALSE(
content::SiteIsolationPolicy::UseDedicatedProcessesForAllSites());
}
using SitePerProcessMemoryThresholdBrowserTestIsolation =
SitePerProcessMemoryThresholdBrowserTest;
TEST_P(SitePerProcessMemoryThresholdBrowserTestIsolation, Isolation) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Isolation should be enabled given the set of parameters used to
// instantiate these tests.
EXPECT_TRUE(content::SiteIsolationPolicy::UseDedicatedProcessesForAllSites());
}
INSTANTIATE_TEST_SUITE_P(
NoIsolation,
SitePerProcessMemoryThresholdBrowserTestNoIsolation,
testing::Values(
#if BUILDFLAG(IS_ANDROID)
// Expect no isolation on Android because 512MB physical memory
// triggered by kEnableLowEndDeviceMode in SetUp() is below the 1024MB
// Android specific memory limit which disables site isolation for all
// sites.
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::kNone, SitePerProcessMode::kEnabled},
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::k768MB,
SitePerProcessMode::kEnabled},
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::k128MB,
SitePerProcessMode::kDisabled},
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::k768MB,
SitePerProcessMode::kDisabled},
#endif // BUILDFLAG(IS_ANDROID)
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::kNone,
SitePerProcessMode::kDisabled}));
INSTANTIATE_TEST_SUITE_P(Isolation,
SitePerProcessMemoryThresholdBrowserTestIsolation,
testing::Values(
#if BUILDFLAG(IS_ANDROID)
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::k128MB,
SitePerProcessMode::kEnabled}));
#else
// See the note above regarding why this
// expectation is different on Android.
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::kNone,
SitePerProcessMode::kEnabled}));
#endif
#if BUILDFLAG(IS_ANDROID)
using SitePerProcessMemoryThresholdBrowserTestNoIsolatedOrigin =
SitePerProcessMemoryThresholdBrowserTest;
TEST_P(SitePerProcessMemoryThresholdBrowserTestNoIsolatedOrigin,
TrialNoIsolatedOrigin) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
content::SiteIsolationPolicy::ApplyGlobalIsolatedOrigins();
auto* cpsp = content::ChildProcessSecurityPolicy::GetInstance();
std::vector<url::Origin> isolated_origins = cpsp->GetIsolatedOrigins();
EXPECT_EQ(expected_embedder_origins_.size(), isolated_origins.size());
// Verify that the expected embedder origins are present even though site
// isolation has been disabled and the trial origins should not be present.
EXPECT_THAT(expected_embedder_origins_,
::testing::IsSubsetOf(isolated_origins));
// Verify that the trial origin is not present.
EXPECT_THAT(isolated_origins,
::testing::Not(::testing::Contains(GetTrialOrigin())));
}
#endif // BUILDFLAG(IS_ANDROID)
using SitePerProcessMemoryThresholdBrowserTestIsolatedOrigin =
SitePerProcessMemoryThresholdBrowserTest;
TEST_P(SitePerProcessMemoryThresholdBrowserTestIsolatedOrigin,
TrialIsolatedOrigin) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
content::SiteIsolationPolicy::ApplyGlobalIsolatedOrigins();
auto* cpsp = content::ChildProcessSecurityPolicy::GetInstance();
std::vector<url::Origin> isolated_origins = cpsp->GetIsolatedOrigins();
EXPECT_EQ(1u + expected_embedder_origins_.size(), isolated_origins.size());
EXPECT_THAT(expected_embedder_origins_,
::testing::IsSubsetOf(isolated_origins));
// Verify that the trial origin is present.
EXPECT_THAT(isolated_origins, ::testing::Contains(GetTrialOrigin()));
}
#if BUILDFLAG(IS_ANDROID)
INSTANTIATE_TEST_SUITE_P(
TrialNoIsolatedOrigin,
SitePerProcessMemoryThresholdBrowserTestNoIsolatedOrigin,
testing::Values(
// When the memory threshold is not explicitly specified, Android uses
// a 1900MB global memory threshold. The 512MB simulated device memory
// is below 1900MB, so the test origin should not be isolated.
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::kNone,
SitePerProcessMode::kIsolatedOrigin},
// The 512MB simulated device memory is under the explicit 768MB memory
// threshold below, so the test origin should not be isolated.
SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::k768MB,
SitePerProcessMode::kIsolatedOrigin}));
#endif // BUILDFLAG(IS_ANDROID)
INSTANTIATE_TEST_SUITE_P(
TrialIsolatedOrigin,
SitePerProcessMemoryThresholdBrowserTestIsolatedOrigin,
#if BUILDFLAG(IS_ANDROID)
// The 512MB simulated device memory is above the explicit 128MB memory
// threshold below, so the test origin should be isolated both on desktop
// and Android.
testing::Values(SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::k128MB,
SitePerProcessMode::kIsolatedOrigin}));
#else
testing::Values(SitePerProcessMemoryThresholdBrowserTestParams{
SitePerProcessMemoryThreshold::kNone,
SitePerProcessMode::kIsolatedOrigin}));
#endif
// Helper class to run tests with password-triggered site isolation initialized
// via a regular field trial and *not* via a command-line override. It
// creates a new field trial (with 100% probability of being in the group), and
// initializes the test class's ScopedFeatureList using it. Two derived
// classes below control are used to initialize the feature to either enabled
// or disabled state.
class PasswordSiteIsolationFieldTrialTest : public BaseSiteIsolationTest {
public:
explicit PasswordSiteIsolationFieldTrialTest(bool should_enable) {
empty_feature_scope_.InitWithEmptyFeatureAndFieldTrialLists();
const std::string kTrialName = "PasswordSiteIsolation";
const std::string kGroupName = "FooGroup"; // unused
scoped_refptr<base::FieldTrial> trial =
base::FieldTrialList::CreateFieldTrial(kTrialName, kGroupName);
std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->RegisterFieldTrialOverride(
features::kSiteIsolationForPasswordSites.name,
should_enable
? base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE
: base::FeatureList::OverrideState::OVERRIDE_DISABLE_FEATURE,
trial.get());
feature_list_.InitWithFeatureList(std::move(feature_list));
}
PasswordSiteIsolationFieldTrialTest(
const PasswordSiteIsolationFieldTrialTest&) = delete;
PasswordSiteIsolationFieldTrialTest& operator=(
const PasswordSiteIsolationFieldTrialTest&) = delete;
void SetUp() override {
// This test creates and tests its own field trial group, so it needs to
// disable the field trial testing config, which might define an
// incompatible trial name/group.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
variations::switches::kDisableFieldTrialTestingConfig);
// This way the test always sees the same amount of physical memory
// (kLowMemoryDeviceThresholdMB = 512MB), regardless of how much memory is
// available in the testing environment.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
BaseSiteIsolationTest::SetUp();
}
protected:
// |empty_feature_scope_| is used to prepare an environment with empty
// features and field trial lists.
base::test::ScopedFeatureList empty_feature_scope_;
// |feature_list_| is used to enable and disable features for
// PasswordSiteIsolationFieldTrialTest.
base::test::ScopedFeatureList feature_list_;
};
class EnabledPasswordSiteIsolationFieldTrialTest
: public PasswordSiteIsolationFieldTrialTest {
public:
EnabledPasswordSiteIsolationFieldTrialTest()
: PasswordSiteIsolationFieldTrialTest(true /* should_enable */) {}
EnabledPasswordSiteIsolationFieldTrialTest(
const EnabledPasswordSiteIsolationFieldTrialTest&) = delete;
EnabledPasswordSiteIsolationFieldTrialTest& operator=(
const EnabledPasswordSiteIsolationFieldTrialTest&) = delete;
};
class DisabledPasswordSiteIsolationFieldTrialTest
: public PasswordSiteIsolationFieldTrialTest {
public:
DisabledPasswordSiteIsolationFieldTrialTest()
: PasswordSiteIsolationFieldTrialTest(false /* should_enable */) {}
DisabledPasswordSiteIsolationFieldTrialTest(
const DisabledPasswordSiteIsolationFieldTrialTest&) = delete;
DisabledPasswordSiteIsolationFieldTrialTest& operator=(
const DisabledPasswordSiteIsolationFieldTrialTest&) = delete;
};
#if BUILDFLAG(IS_ANDROID)
TEST_F(EnabledPasswordSiteIsolationFieldTrialTest, BelowThreshold_Android) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// If no memory threshold is defined, password site isolation should be
// disabled on Android, because Android defaults to a 1900MB memory threshold,
// which is above the 512MB physical memory that this test simulates.
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Define a memory threshold at 768MB. Since this is above the 512MB of
// physical memory that this test simulates, password site isolation should
// now be disabled on Android.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "768"}});
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Simulate enabling password site isolation from command line. (Note that
// InitAndEnableFeature uses ScopedFeatureList::InitFromCommandLine
// internally, and that triggering the feature via chrome://flags follows the
// same override path as well.)
base::test::ScopedFeatureList password_site_isolation_feature;
password_site_isolation_feature.InitAndEnableFeature(
features::kSiteIsolationForPasswordSites);
// This should override the memory threshold and enable password site
// isolation.
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
}
TEST_F(EnabledPasswordSiteIsolationFieldTrialTest, AboveThreshold_Android) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// If no memory threshold is defined, password site isolation should be
// disabled on Android, because Android defaults to a 1900MB memory threshold,
// which is above the 512MB physical memory that this test simulates.
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Define a memory threshold at 128MB. Since this is below the 512MB of
// physical memory that this test simulates, password site isolation should
// still be enabled.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "128"}});
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Simulate disabling password site isolation from command line. (Note that
// InitAndEnableFeature uses ScopedFeatureList::InitFromCommandLine
// internally, and that triggering the feature via chrome://flags follows the
// same override path as well.) This should take precedence over the regular
// field trial behavior.
base::test::ScopedFeatureList password_site_isolation_feature;
password_site_isolation_feature.InitAndDisableFeature(
features::kSiteIsolationForPasswordSites);
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
}
#else // BUILDFLAG(IS_ANDROID)
TEST_F(EnabledPasswordSiteIsolationFieldTrialTest, NonAndroid) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Simulate disabling password site isolation from command line. (Note that
// InitAndEnableFeature uses ScopedFeatureList::InitFromCommandLine
// internally, and that triggering the feature via chrome://flags follows the
// same override path as well.) This should take precedence over the regular
// field trial behavior.
base::test::ScopedFeatureList password_site_isolation_feature;
password_site_isolation_feature.InitAndDisableFeature(
features::kSiteIsolationForPasswordSites);
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
}
#endif
// This test verifies that when password-triggered site isolation is disabled
// via field trials but force-enabled via command line, it takes effect even
// when below the memory threshold. See https://crbug.com/1009828.
TEST_F(DisabledPasswordSiteIsolationFieldTrialTest,
CommandLineOverride_BelowThreshold) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Password site isolation should be disabled at this point.
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
// Simulate enabling password site isolation from command line. (Note that
// InitAndEnableFeature uses ScopedFeatureList::InitFromCommandLine
// internally, and that triggering the feature via chrome://flags follows the
// same override path as well.)
base::test::ScopedFeatureList password_site_isolation_feature;
password_site_isolation_feature.InitAndEnableFeature(
features::kSiteIsolationForPasswordSites);
// If no memory threshold is defined, password site isolation should be
// enabled.
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
#if BUILDFLAG(IS_ANDROID)
// Define a memory threshold at 768MB. This is above the 512MB of physical
// memory that this test simulates, but password site isolation should still
// be enabled, because the test has simulated the user manually overriding
// this feature via command line.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "768"}});
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
#endif // BUILDFLAG(IS_ANDROID)
}
// Similar to the test above, but with device memory being above memory
// threshold.
TEST_F(DisabledPasswordSiteIsolationFieldTrialTest,
CommandLineOverride_AboveThreshold) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
EXPECT_FALSE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
base::test::ScopedFeatureList password_site_isolation_feature;
password_site_isolation_feature.InitAndEnableFeature(
features::kSiteIsolationForPasswordSites);
// If no memory threshold is defined, password site isolation should be
// enabled.
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
#if BUILDFLAG(IS_ANDROID)
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "128"}});
EXPECT_TRUE(SiteIsolationPolicy::IsIsolationForPasswordSitesEnabled());
#endif // BUILDFLAG(IS_ANDROID)
}
// Helper class to run tests with strict origin isolation initialized via
// a regular field trial and *not* via a command-line override. It creates a
// new field trial (with 100% probability of being in the group), and
// initializes the test class's ScopedFeatureList using it. Two derived
// classes below control are used to initialize the feature to either enabled
// or disabled state.
class StrictOriginIsolationFieldTrialTest : public BaseSiteIsolationTest {
public:
explicit StrictOriginIsolationFieldTrialTest(bool should_enable) {
empty_feature_scope_.InitWithEmptyFeatureAndFieldTrialLists();
const std::string kTrialName = "StrictOriginIsolation";
const std::string kGroupName = "FooGroup"; // unused
scoped_refptr<base::FieldTrial> trial =
base::FieldTrialList::CreateFieldTrial(kTrialName, kGroupName);
std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->RegisterFieldTrialOverride(
::features::kStrictOriginIsolation.name,
should_enable
? base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE
: base::FeatureList::OverrideState::OVERRIDE_DISABLE_FEATURE,
trial.get());
feature_list_.InitWithFeatureList(std::move(feature_list));
}
StrictOriginIsolationFieldTrialTest(
const StrictOriginIsolationFieldTrialTest&) = delete;
StrictOriginIsolationFieldTrialTest& operator=(
const StrictOriginIsolationFieldTrialTest&) = delete;
void SetUp() override {
// This test creates and tests its own field trial group, so it needs to
// disable the field trial testing config, which might define an
// incompatible trial name/group.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
variations::switches::kDisableFieldTrialTestingConfig);
// This way the test always sees the same amount of physical memory
// (kLowMemoryDeviceThresholdMB = 512MB), regardless of how much memory is
// available in the testing environment.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
BaseSiteIsolationTest::SetUp();
}
protected:
// |empty_feature_scope_| is used to prepare an environment with empty
// features and field trial lists.
base::test::ScopedFeatureList empty_feature_scope_;
// |feature_list_| is used to enable and disable features for
// StrictOriginIsolationFieldTrialTest.
base::test::ScopedFeatureList feature_list_;
};
class EnabledStrictOriginIsolationFieldTrialTest
: public StrictOriginIsolationFieldTrialTest {
public:
EnabledStrictOriginIsolationFieldTrialTest()
: StrictOriginIsolationFieldTrialTest(true /* should_enable */) {}
EnabledStrictOriginIsolationFieldTrialTest(
const EnabledStrictOriginIsolationFieldTrialTest&) = delete;
EnabledStrictOriginIsolationFieldTrialTest& operator=(
const EnabledStrictOriginIsolationFieldTrialTest&) = delete;
};
class DisabledStrictOriginIsolationFieldTrialTest
: public StrictOriginIsolationFieldTrialTest {
public:
DisabledStrictOriginIsolationFieldTrialTest()
: StrictOriginIsolationFieldTrialTest(false /* should_enable */) {}
DisabledStrictOriginIsolationFieldTrialTest(
const DisabledStrictOriginIsolationFieldTrialTest&) = delete;
DisabledStrictOriginIsolationFieldTrialTest& operator=(
const DisabledStrictOriginIsolationFieldTrialTest&) = delete;
};
// Check that when strict origin isolation is enabled via a field trial, and
// the device is above the memory threshold, disabling it via the command line
// takes precedence.
TEST_F(EnabledStrictOriginIsolationFieldTrialTest,
DisabledViaCommandLineOverride) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
#if BUILDFLAG(IS_ANDROID)
// If no memory threshold is defined, strict origin isolation should be
// disabled on Android, because Android defaults to a 1900MB memory threshold,
// which is above the 512MB physical memory that this test simulates.
EXPECT_FALSE(content::SiteIsolationPolicy::IsStrictOriginIsolationEnabled());
// Define a memory threshold at 128MB. Since this is below the 512MB of
// physical memory that this test simulates, strict origin isolation should
// now be enabled. String origin isolation should be enabled on desktop
// platforms regardless, since they do not respect memory thresholds.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kStrictSiteIsolationMemoryThresholdParamName, "128"}});
#endif // BUILDFLAG(IS_ANDROID)
EXPECT_TRUE(content::SiteIsolationPolicy::IsStrictOriginIsolationEnabled());
// Simulate disabling strict origin isolation from command line. (Note that
// InitAndEnableFeature uses ScopedFeatureList::InitFromCommandLine
// internally, and that disabling the feature via chrome://flags follows the
// same override path as well.)
base::test::ScopedFeatureList strict_origin_isolation_feature;
strict_origin_isolation_feature.InitAndDisableFeature(
::features::kStrictOriginIsolation);
EXPECT_FALSE(content::SiteIsolationPolicy::IsStrictOriginIsolationEnabled());
}
// This test verifies that when strict origin isolation is disabled
// via field trials but force-enabled via command line, it takes effect even
// when below the memory threshold. See https://crbug.com/1009828.
TEST_F(DisabledStrictOriginIsolationFieldTrialTest,
EnabledViaCommandLineOverride_BelowThreshold) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Strict origin isolation should be disabled at this point.
EXPECT_FALSE(content::SiteIsolationPolicy::IsStrictOriginIsolationEnabled());
// Simulate enabling strict origin isolation from command line. (Note that
// InitAndEnableFeature uses ScopedFeatureList::InitFromCommandLine
// internally, and that triggering the feature via chrome://flags follows the
// same override path as well.)
base::test::ScopedFeatureList strict_origin_isolation_feature;
strict_origin_isolation_feature.InitAndEnableFeature(
::features::kStrictOriginIsolation);
// If no memory threshold is defined, strict origin isolation should be
// enabled.
EXPECT_TRUE(content::SiteIsolationPolicy::IsStrictOriginIsolationEnabled());
#if BUILDFLAG(IS_ANDROID)
// Define a memory threshold at 768MB. This is above the 512MB of physical
// memory that this test simulates, but strict origin isolation should still
// be enabled, because the test has simulated the user manually overriding
// this feature via command line.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kStrictSiteIsolationMemoryThresholdParamName, "768"}});
EXPECT_TRUE(content::SiteIsolationPolicy::IsStrictOriginIsolationEnabled());
#endif // BUILDFLAG(IS_ANDROID)
}
// The following tests verify that the list of Android's built-in isolated
// origins takes effect. This list is only used in official builds, and only
// when above the memory threshold.
#if BUILDFLAG(GOOGLE_CHROME_BRANDING) && BUILDFLAG(IS_ANDROID)
class BuiltInIsolatedOriginsTest : public SiteIsolationPolicyTest {
public:
BuiltInIsolatedOriginsTest() = default;
BuiltInIsolatedOriginsTest(const BuiltInIsolatedOriginsTest&) = delete;
BuiltInIsolatedOriginsTest& operator=(const BuiltInIsolatedOriginsTest&) =
delete;
protected:
void SetUp() override {
// Simulate a 512MB device.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
SiteIsolationPolicyTest::SetUp();
}
};
// Check that the list of preloaded isolated origins is properly applied when
// device RAM is above the site isolation memory threshold.
TEST_F(BuiltInIsolatedOriginsTest, DefaultThreshold) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Define a memory threshold at 128MB. This is below the 512MB of physical
// memory that this test simulates, so preloaded isolated origins should take
// effect.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "128"}});
// Ensure that isolated origins that are normally loaded on browser
// startup are applied.
content::SiteIsolationPolicy::ApplyGlobalIsolatedOrigins();
EXPECT_TRUE(
content::SiteIsolationPolicy::ArePreloadedIsolatedOriginsEnabled());
auto* cpsp = content::ChildProcessSecurityPolicy::GetInstance();
std::vector<url::Origin> isolated_origins = cpsp->GetIsolatedOrigins(
content::ChildProcessSecurityPolicy::IsolatedOriginSource::BUILT_IN);
// The list of built-in origins is fairly large; we don't want to hardcode
// the size here as it might change, so just check that there are at least 10
// origins.
EXPECT_GT(isolated_origins.size(), 10u);
// Check that a couple of well-known origins are on the list.
EXPECT_THAT(
isolated_origins,
::testing::Contains(url::Origin::Create(GURL("https://google.com/"))));
EXPECT_THAT(
isolated_origins,
::testing::Contains(url::Origin::Create(GURL("https://amazon.com/"))));
EXPECT_THAT(
isolated_origins,
::testing::Contains(url::Origin::Create(GURL("https://facebook.com/"))));
cpsp->ClearIsolatedOriginsForTesting();
}
TEST_F(BuiltInIsolatedOriginsTest, BelowThreshold) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Define a memory threshold at 768MB. This is above the 512MB of physical
// memory that this test simulates, so preloaded isolated origins shouldn't
// take effect.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "768"}});
// Ensure that isolated origins that are normally loaded on browser
// startup are applied.
content::SiteIsolationPolicy::ApplyGlobalIsolatedOrigins();
EXPECT_FALSE(
content::SiteIsolationPolicy::ArePreloadedIsolatedOriginsEnabled());
auto* cpsp = content::ChildProcessSecurityPolicy::GetInstance();
std::vector<url::Origin> isolated_origins = cpsp->GetIsolatedOrigins(
content::ChildProcessSecurityPolicy::IsolatedOriginSource::BUILT_IN);
// There shouldn't be any built-in origins on Android. (Note that desktop has
// some built-in origins that are applied regardless of memory threshold.)
EXPECT_EQ(isolated_origins.size(), 0u);
cpsp->ClearIsolatedOriginsForTesting();
}
// Check that the list of preloaded isolated origins is not applied when full
// site isolation is used, since in that case the list is redundant.
TEST_F(BuiltInIsolatedOriginsTest, NotAppliedWithFullSiteIsolation) {
// Force full site-per-process mode.
content::IsolateAllSitesForTesting(base::CommandLine::ForCurrentProcess());
// Define a memory threshold at 128MB. This is below the 512MB of physical
// memory that this test simulates, so preloaded isolated origins shouldn't
// be disabled by the memory threshold.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "128"}});
// Ensure that isolated origins that are normally loaded on browser
// startup are applied.
content::SiteIsolationPolicy::ApplyGlobalIsolatedOrigins();
// Because full site-per-process is used, the preloaded isolated origins are
// redundant and should not be applied.
EXPECT_FALSE(
content::SiteIsolationPolicy::ArePreloadedIsolatedOriginsEnabled());
auto* cpsp = content::ChildProcessSecurityPolicy::GetInstance();
std::vector<url::Origin> isolated_origins = cpsp->GetIsolatedOrigins(
content::ChildProcessSecurityPolicy::IsolatedOriginSource::BUILT_IN);
EXPECT_EQ(isolated_origins.size(), 0u);
}
#endif
// Helper class for tests that use header-based opt-in origin isolation and
// simulate a 512MB device, while turning off strict site isolation. This is
// used for checking how opt-in origin isolation behaves with site isolation
// memory thresholds.
class OptInOriginIsolationPolicyTest : public BaseSiteIsolationTest {
public:
OptInOriginIsolationPolicyTest() = default;
OptInOriginIsolationPolicyTest(const OptInOriginIsolationPolicyTest&) =
delete;
OptInOriginIsolationPolicyTest& operator=(
const OptInOriginIsolationPolicyTest&) = delete;
protected:
void SetUp() override {
// Simulate a 512MB device.
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableLowEndDeviceMode);
EXPECT_EQ(512, base::SysInfo::AmountOfPhysicalMemoryMB());
// Turn off strict site isolation. This simulates what would happen on
// Android.
SetEnableStrictSiteIsolation(false);
// Enable Origin-Agent-Cluster header.
feature_list_.InitAndEnableFeature(::features::kOriginIsolationHeader);
BaseSiteIsolationTest::SetUp();
}
content::BrowserContext* browser_context() { return &browser_context_; }
private:
content::BrowserTaskEnvironment task_environment_;
content::TestBrowserContext browser_context_;
content::RenderViewHostTestEnabler rvh_test_enabler_;
base::test::ScopedFeatureList feature_list_;
};
#if BUILDFLAG(IS_ANDROID)
// Check that opt-in origin isolation is not applied when below the memory
// threshold (and when full site isolation is not used).
TEST_F(OptInOriginIsolationPolicyTest, BelowThreshold_Android) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Define a memory threshold at 768MB. This is above the 512MB of physical
// memory that this test simulates, so process isolation for
// Origin-Agent-Cluster (OAC) should be disabled. But other aspects of OAC
// should still take effect.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "768"}});
EXPECT_FALSE(content::SiteIsolationPolicy::
IsProcessIsolationForOriginAgentClusterEnabled());
EXPECT_TRUE(content::SiteIsolationPolicy::IsOriginAgentClusterEnabled());
// Simulate a navigation to a URL that serves an Origin-Agent-Cluster header.
// Since we're outside of content/, it's difficult to verify that internal
// ChildProcessSecurityPolicy state wasn't changed by opt-in origin
// isolation. Instead, verify that the resulting SiteInstance doesn't
// require a dedicated process. This should be the end result, and it
// implicitly checks that ChildProcessSecurityPolicy::IsIsolatedOrigin()
// doesn't return true for this origin.
const GURL kUrl("https://www.google.com/");
std::unique_ptr<content::WebContents> web_contents =
content::WebContentsTester::CreateTestWebContents(browser_context(),
nullptr);
std::unique_ptr<content::NavigationSimulator> simulator =
SimulateNavigationToURLWithOriginAgentClusterHeader(kUrl,
web_contents.get());
content::SiteInstance* site_instance =
simulator->GetFinalRenderFrameHost()->GetSiteInstance();
EXPECT_FALSE(site_instance->RequiresDedicatedProcess());
// Despite not getting process isolation, the origin will still get logical
// isolation in Blink, and should still be tracked by
// ChildProcessSecurityPolicy to ensure consistent OAC behavior for this
// origin within this BrowsingInstance.
EXPECT_TRUE(IsOriginAgentClusterEnabledForOrigin(site_instance,
url::Origin::Create(kUrl)));
}
// Counterpart to the test above, but verifies that opt-in origin isolation is
// enabled when above the memory threshold.
TEST_F(OptInOriginIsolationPolicyTest, AboveThreshold_Android) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
// Define a memory threshold at 128MB. This is below the 512MB of physical
// memory that this test simulates, so opt-in origin isolation should be
// enabled.
base::test::ScopedFeatureList memory_feature;
memory_feature.InitAndEnableFeatureWithParameters(
features::kSiteIsolationMemoryThresholdsAndroid,
{{features::kPartialSiteIsolationMemoryThresholdParamName, "128"}});
EXPECT_TRUE(content::SiteIsolationPolicy::
IsProcessIsolationForOriginAgentClusterEnabled());
EXPECT_TRUE(content::SiteIsolationPolicy::IsOriginAgentClusterEnabled());
// Simulate a navigation to a URL that serves an Origin-Agent-Cluster header.
// Verify that the resulting SiteInstance requires a dedicated process. Note
// that this test disables strict site isolation, so this would happen only
// if opt-in isolation took place.
const GURL kUrl("https://www.google.com/");
std::unique_ptr<content::WebContents> web_contents =
content::WebContentsTester::CreateTestWebContents(browser_context(),
nullptr);
std::unique_ptr<content::NavigationSimulator> simulator =
SimulateNavigationToURLWithOriginAgentClusterHeader(kUrl,
web_contents.get());
content::SiteInstance* site_instance =
simulator->GetFinalRenderFrameHost()->GetSiteInstance();
EXPECT_TRUE(site_instance->RequiresDedicatedProcess());
}
#else // BUILDFLAG(IS_ANDROID)
// Check that opt-in origin isolation is applied on non-Android.
TEST_F(OptInOriginIsolationPolicyTest, NonAndroid) {
if (ShouldSkipBecauseOfConflictingCommandLineSwitches()) {
return;
}
EXPECT_TRUE(content::SiteIsolationPolicy::
IsProcessIsolationForOriginAgentClusterEnabled());
EXPECT_TRUE(content::SiteIsolationPolicy::IsOriginAgentClusterEnabled());
// Simulate a navigation to a URL that serves an Origin-Agent-Cluster header.
// Verify that the resulting SiteInstance requires a dedicated process. Note
// that this test disables strict site isolation, so this would happen only
// if opt-in isolation took place.
const GURL kUrl("https://www.google.com/");
std::unique_ptr<content::WebContents> web_contents =
content::WebContentsTester::CreateTestWebContents(browser_context(),
nullptr);
std::unique_ptr<content::NavigationSimulator> simulator =
SimulateNavigationToURLWithOriginAgentClusterHeader(kUrl,
web_contents.get());
content::SiteInstance* site_instance =
simulator->GetFinalRenderFrameHost()->GetSiteInstance();
EXPECT_TRUE(site_instance->RequiresDedicatedProcess());
}
#endif
} // namespace site_isolation
|