1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/sync/service/sync_policy_handler.h"
#include <memory>
#include <string>
#include <utility>
#include <vector>
#include "base/values.h"
#include "components/policy/core/browser/policy_error_map.h"
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_types.h"
#include "components/policy/policy_constants.h"
#include "components/prefs/pref_value_map.h"
#include "components/sync/base/pref_names.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace syncer {
namespace {
TEST(SyncPolicyHandlerTest, Default) {
policy::PolicyMap policy;
SyncPolicyHandler handler;
PrefValueMap prefs;
handler.ApplyPolicySettings(policy, &prefs);
EXPECT_FALSE(prefs.GetValue(prefs::internal::kSyncManaged, nullptr));
}
TEST(SyncPolicyHandlerTest, Enabled) {
policy::PolicyMap policy;
policy.Set(policy::key::kSyncDisabled, policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
base::Value(false), nullptr);
SyncPolicyHandler handler;
PrefValueMap prefs;
handler.ApplyPolicySettings(policy, &prefs);
// Enabling Sync should not set the pref.
EXPECT_FALSE(prefs.GetValue(prefs::internal::kSyncManaged, nullptr));
}
TEST(SyncPolicyHandlerTest, Disabled) {
policy::PolicyMap policy;
policy.Set(policy::key::kSyncDisabled, policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
base::Value(true), nullptr);
SyncPolicyHandler handler;
PrefValueMap prefs;
handler.ApplyPolicySettings(policy, &prefs);
// Sync should be flagged as managed.
const base::Value* value = nullptr;
EXPECT_TRUE(prefs.GetValue(prefs::internal::kSyncManaged, &value));
ASSERT_TRUE(value);
EXPECT_TRUE(value->GetBool());
}
TEST(SyncPolicyHandlerTest, SyncTypesListDisabled) {
// Start with prefs enabled so we can sense that they have changed.
PrefValueMap prefs;
prefs.SetBoolean(prefs::internal::kSyncBookmarks, true);
prefs.SetBoolean(prefs::internal::kSyncReadingList, true);
prefs.SetBoolean(prefs::internal::kSyncPreferences, true);
prefs.SetBoolean(prefs::internal::kSyncAutofill, true);
prefs.SetBoolean(prefs::internal::kSyncPayments, true);
prefs.SetBoolean(prefs::internal::kSyncThemes, true);
// Create a policy that disables some types.
policy::PolicyMap policy;
auto disabled_types = base::Value::List()
.Append("bookmarks")
.Append("readingList")
.Append("preferences");
policy.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
SyncPolicyHandler handler;
handler.ApplyPolicySettings(policy, &prefs);
// Prefs in the policy should be disabled.
bool enabled;
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncBookmarks, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncReadingList, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncPreferences, &enabled));
EXPECT_FALSE(enabled);
// Prefs that are not part of the policy are still enabled.
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncAutofill, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncPayments, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncThemes, &enabled));
EXPECT_TRUE(enabled);
}
// Same as SyncTypesListDisabled but tests autofill specifically.
TEST(SyncPolicyHandlerTest, SyncTypesListDisabledAutofill) {
// Start with prefs enabled so we can sense that they have changed.
PrefValueMap prefs;
prefs.SetBoolean(prefs::internal::kSyncBookmarks, true);
prefs.SetBoolean(prefs::internal::kSyncReadingList, true);
prefs.SetBoolean(prefs::internal::kSyncPreferences, true);
prefs.SetBoolean(prefs::internal::kSyncAutofill, true);
prefs.SetBoolean(prefs::internal::kSyncPayments, true);
prefs.SetBoolean(prefs::internal::kSyncThemes, true);
// Create a policy that disables autofill.
policy::PolicyMap policy;
auto disabled_types = base::Value::List().Append("autofill");
policy.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
SyncPolicyHandler handler;
handler.ApplyPolicySettings(policy, &prefs);
// Prefs in the policy should be disabled.
bool enabled;
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncAutofill, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncPayments, &enabled));
EXPECT_FALSE(enabled);
// Prefs that are not part of the policy are still enabled.
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncBookmarks, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncReadingList, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncPreferences, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncThemes, &enabled));
EXPECT_TRUE(enabled);
}
TEST(SyncPolicyHandlerTest, SyncTypesListDisabledInvalidEntry) {
// Start with prefs enabled so we can sense that they have changed.
PrefValueMap prefs;
prefs.SetBoolean(prefs::internal::kSyncBookmarks, true);
prefs.SetBoolean(prefs::internal::kSyncReadingList, true);
prefs.SetBoolean(prefs::internal::kSyncPreferences, true);
prefs.SetBoolean(prefs::internal::kSyncAutofill, true);
// Create a policy that disables some types, but also contains a non-string
// entry in the list.
policy::PolicyMap policy;
auto disabled_types =
base::Value::List().Append("bookmarks").Append(123).Append("preferences");
policy.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
SyncPolicyHandler handler;
// The invalid value should have produced a warning message.
policy::PolicyErrorMap errors;
handler.CheckPolicySettings(policy, &errors);
std::vector<policy::PolicyErrorMap::Data> error_data =
errors.GetErrors(policy::key::kSyncTypesListDisabled);
ASSERT_EQ(error_data.size(), 1u);
EXPECT_EQ(error_data[0].level, policy::PolicyMap::MessageType::kWarning);
// But the valid entries should still have been applied.
handler.ApplyPolicySettings(policy, &prefs);
bool enabled;
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncBookmarks, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncPreferences, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncAutofill, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncReadingList, &enabled));
EXPECT_TRUE(enabled);
}
TEST(SyncPolicyHandlerTest, SyncTypesListDisabledUnknownEntry) {
// Start with prefs enabled so we can sense that they have changed.
PrefValueMap prefs;
prefs.SetBoolean(prefs::internal::kSyncBookmarks, true);
prefs.SetBoolean(prefs::internal::kSyncReadingList, true);
prefs.SetBoolean(prefs::internal::kSyncPreferences, true);
prefs.SetBoolean(prefs::internal::kSyncAutofill, true);
// Create a policy that disables some types, but also contains an unrecognized
// value (in practice, this could be a previous data type that was deprecated,
// or a new data type that this version of the browser doesn't know about yet,
// or just a typo in the configuration).
policy::PolicyMap policy;
auto disabled_types = base::Value::List()
.Append("bookmarks")
.Append("nonexistent")
.Append("preferences");
policy.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
SyncPolicyHandler handler;
// The invalid value should have produced a warning message.
policy::PolicyErrorMap errors;
handler.CheckPolicySettings(policy, &errors);
std::vector<policy::PolicyErrorMap::Data> error_data =
errors.GetErrors(policy::key::kSyncTypesListDisabled);
ASSERT_EQ(error_data.size(), 1u);
EXPECT_NE(error_data[0].message.find(u"nonexistent"), std::string::npos);
EXPECT_EQ(error_data[0].level, policy::PolicyMap::MessageType::kWarning);
// But the valid entries should still have been applied.
handler.ApplyPolicySettings(policy, &prefs);
bool enabled;
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncBookmarks, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncPreferences, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncAutofill, &enabled));
EXPECT_TRUE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncReadingList, &enabled));
EXPECT_TRUE(enabled);
}
#if BUILDFLAG(IS_CHROMEOS)
TEST(SyncPolicyHandlerOsTest, SyncTypesListDisabled_OsTypes) {
// Start with prefs enabled so we can sense that they have changed.
PrefValueMap prefs;
prefs.SetBoolean(prefs::internal::kSyncOsApps, true);
prefs.SetBoolean(prefs::internal::kSyncOsPreferences, true);
prefs.SetBoolean(prefs::internal::kSyncWifiConfigurations, true);
// Create a policy that disables the types.
policy::PolicyMap policy;
auto disabled_types = base::Value::List()
.Append("osApps")
.Append("osPreferences")
.Append("osWifiConfigurations");
policy.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
SyncPolicyHandler handler;
handler.ApplyPolicySettings(policy, &prefs);
// Prefs in the policy are disabled.
bool enabled;
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncOsApps, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncOsPreferences, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(
prefs.GetBoolean(prefs::internal::kSyncWifiConfigurations, &enabled));
EXPECT_FALSE(enabled);
}
TEST(SyncPolicyHandlerOsTest, SyncTypesListDisabled_MigratedTypes) {
// Start with prefs enabled so we can sense that they have changed.
PrefValueMap prefs;
prefs.SetBoolean(prefs::internal::kSyncOsApps, true);
prefs.SetBoolean(prefs::internal::kSyncOsPreferences, true);
// Create a policy that disables the types, but using the original browser
// policy names from before the SplitSettingsSync launch.
policy::PolicyMap policy;
auto disabled_types = base::Value::List()
.Append("apps")
.Append("wifiConfigurations")
.Append("preferences");
policy.Set(policy::key::kSyncTypesListDisabled,
policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD,
base::Value(std::move(disabled_types)), nullptr);
SyncPolicyHandler handler;
handler.ApplyPolicySettings(policy, &prefs);
// The equivalent OS types are disabled.
bool enabled;
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncOsApps, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(
prefs.GetBoolean(prefs::internal::kSyncWifiConfigurations, &enabled));
EXPECT_FALSE(enabled);
ASSERT_TRUE(prefs.GetBoolean(prefs::internal::kSyncOsPreferences, &enabled));
EXPECT_FALSE(enabled);
}
#endif // BUILDFLAG(IS_CHROMEOS)
} // namespace
} // namespace syncer
|
