1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/trusted_vault/trusted_vault_request.h"
#include <memory>
#include <string>
#include <utility>
#include "base/containers/flat_map.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/scoped_refptr.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/mock_callback.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "components/signin/public/identity_manager/access_token_info.h"
#include "components/trusted_vault/test/fake_trusted_vault_access_token_fetcher.h"
#include "components/trusted_vault/trusted_vault_access_token_fetcher.h"
#include "components/trusted_vault/trusted_vault_histograms.h"
#include "components/trusted_vault/trusted_vault_server_constants.h"
#include "google_apis/gaia/core_account_id.h"
#include "services/network/public/cpp/shared_url_loader_factory.h"
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/public/mojom/url_response_head.mojom.h"
#include "services/network/test/test_url_loader_factory.h"
#include "services/network/test/test_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace trusted_vault {
namespace {
using testing::_;
using testing::Eq;
using testing::Invoke;
using testing::IsEmpty;
using testing::Ne;
using testing::NotNull;
using testing::Pointee;
const char kAccessToken[] = "access_token";
const char kRequestUrl[] = "https://test.com/test";
const char kRequestUrlWithAlternateOutputProto[] =
"https://test.com/test?alt=proto";
const char kResponseBody[] = "response_body";
MATCHER(HasValidAccessToken, "") {
const network::TestURLLoaderFactory::PendingRequest& pending_request = arg;
std::string access_token_header =
pending_request.request.headers.GetHeader("Authorization")
.value_or(std::string());
return access_token_header == base::StringPrintf("Bearer %s", kAccessToken);
}
signin::AccessTokenInfo MakeAccessTokenInfo(const std::string& access_token) {
return signin::AccessTokenInfo(
access_token,
/*expiration_time_param=*/base::Time::Now() + base::Hours(1),
/*id_token=*/std::string());
}
class TrustedVaultRequestTest : public testing::Test {
public:
TrustedVaultRequestTest()
: shared_url_loader_factory_(
base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>(
&test_url_loader_factory_)) {}
std::unique_ptr<TrustedVaultRequest>
StartNewRequestWithAccessTokenAndRetriesDuration(
const std::string& access_token,
TrustedVaultRequest::HttpMethod http_method,
const std::optional<std::string>& request_body,
base::TimeDelta max_retry_duration,
TrustedVaultRequest::CompletionCallback completion_callback) {
const CoreAccountId account_id =
CoreAccountId::FromGaiaId(GaiaId("user_id"));
FakeTrustedVaultAccessTokenFetcher access_token_fetcher(
MakeAccessTokenInfo(access_token));
auto request = std::make_unique<TrustedVaultRequest>(
GetSecurityDomainId(), account_id, http_method, GURL(kRequestUrl),
request_body, max_retry_duration, shared_url_loader_factory_,
std::make_unique<FakeTrustedVaultAccessTokenFetcher>(
MakeAccessTokenInfo(access_token)),
/*record_fetch_status_callback=*/base::DoNothing());
request->FetchAccessTokenAndSendRequest(std::move(completion_callback));
return request;
}
std::unique_ptr<TrustedVaultRequest> StartNewRequestWithAccessToken(
const std::string& access_token,
TrustedVaultRequest::HttpMethod http_method,
const std::optional<std::string>& request_body,
TrustedVaultRequest::CompletionCallback completion_callback) {
return StartNewRequestWithAccessTokenAndRetriesDuration(
access_token, http_method, request_body,
/*max_retry_duration=*/base::Seconds(0),
std::move(completion_callback));
}
std::unique_ptr<TrustedVaultRequest> StartNewRequestWithAccessTokenError(
TrustedVaultAccessTokenFetcher::FetchingError error,
TrustedVaultRequest::CompletionCallback completion_callback) {
const CoreAccountId account_id =
CoreAccountId::FromGaiaId(GaiaId("user_id"));
auto request = std::make_unique<TrustedVaultRequest>(
GetSecurityDomainId(), account_id,
TrustedVaultRequest::HttpMethod::kGet, GURL(kRequestUrl),
/*serialized_request_proto=*/std::nullopt,
/*max_retry_duration=*/base::Seconds(0), shared_url_loader_factory_,
std::make_unique<FakeTrustedVaultAccessTokenFetcher>(
base::unexpected{error}),
/*record_fetch_status_callback=*/base::DoNothing());
request->FetchAccessTokenAndSendRequest(std::move(completion_callback));
return request;
}
bool RespondToHttpRequest(
net::Error error,
std::optional<net::HttpStatusCode> response_http_code,
const std::string& response_body) {
network::mojom::URLResponseHeadPtr response_head;
if (response_http_code.has_value()) {
response_head = network::CreateURLResponseHead(*response_http_code);
} else {
response_head = network::mojom::URLResponseHead::New();
}
return test_url_loader_factory_.SimulateResponseForPendingRequest(
GURL(kRequestUrlWithAlternateOutputProto),
network::URLLoaderCompletionStatus(error), std::move(response_head),
response_body);
}
SecurityDomainId GetSecurityDomainId() {
return SecurityDomainId::kChromeSync;
}
network::TestURLLoaderFactory::PendingRequest* GetPendingRequest() {
return test_url_loader_factory_.GetPendingRequest(/*index=*/0);
}
base::test::SingleThreadTaskEnvironment& task_environment() {
return task_environment_;
}
private:
base::test::SingleThreadTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
network::TestURLLoaderFactory test_url_loader_factory_;
scoped_refptr<network::SharedURLLoaderFactory> shared_url_loader_factory_;
};
} // namespace
TEST_F(TrustedVaultRequestTest, ShouldSendGetRequestAndHandleSuccess) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
base::HistogramTester histogram_tester;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
histogram_tester.ExpectUniqueSample(
/*name=*/"TrustedVault.AccessTokenFetchSuccess." +
GetSecurityDomainNameForUma(GetSecurityDomainId()),
/*sample=*/true,
/*expected_bucket_count=*/1);
network::TestURLLoaderFactory::PendingRequest* pending_request =
GetPendingRequest();
EXPECT_THAT(pending_request, Pointee(HasValidAccessToken()));
const network::ResourceRequest& resource_request = pending_request->request;
EXPECT_THAT(resource_request.method, Eq("GET"));
EXPECT_THAT(resource_request.url,
Eq(GURL(kRequestUrlWithAlternateOutputProto)));
EXPECT_THAT(network::GetUploadData(resource_request), IsEmpty());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(
completion_callback,
Run(TrustedVaultRequest::HttpStatus::kSuccess, Eq(kResponseBody)));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_OK, kResponseBody));
}
TEST_F(TrustedVaultRequestTest,
ShouldSendPostRequestWithoutPayloadAndHandleSuccess) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kPost,
/*request_body=*/std::nullopt, completion_callback.Get());
network::TestURLLoaderFactory::PendingRequest* pending_request =
GetPendingRequest();
EXPECT_THAT(pending_request, Pointee(HasValidAccessToken()));
const network::ResourceRequest& resource_request = pending_request->request;
EXPECT_THAT(resource_request.method, Eq("POST"));
EXPECT_THAT(resource_request.url,
Eq(GURL(kRequestUrlWithAlternateOutputProto)));
EXPECT_THAT(network::GetUploadData(resource_request), IsEmpty());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(
completion_callback,
Run(TrustedVaultRequest::HttpStatus::kSuccess, Eq(kResponseBody)));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_OK, kResponseBody));
}
TEST_F(TrustedVaultRequestTest,
ShouldSendPatchRequestWithoutPayloadAndHandleSuccess) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kPatch,
/*request_body=*/std::nullopt, completion_callback.Get());
network::TestURLLoaderFactory::PendingRequest* pending_request =
GetPendingRequest();
EXPECT_THAT(pending_request, Pointee(HasValidAccessToken()));
const network::ResourceRequest& resource_request = pending_request->request;
EXPECT_THAT(resource_request.method, Eq("PATCH"));
EXPECT_THAT(resource_request.url,
Eq(GURL(kRequestUrlWithAlternateOutputProto)));
EXPECT_THAT(network::GetUploadData(resource_request), IsEmpty());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(
completion_callback,
Run(TrustedVaultRequest::HttpStatus::kSuccess, Eq(kResponseBody)));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_OK, kResponseBody));
}
TEST_F(TrustedVaultRequestTest,
ShouldSendPostRequestWithPayloadAndHandleSuccess) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
const std::string kRequestBody = "Request body";
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kPost, kRequestBody,
completion_callback.Get());
network::TestURLLoaderFactory::PendingRequest* pending_request =
GetPendingRequest();
EXPECT_THAT(pending_request, Pointee(HasValidAccessToken()));
const network::ResourceRequest& resource_request = pending_request->request;
EXPECT_THAT(resource_request.method, Eq("POST"));
EXPECT_THAT(resource_request.url,
Eq(GURL(kRequestUrlWithAlternateOutputProto)));
EXPECT_THAT(network::GetUploadData(resource_request), Eq(kRequestBody));
// |completion_callback| should be called after receiving response.
EXPECT_CALL(
completion_callback,
Run(TrustedVaultRequest::HttpStatus::kSuccess, Eq(kResponseBody)));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_OK, kResponseBody));
}
TEST_F(TrustedVaultRequestTest, ShouldHandleNetworkFailures) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kNetworkError, _));
EXPECT_TRUE(RespondToHttpRequest(net::ERR_FAILED, std::nullopt,
/*response_body=*/std::string()));
}
TEST_F(TrustedVaultRequestTest, ShouldHandleHttpErrors) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kOtherError, _));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_INTERNAL_SERVER_ERROR,
/*response_body=*/""));
}
TEST_F(TrustedVaultRequestTest, ShouldHandleBadRequestStatus) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kBadRequest, _));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_BAD_REQUEST,
/*response_body=*/""));
}
TEST_F(TrustedVaultRequestTest,
ShouldHandleConflictStatusAndPopulateResponseBody) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kConflict, kResponseBody));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_CONFLICT, kResponseBody));
}
TEST_F(TrustedVaultRequestTest, ShouldHandleNotFoundStatus) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
// |completion_callback| should be called after receiving response.
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kNotFound, _));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_NOT_FOUND,
/*response_body=*/""));
}
TEST_F(TrustedVaultRequestTest, ShouldRetryUponNetworkChange) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request = StartNewRequestWithAccessToken(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt, completion_callback.Get());
// Mimic network change error for the first request.
EXPECT_CALL(completion_callback, Run).Times(0);
EXPECT_TRUE(RespondToHttpRequest(net::ERR_NETWORK_CHANGED, net::HTTP_OK,
/*response_body=*/""));
testing::Mock::VerifyAndClearExpectations(&completion_callback);
// Second request should be sent, mimic its success.
network::TestURLLoaderFactory::PendingRequest* pending_request =
GetPendingRequest();
EXPECT_THAT(pending_request, NotNull());
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kSuccess, kResponseBody));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_OK, kResponseBody));
}
TEST_F(TrustedVaultRequestTest, ShouldRetryUponTransientErrorAndHandleSuccess) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request =
StartNewRequestWithAccessTokenAndRetriesDuration(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt,
/*max_retry_duration=*/base::Minutes(1), completion_callback.Get());
// Mimic network error for the first request.
EXPECT_CALL(completion_callback, Run).Times(0);
EXPECT_TRUE(RespondToHttpRequest(net::ERR_DNS_REQUEST_CANCELLED, net::HTTP_OK,
/*response_body=*/""));
testing::Mock::VerifyAndClearExpectations(&completion_callback);
// Forward time and expect the second attempt.
task_environment().FastForwardBy(base::Seconds(15));
network::TestURLLoaderFactory::PendingRequest* pending_request =
GetPendingRequest();
EXPECT_THAT(pending_request, NotNull());
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kSuccess, kResponseBody));
EXPECT_TRUE(RespondToHttpRequest(net::OK, net::HTTP_OK, kResponseBody));
}
TEST_F(TrustedVaultRequestTest, ShouldStopRetryingAndReportTransientError) {
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
std::unique_ptr<TrustedVaultRequest> request =
StartNewRequestWithAccessTokenAndRetriesDuration(
kAccessToken, TrustedVaultRequest::HttpMethod::kGet,
/*request_body=*/std::nullopt,
/*max_retry_duration=*/base::Minutes(1), completion_callback.Get());
// Mimic network error for the first request with significant delay,
// sufficient to stop retries.
task_environment().FastForwardBy(base::Minutes(2));
EXPECT_CALL(completion_callback,
Run(TrustedVaultRequest::HttpStatus::kNetworkError, _));
EXPECT_TRUE(RespondToHttpRequest(net::ERR_DNS_REQUEST_CANCELLED, net::HTTP_OK,
/*response_body=*/""));
testing::Mock::VerifyAndClearExpectations(&completion_callback);
}
TEST_F(TrustedVaultRequestTest, ShouldHandleAccessTokenFetchingFailures) {
base::flat_map<TrustedVaultAccessTokenFetcher::FetchingError,
TrustedVaultRequest::HttpStatus>
fetching_error_to_http_status = {
{TrustedVaultAccessTokenFetcher::FetchingError::kTransientAuthError,
TrustedVaultRequest::HttpStatus::kTransientAccessTokenFetchError},
{TrustedVaultAccessTokenFetcher::FetchingError::kPersistentAuthError,
TrustedVaultRequest::HttpStatus::kPersistentAccessTokenFetchError},
{TrustedVaultAccessTokenFetcher::FetchingError::kNotPrimaryAccount,
TrustedVaultRequest::HttpStatus::
kPrimaryAccountChangeAccessTokenFetchError}};
for (const auto& [fetching_error, expected_http_status] :
fetching_error_to_http_status) {
base::HistogramTester histogram_tester;
base::MockCallback<TrustedVaultRequest::CompletionCallback>
completion_callback;
// Access token fetching failure propagated immediately in this test, so
// |completion_callback| should be called immediately as well.
EXPECT_CALL(completion_callback, Run(expected_http_status, _));
std::unique_ptr<TrustedVaultRequest> request =
StartNewRequestWithAccessTokenError(fetching_error,
completion_callback.Get());
histogram_tester.ExpectUniqueSample(
/*name=*/"TrustedVault.AccessTokenFetchSuccess." +
GetSecurityDomainNameForUma(GetSecurityDomainId()),
/*sample=*/false,
/*expected_bucket_count=*/1);
}
}
} // namespace trusted_vault
|