1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/url_rewrite/browser/url_request_rewrite_rules_validation.h"
#include <string_view>
#include "base/run_loop.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace url_rewrite {
namespace {
mojom::UrlRequestActionPtr CreateRewriteAddHeaders(
std::string_view header_name,
std::string_view header_value) {
auto add_headers = mojom::UrlRequestRewriteAddHeaders::New();
add_headers->headers.push_back(mojom::UrlHeader::New(
std::string(header_name), std::string(header_value)));
return mojom::UrlRequestAction::NewAddHeaders(std::move(add_headers));
}
mojom::UrlRequestActionPtr CreateRewriteRemoveHeader(
std::optional<std::string_view> query_pattern,
std::string_view header_name) {
auto remove_header = mojom::UrlRequestRewriteRemoveHeader::New();
if (query_pattern)
remove_header->query_pattern.emplace(std::string(*query_pattern));
remove_header->header_name = std::string(header_name);
return mojom::UrlRequestAction::NewRemoveHeader(std::move(remove_header));
}
mojom::UrlRequestActionPtr CreateRewriteSubstituteQueryPattern(
std::string_view pattern,
std::string_view substitution) {
auto substitute_query_pattern =
mojom::UrlRequestRewriteSubstituteQueryPattern::New();
substitute_query_pattern->pattern = std::string(pattern);
substitute_query_pattern->substitution = std::string(substitution);
return mojom::UrlRequestAction::NewSubstituteQueryPattern(
std::move(substitute_query_pattern));
}
mojom::UrlRequestActionPtr CreateRewriteReplaceUrl(
std::string_view url_ends_with,
std::string_view new_url) {
auto replace_url = mojom::UrlRequestRewriteReplaceUrl::New();
replace_url->url_ends_with = std::string(url_ends_with);
replace_url->new_url = GURL(new_url);
return mojom::UrlRequestAction::NewReplaceUrl(std::move(replace_url));
}
mojom::UrlRequestActionPtr CreateRewriteAppendToQuery(std::string_view query) {
auto append_to_query = mojom::UrlRequestRewriteAppendToQuery::New();
append_to_query->query = std::string(query);
return mojom::UrlRequestAction::NewAppendToQuery(std::move(append_to_query));
}
bool ValidateRulesFromAction(mojom::UrlRequestActionPtr action) {
auto rule = mojom::UrlRequestRule::New();
rule->actions.emplace_back(std::move(action));
mojom::UrlRequestRewriteRulesPtr rules = mojom::UrlRequestRewriteRules::New();
rules->rules.push_back(std::move(rule));
return ValidateRules(rules.get());
}
} // namespace
// Tests AddHeaders rewrites are properly converted to their Mojo equivalent.
TEST(UrlRequestRewriteRulesValidationTest, ValidateAddHeaders) {
EXPECT_TRUE(
ValidateRulesFromAction(CreateRewriteAddHeaders("Test", "Value")));
// Invalid AddHeaders header name.
EXPECT_FALSE(
ValidateRulesFromAction(CreateRewriteAddHeaders("Te\nst1", "Value")));
// Invalid AddHeaders header value.
EXPECT_FALSE(
ValidateRulesFromAction(CreateRewriteAddHeaders("Test1", "Val\nue")));
// Empty AddHeaders.
EXPECT_FALSE(ValidateRulesFromAction(mojom::UrlRequestAction::NewAddHeaders(
mojom::UrlRequestRewriteAddHeaders::New())));
}
// Tests RemoveHeader rewrites are properly converted to their Mojo equivalent.
TEST(UrlRequestRewriteRulesValidationTest, ValidateRemoveHeader) {
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteRemoveHeader(std::make_optional("Test"), "Header")));
// Create a RemoveHeader action with no pattern.
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteRemoveHeader(std::nullopt, "Header")));
// Invalid RemoveHeader header name.
EXPECT_FALSE(
ValidateRulesFromAction(CreateRewriteRemoveHeader("Query", "Head\ner")));
// Empty RemoveHeader.
EXPECT_FALSE(ValidateRulesFromAction(mojom::UrlRequestAction::NewRemoveHeader(
mojom::UrlRequestRewriteRemoveHeader::New())));
}
// Tests SubstituteQueryPattern rewrites are properly converted to their Mojo
// equivalent.
TEST(UrlRequestRewriteRulesValidationTest, ValidateSubstituteQueryPattern) {
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteSubstituteQueryPattern("Pattern", "Substitution")));
EXPECT_FALSE(ValidateRulesFromAction(
mojom::UrlRequestAction::NewSubstituteQueryPattern(
mojom::UrlRequestRewriteSubstituteQueryPattern::New())));
}
// Tests ReplaceUrl rewrites are properly converted to their Mojo equivalent.
TEST(UrlRequestRewriteRulesValidationTest, ValidateReplaceUrl) {
// ReplaceURL with valid new_url.
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteReplaceUrl("/something", "http://site.xyz")));
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteReplaceUrl("some%00thing", "http://site.xyz")));
// ReplaceURL with valid new_url including "%00" in its path.
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteReplaceUrl("/something", "http://site.xyz/%00")));
EXPECT_TRUE(ValidateRulesFromAction(
CreateRewriteReplaceUrl("some%00thing", "http://site.xyz/%00")));
// ReplaceURL with invalid new_url.
EXPECT_FALSE(ValidateRulesFromAction(
CreateRewriteReplaceUrl("/something", "http:site:xyz")));
EXPECT_FALSE(ValidateRulesFromAction(
CreateRewriteReplaceUrl("some%00thing", "http:site:xyz")));
// Empty ReplaceUrl.
EXPECT_FALSE(ValidateRulesFromAction(mojom::UrlRequestAction::NewReplaceUrl(
mojom::UrlRequestRewriteReplaceUrl::New())));
}
// Tests AppendToQuery rewrites are properly converted to their Mojo equivalent.
TEST(UrlRequestRewriteRulesValidationTest, ValidateAppendToQuery) {
EXPECT_TRUE(
ValidateRulesFromAction(CreateRewriteAppendToQuery("foo=bar&foo")));
EXPECT_FALSE(
ValidateRulesFromAction(mojom::UrlRequestAction::NewAppendToQuery(
mojom::UrlRequestRewriteAppendToQuery::New())));
}
// Tests validation is working as expected.
TEST(UrlRequestRewriteRulesValidationTest, ValidateNullAction) {
// Empty action.
EXPECT_FALSE(ValidateRulesFromAction(nullptr));
}
TEST(UrlRequestRewriteRulesValidationTest, ValidateNullRules) {
// Empty action.
EXPECT_FALSE(ValidateRules(nullptr));
}
} // namespace url_rewrite
|
