1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/variations/cros_evaluate_seed/early_boot_feature_visitor.h"
#include <map>
#include <memory>
#include <string>
#include "base/feature_list.h"
#include "base/metrics/field_trial.h"
#include "base/test/scoped_feature_list.h"
#include "chromeos/ash/components/dbus/featured/featured.pb.h"
#include "early_boot_feature_visitor.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace variations::cros_early_boot::evaluate_seed {
namespace {
constexpr char kEarlyBootFeatureTestName[] = "CrOSEarlyBootTestFeature";
constexpr char kEarlyBootFeatureOffByDefaultName[] =
"CrOSEarlyBootOffByDefault";
BASE_FEATURE(kEarlyBootFeatureOffByDefault,
kEarlyBootFeatureOffByDefaultName,
base::FEATURE_DISABLED_BY_DEFAULT);
} // namespace
TEST(EarlyBootFeatureVisitor, FeatureWithNoFieldTrial) {
base::test::ScopedFeatureList outer_scope;
outer_scope.InitWithEmptyFeatureAndFieldTrialLists();
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(kEarlyBootFeatureOffByDefault);
EarlyBootFeatureVisitor visitor;
base::FeatureList::VisitFeaturesAndParams(visitor,
EarlyBootFeatureVisitor::kPrefix);
google::protobuf::RepeatedPtrField<featured::FeatureOverride> overrides =
visitor.release_overrides();
ASSERT_EQ(overrides.size(), 1);
const featured::FeatureOverride& feature = overrides[0];
EXPECT_EQ(feature.name(), kEarlyBootFeatureOffByDefaultName);
EXPECT_EQ(feature.override_state(), featured::OVERRIDE_ENABLE_FEATURE);
EXPECT_EQ(feature.trial_name(), "");
EXPECT_EQ(feature.group_name(), "");
EXPECT_EQ(feature.params_size(), 0);
}
TEST(EarlyBootFeatureVisitor, InvalidFeatureName) {
base::test::ScopedFeatureList outer_scope;
outer_scope.InitWithEmptyFeatureAndFieldTrialLists();
auto feature_list = std::make_unique<base::FeatureList>();
base::FieldTrial* trial =
base::FieldTrialList::CreateFieldTrial("TrialExample", "A");
feature_list->RegisterFieldTrialOverride(
"FeatureNameWithoutCrOSEarlyBootPrefix",
base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE, trial);
base::test::ScopedFeatureList initialized_field_feature_list;
initialized_field_feature_list.InitWithFeatureList(std::move(feature_list));
EarlyBootFeatureVisitor visitor;
base::FeatureList::VisitFeaturesAndParams(visitor,
EarlyBootFeatureVisitor::kPrefix);
google::protobuf::RepeatedPtrField<featured::FeatureOverride> overrides =
visitor.release_overrides();
ASSERT_EQ(overrides.size(), 0);
}
TEST(EarlyBootFeatureVisitor, FeatureOverrideUseDefault) {
base::test::ScopedFeatureList outer_scope;
outer_scope.InitWithEmptyFeatureAndFieldTrialLists();
auto feature_list = std::make_unique<base::FeatureList>();
base::FieldTrial* trial =
base::FieldTrialList::CreateFieldTrial("TrialExample", "A");
feature_list->RegisterFieldTrialOverride(
kEarlyBootFeatureTestName, base::FeatureList::OVERRIDE_USE_DEFAULT,
trial);
base::test::ScopedFeatureList initialized_field_feature_list;
initialized_field_feature_list.InitWithFeatureList(std::move(feature_list));
EarlyBootFeatureVisitor visitor;
base::FeatureList::VisitFeaturesAndParams(visitor,
EarlyBootFeatureVisitor::kPrefix);
google::protobuf::RepeatedPtrField<featured::FeatureOverride> overrides =
visitor.release_overrides();
ASSERT_EQ(overrides.size(), 1);
const featured::FeatureOverride& feature = overrides[0];
EXPECT_EQ(feature.name(), kEarlyBootFeatureTestName);
EXPECT_EQ(feature.override_state(), featured::OVERRIDE_USE_DEFAULT);
EXPECT_EQ(feature.trial_name(), "TrialExample");
EXPECT_EQ(feature.group_name(), "A");
}
TEST(EarlyBootFeatureVisitor, FeatureOverrideUseDisabled) {
base::test::ScopedFeatureList outer_scope;
outer_scope.InitWithEmptyFeatureAndFieldTrialLists();
auto feature_list = std::make_unique<base::FeatureList>();
base::FieldTrial* trial =
base::FieldTrialList::CreateFieldTrial("TrialExample", "A");
feature_list->RegisterFieldTrialOverride(
kEarlyBootFeatureTestName, base::FeatureList::OVERRIDE_DISABLE_FEATURE,
trial);
base::test::ScopedFeatureList initialized_field_feature_list;
initialized_field_feature_list.InitWithFeatureList(std::move(feature_list));
EarlyBootFeatureVisitor visitor;
base::FeatureList::VisitFeaturesAndParams(visitor,
EarlyBootFeatureVisitor::kPrefix);
google::protobuf::RepeatedPtrField<featured::FeatureOverride> overrides =
visitor.release_overrides();
ASSERT_EQ(overrides.size(), 1);
const featured::FeatureOverride& feature = overrides[0];
EXPECT_EQ(feature.name(), kEarlyBootFeatureTestName);
EXPECT_EQ(feature.override_state(), featured::OVERRIDE_DISABLE_FEATURE);
EXPECT_EQ(feature.trial_name(), "TrialExample");
EXPECT_EQ(feature.group_name(), "A");
}
TEST(EarlyBootFeatureVisitor, FeatureOverrideUseEnabled) {
base::test::ScopedFeatureList outer_scope;
outer_scope.InitWithEmptyFeatureAndFieldTrialLists();
auto feature_list = std::make_unique<base::FeatureList>();
base::FieldTrial* trial =
base::FieldTrialList::CreateFieldTrial("TrialExample", "A");
feature_list->RegisterFieldTrialOverride(
kEarlyBootFeatureTestName, base::FeatureList::OVERRIDE_ENABLE_FEATURE,
trial);
base::test::ScopedFeatureList initialized_field_feature_list;
initialized_field_feature_list.InitWithFeatureList(std::move(feature_list));
EarlyBootFeatureVisitor visitor;
base::FeatureList::VisitFeaturesAndParams(visitor,
EarlyBootFeatureVisitor::kPrefix);
google::protobuf::RepeatedPtrField<featured::FeatureOverride> overrides =
visitor.release_overrides();
ASSERT_EQ(overrides.size(), 1);
const featured::FeatureOverride& feature = overrides[0];
EXPECT_EQ(feature.name(), kEarlyBootFeatureTestName);
EXPECT_EQ(feature.override_state(), featured::OVERRIDE_ENABLE_FEATURE);
EXPECT_EQ(feature.trial_name(), "TrialExample");
EXPECT_EQ(feature.group_name(), "A");
}
TEST(EarlyBootFeatureVisitor, FeatureHasParams) {
base::test::ScopedFeatureList outer_scope;
outer_scope.InitWithEmptyFeatureAndFieldTrialLists();
base::test::ScopedFeatureList initialized_field_feature_list;
initialized_field_feature_list.InitFromCommandLine(
/*enabled_features=*/"CrOSEarlyBootTestFeature<foo.bar:k1/v1/k2/v2",
/*disabled_features=*/"");
EarlyBootFeatureVisitor visitor;
base::FeatureList::VisitFeaturesAndParams(visitor,
EarlyBootFeatureVisitor::kPrefix);
google::protobuf::RepeatedPtrField<featured::FeatureOverride> overrides =
visitor.release_overrides();
ASSERT_EQ(overrides.size(), 1);
const featured::FeatureOverride& feature = overrides[0];
EXPECT_EQ(feature.name(), kEarlyBootFeatureTestName);
EXPECT_EQ(feature.override_state(), featured::OVERRIDE_ENABLE_FEATURE);
EXPECT_EQ(feature.trial_name(), "foo");
EXPECT_EQ(feature.group_name(), "bar");
const std::map<std::string, std::string> expected_params = {{"k1", "v1"},
{"k2", "v2"}};
std::map<std::string, std::string> actual_params;
for (const auto& entry : feature.params()) {
actual_params.insert({entry.key(), entry.value()});
}
EXPECT_EQ(actual_params, expected_params);
}
} // namespace variations::cros_early_boot::evaluate_seed
|
