1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/viz/service/display_embedder/skia_output_surface_impl.h"
#include <memory>
#include <utility>
#include "base/functional/bind.h"
#include "base/functional/callback_forward.h"
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "cc/test/fake_output_surface_client.h"
#include "cc/test/pixel_test_utils.h"
#include "components/viz/common/display/renderer_settings.h"
#include "components/viz/common/frame_sinks/copy_output_request.h"
#include "components/viz/common/frame_sinks/copy_output_result.h"
#include "components/viz/common/frame_sinks/copy_output_util.h"
#include "components/viz/service/display/output_surface_frame.h"
#include "components/viz/service/display_embedder/skia_output_surface_dependency_impl.h"
#include "components/viz/service/gl/gpu_service_impl.h"
#include "components/viz/test/test_gpu_service_holder.h"
#include "gpu/command_buffer/service/service_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/skia_conversions.h"
#include "ui/gfx/gpu_fence_handle.h"
#include "ui/gl/gl_implementation.h"
namespace viz {
namespace {
constexpr gfx::Rect kSurfaceRect(0, 0, 100, 100);
constexpr SkColor4f kOutputColor = SkColors::kRed;
} // namespace
class SkiaOutputSurfaceImplTest : public testing::Test {
public:
SkiaOutputSurfaceImplTest();
~SkiaOutputSurfaceImplTest() override;
GpuServiceImpl* GetGpuService() {
return TestGpuServiceHolder::GetInstance()->gpu_service();
}
void SetUpSkiaOutputSurfaceImpl();
// Paints and submits root RenderPass with a solid color rect of |size|.
gpu::SyncToken PaintRootRenderPass(
const gfx::Rect& output_rect,
base::OnceClosure closure,
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence);
void CheckSyncTokenOnGpuThread(const gpu::SyncToken& sync_token);
void CopyRequestCallbackOnGpuThread(const gfx::Rect& output_rect,
const gfx::ColorSpace& color_space,
std::unique_ptr<CopyOutputResult> result);
void BlockMainThread();
void UnblockMainThread();
protected:
DebugRendererSettings debug_settings_;
gl::DisableNullDrawGLBindings enable_pixel_output_;
std::unique_ptr<DisplayCompositorMemoryAndTaskController> display_controller_;
std::unique_ptr<SkiaOutputSurface> output_surface_;
cc::FakeOutputSurfaceClient output_surface_client_;
base::WaitableEvent wait_;
};
SkiaOutputSurfaceImplTest::SkiaOutputSurfaceImplTest()
: wait_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED) {
SetUpSkiaOutputSurfaceImpl();
}
SkiaOutputSurfaceImplTest::~SkiaOutputSurfaceImplTest() {
output_surface_.reset();
}
void SkiaOutputSurfaceImplTest::SetUpSkiaOutputSurfaceImpl() {
auto skia_deps = std::make_unique<SkiaOutputSurfaceDependencyImpl>(
GetGpuService(), gpu::kNullSurfaceHandle);
display_controller_ =
std::make_unique<DisplayCompositorMemoryAndTaskController>(
std::move(skia_deps));
output_surface_ = SkiaOutputSurfaceImpl::Create(
display_controller_.get(), RendererSettings(), &debug_settings_);
output_surface_->BindToClient(&output_surface_client_);
}
gpu::SyncToken SkiaOutputSurfaceImplTest::PaintRootRenderPass(
const gfx::Rect& output_rect,
base::OnceClosure closure,
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence) {
SkPaint paint;
paint.setColor(kOutputColor);
SkCanvas* root_canvas = output_surface_->BeginPaintCurrentFrame();
root_canvas->drawRect(gfx::RectToSkRect(output_rect), paint);
output_surface_->EndPaint(std::move(closure), std::move(return_release_fence),
output_rect,
/*is_overlay=*/false);
return output_surface_->Flush();
}
void SkiaOutputSurfaceImplTest::BlockMainThread() {
wait_.Wait();
}
void SkiaOutputSurfaceImplTest::UnblockMainThread() {
DCHECK(!wait_.IsSignaled());
wait_.Signal();
}
void SkiaOutputSurfaceImplTest::CheckSyncTokenOnGpuThread(
const gpu::SyncToken& sync_token) {
EXPECT_TRUE(
GetGpuService()->sync_point_manager()->IsSyncTokenReleased(sync_token));
UnblockMainThread();
}
void SkiaOutputSurfaceImplTest::CopyRequestCallbackOnGpuThread(
const gfx::Rect& output_rect,
const gfx::ColorSpace& color_space,
std::unique_ptr<CopyOutputResult> result) {
auto scoped_bitmap = result->ScopedAccessSkBitmap();
auto result_bitmap = scoped_bitmap.bitmap();
EXPECT_EQ(result_bitmap.width(), output_rect.width());
EXPECT_EQ(result_bitmap.height(), output_rect.height());
SkBitmap expected;
expected.allocPixels(SkImageInfo::MakeN32Premul(
output_rect.width(), output_rect.height(), color_space.ToSkColorSpace()));
expected.eraseColor(kOutputColor);
EXPECT_TRUE(
cc::MatchesBitmap(result_bitmap, expected, cc::ExactPixelComparator()));
UnblockMainThread();
}
// TODO(crbug.com/40922049): Re-enable this test
#if defined(MEMORY_SANITIZER)
#define MAYBE_EndPaint DISABLED_EndPaint
#else
#define MAYBE_EndPaint EndPaint
#endif
TEST_F(SkiaOutputSurfaceImplTest, MAYBE_EndPaint) {
OutputSurface::ReshapeParams reshape_params;
reshape_params.size = kSurfaceRect.size();
output_surface_->Reshape(reshape_params);
constexpr gfx::Rect output_rect(0, 0, 10, 10);
bool on_finished_called = false;
base::OnceClosure on_finished =
base::BindOnce([](bool* result) { *result = true; }, &on_finished_called);
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence_cb;
gpu::SyncToken sync_token = PaintRootRenderPass(
output_rect, std::move(on_finished), std::move(return_release_fence_cb));
EXPECT_TRUE(sync_token.HasData());
// Copy the output
const gfx::ColorSpace color_space = gfx::ColorSpace::CreateSRGB();
auto request = std::make_unique<CopyOutputRequest>(
CopyOutputRequest::ResultFormat::RGBA,
CopyOutputRequest::ResultDestination::kSystemMemory,
base::BindOnce(&SkiaOutputSurfaceImplTest::CopyRequestCallbackOnGpuThread,
base::Unretained(this), output_rect, color_space));
request->set_result_task_runner(
TestGpuServiceHolder::GetInstance()->gpu_main_thread_task_runner());
copy_output::RenderPassGeometry geometry;
geometry.result_bounds = output_rect;
geometry.result_selection = output_rect;
geometry.sampling_bounds = output_rect;
geometry.readback_offset = gfx::Vector2d(0, 0);
output_surface_->CopyOutput(geometry, color_space, std::move(request),
gpu::Mailbox());
output_surface_->SwapBuffersSkipped(kSurfaceRect);
output_surface_->Flush();
BlockMainThread();
// EndPaint draw is deferred until CopyOutput.
base::OnceClosure closure =
base::BindOnce(&SkiaOutputSurfaceImplTest::CheckSyncTokenOnGpuThread,
base::Unretained(this), sync_token);
output_surface_->ScheduleGpuTaskForTesting(std::move(closure), {sync_token});
BlockMainThread();
// Let the cb to come back.
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(on_finished_called);
}
// TODO(crbug.com/40922049): Re-enable this test
#if defined(MEMORY_SANITIZER)
#define MAYBE_EndPaintReleaseFence DISABLED_EndPaintReleaseFence
#else
#define MAYBE_EndPaintReleaseFence EndPaintReleaseFence
#endif
TEST_F(SkiaOutputSurfaceImplTest, MAYBE_EndPaintReleaseFence) {
// Skip test for Skia Graphite
gpu::GrContextType gr_context_type =
GetGpuService()->gpu_preferences().gr_context_type;
if (gr_context_type == gpu::GrContextType::kGraphiteDawn ||
gr_context_type == gpu::GrContextType::kGraphiteMetal) {
GTEST_SKIP();
}
OutputSurface::ReshapeParams reshape_params;
reshape_params.size = kSurfaceRect.size();
output_surface_->Reshape(reshape_params);
constexpr gfx::Rect output_rect(0, 0, 10, 10);
bool on_finished_called = false;
base::OnceClosure on_finished =
base::BindOnce([](bool* result) { *result = true; }, &on_finished_called);
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence_cb;
bool on_return_release_fence_called = false;
// This callback is unsupported when using Metal.
return_release_fence_cb = base::BindOnce(
[](bool* result, gfx::GpuFenceHandle handle) { *result = true; },
&on_return_release_fence_called);
gpu::SyncToken sync_token = PaintRootRenderPass(
output_rect, std::move(on_finished), std::move(return_release_fence_cb));
EXPECT_TRUE(sync_token.HasData());
// Copy the output
const gfx::ColorSpace color_space = gfx::ColorSpace::CreateSRGB();
auto request = std::make_unique<CopyOutputRequest>(
CopyOutputRequest::ResultFormat::RGBA,
CopyOutputRequest::ResultDestination::kSystemMemory,
base::BindOnce(&SkiaOutputSurfaceImplTest::CopyRequestCallbackOnGpuThread,
base::Unretained(this), output_rect, color_space));
request->set_result_task_runner(
TestGpuServiceHolder::GetInstance()->gpu_main_thread_task_runner());
copy_output::RenderPassGeometry geometry;
geometry.result_bounds = output_rect;
geometry.result_selection = output_rect;
geometry.sampling_bounds = output_rect;
geometry.readback_offset = gfx::Vector2d(0, 0);
output_surface_->CopyOutput(geometry, color_space, std::move(request),
gpu::Mailbox());
output_surface_->SwapBuffersSkipped(kSurfaceRect);
output_surface_->Flush();
BlockMainThread();
// EndPaint draw is deferred until CopyOutput.
base::OnceClosure closure =
base::BindOnce(&SkiaOutputSurfaceImplTest::CheckSyncTokenOnGpuThread,
base::Unretained(this), sync_token);
output_surface_->ScheduleGpuTaskForTesting(std::move(closure), {sync_token});
BlockMainThread();
// Let the cb to come back.
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(on_finished_called);
EXPECT_TRUE(on_return_release_fence_called);
}
// Draws two frames and calls Reshape() between the two frames changing the
// color space. Verifies draw after color space change is successful.
TEST_F(SkiaOutputSurfaceImplTest, SupportsColorSpaceChange) {
for (auto& color_space : {gfx::ColorSpace(), gfx::ColorSpace::CreateSRGB()}) {
OutputSurface::ReshapeParams reshape_params;
reshape_params.size = kSurfaceRect.size();
reshape_params.color_space = color_space;
output_surface_->Reshape(reshape_params);
// Draw something, it's not important what.
base::RunLoop run_loop;
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence_cb;
PaintRootRenderPass(kSurfaceRect, run_loop.QuitClosure(),
std::move(return_release_fence_cb));
OutputSurfaceFrame frame;
frame.size = kSurfaceRect.size();
output_surface_->SwapBuffers(std::move(frame));
output_surface_->Flush();
// TODO(crbug.com/40279197): We should not need to poll in this test.
while (!run_loop.AnyQuitCalled()) {
run_loop.RunUntilIdle();
output_surface_->CheckAsyncWorkCompletionForTesting();
}
}
}
// TODO(crbug.com/40922049): Re-enable this test
#if defined(MEMORY_SANITIZER)
#define MAYBE_CopyOutputBitmapSupportedColorSpace \
DISABLED_CopyOutputBitmapSupportedColorSpace
#else
#define MAYBE_CopyOutputBitmapSupportedColorSpace \
CopyOutputBitmapSupportedColorSpace
#endif
// Tests that the destination color space is preserved across a CopyOutput for
// ColorSpaces supported by SkColorSpace.
TEST_F(SkiaOutputSurfaceImplTest, MAYBE_CopyOutputBitmapSupportedColorSpace) {
OutputSurface::ReshapeParams reshape_params;
reshape_params.size = kSurfaceRect.size();
output_surface_->Reshape(reshape_params);
constexpr gfx::Rect output_rect(0, 0, 10, 10);
const gfx::ColorSpace color_space = gfx::ColorSpace(
gfx::ColorSpace::PrimaryID::BT709, gfx::ColorSpace::TransferID::LINEAR);
base::RunLoop run_loop;
std::unique_ptr<CopyOutputResult> result;
auto request = std::make_unique<CopyOutputRequest>(
CopyOutputRequest::ResultFormat::RGBA,
CopyOutputRequest::ResultDestination::kSystemMemory,
base::BindOnce(
[](std::unique_ptr<CopyOutputResult>* result_out,
base::OnceClosure quit_closure,
std::unique_ptr<CopyOutputResult> tmp_result) {
*result_out = std::move(tmp_result);
std::move(quit_closure).Run();
},
&result, run_loop.QuitClosure()));
request->set_result_task_runner(
TestGpuServiceHolder::GetInstance()->gpu_main_thread_task_runner());
copy_output::RenderPassGeometry geometry;
geometry.result_bounds = output_rect;
geometry.result_selection = output_rect;
geometry.sampling_bounds = output_rect;
geometry.readback_offset = gfx::Vector2d(0, 0);
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence_cb;
PaintRootRenderPass(kSurfaceRect, base::DoNothing(),
std::move(return_release_fence_cb));
output_surface_->CopyOutput(geometry, color_space, std::move(request),
gpu::Mailbox());
output_surface_->SwapBuffersSkipped(kSurfaceRect);
output_surface_->Flush();
run_loop.Run();
EXPECT_EQ(color_space, result->GetRGBAColorSpace());
}
// Tests that copying from a source with a color space that can't be converted
// to a SkColorSpace will fallback to a transform to sRGB.
TEST_F(SkiaOutputSurfaceImplTest, CopyOutputBitmapUnsupportedColorSpace) {
OutputSurface::ReshapeParams reshape_params;
reshape_params.size = kSurfaceRect.size();
output_surface_->Reshape(reshape_params);
constexpr gfx::Rect output_rect(0, 0, 10, 10);
const gfx::ColorSpace color_space =
gfx::ColorSpace(gfx::ColorSpace::PrimaryID::BT2020,
gfx::ColorSpace::TransferID::LOG_SQRT);
base::RunLoop run_loop;
std::unique_ptr<CopyOutputResult> result;
auto request = std::make_unique<CopyOutputRequest>(
CopyOutputRequest::ResultFormat::RGBA,
CopyOutputRequest::ResultDestination::kSystemMemory,
base::BindOnce(
[](std::unique_ptr<CopyOutputResult>* result_out,
base::OnceClosure quit_closure,
std::unique_ptr<CopyOutputResult> tmp_result) {
*result_out = std::move(tmp_result);
std::move(quit_closure).Run();
},
&result, run_loop.QuitClosure()));
request->set_result_task_runner(
TestGpuServiceHolder::GetInstance()->gpu_main_thread_task_runner());
copy_output::RenderPassGeometry geometry;
geometry.result_bounds = output_rect;
geometry.result_selection = output_rect;
geometry.sampling_bounds = output_rect;
geometry.readback_offset = gfx::Vector2d(0, 0);
base::OnceCallback<void(gfx::GpuFenceHandle)> return_release_fence_cb;
PaintRootRenderPass(kSurfaceRect, base::DoNothing(),
std::move(return_release_fence_cb));
output_surface_->CopyOutput(geometry, color_space, std::move(request),
gpu::Mailbox());
output_surface_->SwapBuffersSkipped(kSurfaceRect);
output_surface_->Flush();
run_loop.Run();
EXPECT_EQ(gfx::ColorSpace::CreateSRGB(), result->GetRGBAColorSpace());
}
} // namespace viz
|