1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/api/declarative_net_request/file_sequence_helper.h"
#include <algorithm>
#include <cstdint>
#include <set>
#include <utility>
#include <vector>
#include "base/barrier_closure.h"
#include "base/check_op.h"
#include "base/containers/contains.h"
#include "base/files/file_util.h"
#include "base/files/important_file_writer.h"
#include "base/functional/bind.h"
#include "base/memory/ref_counted.h"
#include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h"
#include "base/notreached.h"
#include "base/strings/string_number_conversions.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "extensions/browser/api/declarative_net_request/constants.h"
#include "extensions/browser/api/declarative_net_request/parse_info.h"
#include "extensions/browser/api/declarative_net_request/rule_counts.h"
#include "extensions/browser/api/declarative_net_request/utils.h"
#include "extensions/browser/extension_file_task_runner.h"
#include "extensions/common/api/declarative_net_request.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/extension_features.h"
#include "services/data_decoder/public/cpp/data_decoder.h"
namespace extensions::declarative_net_request {
namespace {
namespace dnr_api = extensions::api::declarative_net_request;
// A class to help in indexing multiple rulesets.
// TODO(crbug.com/40794487): Look into unifying this with the InstallIndexHelper
// class, moving any differing logic to the clients.
class IndexHelper : public base::RefCountedThreadSafe<IndexHelper> {
public:
using IndexCallback = base::OnceCallback<void(LoadRequestData)>;
IndexHelper(LoadRequestData data, IndexCallback callback)
: data_(std::move(data)), callback_(std::move(callback)) {}
IndexHelper(const IndexHelper&) = delete;
IndexHelper& operator=(const IndexHelper&) = delete;
// Starts indexing rulesets. Must be called on the extension file task runner.
// TODO(crbug.com/380434972): Kick off content verification job to guard
// against the possibility that the extension's ruleset JSON files were
// corrupted.
void Start(uint8_t parse_flags) {
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
std::vector<RulesetInfo*> rulesets_to_index;
for (auto& ruleset : data_.rulesets) {
if (ruleset.did_load_successfully()) {
continue;
}
rulesets_to_index.push_back(&ruleset);
}
// `done_closure` will be invoked once `barrier_closure` is run
// `rulesets_to_index.size()` times.
base::OnceClosure done_closure =
base::BindOnce(&IndexHelper::OnAllRulesetsIndexed, this);
base::RepeatingClosure barrier_closure =
base::BarrierClosure(rulesets_to_index.size(), std::move(done_closure));
// Post tasks to index individual rulesets.
for (RulesetInfo* ruleset : rulesets_to_index) {
auto callback = base::BindOnce(&IndexHelper::OnIndexCompleted, this,
ruleset, barrier_closure);
ruleset->source().IndexAndPersistJSONRuleset(&decoder_, parse_flags,
std::move(callback));
}
}
private:
friend class base::RefCountedThreadSafe<IndexHelper>;
~IndexHelper() = default;
// Callback invoked when indexing of all rulesets is completed.
void OnAllRulesetsIndexed() {
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
// Our job is done.
std::move(callback_).Run(std::move(data_));
}
// Callback invoked when a single ruleset is indexed.
void OnIndexCompleted(RulesetInfo* ruleset,
base::OnceClosure done_closure,
IndexAndPersistJSONRulesetResult result) {
using IndexStatus = IndexAndPersistJSONRulesetResult::Status;
DCHECK(ruleset);
bool indexing_success = result.status == IndexStatus::kSuccess;
bool is_reindexing = ruleset->expected_checksum().has_value();
if (indexing_success) {
// Update the checksum if either:
// - this is the first time that the ruleset is being indexed and there's
// no expected checksum.
// - there is a checksum mismatch between indexing and what's in prefs.
// Use the checksum that was just derived from reindexing.
// - the ruleset's version has updated, so the old checksum is invalid
bool update_checksum = !is_reindexing ||
ruleset->load_ruleset_result() ==
LoadRulesetResult::kErrorChecksumMismatch ||
ruleset->load_ruleset_result() ==
LoadRulesetResult::kErrorVersionMismatch;
if (update_checksum) {
ruleset->set_new_checksum(result.ruleset_checksum);
// Also change the `expected_checksum` so that any subsequent load
// succeeds.
ruleset->set_expected_checksum(result.ruleset_checksum);
} else {
// Otherwise, the checksum of the re-indexed ruleset should match the
// expected checksum. If this is not the case, then there is some other
// issue (like the JSON rules file has been modified from the one used
// during installation or preferences are corrupted). But taking care of
// these is beyond our scope here, so simply signal a failure.
indexing_success =
ruleset->expected_checksum() == result.ruleset_checksum;
}
}
ruleset->set_indexing_successful(indexing_success);
if (is_reindexing) {
UMA_HISTOGRAM_BOOLEAN(
"Extensions.DeclarativeNetRequest.RulesetReindexSuccessful",
indexing_success);
}
std::move(done_closure).Run();
}
LoadRequestData data_;
IndexCallback callback_;
// We use a single shared Data Decoder service instance to process all of the
// rulesets for this IndexHelper.
data_decoder::DataDecoder decoder_;
};
UpdateDynamicRulesStatus GetUpdateDynamicRuleStatus(LoadRulesetResult result) {
switch (result) {
case LoadRulesetResult::kSuccess:
break;
case LoadRulesetResult::kErrorInvalidPath:
return UpdateDynamicRulesStatus::kErrorCreateMatcher_InvalidPath;
case LoadRulesetResult::kErrorCannotReadFile:
return UpdateDynamicRulesStatus::kErrorCreateMatcher_FileReadError;
case LoadRulesetResult::kErrorChecksumMismatch:
return UpdateDynamicRulesStatus::kErrorCreateMatcher_ChecksumMismatch;
case LoadRulesetResult::kErrorVersionMismatch:
return UpdateDynamicRulesStatus::kErrorCreateMatcher_VersionMismatch;
case LoadRulesetResult::kErrorChecksumNotFound:
// Updating dynamic rules shouldn't require looking up checksum from
// prefs.
break;
}
NOTREACHED();
}
// Helper to create the new list of dynamic rules. Returns false on failure and
// populates |error| and |status|.
bool GetNewDynamicRules(const FileBackedRulesetSource& source,
std::vector<int> rule_ids_to_remove,
std::vector<dnr_api::Rule> rules_to_add,
const RuleCounts& rule_limit,
std::vector<dnr_api::Rule>* new_rules,
std::string* error,
UpdateDynamicRulesStatus* status) {
DCHECK(new_rules);
DCHECK(error);
DCHECK(status);
// Read the current set of rules. Note: this is trusted JSON and hence it is
// ok to parse in the browser itself.
ReadJSONRulesResult result = source.ReadJSONRulesUnsafe();
LogReadDynamicRulesStatus(result.status);
DCHECK(result.status == ReadJSONRulesResult::Status::kSuccess ||
result.rules.empty());
// Possible cases:
// - kSuccess
// - kFileDoesNotExist: This can happen when persisting dynamic rules for the
// first time.
// - kFileReadError: Throw an internal error.
// - kJSONParseError, kJSONIsNotList: These denote JSON ruleset corruption.
// Assume the current set of rules is empty.
if (result.status == ReadJSONRulesResult::Status::kFileReadError) {
*status = UpdateDynamicRulesStatus::kErrorReadJSONRules;
*error = kInternalErrorUpdatingDynamicRules;
return false;
}
*new_rules = std::move(result.rules);
// Remove old rules
std::set<int> ids_to_remove(rule_ids_to_remove.begin(), rule_ids_to_remove.end());
std::erase_if(*new_rules, [&ids_to_remove](const dnr_api::Rule& rule) {
return base::Contains(ids_to_remove, rule.id);
});
// Add new rules
new_rules->insert(new_rules->end(),
std::make_move_iterator(rules_to_add.begin()),
std::make_move_iterator(rules_to_add.end()));
if (new_rules->size() > rule_limit.rule_count) {
*status = UpdateDynamicRulesStatus::kErrorRuleCountExceeded;
*error = kDynamicRuleCountExceeded;
return false;
}
if (base::FeatureList::IsEnabled(
extensions_features::kDeclarativeNetRequestSafeRuleLimits)) {
size_t unsafe_rule_count = std::ranges::count_if(
*new_rules,
[](const dnr_api::Rule& rule) { return !IsRuleSafe(rule); });
if (unsafe_rule_count > rule_limit.unsafe_rule_count) {
*status = UpdateDynamicRulesStatus::kErrorUnsafeRuleCountExceeded;
*error = kDynamicUnsafeRuleCountExceeded;
return false;
}
}
size_t regex_rule_count = std::ranges::count_if(
*new_rules,
[](const dnr_api::Rule& rule) { return !!rule.condition.regex_filter; });
if (regex_rule_count > rule_limit.regex_rule_count) {
*status = UpdateDynamicRulesStatus::kErrorRegexRuleCountExceeded;
*error = kDynamicRegexRuleCountExceeded;
return false;
}
return true;
}
// Returns true on success and populates |ruleset_checksum|. Returns false on
// failure and populates |error| and |status|.
bool UpdateAndIndexDynamicRules(const FileBackedRulesetSource& source,
std::vector<int> rule_ids_to_remove,
std::vector<dnr_api::Rule> rules_to_add,
const RuleCounts& rule_limit,
int* ruleset_checksum,
std::string* error,
UpdateDynamicRulesStatus* status) {
DCHECK(ruleset_checksum);
DCHECK(error);
DCHECK(status);
// Dynamic JSON and indexed rulesets for an extension are stored in the same
// directory.
DCHECK_EQ(source.indexed_path().DirName(), source.json_path().DirName());
std::set<int> rule_ids_to_add;
for (const dnr_api::Rule& rule : rules_to_add) {
rule_ids_to_add.insert(rule.id);
}
std::vector<dnr_api::Rule> new_rules;
if (!GetNewDynamicRules(source, std::move(rule_ids_to_remove),
std::move(rules_to_add), rule_limit, &new_rules,
error, status)) {
return false; // |error| and |status| already populated.
}
// Serialize rules to JSON.
std::string json;
if (!source.SerializeRulesToJSON(new_rules, &json)) {
*error = kInternalErrorUpdatingDynamicRules;
*status = UpdateDynamicRulesStatus::kErrorSerializeToJson;
return false;
}
// Index rules.
auto parse_flags = RulesetSource::kRaiseErrorOnInvalidRules |
RulesetSource::kRaiseWarningOnLargeRegexRules;
ParseInfo info = source.IndexRules(std::move(new_rules), parse_flags);
if (info.has_error()) {
*error = info.error();
*status = UpdateDynamicRulesStatus::kErrorInvalidRules;
return false;
}
// Treat rules which exceed the regex memory limit as errors if these are new
// rules. Just surface an error for the first such rule.
for (const auto& warning : info.rule_ignored_warnings()) {
if (!base::Contains(rule_ids_to_add, warning.rule_id)) {
// Any rule added earlier which is ignored now (say due to exceeding the
// regex memory limit), will be silently ignored.
// TODO(crbug.com/40118204): Notify the extension about the same.
continue;
}
*error = warning.message;
*status = UpdateDynamicRulesStatus::kErrorRegexTooLarge;
return false;
}
// Ensure that the destination directory exists.
if (!base::CreateDirectory(source.indexed_path().DirName())) {
*error = kInternalErrorUpdatingDynamicRules;
*status = UpdateDynamicRulesStatus::kErrorCreateDynamicRulesDirectory;
return false;
}
// Persist indexed ruleset. Use `ImportantFileWriter` to make this atomic and
// decrease the likelihood of file corruption.
if (!base::ImportantFileWriter::WriteFileAtomically(
source.indexed_path(), GetIndexedRulesetData(info.GetBuffer()),
"DNRDynamicRulesFlatbuffer")) {
// If this fails, we might have corrupted the existing indexed ruleset file.
// However the JSON source of truth hasn't been modified. The next time the
// extension is loaded, the indexed ruleset will fail checksum verification
// leading to reindexing of the JSON ruleset.
*error = kInternalErrorUpdatingDynamicRules;
*status = UpdateDynamicRulesStatus::kErrorWriteFlatbuffer;
return false;
}
// Persist JSON. Since the JSON ruleset is the source of truth, use
// `ImportantFileWriter` to make this atomic and decrease the likelihood of
// file corruption.
if (!base::ImportantFileWriter::WriteFileAtomically(
source.json_path(), json, "DNRDynamicRulesetJson")) {
// We have entered into an inconsistent state where the indexed ruleset was
// updated but not the JSON ruleset. This should be extremely rare. However
// if we get here, the next time the extension is loaded, we'll identify
// that the indexed ruleset checksum is inconsistent and re-index the JSON
// ruleset.
// If the JSON ruleset is corrupted here though, loading the dynamic ruleset
// subsequently will fail. A call by extension to `updateDynamicRules`
// should help it start from a clean slate in this case (See
// `GetNewDynamicRules` above).
*error = kInternalErrorUpdatingDynamicRules;
*status = UpdateDynamicRulesStatus::kErrorWriteJson;
return false;
}
*ruleset_checksum = info.ruleset_checksum();
return true;
}
} // namespace
RulesetInfo::RulesetInfo(FileBackedRulesetSource source)
: source_(std::move(source)) {}
RulesetInfo::~RulesetInfo() = default;
RulesetInfo::RulesetInfo(RulesetInfo&&) = default;
RulesetInfo& RulesetInfo::operator=(RulesetInfo&&) = default;
std::unique_ptr<RulesetMatcher> RulesetInfo::TakeMatcher() {
DCHECK(did_load_successfully());
return std::move(matcher_);
}
const std::optional<LoadRulesetResult>& RulesetInfo::load_ruleset_result()
const {
// |matcher_| is valid only on success.
DCHECK_EQ(load_ruleset_result_ == LoadRulesetResult::kSuccess, !!matcher_);
return load_ruleset_result_;
}
void RulesetInfo::CreateVerifiedMatcher() {
DCHECK(expected_checksum_);
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
// Ensure we aren't calling this redundantly. If did_load_successfully()
// returns true, we should already have a valid RulesetMatcher.
DCHECK(!did_load_successfully());
load_ruleset_result_ =
source_.CreateVerifiedMatcher(*expected_checksum_, &matcher_);
}
LoadRequestData::LoadRequestData(ExtensionId extension_id,
base::Version extension_version,
LoadRulesetRequestSource request_source)
: extension_id(std::move(extension_id)),
extension_version(std::move(extension_version)),
request_source(request_source) {}
LoadRequestData::~LoadRequestData() = default;
LoadRequestData::LoadRequestData(LoadRequestData&&) = default;
LoadRequestData& LoadRequestData::operator=(LoadRequestData&&) = default;
FileSequenceHelper::FileSequenceHelper() = default;
FileSequenceHelper::~FileSequenceHelper() {
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
}
void FileSequenceHelper::LoadRulesets(
LoadRequestData load_data,
LoadRulesetsUICallback ui_callback) const {
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
bool success = true;
for (auto& ruleset : load_data.rulesets) {
if (!ruleset.expected_checksum()) {
// This ruleset hasn't been indexed yet.
success = false;
continue;
}
ruleset.CreateVerifiedMatcher();
success &= ruleset.did_load_successfully();
}
if (success) {
// Set priority explicitly to avoid unwanted task priority inheritance.
content::GetUIThreadTaskRunner({base::TaskPriority::USER_BLOCKING})
->PostTask(FROM_HERE, base::BindOnce(std::move(ui_callback),
std::move(load_data)));
return;
}
// Not all rulesets were loaded. This can be because some rulesets haven't
// been indexed previously or because indexing failed for a ruleset. Try
// indexing these rulesets now.
// Ignore invalid static rules during deferred indexing or while re-indexing.
auto parse_flags = RulesetSource::kNone;
// Using a WeakPtr is safe since `index_callback` will be called on this
// sequence itself.
auto index_callback =
base::BindOnce(&FileSequenceHelper::OnRulesetsIndexed,
weak_factory_.GetWeakPtr(), std::move(ui_callback));
auto index_helper = base::MakeRefCounted<IndexHelper>(
std::move(load_data), std::move(index_callback));
index_helper->Start(parse_flags);
}
void FileSequenceHelper::UpdateDynamicRules(
LoadRequestData load_data,
std::vector<int> rule_ids_to_remove,
std::vector<api::declarative_net_request::Rule> rules_to_add,
const RuleCounts& rule_limit,
UpdateDynamicRulesUICallback ui_callback) const {
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
DCHECK_EQ(1u, load_data.rulesets.size());
RulesetInfo& dynamic_ruleset = load_data.rulesets[0];
DCHECK(!dynamic_ruleset.expected_checksum());
auto log_status_and_dispatch_callback = [&ui_callback, &load_data](
std::optional<std::string> error,
UpdateDynamicRulesStatus status) {
base::UmaHistogramEnumeration(kUpdateDynamicRulesStatusHistogram, status);
// Set priority explicitly to avoid unwanted task priority inheritance.
content::GetUIThreadTaskRunner({base::TaskPriority::USER_BLOCKING})
->PostTask(FROM_HERE,
base::BindOnce(std::move(ui_callback), std::move(load_data),
std::move(error)));
};
int new_ruleset_checksum = -1;
std::string error;
UpdateDynamicRulesStatus status = UpdateDynamicRulesStatus::kSuccess;
if (!UpdateAndIndexDynamicRules(dynamic_ruleset.source(),
std::move(rule_ids_to_remove),
std::move(rules_to_add), rule_limit,
&new_ruleset_checksum, &error, &status)) {
DCHECK(!error.empty());
log_status_and_dispatch_callback(std::move(error), status);
return;
}
DCHECK_EQ(UpdateDynamicRulesStatus::kSuccess, status);
dynamic_ruleset.set_expected_checksum(new_ruleset_checksum);
dynamic_ruleset.set_new_checksum(new_ruleset_checksum);
dynamic_ruleset.CreateVerifiedMatcher();
DCHECK(dynamic_ruleset.load_ruleset_result());
if (!dynamic_ruleset.did_load_successfully()) {
status = GetUpdateDynamicRuleStatus(*dynamic_ruleset.load_ruleset_result());
log_status_and_dispatch_callback(kInternalErrorUpdatingDynamicRules,
status);
return;
}
// Success.
log_status_and_dispatch_callback(std::nullopt, status);
}
void FileSequenceHelper::OnRulesetsIndexed(LoadRulesetsUICallback ui_callback,
LoadRequestData load_data) const {
DCHECK(GetExtensionFileTaskRunner()->RunsTasksInCurrentSequence());
// Load rulesets for which indexing succeeded.
for (auto& ruleset : load_data.rulesets) {
if (ruleset.indexing_successful().value_or(false)) {
// Only rulesets which weren't indexed previously or for which loading
// failed are being indexed.
DCHECK(!ruleset.did_load_successfully());
ruleset.CreateVerifiedMatcher();
}
}
// The UI thread will handle success or failure.
content::GetUIThreadTaskRunner({base::TaskPriority::USER_BLOCKING})
->PostTask(FROM_HERE,
base::BindOnce(std::move(ui_callback), std::move(load_data)));
}
} // namespace extensions::declarative_net_request
|