1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/api/storage/storage_api.h"
#include <stdint.h>
#include <limits>
#include <memory>
#include <set>
#include "base/command_line.h"
#include "base/containers/contains.h"
#include "base/files/file_path.h"
#include "base/functional/bind.h"
#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/strings/stringprintf.h"
#include "base/test/bind.h"
#include "components/crx_file/id_util.h"
#include "components/value_store/leveldb_value_store.h"
#include "components/value_store/value_store.h"
#include "components/value_store/value_store_factory_impl.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
#include "extensions/browser/api/extensions_api_client.h"
#include "extensions/browser/api/storage/settings_storage_quota_enforcer.h"
#include "extensions/browser/api/storage/settings_test_util.h"
#include "extensions/browser/api/storage/storage_frontend.h"
#include "extensions/browser/api/storage/value_store_cache.h"
#include "extensions/browser/api_test_utils.h"
#include "extensions/browser/api_unittest.h"
#include "extensions/browser/event_router.h"
#include "extensions/browser/event_router_factory.h"
#include "extensions/browser/extension_function.h"
#include "extensions/browser/test_event_router_observer.h"
#include "extensions/browser/test_extensions_browser_client.h"
#include "extensions/common/api/storage.h"
#include "extensions/common/manifest.h"
#include "third_party/leveldatabase/src/include/leveldb/db.h"
#include "third_party/leveldatabase/src/include/leveldb/write_batch.h"
namespace extensions {
namespace {
// Caller owns the returned object.
std::unique_ptr<KeyedService> CreateStorageFrontendForTesting(
content::BrowserContext* context) {
scoped_refptr<value_store::ValueStoreFactory> factory =
new value_store::ValueStoreFactoryImpl(context->GetPath());
return StorageFrontend::CreateForTesting(factory, context);
}
std::unique_ptr<KeyedService> BuildEventRouter(
content::BrowserContext* context) {
return std::make_unique<extensions::EventRouter>(context, nullptr);
}
} // namespace
class StorageApiUnittest : public ApiUnitTest {
public:
StorageApiUnittest() = default;
~StorageApiUnittest() override = default;
protected:
void SetUp() override {
ApiUnitTest::SetUp();
EventRouterFactory::GetInstance()->SetTestingFactory(
browser_context(), base::BindRepeating(&BuildEventRouter));
// Ensure a StorageFrontend can be created on demand. The StorageFrontend
// will be owned by the KeyedService system.
StorageFrontend::GetFactoryInstance()->SetTestingFactory(
browser_context(),
base::BindRepeating(&CreateStorageFrontendForTesting));
render_process_host_ =
std::make_unique<content::MockRenderProcessHost>(browser_context());
}
void TearDown() override {
render_process_host_.reset();
ApiUnitTest::TearDown();
}
content::RenderProcessHost* render_process_host() const {
return render_process_host_.get();
}
// Runs the storage.set() API function with local storage.
void RunSetFunction(const std::string& key, const std::string& value) {
RunFunction(
new StorageStorageAreaSetFunction(),
base::StringPrintf(
"[\"local\", {\"%s\": \"%s\"}]", key.c_str(), value.c_str()));
}
// Runs the storage.get() API function with the local storage, and populates
// |out_value| with the string result.
testing::AssertionResult RunGetFunction(const std::string& key,
std::string* out_value) {
std::optional<base::Value> result = RunFunctionAndReturnValue(
new StorageStorageAreaGetFunction(),
base::StringPrintf("[\"local\", \"%s\"]", key.c_str()));
if (!result) {
return testing::AssertionFailure() << "No result";
}
const base::Value::Dict* dict = result->GetIfDict();
if (!dict) {
return testing::AssertionFailure() << *result << " was not a dictionary.";
}
const std::string* dict_value = dict->FindString(key);
if (!dict_value) {
return testing::AssertionFailure() << " could not retrieve a string from"
<< dict << " at " << key;
}
*out_value = *dict_value;
return testing::AssertionSuccess();
}
ExtensionsAPIClient extensions_api_client_;
std::unique_ptr<content::RenderProcessHost> render_process_host_;
};
TEST_F(StorageApiUnittest, RestoreCorruptedStorage) {
const char kKey[] = "key";
const char kValue[] = "value";
std::string result;
// Do a simple set/get combo to make sure the API works.
RunSetFunction(kKey, kValue);
EXPECT_TRUE(RunGetFunction(kKey, &result));
EXPECT_EQ(kValue, result);
// Corrupt the store. This is not as pretty as ideal, because we use knowledge
// of the underlying structure, but there's no real good way to corrupt a
// store other than directly modifying the files.
value_store::ValueStore* store =
settings_test_util::GetStorage(extension_ref(), settings_namespace::LOCAL,
StorageFrontend::Get(browser_context()));
ASSERT_TRUE(store);
// TODO(cmumford): Modify test as this requires that the factory always
// creates instances of LeveldbValueStore.
SettingsStorageQuotaEnforcer* quota_store =
static_cast<SettingsStorageQuotaEnforcer*>(store);
value_store::LeveldbValueStore* leveldb_store =
static_cast<value_store::LeveldbValueStore*>(
quota_store->get_delegate_for_test());
leveldb::WriteBatch batch;
batch.Put(kKey, "[{(.*+\"\'\\");
EXPECT_TRUE(leveldb_store->WriteToDbForTest(&batch));
EXPECT_TRUE(leveldb_store->Get(kKey).status().IsCorrupted());
// Running another set should end up working (even though it will restore the
// store behind the scenes).
RunSetFunction(kKey, kValue);
EXPECT_TRUE(RunGetFunction(kKey, &result));
EXPECT_EQ(kValue, result);
}
TEST_F(StorageApiUnittest, StorageAreaOnChanged) {
TestEventRouterObserver event_observer(EventRouter::Get(browser_context()));
EventRouter* event_router = EventRouter::Get(browser_context());
event_router->AddEventListener(api::storage::OnChanged::kEventName,
render_process_host(), extension()->id());
event_router->AddEventListener("storage.local.onChanged",
render_process_host(), extension()->id());
RunSetFunction("key", "value");
EXPECT_EQ(2u, event_observer.events().size());
EXPECT_TRUE(base::Contains(event_observer.events(),
api::storage::OnChanged::kEventName));
EXPECT_TRUE(
base::Contains(event_observer.events(), "storage.local.onChanged"));
}
// Test that no event is dispatched if no listener is added.
TEST_F(StorageApiUnittest, StorageAreaOnChangedNoListener) {
TestEventRouterObserver event_observer(EventRouter::Get(browser_context()));
RunSetFunction("key", "value");
EXPECT_EQ(0u, event_observer.events().size());
}
// Test that no event is dispatched if a listener for a different extension is
// added.
TEST_F(StorageApiUnittest, StorageAreaOnChangedOtherListener) {
TestEventRouterObserver event_observer(EventRouter::Get(browser_context()));
EventRouter* event_router = EventRouter::Get(browser_context());
std::string other_listener_id =
crx_file::id_util::GenerateId("other-listener");
event_router->AddEventListener(api::storage::OnChanged::kEventName,
render_process_host(), other_listener_id);
event_router->AddEventListener("storage.local.onChanged",
render_process_host(), other_listener_id);
RunSetFunction("key", "value");
EXPECT_EQ(0u, event_observer.events().size());
}
TEST_F(StorageApiUnittest, StorageAreaOnChangedOnlyOneListener) {
TestEventRouterObserver event_observer(EventRouter::Get(browser_context()));
EventRouter* event_router = EventRouter::Get(browser_context());
event_router->AddEventListener(api::storage::OnChanged::kEventName,
render_process_host(), extension()->id());
RunSetFunction("key", "value");
EXPECT_EQ(1u, event_observer.events().size());
EXPECT_TRUE(base::Contains(event_observer.events(),
api::storage::OnChanged::kEventName));
}
// This is a regression test for crbug.com/1483828.
TEST_F(StorageApiUnittest, GetBytesInUseIntOverflow) {
// A fake value store that only implements the overloads of GetBytesInUse().
class FakeValueStore : public value_store::ValueStore {
public:
explicit FakeValueStore(size_t bytes_in_use)
: bytes_in_use_(bytes_in_use) {}
size_t GetBytesInUse(const std::string& key) override {
return bytes_in_use_;
}
size_t GetBytesInUse(const std::vector<std::string>& keys) override {
return bytes_in_use_;
}
size_t GetBytesInUse() override { return bytes_in_use_; }
ReadResult GetKeys() override { NOTREACHED(); }
ReadResult Get(const std::string& key) override { NOTREACHED(); }
ReadResult Get(const std::vector<std::string>& keys) override {
NOTREACHED();
}
ReadResult Get() override { NOTREACHED(); }
WriteResult Set(WriteOptions options,
const std::string& key,
const base::Value& value) override {
NOTREACHED();
}
WriteResult Set(WriteOptions options,
const base::Value::Dict& values) override {
NOTREACHED();
}
WriteResult Remove(const std::string& key) override { NOTREACHED(); }
WriteResult Remove(const std::vector<std::string>& keys) override {
NOTREACHED();
}
WriteResult Clear() override { NOTREACHED(); }
private:
size_t bytes_in_use_ = 0;
};
// Create a fake ValueStoreCache that we can assign to a storage area in the
// StorageFrontend. This allows us to call StorageFrontend using an extension
// API and access our mock ValueStore.
class FakeValueStoreCache : public ValueStoreCache {
public:
explicit FakeValueStoreCache(FakeValueStore store) : store_(store) {}
// ValueStoreCache:
void ShutdownOnUI() override {}
void RunWithValueStoreForExtension(
FakeValueStoreCache::StorageCallback callback,
scoped_refptr<const Extension> extension) override {
std::move(callback).Run(&store_);
}
void DeleteStorageSoon(const ExtensionId& extension_id) override {}
private:
FakeValueStore store_;
};
static constexpr struct TestCase {
size_t bytes_in_use;
double result;
} test_cases[] = {
{1, 1.0},
{std::numeric_limits<int>::max(), std::numeric_limits<int>::max()},
// Test the overflow case from the bug. It's enough to have a value
// that exceeds the max value that an int can represent.
{static_cast<size_t>(std::numeric_limits<int>::max()) + 1,
static_cast<size_t>(std::numeric_limits<int>::max()) + 1}};
StorageFrontend* frontend = StorageFrontend::Get(browser_context());
for (const auto& test_case : test_cases) {
FakeValueStore value_store(test_case.bytes_in_use);
frontend->SetCacheForTesting(
settings_namespace::Namespace::LOCAL,
std::make_unique<FakeValueStoreCache>(value_store));
auto function =
base::MakeRefCounted<StorageStorageAreaGetBytesInUseFunction>();
function->set_extension(extension());
std::optional<base::Value> result =
api_test_utils::RunFunctionAndReturnSingleResult(
function.get(),
base::Value::List().Append("local").Append(base::Value()),
browser_context());
ASSERT_TRUE(result);
ASSERT_TRUE(result->is_double());
EXPECT_EQ(test_case.result, result->GetDouble());
frontend->DisableStorageForTesting(settings_namespace::Namespace::LOCAL);
}
}
} // namespace extensions
|