1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/common/manifest_handler_helpers.h"
#include <stddef.h>
#include <optional>
#include <string>
#include <string_view>
#include "base/check.h"
#include "base/feature_list.h"
#include "base/files/file_path.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/values.h"
#include "extensions/common/constants.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/icons/extension_icon_set.h"
#include "extensions/common/manifest_constants.h"
#include "net/base/mime_util.h"
#include "third_party/blink/public/common/mime_util/mime_util.h"
namespace extensions {
namespace errors = manifest_errors;
namespace manifest_handler_helpers {
namespace {
BASE_FEATURE(kValidateIconMimeType,
"ValidateIconMimeType",
base::FEATURE_ENABLED_BY_DEFAULT);
}
std::vector<std::string_view> TokenizeDictionaryPath(std::string_view path) {
return base::SplitStringPiece(path, ".", base::TRIM_WHITESPACE,
base::SPLIT_WANT_ALL);
}
bool NormalizeAndValidatePath(std::string* path) {
return NormalizeAndValidatePath(*path, path);
}
bool NormalizeAndValidatePath(const std::string& path,
std::string* normalized_path) {
size_t first_non_slash = path.find_first_not_of('/');
if (first_non_slash == std::string::npos) {
*normalized_path = "";
return false;
}
*normalized_path = path.substr(first_non_slash);
return true;
}
std::optional<int> LoadValidSizeFromString(const std::string& string_size) {
int size = 0;
bool is_valid = base::StringToInt(string_size, &size) && size > 0 &&
size <= extension_misc::EXTENSION_ICON_GIGANTOR * 4;
return is_valid ? std::make_optional(size) : std::nullopt;
}
bool LoadIconsFromDictionary(const base::Value::Dict& icons_value,
ExtensionIconSet* icons,
std::u16string* error,
std::vector<std::string>* warnings) {
DCHECK(icons);
DCHECK(error);
for (auto entry : icons_value) {
std::optional<int> size = LoadValidSizeFromString(entry.first);
if (!size.has_value()) {
*error = ErrorUtils::FormatErrorMessageUTF16(errors::kInvalidIconKey,
entry.first);
return false;
}
std::string icon_path;
if (!entry.second.is_string() ||
!NormalizeAndValidatePath(entry.second.GetString(), &icon_path)) {
*error = ErrorUtils::FormatErrorMessageUTF16(errors::kInvalidIconPath,
entry.first);
return false;
}
if (!IsIconMimeTypeValid(base::FilePath::FromUTF8Unsafe(icon_path))) {
// Issue a warning and ignore this file. This is a warning and not a
// hard-error to preserve both backwards compatibility and potential
// future-compatibility if mime types change.
warnings->emplace_back(ErrorUtils::FormatErrorMessage(
errors::kInvalidIconMimeType, entry.first));
continue;
}
icons->Add(size.value(), icon_path);
}
return true;
}
bool IsSupportedExtensionImageMimeType(const base::FilePath& relative_path) {
std::string mime_type;
if (!net::GetWellKnownMimeTypeFromFile(relative_path, &mime_type)) {
return false;
}
// SVG is text-based XML, even though it has an "image/" type. Allow it
// explicitly.
constexpr char kSvgMimeType[] = "image/svg+xml";
return blink::IsSupportedImageMimeType(mime_type) ||
mime_type == kSvgMimeType;
}
bool IsIconMimeTypeValid(const base::FilePath& relative_path) {
// TODO(crbug.com/40059598): Remove this if-check and always validate the mime
// type in M140.
if (!base::FeatureList::IsEnabled(kValidateIconMimeType)) {
return true;
}
return IsSupportedExtensionImageMimeType(relative_path);
}
} // namespace manifest_handler_helpers
} // namespace extensions
|
