1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/common/manifest_handlers/app_display_info.h"
#include "base/values.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest.h"
#include "extensions/common/manifest_constants.h"
namespace extensions {
namespace keys = manifest_keys;
namespace errors = manifest_errors;
namespace {
// This info is used for both the kDisplayInLauncher and kDisplayInNewTabPage
// keys, but we just arbitrarily pick one to store it under in the manifest.
const char* kAppDisplayInfoKey = keys::kDisplayInLauncher;
AppDisplayInfo* GetAppDisplayInfo(const Extension& extension) {
auto* info = static_cast<AppDisplayInfo*>(
extension.GetManifestData(kAppDisplayInfoKey));
DCHECK(!info || extension.is_app())
<< "Only apps are allowed to be displayed in the NTP or launcher.";
return info;
}
} // namespace
AppDisplayInfo::AppDisplayInfo(bool display_in_launcher,
bool display_in_new_tab_page)
: display_in_launcher_(display_in_launcher),
display_in_new_tab_page_(display_in_new_tab_page) {}
AppDisplayInfo::~AppDisplayInfo() = default;
bool AppDisplayInfo::RequiresSortOrdinal(const Extension& extension) {
AppDisplayInfo* info = GetAppDisplayInfo(extension);
return info && (info->display_in_launcher_ || info->display_in_new_tab_page_);
}
bool AppDisplayInfo::ShouldDisplayInAppLauncher(const Extension& extension) {
AppDisplayInfo* info = GetAppDisplayInfo(extension);
return info && info->display_in_launcher_;
}
bool AppDisplayInfo::ShouldDisplayInNewTabPage(const Extension& extension) {
AppDisplayInfo* info = GetAppDisplayInfo(extension);
return info && info->display_in_new_tab_page_;
}
AppDisplayManifestHandler::AppDisplayManifestHandler() = default;
AppDisplayManifestHandler::~AppDisplayManifestHandler() = default;
bool AppDisplayManifestHandler::Parse(Extension* extension,
std::u16string* error) {
bool display_in_launcher = true;
bool display_in_new_tab_page = true;
const Manifest* manifest = extension->manifest();
if (const base::Value* value = manifest->FindKey(keys::kDisplayInLauncher)) {
if (!value->is_bool()) {
*error = errors::kInvalidDisplayInLauncher;
return false;
}
display_in_launcher = value->GetBool();
}
if (const base::Value* value =
manifest->FindKey(keys::kDisplayInNewTabPage)) {
if (!value->is_bool()) {
*error = errors::kInvalidDisplayInNewTabPage;
return false;
}
display_in_new_tab_page = value->GetBool();
} else {
// Inherit default from display_in_launcher property.
display_in_new_tab_page = display_in_launcher;
}
extension->SetManifestData(kAppDisplayInfoKey,
std::make_unique<AppDisplayInfo>(
display_in_launcher, display_in_new_tab_page));
return true;
}
base::span<const char* const> AppDisplayManifestHandler::Keys() const {
static constexpr const char* kKeys[] = {keys::kDisplayInLauncher,
keys::kDisplayInNewTabPage};
return kKeys;
}
bool AppDisplayManifestHandler::AlwaysParseForType(Manifest::Type type) const {
// Always parse for app types; this ensures that apps default to being
// displayed in the proper surfaces.
return type == Manifest::TYPE_LEGACY_PACKAGED_APP ||
type == Manifest::TYPE_HOSTED_APP ||
type == Manifest::TYPE_PLATFORM_APP;
}
} // namespace extensions
|
