1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/shell/browser/shell_desktop_controller_aura.h"
#include <memory>
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/bind.h"
#include "base/time/time.h"
#include "components/keep_alive_registry/keep_alive_registry.h"
#include "extensions/browser/app_window/app_window.h"
#include "extensions/browser/app_window/app_window_registry.h"
#include "extensions/browser/browsertest_util.h"
#include "extensions/shell/browser/desktop_controller.h"
#include "extensions/shell/test/shell_apitest.h"
#include "extensions/test/result_catcher.h"
namespace extensions {
// Tests that spin up the ShellDesktopControllerAura and run async tasks like
// launching and reloading apps.
class ShellDesktopControllerAuraBrowserTest : public ShellApiTest {
public:
ShellDesktopControllerAuraBrowserTest() = default;
~ShellDesktopControllerAuraBrowserTest() override = default;
ShellDesktopControllerAuraBrowserTest(
const ShellDesktopControllerAuraBrowserTest&) = delete;
ShellDesktopControllerAuraBrowserTest& operator=(
const ShellDesktopControllerAuraBrowserTest&) = delete;
// Loads and launches a platform app that opens an app window.
void LoadAndLaunchApp() {
ASSERT_FALSE(app_);
app_ = LoadApp("platform_app");
ASSERT_TRUE(app_);
// Wait for app window to load.
ResultCatcher catcher;
EXPECT_TRUE(catcher.GetNextResult());
// A window was created.
EXPECT_EQ(1u,
AppWindowRegistry::Get(browser_context())->app_windows().size());
}
protected:
// Returns an open app window.
AppWindow* GetAppWindow() {
EXPECT_GT(AppWindowRegistry::Get(browser_context())->app_windows().size(),
0u);
return AppWindowRegistry::Get(browser_context())->app_windows().front();
}
// ShellApiTest:
void SetUpOnMainThread() override {
ShellApiTest::SetUpOnMainThread();
desktop_controller_ =
static_cast<ShellDesktopControllerAura*>(DesktopController::instance());
ASSERT_TRUE(desktop_controller_);
}
void TearDownOnMainThread() override {
EXPECT_FALSE(KeepAliveRegistry::GetInstance()->IsKeepingAlive());
desktop_controller_ = nullptr;
ShellApiTest::TearDownOnMainThread();
}
void RunDesktopController() {
desktop_controller_->PreMainMessageLoopRun();
auto run_loop = std::make_unique<base::RunLoop>();
desktop_controller_->WillRunMainMessageLoop(run_loop);
run_loop->Run();
desktop_controller_->PostMainMessageLoopRun();
}
scoped_refptr<const Extension> app_;
private:
raw_ptr<ShellDesktopControllerAura> desktop_controller_ = nullptr;
};
// Test that closing the app window stops the DesktopController.
IN_PROC_BROWSER_TEST_F(ShellDesktopControllerAuraBrowserTest, CloseAppWindow) {
bool test_succeeded = false;
// Post a task so everything runs after the DesktopController starts.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTaskAndReply(
FROM_HERE,
// Asynchronously launch the app.
base::BindOnce(&ShellDesktopControllerAuraBrowserTest::LoadAndLaunchApp,
base::Unretained(this)),
// Once the app launches, run the test.
base::BindLambdaForTesting([this, &test_succeeded]() {
// Close the app window so DesktopController quits.
GetAppWindow()->OnNativeClose();
test_succeeded = true;
}));
// Start DesktopController. It should run until the last app window closes.
RunDesktopController();
EXPECT_TRUE(test_succeeded)
<< "DesktopController quit before test completed.";
}
// Test that the DesktopController runs until all app windows close.
IN_PROC_BROWSER_TEST_F(ShellDesktopControllerAuraBrowserTest, TwoAppWindows) {
bool test_succeeded = false;
// Post a task so everything runs after the DesktopController starts.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTaskAndReply(
FROM_HERE,
// Asynchronously launch the app.
base::BindOnce(&ShellDesktopControllerAuraBrowserTest::LoadAndLaunchApp,
base::Unretained(this)),
// Once the app launches, run the test.
base::BindLambdaForTesting([this, &test_succeeded]() {
// Create a second app window.
ASSERT_TRUE(browsertest_util::ExecuteScriptInBackgroundPageNoWait(
browser_context(), app_->id(),
"chrome.app.window.create('/hello.html');"));
ResultCatcher catcher;
ASSERT_TRUE(catcher.GetNextResult());
// Close the first app window.
GetAppWindow()->OnNativeClose();
// One window is still open, so the DesktopController should still be
// running. Post a task to close the last window.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostDelayedTask(
FROM_HERE, base::BindLambdaForTesting([this, &test_succeeded]() {
GetAppWindow()->OnNativeClose();
test_succeeded = true;
}),
// A regression might cause DesktopController to quit before the
// last window closes. To ensure we catch this, wait a while before
// closing the last window. If DesktopController::Run() finishes
// before we close the last window and update |test_succeeded|, the
// test fails.
base::Milliseconds(500));
}));
RunDesktopController();
EXPECT_TRUE(test_succeeded)
<< "DesktopController quit before test completed.";
}
// Test that the DesktopController stays open while an app reloads, even though
// the app window closes.
IN_PROC_BROWSER_TEST_F(ShellDesktopControllerAuraBrowserTest, ReloadApp) {
bool test_succeeded = false;
// Post a task so everything runs after the DesktopController starts.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTaskAndReply(
FROM_HERE,
// Asynchronously launch the app.
base::BindOnce(&ShellDesktopControllerAuraBrowserTest::LoadAndLaunchApp,
base::Unretained(this)),
// Once the app launches, run the test.
base::BindLambdaForTesting([this, &test_succeeded]() {
// Reload the app.
ASSERT_TRUE(browsertest_util::ExecuteScriptInBackgroundPageNoWait(
browser_context(), app_->id(), "chrome.runtime.reload();"));
// Wait for the app window to re-open.
ResultCatcher catcher;
ASSERT_TRUE(catcher.GetNextResult());
// Close the new window after a delay. DesktopController should remain
// open until the window closes.
base::SingleThreadTaskRunner::GetCurrentDefault()->PostDelayedTask(
FROM_HERE, base::BindLambdaForTesting([this, &test_succeeded]() {
AppWindow* app_window = AppWindowRegistry::Get(browser_context())
->app_windows()
.front();
app_window->OnNativeClose();
test_succeeded = true;
}),
base::Milliseconds(500));
}));
RunDesktopController();
EXPECT_TRUE(test_succeeded)
<< "DesktopController quit before test completed.";
}
} // namespace extensions
|
