1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "gpu/command_buffer/client/client_shared_image.h"
#include <GLES2/gl2.h>
#include <GLES2/gl2extchromium.h>
#include "gpu/command_buffer/client/shared_image_interface.h"
#include "gpu/command_buffer/client/test_shared_image_interface.h"
#include "gpu/command_buffer/common/shared_image_capabilities.h"
#include "gpu/command_buffer/common/shared_image_usage.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/gpu_fence.h"
namespace gpu {
namespace {
constexpr viz::SharedImageFormat kMultiPlaneFormatsWithHardwareGMBs[4] = {
viz::MultiPlaneFormat::kYV12, viz::MultiPlaneFormat::kNV12,
viz::MultiPlaneFormat::kNV12A, viz::MultiPlaneFormat::kP010};
} // namespace
TEST(ClientSharedImageTest, ImportUnowned) {
auto mailbox = Mailbox::Generate();
const auto kFormat = viz::SinglePlaneFormat::kRGBA_8888;
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
SharedImageMetadata metadata{kFormat,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage};
auto client_si = ClientSharedImage::ImportUnowned(ExportedSharedImage(
mailbox, metadata, SyncToken(), "ClientSharedImageTest", std::nullopt,
std::nullopt, GL_TEXTURE_2D));
// Check that the ClientSI's state matches the input parameters.
EXPECT_EQ(client_si->mailbox(), mailbox);
EXPECT_EQ(client_si->format(), kFormat);
EXPECT_EQ(client_si->size(), kSize);
EXPECT_EQ(client_si->usage(), kUsage);
EXPECT_EQ(client_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_2D));
EXPECT_FALSE(client_si->HasHolder());
}
TEST(ClientSharedImageTest, CreateViaSharedImageInterface) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const auto kFormat = viz::SinglePlaneFormat::kRGBA_8888;
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
SharedImageInfo si_info{kFormat,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
EXPECT_TRUE(client_si->HasHolder());
EXPECT_FALSE(client_si->mailbox().IsZero());
// Check that the ClientSI's state matches the input parameters.
EXPECT_EQ(client_si->format(), kFormat);
EXPECT_EQ(client_si->size(), kSize);
EXPECT_EQ(client_si->usage(), kUsage);
// With no scanout or WebGPU usage, external sampling not configured, and no
// client-side native buffer handle passed, the SharedImage should be using
// the default texture target on all platforms.
EXPECT_EQ(client_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_2D));
}
TEST(ClientSharedImageTest, BackingWasExternallyUpdatedForwardsToSII) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const auto kFormat = viz::SinglePlaneFormat::kRGBA_8888;
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
SharedImageInfo si_info{kFormat,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
ASSERT_EQ(0u, sii->num_update_shared_image_no_fence_calls());
client_si->BackingWasExternallyUpdated(gpu::SyncToken());
EXPECT_EQ(1u, sii->num_update_shared_image_no_fence_calls());
}
// Verifies that invoking BackingWasExternallyUpdated() on a
// ClientSharedImage after its SharedImageInterface has been lost does not cause
// a crash.
TEST(ClientSharedImageTest, BackingWasExternallyUpdatedAfterLossOfSII) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const auto kFormat = viz::SinglePlaneFormat::kRGBA_8888;
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
SharedImageInfo si_info{kFormat,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
sii.reset();
client_si->BackingWasExternallyUpdated(gpu::SyncToken());
}
TEST(ClientSharedImageTest, ExportAndImport) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const auto kFormat = viz::SinglePlaneFormat::kRGBA_8888;
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
SharedImageInfo si_info{kFormat,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
auto exported_si = client_si->Export();
auto imported_client_si =
ClientSharedImage::ImportUnowned(std::move(exported_si));
EXPECT_EQ(imported_client_si->mailbox(), client_si->mailbox());
EXPECT_EQ(imported_client_si->format(), kFormat);
EXPECT_EQ(imported_client_si->size(), kSize);
EXPECT_EQ(imported_client_si->usage(), kUsage);
EXPECT_EQ(imported_client_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_2D));
}
TEST(ClientSharedImageTest, MakeUnowned) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const auto kFormat = viz::SinglePlaneFormat::kRGBA_8888;
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
SharedImageInfo si_info{kFormat,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
auto unowned_si = client_si->MakeUnowned();
EXPECT_EQ(unowned_si->mailbox(), client_si->mailbox());
EXPECT_EQ(unowned_si->format(), kFormat);
EXPECT_EQ(unowned_si->size(), kSize);
EXPECT_EQ(unowned_si->usage(), kUsage);
EXPECT_EQ(unowned_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_2D));
EXPECT_FALSE(unowned_si->HasHolder());
}
// The default target should be set for single-planar formats with no
// native buffer used.
TEST(ClientSharedImageTest,
GetTextureTarget_SinglePlaneFormats_NoNativeBuffer) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
for (auto format : viz::SinglePlaneFormat::kAll) {
SharedImageInfo si_info{format,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
EXPECT_EQ(client_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_2D));
}
}
// When the client provides a native buffer with a single-plane format,
// GL_TEXTURE_2D should be used as the texture target on all platforms other
// than Mac, where the target for IO surfaces should be used.
TEST(ClientSharedImageTest,
GetTextureTarget_SinglePlaneFormats_ClientNativeBuffer) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
sii->emulate_client_provided_native_buffer();
#if BUILDFLAG(IS_MAC)
// Explicitly set the texture target for IO surfaces to a target other than
// GL_TEXTURE_2D to ensure that the test is meaningful on Mac.
const uint32_t kTargetForIOSurfaces = GL_TEXTURE_RECTANGLE_ARB;
sii->set_texture_target_for_io_surfaces(kTargetForIOSurfaces);
#endif
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
for (auto format : viz::SinglePlaneFormat::kAll) {
SharedImageInfo si_info{format,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
#if BUILDFLAG(IS_MAC)
const uint32_t expected_texture_target = kTargetForIOSurfaces;
#else
const uint32_t expected_texture_target = GL_TEXTURE_2D;
#endif
EXPECT_EQ(client_si->GetTextureTarget(), expected_texture_target);
}
}
// When the client asks for SCANOUT usage, GL_TEXTURE_2D should be used as the
// texture target on all platforms other than Mac, where the target for IO
// surfaces should be used.
TEST(ClientSharedImageTest, GetTextureTarget_ScanoutUsage) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
#if BUILDFLAG(IS_MAC)
// Explicitly set the texture target for IO surfaces to a target other than
// GL_TEXTURE_2D to ensure that the test is meaningful on Mac.
const uint32_t kTargetForIOSurfaces = GL_TEXTURE_RECTANGLE_ARB;
sii->set_texture_target_for_io_surfaces(kTargetForIOSurfaces);
#endif
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage = SHARED_IMAGE_USAGE_SCANOUT;
// Test all single-plane formats as well as multiplane formats for which
// hardware GMBs are supported.
std::vector<viz::SharedImageFormat> formats_to_test;
for (auto format : viz::SinglePlaneFormat::kAll) {
formats_to_test.push_back(format);
}
for (auto format : kMultiPlaneFormatsWithHardwareGMBs) {
formats_to_test.push_back(format);
}
for (auto format : formats_to_test) {
SharedImageInfo si_info{format,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
#if BUILDFLAG(IS_MAC)
const uint32_t expected_texture_target = kTargetForIOSurfaces;
#else
const uint32_t expected_texture_target = GL_TEXTURE_2D;
#endif
EXPECT_EQ(client_si->GetTextureTarget(), expected_texture_target);
}
}
// When the client asks for WEBGPU usage, GL_TEXTURE_2D should be used as the
// texture target on all platforms other than Mac, where the target for IO
// surfaces should be used.
TEST(ClientSharedImageTest, GetTextureTarget_WebGPUUsage) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
#if BUILDFLAG(IS_MAC)
// Explicitly set the texture target for IO surfaces to a target other than
// GL_TEXTURE_2D to ensure that the test is meaningful on Mac.
const uint32_t kTargetForIOSurfaces = GL_TEXTURE_RECTANGLE_ARB;
sii->set_texture_target_for_io_surfaces(kTargetForIOSurfaces);
#endif
// Test all single-plane formats as well as multiplane formats for which
// hardware GMBs are supported.
std::vector<viz::SharedImageFormat> formats_to_test;
for (auto format : viz::SinglePlaneFormat::kAll) {
formats_to_test.push_back(format);
}
for (auto format : kMultiPlaneFormatsWithHardwareGMBs) {
formats_to_test.push_back(format);
}
for (SharedImageUsageSet webgpu_usage :
{SHARED_IMAGE_USAGE_WEBGPU_READ, SHARED_IMAGE_USAGE_WEBGPU_WRITE}) {
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage = webgpu_usage;
for (auto format : formats_to_test) {
SharedImageInfo si_info{format,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
#if BUILDFLAG(IS_MAC)
const uint32_t expected_texture_target = kTargetForIOSurfaces;
#else
const uint32_t expected_texture_target = GL_TEXTURE_2D;
#endif
EXPECT_EQ(client_si->GetTextureTarget(), expected_texture_target);
}
}
}
// On all platforms, the default target should be used for multi-planar
// formats if external sampling is not set and scanout/WebGPU usage are not
// specified.
TEST(ClientSharedImageTest,
GetTextureTarget_MultiplanarFormats_NoScanoutOrWebGPUUsage) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
// Pass all the multiplanar formats that are used with hardware GMBs.
for (auto format : kMultiPlaneFormatsWithHardwareGMBs) {
SharedImageInfo si_info{format,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
// Since the format does not have external sampling enabled, the default
// target should be used.
EXPECT_EQ(client_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_2D));
}
}
#if BUILDFLAG(IS_OZONE)
// On Ozone, the target for native buffers should be used if a
// multiplanar format with external sampling is passed.
TEST(ClientSharedImageTest,
GetTextureTarget_MultiplanarFormatsWithExternalSampling) {
auto sii = base::MakeRefCounted<TestSharedImageInterface>();
sii->emulate_client_provided_native_buffer();
const gfx::Size kSize(256, 256);
const SharedImageUsageSet kUsage =
SHARED_IMAGE_USAGE_RASTER_WRITE | SHARED_IMAGE_USAGE_DISPLAY_READ;
// Pass all the multiplanar formats that are used with hardware GMBs.
for (auto format :
{viz::MultiPlaneFormat::kYV12, viz::MultiPlaneFormat::kNV12,
viz::MultiPlaneFormat::kNV12A, viz::MultiPlaneFormat::kP010}) {
format.SetPrefersExternalSampler();
SharedImageInfo si_info{format,
kSize,
gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin,
kOpaque_SkAlphaType,
kUsage,
""};
auto client_si = sii->CreateSharedImage(si_info, kNullSurfaceHandle);
// Since the format has external sampling enabled, the platform-specific
// target for native buffers should be used.
#if BUILDFLAG(IS_FUCHSIA)
EXPECT_EQ(client_si->GetTextureTarget(), 0u);
#else
EXPECT_EQ(client_si->GetTextureTarget(),
static_cast<uint32_t>(GL_TEXTURE_EXTERNAL_OES));
#endif
}
}
#endif
} // namespace gpu
|
