1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "gpu/command_buffer/service/multi_draw_manager.h"
#include <memory>
#include <tuple>
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/gl_bindings.h"
namespace gpu {
namespace gles2 {
namespace {
using Param = std::tuple<MultiDrawManager::IndexStorageType,
MultiDrawManager::DrawFunction>;
} // namespace
class MultiDrawManagerTest : public testing::TestWithParam<Param> {
public:
MultiDrawManagerTest()
: multi_draw_manager_(new MultiDrawManager(std::get<0>(GetParam()))) {}
protected:
bool DoMultiDraw(uint32_t count,
GLenum mode = GL_TRIANGLES,
GLenum type = GL_UNSIGNED_INT) {
std::vector<GLsizei> data(count);
std::vector<GLint> basevertices(count);
std::vector<GLuint> baseinstances(count);
switch (std::get<1>(GetParam())) {
case MultiDrawManager::DrawFunction::DrawArrays:
return multi_draw_manager_->MultiDrawArrays(mode, data.data(),
data.data(), count);
case MultiDrawManager::DrawFunction::DrawArraysInstanced:
return multi_draw_manager_->MultiDrawArraysInstanced(
mode, data.data(), data.data(), data.data(), count);
case MultiDrawManager::DrawFunction::DrawArraysInstancedBaseInstance:
return multi_draw_manager_->MultiDrawArraysInstancedBaseInstance(
mode, data.data(), data.data(), data.data(), baseinstances.data(),
count);
case MultiDrawManager::DrawFunction::DrawElements:
return multi_draw_manager_->MultiDrawElements(mode, data.data(), type,
data.data(), count);
case MultiDrawManager::DrawFunction::DrawElementsInstanced:
return multi_draw_manager_->MultiDrawElementsInstanced(
mode, data.data(), type, data.data(), data.data(), count);
case MultiDrawManager::DrawFunction::
DrawElementsInstancedBaseVertexBaseInstance:
return multi_draw_manager_
->MultiDrawElementsInstancedBaseVertexBaseInstance(
mode, data.data(), type, data.data(), data.data(),
basevertices.data(), baseinstances.data(), count);
}
}
void CheckResultSize(uint32_t count,
const MultiDrawManager::ResultData& result) {
MultiDrawManager::DrawFunction draw_function = std::get<1>(GetParam());
EXPECT_TRUE(draw_function == result.draw_function);
switch (draw_function) {
case MultiDrawManager::DrawFunction::DrawArraysInstancedBaseInstance:
EXPECT_TRUE(result.baseinstances.size() == count);
[[fallthrough]];
case MultiDrawManager::DrawFunction::DrawArraysInstanced:
EXPECT_TRUE(result.instance_counts.size() == count);
[[fallthrough]];
case MultiDrawManager::DrawFunction::DrawArrays:
EXPECT_TRUE(result.firsts.size() == count);
EXPECT_TRUE(result.counts.size() == count);
break;
case MultiDrawManager::DrawFunction::
DrawElementsInstancedBaseVertexBaseInstance:
EXPECT_TRUE(result.basevertices.size() == count);
EXPECT_TRUE(result.baseinstances.size() == count);
[[fallthrough]];
case MultiDrawManager::DrawFunction::DrawElementsInstanced:
EXPECT_TRUE(result.instance_counts.size() == count);
[[fallthrough]];
case MultiDrawManager::DrawFunction::DrawElements:
EXPECT_TRUE(result.counts.size() == count);
switch (std::get<0>(GetParam())) {
case MultiDrawManager::IndexStorageType::Offset:
EXPECT_TRUE(result.offsets.size() == count);
break;
case MultiDrawManager::IndexStorageType::Pointer:
EXPECT_TRUE(result.indices.size() == count);
break;
}
break;
}
}
std::unique_ptr<MultiDrawManager> multi_draw_manager_;
};
// Test that the simple case succeeds
TEST_P(MultiDrawManagerTest, Success) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(100));
EXPECT_TRUE(multi_draw_manager_->End(&result));
CheckResultSize(100, result);
}
// Test that the internal state of the multi draw manager resets such that
// successive valid multi draws can be executed
TEST_P(MultiDrawManagerTest, SuccessAfterSuccess) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(100));
EXPECT_TRUE(multi_draw_manager_->End(&result));
CheckResultSize(100, result);
EXPECT_TRUE(multi_draw_manager_->Begin(1000));
EXPECT_TRUE(DoMultiDraw(1000));
EXPECT_TRUE(multi_draw_manager_->End(&result));
CheckResultSize(1000, result);
}
// Test that multiple chunked multi draw calls succeed
TEST_P(MultiDrawManagerTest, SuccessMultiple) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(83));
EXPECT_TRUE(DoMultiDraw(4));
EXPECT_TRUE(DoMultiDraw(13));
EXPECT_TRUE(multi_draw_manager_->End(&result));
CheckResultSize(100, result);
}
// Test that it is invalid to submit an empty multi draw
TEST_P(MultiDrawManagerTest, Empty) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(0));
EXPECT_FALSE(multi_draw_manager_->End(&result));
}
// Test that it is invalid to end a multi draw if it has not been started
TEST_P(MultiDrawManagerTest, EndBeforeBegin) {
MultiDrawManager::ResultData result;
EXPECT_FALSE(multi_draw_manager_->End(&result));
}
// Test that it is invalid to begin a multi draw twice
TEST_P(MultiDrawManagerTest, BeginAfterBegin) {
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_FALSE(multi_draw_manager_->Begin(100));
}
// Test that it is invalid to begin a multi draw twice, even if
// the first begin was empty
TEST_P(MultiDrawManagerTest, BeginAfterEmptyBegin) {
EXPECT_TRUE(multi_draw_manager_->Begin(0));
EXPECT_FALSE(multi_draw_manager_->Begin(100));
}
// Test that it is invalid to do a multi draw before begin
TEST_P(MultiDrawManagerTest, DrawBeforeBegin) {
EXPECT_FALSE(DoMultiDraw(1));
}
// Test that it is invalid to end a multi draw twice
TEST_P(MultiDrawManagerTest, DoubleEnd) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(1));
EXPECT_TRUE(DoMultiDraw(1));
EXPECT_TRUE(multi_draw_manager_->End(&result));
EXPECT_FALSE(multi_draw_manager_->End(&result));
}
// Test that it is invalid to end a multi draw before the drawcount
// is saturated
TEST_P(MultiDrawManagerTest, Underflow) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(99));
EXPECT_FALSE(multi_draw_manager_->End(&result));
}
// Test that it is invalid to end a multi draw before the drawcount
// is saturated, using multiple chunks
TEST_P(MultiDrawManagerTest, UnderflowMultiple) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(42));
EXPECT_TRUE(DoMultiDraw(31));
EXPECT_TRUE(DoMultiDraw(26));
EXPECT_FALSE(multi_draw_manager_->End(&result));
}
// Test that it is invalid to do a multi draw that overflows the drawcount
TEST_P(MultiDrawManagerTest, Overflow) {
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_FALSE(DoMultiDraw(101));
}
// Test that it is invalid to do a multi draw that overflows the drawcount,
// using multiple chunks
TEST_P(MultiDrawManagerTest, OverflowMultiple) {
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(31));
EXPECT_TRUE(DoMultiDraw(49));
EXPECT_FALSE(DoMultiDraw(21));
}
// Test that it is invalid to do a multi draw that does not match the first
// chunk's draw mode
TEST_P(MultiDrawManagerTest, DrawModeMismatch) {
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(50, GL_TRIANGLES));
EXPECT_FALSE(DoMultiDraw(50, GL_LINES));
}
// Test that it is invalid to do a multi draw that does not match the first
// chunk's element type
TEST_P(MultiDrawManagerTest, ElementTypeMismatch) {
MultiDrawManager::DrawFunction draw_function = std::get<1>(GetParam());
if (draw_function != MultiDrawManager::DrawFunction::DrawElements &&
draw_function != MultiDrawManager::DrawFunction::DrawElementsInstanced) {
return;
}
MultiDrawManager::ResultData result;
EXPECT_TRUE(multi_draw_manager_->Begin(100));
EXPECT_TRUE(DoMultiDraw(50, GL_TRIANGLES, GL_UNSIGNED_INT));
EXPECT_FALSE(DoMultiDraw(50, GL_TRIANGLES, GL_UNSIGNED_SHORT));
}
INSTANTIATE_TEST_SUITE_P(
All,
MultiDrawManagerTest,
testing::Combine(
testing::Values(MultiDrawManager::IndexStorageType::Offset,
MultiDrawManager::IndexStorageType::Pointer),
testing::Values(
MultiDrawManager::DrawFunction::DrawArrays,
MultiDrawManager::DrawFunction::DrawArraysInstanced,
MultiDrawManager::DrawFunction::DrawArraysInstancedBaseInstance,
MultiDrawManager::DrawFunction::DrawElements,
MultiDrawManager::DrawFunction::DrawElementsInstanced,
MultiDrawManager::DrawFunction::
DrawElementsInstancedBaseVertexBaseInstance)));
} // namespace gles2
} // namespace gpu
|
