1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "gpu/command_buffer/service/shared_image/compound_image_backing.h"
#include "components/viz/common/resources/shared_image_format.h"
#include "components/viz/common/resources/shared_image_format_utils.h"
#include "gpu/command_buffer/common/shared_image_usage.h"
#include "gpu/command_buffer/service/memory_tracking.h"
#include "gpu/command_buffer/service/shared_context_state.h"
#include "gpu/command_buffer/service/shared_image/shared_image_backing.h"
#include "gpu/command_buffer/service/shared_image/shared_image_backing_factory.h"
#include "gpu/command_buffer/service/shared_image/shared_image_manager.h"
#include "gpu/command_buffer/service/shared_image/shared_memory_image_backing.h"
#include "gpu/command_buffer/service/shared_image/test_image_backing.h"
#include "gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.h"
#include "gpu/ipc/common/surface_handle.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkAlphaType.h"
#include "third_party/skia/include/gpu/ganesh/GrBackendSemaphore.h"
#include "third_party/skia/include/gpu/ganesh/GrTypes.h"
#include "ui/gfx/buffer_types.h"
namespace gpu {
namespace {
constexpr uint32_t kTestBackingSize = 40000;
class TestSharedImageBackingFactory : public SharedImageBackingFactory {
public:
TestSharedImageBackingFactory() : SharedImageBackingFactory(kUsageAll) {}
// SharedImageBackingFactory implementation.
std::unique_ptr<SharedImageBacking> CreateSharedImage(
const Mailbox& mailbox,
viz::SharedImageFormat format,
SurfaceHandle surface_handle,
const gfx::Size& size,
const gfx::ColorSpace& color_space,
GrSurfaceOrigin surface_origin,
SkAlphaType alpha_type,
SharedImageUsageSet usage,
std::string debug_label,
bool is_thread_safe) override {
if (allocations_should_fail_)
return nullptr;
return std::make_unique<TestImageBacking>(
mailbox, format, size, color_space, surface_origin, alpha_type, usage,
kTestBackingSize);
}
std::unique_ptr<SharedImageBacking> CreateSharedImage(
const Mailbox& mailbox,
viz::SharedImageFormat format,
const gfx::Size& size,
const gfx::ColorSpace& color_space,
GrSurfaceOrigin surface_origin,
SkAlphaType alpha_type,
SharedImageUsageSet usage,
std::string debug_label,
bool is_thread_safe,
base::span<const uint8_t> pixel_data) override {
return nullptr;
}
std::unique_ptr<SharedImageBacking> CreateSharedImage(
const Mailbox& mailbox,
viz::SharedImageFormat format,
const gfx::Size& size,
const gfx::ColorSpace& color_space,
GrSurfaceOrigin surface_origin,
SkAlphaType alpha_type,
SharedImageUsageSet usage,
std::string debug_label,
bool is_thread_safe,
gfx::GpuMemoryBufferHandle handle) override {
return nullptr;
}
bool IsSupported(SharedImageUsageSet usage,
viz::SharedImageFormat format,
const gfx::Size& size,
bool thread_safe,
gfx::GpuMemoryBufferType gmb_type,
GrContextType gr_context_type,
base::span<const uint8_t> pixel_data) override {
return true;
}
SharedImageBackingType GetBackingType() override {
return SharedImageBackingType::kTest;
}
using SharedImageBackingFactory::InvalidateWeakPtrsForTesting;
void SetAllocationsShouldFail(bool allocations_should_fail) {
allocations_should_fail_ = allocations_should_fail;
}
private:
bool allocations_should_fail_ = false;
};
} // namespace
class CompoundImageBackingTest : public testing::Test {
public:
CompoundImageBackingTest()
: memory_tracker_(base::MakeRefCounted<MemoryTracker>()),
memory_type_tracker_(memory_tracker_) {}
bool HasGpuBacking(CompoundImageBacking* backing) {
return !!backing->elements_[1].backing;
}
bool HasGpuCreateBackingCallback(CompoundImageBacking* backing) {
return !backing->elements_[1].create_callback.is_null();
}
TestImageBacking* GetGpuBacking(CompoundImageBacking* backing) {
auto* gpu_backing = backing->elements_[1].backing.get();
DCHECK_EQ(gpu_backing->GetType(), SharedImageBackingType::kTest);
return static_cast<TestImageBacking*>(gpu_backing);
}
SharedMemoryImageBacking* GetShmImageBacking(CompoundImageBacking* backing) {
auto* shm_backing = backing->elements_[0].backing.get();
DCHECK_EQ(shm_backing->GetType(), SharedImageBackingType::kSharedMemory);
return static_cast<SharedMemoryImageBacking*>(shm_backing);
}
bool GetShmHasLatestContent(CompoundImageBacking* backing) {
return backing->elements_[0].content_id_ == backing->latest_content_id_;
}
bool GetGpuHasLatestContent(CompoundImageBacking* backing) {
return backing->elements_[1].content_id_ == backing->latest_content_id_;
}
// Create a compound backing containing shared memory + GPU backing.
std::unique_ptr<SharedImageBacking> CreateCompoundBacking(
SharedImageUsageSet usage) {
constexpr gfx::Size size(100, 100);
constexpr gfx::BufferFormat buffer_format = gfx::BufferFormat::RGBA_8888;
constexpr gfx::BufferUsage buffer_usage =
gfx::BufferUsage::SCANOUT_CPU_READ_WRITE;
gfx::GpuMemoryBufferHandle handle =
GpuMemoryBufferImplSharedMemory::CreateGpuMemoryBuffer(
static_cast<gfx::GpuMemoryBufferId>(1), size, buffer_format,
buffer_usage);
return CompoundImageBacking::CreateSharedMemory(
&test_factory_, Mailbox::Generate(), std::move(handle),
viz::SinglePlaneFormat::kRGBA_8888, size, gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin, kOpaque_SkAlphaType, usage, "TestLabel");
}
std::unique_ptr<SharedImageBacking> CreateMultiplanarCompoundBacking() {
constexpr gfx::Size size(100, 100);
constexpr gfx::BufferFormat buffer_format =
gfx::BufferFormat::YUV_420_BIPLANAR;
constexpr gfx::BufferUsage buffer_usage =
gfx::BufferUsage::SCANOUT_CPU_READ_WRITE;
gfx::GpuMemoryBufferHandle handle =
GpuMemoryBufferImplSharedMemory::CreateGpuMemoryBuffer(
static_cast<gfx::GpuMemoryBufferId>(1), size, buffer_format,
buffer_usage);
return CompoundImageBacking::CreateSharedMemory(
&test_factory_, Mailbox::Generate(), std::move(handle),
viz::MultiPlaneFormat::kNV12, size, gfx::ColorSpace(),
kTopLeft_GrSurfaceOrigin, kOpaque_SkAlphaType,
SharedImageUsageSet(
{SHARED_IMAGE_USAGE_DISPLAY_READ, SHARED_IMAGE_USAGE_SCANOUT}),
"TestLabel");
}
protected:
scoped_refptr<MemoryTracker> memory_tracker_;
MemoryTypeTracker memory_type_tracker_;
SharedImageManager manager_;
TestSharedImageBackingFactory test_factory_;
};
TEST_F(CompoundImageBackingTest, References) {
auto backing = CreateCompoundBacking(
{SHARED_IMAGE_USAGE_DISPLAY_READ, SHARED_IMAGE_USAGE_SCANOUT});
auto* compound_backing = static_cast<CompoundImageBacking*>(backing.get());
EXPECT_NE(compound_backing, nullptr);
// The compound backing hasn't been added to the manager yet so it should
// have zero references.
EXPECT_FALSE(compound_backing->HasAnyRefs());
EXPECT_FALSE(HasGpuBacking(compound_backing));
auto factory_rep =
manager_.Register(std::move(backing), &memory_type_tracker_);
// When the compound backing is first registered it will get a reference
// and add shared memory backing size to the memory tracker.
EXPECT_EQ(memory_tracker_->GetSize(), kTestBackingSize);
// After register compound backing it should have a reference. The GPU
// backing should never have any reference as it's owned by the compound
// backing and isn't reference counted.
EXPECT_TRUE(compound_backing->HasAnyRefs());
EXPECT_FALSE(HasGpuBacking(compound_backing));
auto overlay_rep = manager_.ProduceOverlay(compound_backing->mailbox(),
&memory_type_tracker_);
#if !BUILDFLAG(IS_WIN)
// On overlay access a GPU backing will be allocated and the recorded size
// will increase.
EXPECT_EQ(memory_tracker_->GetSize(), kTestBackingSize * 2);
ASSERT_TRUE(HasGpuBacking(compound_backing));
auto* gpu_backing = GetGpuBacking(compound_backing);
// GPU backing still shouldn't have any references after a wrapped
// representation is created.
EXPECT_TRUE(compound_backing->HasAnyRefs());
EXPECT_FALSE(gpu_backing->HasAnyRefs());
#else
// On Windows, no GPU backing is needed for overlays.
EXPECT_EQ(memory_tracker_->GetSize(), kTestBackingSize);
EXPECT_FALSE(HasGpuBacking(compound_backing));
{
auto access = overlay_rep->BeginScopedReadAccess();
std::optional<gl::DCLayerOverlayImage> overlay_image =
access->GetDCLayerOverlayImage();
ASSERT_TRUE(overlay_image);
EXPECT_EQ(overlay_image->type(), gl::DCLayerOverlayType::kShMemPixmap);
}
#endif
overlay_rep.reset();
EXPECT_TRUE(compound_backing->HasAnyRefs());
// All the backings will be destroyed after this point.
factory_rep.reset();
// When all references are dropped the total size of shared memory and gpu
// backings will be subtracted from memory tracker.
EXPECT_EQ(memory_tracker_->GetSize(), 0u);
}
TEST_F(CompoundImageBackingTest, UploadOnAccess) {
auto backing = CreateCompoundBacking(
{SHARED_IMAGE_USAGE_SCANOUT, SHARED_IMAGE_USAGE_GLES2_READ,
SHARED_IMAGE_USAGE_DISPLAY_READ, SHARED_IMAGE_USAGE_DISPLAY_WRITE});
auto* compound_backing = static_cast<CompoundImageBacking*>(backing.get());
auto factory_rep =
manager_.Register(std::move(backing), &memory_type_tracker_);
auto overlay_rep = manager_.ProduceOverlay(compound_backing->mailbox(),
&memory_type_tracker_);
if constexpr (!BUILDFLAG(IS_WIN)) {
ASSERT_TRUE(HasGpuBacking(compound_backing));
auto* gpu_backing = GetGpuBacking(compound_backing);
// The compound backing hasn't been accessed yet.
EXPECT_FALSE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// Only shared memory should have latest content initially.
EXPECT_TRUE(GetShmHasLatestContent(compound_backing));
EXPECT_FALSE(GetGpuHasLatestContent(compound_backing));
// First access should trigger upload from memory to GPU.
overlay_rep->BeginScopedReadAccess();
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// After GPU read access both should have latest content.
EXPECT_TRUE(GetShmHasLatestContent(compound_backing));
EXPECT_TRUE(GetGpuHasLatestContent(compound_backing));
// Second access shouldn't trigger upload since no shared memory updates
// happened.
overlay_rep->BeginScopedReadAccess();
EXPECT_FALSE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// Notify compound backing of shared memory update. Next access should
// trigger a new upload.
compound_backing->Update(nullptr);
overlay_rep->BeginScopedReadAccess();
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
} else {
// On Windows, no GPU backing is needed for overlays.
EXPECT_FALSE(HasGpuBacking(compound_backing));
// Shared memory should have the latest content initially.
EXPECT_TRUE(GetShmHasLatestContent(compound_backing));
EXPECT_FALSE(GetGpuHasLatestContent(compound_backing));
// Access does not change that.
overlay_rep->BeginScopedReadAccess();
EXPECT_TRUE(GetShmHasLatestContent(compound_backing));
EXPECT_FALSE(GetGpuHasLatestContent(compound_backing));
}
// Test that GLTexturePassthrough access causes upload.
auto gl_passthrough_rep = manager_.ProduceGLTexturePassthrough(
compound_backing->mailbox(), &memory_type_tracker_);
compound_backing->Update(nullptr);
gl_passthrough_rep->BeginScopedAccess(
0, SharedImageRepresentation::AllowUnclearedAccess::kNo);
ASSERT_TRUE(HasGpuBacking(compound_backing));
auto* gpu_backing = GetGpuBacking(compound_backing);
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// Test that GLTexture access causes upload.
auto gl_rep = manager_.ProduceGLTexture(compound_backing->mailbox(),
&memory_type_tracker_);
compound_backing->Update(nullptr);
gl_rep->BeginScopedAccess(
0, SharedImageRepresentation::AllowUnclearedAccess::kNo);
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// Test that both read and write access by Skia triggers upload.
std::vector<GrBackendSemaphore> begin_semaphores;
std::vector<GrBackendSemaphore> end_semaphores;
auto skia_rep = manager_.ProduceSkia(compound_backing->mailbox(),
&memory_type_tracker_, nullptr);
compound_backing->Update(nullptr);
// After Update() only shared memory should have latest content.
EXPECT_TRUE(GetShmHasLatestContent(compound_backing));
EXPECT_FALSE(GetGpuHasLatestContent(compound_backing));
skia_rep->BeginScopedWriteAccess(
&begin_semaphores, &end_semaphores,
SharedImageRepresentation::AllowUnclearedAccess::kNo);
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// On GPU write access only GPU should have latest content.
EXPECT_FALSE(GetShmHasLatestContent(compound_backing));
EXPECT_TRUE(GetGpuHasLatestContent(compound_backing));
compound_backing->Update(nullptr);
skia_rep->BeginScopedReadAccess(&begin_semaphores, &end_semaphores);
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
}
TEST_F(CompoundImageBackingTest, ReadbackToMemory) {
auto backing = CreateCompoundBacking({SHARED_IMAGE_USAGE_GLES2_READ});
auto* compound_backing = static_cast<CompoundImageBacking*>(backing.get());
auto factory_rep =
manager_.Register(std::move(backing), &memory_type_tracker_);
auto gl_passthrough_rep = manager_.ProduceGLTexturePassthrough(
compound_backing->mailbox(), &memory_type_tracker_);
compound_backing->Update(nullptr);
gl_passthrough_rep->BeginScopedAccess(
0, SharedImageRepresentation::AllowUnclearedAccess::kNo);
ASSERT_TRUE(HasGpuBacking(compound_backing));
auto* gpu_backing = GetGpuBacking(compound_backing);
// On write access UploadFromMemory() should be called and then only GPU
// texture has latest.
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
EXPECT_FALSE(GetShmHasLatestContent(compound_backing));
EXPECT_TRUE(GetGpuHasLatestContent(compound_backing));
compound_backing->CopyToGpuMemoryBuffer();
// On CopyToGpuMemoryBuffer() ReadbackToMemory() should have been called and
// shared memory has latest content again.
EXPECT_TRUE(gpu_backing->GetReadbackToMemoryCalledAndReset());
EXPECT_TRUE(GetShmHasLatestContent(compound_backing));
EXPECT_TRUE(GetGpuHasLatestContent(compound_backing));
}
TEST_F(CompoundImageBackingTest, LazyAllocationFailsCreate) {
auto backing = CreateCompoundBacking({SHARED_IMAGE_USAGE_GLES2_READ});
auto* compound_backing = static_cast<CompoundImageBacking*>(backing.get());
auto factory_rep =
manager_.Register(std::move(backing), &memory_type_tracker_);
// The compound backing shouldn't have GPU backing yet and should have
// a valid factory to create one.
EXPECT_FALSE(HasGpuBacking(compound_backing));
EXPECT_TRUE(HasGpuCreateBackingCallback(compound_backing));
test_factory_.SetAllocationsShouldFail(true);
auto gl_passthrough_rep = manager_.ProduceGLTexturePassthrough(
compound_backing->mailbox(), &memory_type_tracker_);
// Creating the GPU backing should fail so representation should be null.
EXPECT_FALSE(gl_passthrough_rep);
EXPECT_FALSE(HasGpuBacking(compound_backing));
// The backing factory to create GPU backing should be reset so creation is
// not retried.
EXPECT_FALSE(HasGpuCreateBackingCallback(compound_backing));
}
TEST_F(CompoundImageBackingTest, LazyAllocationFailsFactoryInvalidated) {
auto backing = CreateCompoundBacking({SHARED_IMAGE_USAGE_GLES2_READ});
auto* compound_backing = static_cast<CompoundImageBacking*>(backing.get());
auto factory_rep =
manager_.Register(std::move(backing), &memory_type_tracker_);
// The compound backing shouldn't have GPU backing yet and should have
// a valid factory to create one.
EXPECT_FALSE(HasGpuBacking(compound_backing));
EXPECT_TRUE(HasGpuCreateBackingCallback(compound_backing));
test_factory_.InvalidateWeakPtrsForTesting();
auto gl_passthrough_rep = manager_.ProduceGLTexturePassthrough(
compound_backing->mailbox(), &memory_type_tracker_);
// Creating the GPU backing should fail so representation should be null.
EXPECT_FALSE(gl_passthrough_rep);
EXPECT_FALSE(HasGpuBacking(compound_backing));
// The backing factory to create GPU backing should be reset to avoid logging
// about destroyed image multiple times.
EXPECT_FALSE(HasGpuCreateBackingCallback(compound_backing));
}
TEST_F(CompoundImageBackingTest, Multiplanar) {
auto backing = CreateMultiplanarCompoundBacking();
auto* compound_backing = static_cast<CompoundImageBacking*>(backing.get());
auto factory_rep =
manager_.Register(std::move(backing), &memory_type_tracker_);
// There should be two planes stored in shared memory backing.
auto* shm_backing = GetShmImageBacking(compound_backing);
EXPECT_EQ(shm_backing->pixmaps().size(), 2u);
auto overlay_rep = manager_.ProduceOverlay(compound_backing->mailbox(),
&memory_type_tracker_);
if constexpr (!BUILDFLAG(IS_WIN)) {
ASSERT_TRUE(HasGpuBacking(compound_backing));
auto* gpu_backing = GetGpuBacking(compound_backing);
// The compound backing hasn't been accessed yet.
EXPECT_FALSE(gpu_backing->GetUploadFromMemoryCalledAndReset());
// First access should trigger upload from memory to GPU.
overlay_rep->BeginScopedReadAccess();
EXPECT_TRUE(gpu_backing->GetUploadFromMemoryCalledAndReset());
} else {
// On Windows, no GPU backing is needed for overlays.
auto access = overlay_rep->BeginScopedReadAccess();
EXPECT_FALSE(HasGpuBacking(compound_backing));
}
}
} // namespace gpu
|