1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/cert/coalescing_cert_verifier.h"
#include <algorithm>
#include "base/containers/linked_list.h"
#include "base/containers/unique_ptr_adapters.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/time/time.h"
#include "net/base/net_errors.h"
#include "net/cert/cert_verify_result.h"
#include "net/cert/crl_set.h"
#include "net/cert/x509_certificate_net_log_param.h"
#include "net/log/net_log_event_type.h"
#include "net/log/net_log_source.h"
#include "net/log/net_log_source_type.h"
#include "net/log/net_log_values.h"
#include "net/log/net_log_with_source.h"
#include "third_party/boringssl/src/pki/pem.h"
namespace net {
// DESIGN OVERVIEW:
//
// The CoalescingCertVerifier implements an algorithm to group multiple calls
// to Verify() into a single Job. This avoids overloading the underlying
// CertVerifier, particularly those that are expensive to talk to (e.g.
// talking to the system verifier or across processes), batching multiple
// requests to CoaleacingCertVerifier::Verify() into a single underlying call.
//
// However, this makes lifetime management a bit more complex.
// - The Job object represents all of the state for a single verification to
// the CoalescingCertVerifier's underlying CertVerifier.
// * It keeps the CertVerifyResult alive, which is required as long as
// there is a pending verification.
// * It keeps the CertVerify::Request to the underlying verifier alive,
// as long as there is a pending Request attached to the Job.
// * It keeps track of every CoalescingCertVerifier::Request that is
// interested in receiving notification. However, it does NOT own
// these objects, and thus needs to coordinate with the Request (via
// AddRequest/AbortRequest) to make sure it never has a stale
// pointer.
// NB: It would have also been possible for the Job to only
// hold WeakPtr<Request>s, rather than Request*, but that seemed less
// clear as to the lifetime invariants, even if it was more clear
// about how the pointers are used.
// - The Job object is always owned by the CoalescingCertVerifier. If the
// CoalescingCertVerifier is deleted, all in-flight requests to the
// underlying verifier should be cancelled. When the Job goes away, all the
// Requests will be orphaned.
// - The Request object is always owned by the CALLER. It is a handle to
// allow a caller to cancel a request, per the CertVerifier interface. If
// the Request goes away, no caller callbacks should be invoked if the Job
// it was (previously) attached to completes.
// - Per the CertVerifier interface, when the CoalescingCertVerifier is
// deleted, then regardless of there being any live Requests, none of those
// caller callbacks should be invoked.
//
// Finally, to add to the complexity, it's possible that, during the handling
// of a result from the underlying CertVerifier, a Job may begin dispatching
// to its Requests. The Request may delete the CoalescingCertVerifier. If that
// happens, then the Job being processed is also deleted, and none of the
// other Requests should be notified.
namespace {
base::Value::Dict CertVerifierParams(
const CertVerifier::RequestParams& params) {
base::Value::Dict dict;
dict.Set("certificates",
NetLogX509CertificateList(params.certificate().get()));
if (!params.ocsp_response().empty()) {
dict.Set("ocsp_response",
bssl::PEMEncode(params.ocsp_response(), "NETLOG OCSP RESPONSE"));
}
if (!params.sct_list().empty()) {
dict.Set("sct_list", bssl::PEMEncode(params.sct_list(), "NETLOG SCT LIST"));
}
dict.Set("host", NetLogStringValue(params.hostname()));
dict.Set("verifier_flags", params.flags());
return dict;
}
} // namespace
// Job contains all the state for a single verification using the underlying
// verifier.
class CoalescingCertVerifier::Job {
public:
Job(CoalescingCertVerifier* parent,
const CertVerifier::RequestParams& params,
NetLog* net_log,
bool is_first_job);
~Job();
const CertVerifier::RequestParams& params() const { return params_; }
const CertVerifyResult& verify_result() const { return verify_result_; }
// Attaches |request|, causing it to be notified once this Job completes.
void AddRequest(CoalescingCertVerifier::Request* request);
// Stops |request| from being notified. If there are no Requests remaining,
// the Job will be cancelled.
// NOTE: It's only necessary to call this if the Job has not yet completed.
// If the Request has been notified of completion, this should not be called.
void AbortRequest(CoalescingCertVerifier::Request* request);
// Starts a verification using |underlying_verifier|. If this completes
// synchronously, returns the result code, with the associated result being
// available via |verify_result()|. Otherwise, it will complete
// asynchronously, notifying any Requests associated via |AttachRequest|.
int Start(CertVerifier* underlying_verifier);
private:
void OnVerifyComplete(int result);
void LogMetrics();
raw_ptr<CoalescingCertVerifier> parent_verifier_;
const CertVerifier::RequestParams params_;
const NetLogWithSource net_log_;
bool is_first_job_ = false;
CertVerifyResult verify_result_;
base::TimeTicks start_time_;
std::unique_ptr<CertVerifier::Request> pending_request_;
base::LinkedList<CoalescingCertVerifier::Request> attached_requests_;
base::WeakPtrFactory<Job> weak_ptr_factory_{this};
};
// Tracks the state associated with a single CoalescingCertVerifier::Verify
// request.
//
// There are two ways for requests to be cancelled:
// - The caller of Verify() can delete the Request object, indicating
// they are no longer interested in this particular request.
// - The caller can delete the CoalescingCertVerifier, which should cause
// all in-process Jobs to be aborted and deleted. Any Requests attached to
// Jobs should be orphaned, and do nothing when the Request is (eventually)
// deleted.
class CoalescingCertVerifier::Request
: public base::LinkNode<CoalescingCertVerifier::Request>,
public CertVerifier::Request {
public:
// Create a request that will be attached to |job|, and will notify
// |callback| and fill |verify_result| if the Job completes successfully.
// If the Request is deleted, or the Job is deleted, |callback| will not
// be notified.
Request(CoalescingCertVerifier::Job* job,
CertVerifyResult* verify_result,
CompletionOnceCallback callback,
const NetLogWithSource& net_log);
~Request() override;
const NetLogWithSource& net_log() const { return net_log_; }
// Called by Job to complete the requests (either successfully or as a sign
// that the underlying Job is going away).
void Complete(int result);
// Called when |job_| is being deleted, to ensure that the Request does not
// attempt to access the Job further. No callbacks will be invoked,
// consistent with the CoalescingCertVerifier's contract.
void OnJobAbort();
private:
raw_ptr<CoalescingCertVerifier::Job> job_;
raw_ptr<CertVerifyResult> verify_result_;
CompletionOnceCallback callback_;
const NetLogWithSource net_log_;
};
CoalescingCertVerifier::Job::Job(CoalescingCertVerifier* parent,
const CertVerifier::RequestParams& params,
NetLog* net_log,
bool is_first_job)
: parent_verifier_(parent),
params_(params),
net_log_(
NetLogWithSource::Make(net_log, NetLogSourceType::CERT_VERIFIER_JOB)),
is_first_job_(is_first_job) {}
CoalescingCertVerifier::Job::~Job() {
// If there was at least one outstanding Request still pending, then this
// Job was aborted, rather than being completed normally and cleaned up.
if (!attached_requests_.empty() && pending_request_) {
net_log_.AddEvent(NetLogEventType::CANCELLED);
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_JOB);
}
while (!attached_requests_.empty()) {
auto* link_node = attached_requests_.head();
link_node->RemoveFromList();
link_node->value()->OnJobAbort();
}
}
void CoalescingCertVerifier::Job::AddRequest(
CoalescingCertVerifier::Request* request) {
// There must be a pending asynchronous verification in process.
DCHECK(pending_request_);
request->net_log().AddEventReferencingSource(
NetLogEventType::CERT_VERIFIER_REQUEST_BOUND_TO_JOB, net_log_.source());
attached_requests_.Append(request);
}
void CoalescingCertVerifier::Job::AbortRequest(
CoalescingCertVerifier::Request* request) {
// Check to make sure |request| hasn't already been removed.
DCHECK(request->previous() || request->next());
request->RemoveFromList();
// If there are no more pending requests, abort. This isn't strictly
// necessary; the request could be allowed to run to completion (and
// potentially to allow later Requests to join in), but in keeping with the
// idea of providing more stable guarantees about resources, clean up early.
if (attached_requests_.empty()) {
// If this was the last Request, then the Job had not yet completed; this
// matches the logic in the dtor, which handles when it's the Job that is
// deleted first, rather than the last Request.
net_log_.AddEvent(NetLogEventType::CANCELLED);
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_JOB);
// DANGER: This will cause |this_| to be deleted!
parent_verifier_->RemoveJob(this);
return;
}
}
int CoalescingCertVerifier::Job::Start(CertVerifier* underlying_verifier) {
// Requests are only attached for asynchronous completion, so they must
// always be attached after Start() has been called.
DCHECK(attached_requests_.empty());
// There should not be a pending request already started (e.g. Start called
// multiple times).
DCHECK(!pending_request_);
net_log_.BeginEvent(NetLogEventType::CERT_VERIFIER_JOB,
[&] { return CertVerifierParams(params_); });
verify_result_.Reset();
start_time_ = base::TimeTicks::Now();
int result = underlying_verifier->Verify(
params_, &verify_result_,
// Safe, because |verify_request_| is self-owned and guarantees the
// callback won't be called if |this| is deleted.
base::BindOnce(&CoalescingCertVerifier::Job::OnVerifyComplete,
base::Unretained(this)),
&pending_request_, net_log_);
if (result != ERR_IO_PENDING) {
LogMetrics();
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_JOB,
[&] { return verify_result_.NetLogParams(result); });
}
return result;
}
void CoalescingCertVerifier::Job::OnVerifyComplete(int result) {
LogMetrics();
pending_request_.reset(); // Reset to signal clean completion.
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_JOB,
[&] { return verify_result_.NetLogParams(result); });
// It's possible that during the process of invoking a callback for a
// Request, |this| may get deleted (along with the associated parent). If
// that happens, it's important to ensure that processing of the Job is
// stopped - i.e. no other callbacks are invoked for other Requests, nor is
// |this| accessed.
//
// To help detect and protect against this, a WeakPtr to |this| is taken. If
// |this| is deleted, the destructor will have invalidated the WeakPtr.
//
// Note that if a Job had already been deleted, this method would not have
// been invoked in the first place, as the Job (via |pending_request_|) owns
// the underlying CertVerifier::Request that this method was bound to as a
// callback. This is why it's OK to grab the WeakPtr from |this| initially.
base::WeakPtr<Job> weak_this = weak_ptr_factory_.GetWeakPtr();
while (!attached_requests_.empty()) {
// Note: It's also possible for additional Requests to be attached to the
// current Job while processing a Request.
auto* link_node = attached_requests_.head();
link_node->RemoveFromList();
// Note: |this| MAY be deleted here.
// - If the CoalescingCertVerifier is deleted, it will delete the
// Jobs (including |this|)
// - If this is the second-to-last Request, and the completion of this
// event causes the other Request to be deleted, detaching that Request
// from this Job will lead to this Job being deleted (via
// Job::AbortRequest())
link_node->value()->Complete(result);
// Check if |this| has been deleted (which implicitly includes
// |parent_verifier_|), and abort if so, since no further cleanup is
// needed.
if (!weak_this)
return;
}
// DANGER: |this| will be invalidated (deleted) after this point.
return parent_verifier_->RemoveJob(this);
}
void CoalescingCertVerifier::Job::LogMetrics() {
base::TimeDelta latency = base::TimeTicks::Now() - start_time_;
UMA_HISTOGRAM_CUSTOM_TIMES("Net.CertVerifier_Job_Latency", latency,
base::Milliseconds(1), base::Minutes(10), 100);
if (is_first_job_) {
UMA_HISTOGRAM_CUSTOM_TIMES("Net.CertVerifier_First_Job_Latency", latency,
base::Milliseconds(1), base::Minutes(10), 100);
}
}
CoalescingCertVerifier::Request::Request(CoalescingCertVerifier::Job* job,
CertVerifyResult* verify_result,
CompletionOnceCallback callback,
const NetLogWithSource& net_log)
: job_(job),
verify_result_(verify_result),
callback_(std::move(callback)),
net_log_(net_log) {
net_log_.BeginEvent(NetLogEventType::CERT_VERIFIER_REQUEST);
}
CoalescingCertVerifier::Request::~Request() {
if (job_) {
net_log_.AddEvent(NetLogEventType::CANCELLED);
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_REQUEST);
// Need to null out `job_` before aborting the request to avoid a dangling
// pointer warning, as aborting the request may delete `job_`.
auto* job = job_.get();
job_ = nullptr;
// If the Request is deleted before the Job, then detach from the Job.
// Note: This may cause |job_| to be deleted.
job->AbortRequest(this);
}
}
void CoalescingCertVerifier::Request::Complete(int result) {
DCHECK(job_); // There must be a pending/non-aborted job to complete.
*verify_result_ = job_->verify_result();
// On successful completion, the Job removes the Request from its set;
// similarly, break the association here so that when the Request is
// deleted, it does not try to abort the (now-completed) Job.
job_ = nullptr;
// Also need to break the association with `verify_result_`, so that
// dangling pointer checks the result and the Request be destroyed
// in any order.
verify_result_ = nullptr;
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_REQUEST);
// Run |callback_|, which may delete |this|.
std::move(callback_).Run(result);
}
void CoalescingCertVerifier::Request::OnJobAbort() {
DCHECK(job_); // There must be a pending job to abort.
// If the Job is deleted before the Request, just clean up. The Request will
// eventually be deleted by the caller.
net_log_.AddEvent(NetLogEventType::CANCELLED);
net_log_.EndEvent(NetLogEventType::CERT_VERIFIER_REQUEST);
job_ = nullptr;
// Note: May delete |this|, if the caller made |callback_| own the Request.
callback_.Reset();
}
CoalescingCertVerifier::CoalescingCertVerifier(
std::unique_ptr<CertVerifier> verifier)
: verifier_(std::move(verifier)) {
verifier_->AddObserver(this);
}
CoalescingCertVerifier::~CoalescingCertVerifier() {
verifier_->RemoveObserver(this);
}
int CoalescingCertVerifier::Verify(
const RequestParams& params,
CertVerifyResult* verify_result,
CompletionOnceCallback callback,
std::unique_ptr<CertVerifier::Request>* out_req,
const NetLogWithSource& net_log) {
DCHECK(verify_result);
DCHECK(!callback.is_null());
out_req->reset();
++requests_;
Job* job = FindJob(params);
if (job) {
// An identical request is in-flight and joinable, so just attach the
// callback.
++inflight_joins_;
} else {
// No existing Jobs can be used. Create and start a new one.
std::unique_ptr<Job> new_job =
std::make_unique<Job>(this, params, net_log.net_log(), requests_ == 1);
int result = new_job->Start(verifier_.get());
if (result != ERR_IO_PENDING) {
*verify_result = new_job->verify_result();
return result;
}
job = new_job.get();
joinable_jobs_[params] = std::move(new_job);
}
std::unique_ptr<CoalescingCertVerifier::Request> request =
std::make_unique<CoalescingCertVerifier::Request>(
job, verify_result, std::move(callback), net_log);
job->AddRequest(request.get());
*out_req = std::move(request);
return ERR_IO_PENDING;
}
void CoalescingCertVerifier::Verify2QwacBinding(
const std::string& binding,
const std::string& hostname,
const scoped_refptr<X509Certificate>& tls_cert,
base::OnceCallback<void(const scoped_refptr<X509Certificate>&)> callback,
const NetLogWithSource& net_log) {
// 2-QWAC binding verification isn't coalesced. This isn't performance
// critical and if we wanted to coalesce, it would make more sense to do at
// the 2-QWAC link header processing layer.
verifier_->Verify2QwacBinding(binding, hostname, tls_cert,
std::move(callback), net_log);
}
void CoalescingCertVerifier::SetConfig(const CertVerifier::Config& config) {
verifier_->SetConfig(config);
IncrementGenerationAndMakeCurrentJobsUnjoinable();
}
void CoalescingCertVerifier::AddObserver(CertVerifier::Observer* observer) {
verifier_->AddObserver(observer);
}
void CoalescingCertVerifier::RemoveObserver(CertVerifier::Observer* observer) {
verifier_->RemoveObserver(observer);
}
CoalescingCertVerifier::Job* CoalescingCertVerifier::FindJob(
const RequestParams& params) {
auto it = joinable_jobs_.find(params);
if (it != joinable_jobs_.end())
return it->second.get();
return nullptr;
}
void CoalescingCertVerifier::RemoveJob(Job* job) {
// See if this was a job from the current configuration generation.
// Note: It's also necessary to compare that the underlying pointer is the
// same, and not merely a Job with the same parameters.
auto joinable_it = joinable_jobs_.find(job->params());
if (joinable_it != joinable_jobs_.end() && joinable_it->second.get() == job) {
joinable_jobs_.erase(joinable_it);
return;
}
// Otherwise, it MUST have been a job from a previous generation.
auto inflight_it =
std::ranges::find_if(inflight_jobs_, base::MatchesUniquePtr(job));
CHECK(inflight_it != inflight_jobs_.end());
inflight_jobs_.erase(inflight_it);
return;
}
void CoalescingCertVerifier::IncrementGenerationAndMakeCurrentJobsUnjoinable() {
for (auto& job : joinable_jobs_) {
inflight_jobs_.emplace_back(std::move(job.second));
}
joinable_jobs_.clear();
}
void CoalescingCertVerifier::OnCertVerifierChanged() {
IncrementGenerationAndMakeCurrentJobsUnjoinable();
}
} // namespace net
|